Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread Tiago Sousa via pve-devel
--- Begin Message --- Just adding a few things I noticed during testing, on top of what Fabian already mentioned: 1. VM data not wiped after deletion: When I delete a VM and then create a new one with the same settings, the old OS and data are still there. It looks like the disk wasn't properly

Re: [pve-devel] applied: [PATCH edk2-firmware v2] fix #6430: backport patch to fix split lock detection warnings

2025-07-14 Thread Friedrich Weber
On 10/07/2025 15:33, Thomas Lamprecht wrote: > On Thu, 10 Jul 2025 14:50:29 +0200, Friedrich Weber wrote: >> On host CPUs with the split_lock_detect flag (newer Intel CPUs), >> booting an OVMF VM with more than one core may trigger the host >> kernel's split lock detection, as reported in [1]. >> >

Re: [pve-devel] [PATCH v2 3/3] pveceph: print repo metadata when installing from manual

2025-07-14 Thread Aaron Lauterer
On 2025-07-14 10:45, Shannon Sterz wrote: On Mon Jul 14, 2025 at 10:38 AM CEST, Aaron Lauterer wrote: By printing the site and component, the person installing it manuall has a final check to see if the correct repository is being used. Signed-off-by: Aaron Lauterer --- Notes: I int

Re: [pve-devel] [PATCH pve-manager] metrics add OpenTelemetry support

2025-07-14 Thread Thomas Lamprecht
Hello, Am 15.07.25 um 05:55 schrieb nansen.su: > This patch adds OpenTelemetry metrics collection to the PVE manager > to improve observability and monitoring capabilities. > > The implementation includes: > - OTLP/HTTP JSON protocol support for OpenTelemetry Collector > - Comprehensiv

[pve-devel] applied: [pve-installer v2] run-env: filter out interfaces without valid mac address

2025-07-14 Thread Thomas Lamprecht
On Fri, 11 Jul 2025 11:00:35 +0200, Christian Ebner wrote: > The installer assumes to have a valid mac address for all interfaces > as provided by the runtime env json file. Deserialization will fail > if this is not the case. > > In some cases, the interface might however not provide a valid MAC

Re: [pve-devel] [PATCH manager v3 2/2] ui: backup job details: show notification-mode instead of legacy keys

2025-07-14 Thread Lukas Wagner
On 2025-07-11 17:04, Gabriel Goller wrote: > proxmox-biome didn't like this patch :( > > $ make check [] Checked 327 files in 23ms. No fixes applied. All good on my end, could you provide some more detail? What is the issue? -- - Lukas

[pve-devel] [PATCH pve-manager] metrics add OpenTelemetry support

2025-07-14 Thread nansen.su
This patch adds OpenTelemetry metrics collection to the PVE manager to improve observability and monitoring capabilities. The implementation includes: - OTLP/HTTP JSON protocol support for OpenTelemetry Collector - Comprehensive metrics collection for nodes, VMs, containers, and storage

Re: [pve-devel] [RFC pve-installer v3] fix #6508: auto-installer/post-hook: make iface mac address optional

2025-07-14 Thread Christian Ebner
On 7/14/25 21:27, Thomas Lamprecht wrote: Am 11.07.25 um 17:34 schrieb Christian Ebner: This is a breaking change as it affects the answer file fetch payload, the mac address now being optional. The version is therefore bumped. Meh, not a big fan - we could rather serialize it to "unknown" and

Re: [pve-devel] [PATCH manager/widget-toolkit 0/2] show altenative interface names in the web ui

2025-07-14 Thread Christoph Heiss
Tested the series, came across two thing: Given e.g. the following interface: 11: ens8: mtu 1500 qdisc [..] link/ether 01:02:03:04:05:06 brd ff:ff:ff:ff:ff:ff altname nic8 altname enxdeadff02d073 and the following /etc/network/interfaces snippet: auto nic8 i

Re: [pve-devel] [PATCH manager/widget-toolkit 0/2] show altenative interface names in the web ui

2025-07-14 Thread Thomas Lamprecht
Am 14.07.25 um 15:53 schrieb Dominik Csapak: > On 7/14/25 15:49, Christoph Heiss wrote: >> Tested the series, came across two thing: >> >> Given e.g. the following interface: >> >> 11: ens8: mtu 1500 qdisc [..] >> link/ether 01:02:03:04:05:06 brd ff:ff:ff:ff:ff:ff >> altname nic8 >>

Re: [pve-devel] [RFC pve-installer v3] fix #6508: auto-installer/post-hook: make iface mac address optional

2025-07-14 Thread Thomas Lamprecht
Am 11.07.25 um 17:34 schrieb Christian Ebner: > This is a breaking change as it affects the answer file fetch payload, > the mac address now being optional. The version is therefore bumped. Meh, not a big fan - we could rather serialize it to "unknown" and not bump the schema at all, that would IM

Re: [pve-devel] [PATCH manager] www: backup job detail: style fixups using proxmox-biome

2025-07-14 Thread Gabriel Goller
On 14.07.2025 10:45, Lukas Wagner wrote: Signed-off-by: Lukas Wagner --- Notes: Mea culpa, I did not know that 'make check' does not check for formatting issues. www/manager6/dc/BackupJobDetail.js | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc/Ba

Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>4. all snapshot volumes on extsnap dir storages will print warnings >>like >> >>`this volume filename is not supported anymore` >> >>when hitting `parse_namedir` - those can likely be avoided by >>skipping the warning if the name matches the snapshot format and >>external-sn

Re: [pve-devel] [PATCH manager v2] fix #5894: pvestatd: improve broadcast of node version-info

2025-07-14 Thread Aaron Lauterer
sent a rebased v3: https://lore.proxmox.com/pve-devel/20250714082358.56826-1-a.laute...@proxmox.com/ On 2025-02-27 15:33, Aaron Lauterer wrote: Until now, the pvestatd did broadcast the pve-manager version only once after startup of the service. But there are some situations, where the local p

[pve-devel] [PATCH v3] fix #5894: pvestatd: improve broadcast of node version-info

2025-07-14 Thread Aaron Lauterer
Until now, the pvestatd did broadcast the pve-manager version only once after startup of the service. But there are some situations, where the local pmxcfs (pve-cluster) restarts and loses that information. Basically everytime we restart the pmxcfs without restarting pvestatd too. For example, on

Re: [pve-devel] [PATCH manager v3 2/2] ui: backup job details: show notification-mode instead of legacy keys

2025-07-14 Thread Gabriel Goller
On 14.07.2025 09:26, Lukas Wagner wrote: On 2025-07-11 17:04, Gabriel Goller wrote: proxmox-biome didn't like this patch :( $ make check [] Checked 327 files in 23ms. No fixes applied. All good on my end, could you provide some more detail? What is the issue? There is a form

[pve-devel] [PATCH proxmox-backup-qemu 1/1] restore: make chunk loading more parallel

2025-07-14 Thread Dominik Csapak
by using async futures to load chunks and stream::buffer_unordered to buffer up to 16 of them, depending on write/load speed, use tokio's task spawn to make sure the continue to run in the background, since buffer_unordered starts them, but does not poll them to completion unless we're awaiting. W

[pve-devel] [PATCH docs/proxmox-backup-qemu 0/2] increase concurrency for pbs-restore

2025-07-14 Thread Dominik Csapak
for details see the proxmox-backup-qemu patch. docs patch is there to document the environment variables. proxmox-backup-qemu: Dominik Csapak (1): restore: make chunk loading more parallel src/restore.rs | 80 +++--- 1 file changed, 63 insertions(+)

[pve-devel] [PATCH docs 1/1] qmrestore: document pbs restore environment variables

2025-07-14 Thread Dominik Csapak
so users know they can override the concurrency settings. Signed-off-by: Dominik Csapak --- qmrestore.adoc | 5 + 1 file changed, 5 insertions(+) diff --git a/qmrestore.adoc b/qmrestore.adoc index 37f185a..7f0b4a3 100644 --- a/qmrestore.adoc +++ b/qmrestore.adoc @@ -27,6 +27,11 @@ Restore t

[pve-devel] [PATCH v2 1/3] fix #5244 pveceph: install: add new repository for offline installation

2025-07-14 Thread Aaron Lauterer
by adding a 4th repository option called 'offline'. If set, the ceph installation step will not touch the repository configuration. We add a simple version check to make sure that the latest version available (and to be installed) does match the selected major Ceph version. Signed-off-by: Aaron L

[pve-devel] [PATCH v2 3/3] pveceph: print repo metadata when installing from manual

2025-07-14 Thread Aaron Lauterer
By printing the site and component, the person installing it manuall has a final check to see if the correct repository is being used. Signed-off-by: Aaron Lauterer --- Notes: I intially tried to get the repo definition similar to how it is in the .list file and printed by apt-cache poli

[pve-devel] [PATCH v2 2/3] ui: CephInstallWizard: add option and hint for offline repository

2025-07-14 Thread Aaron Lauterer
The new 'offline' repository option will not try to configure the Ceph repositories during installation. Signed-off-by: Aaron Lauterer Tested-by: Christoph Heiss --- Notes: changes since v1: * rebased to new indentation RFC: * renamed option from 'offline' to 'manu

Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>6. it's fairly easy to accidentally create qcow2-formatted LVM >>volumes, as opposed to the requirement to enable a non-UI storage >>option at storage creation time for dir storages, we might want to >>add some warning to the UI at least? or we could also guard usage of >>th

Re: [pve-devel] [PATCH manager v3 2/2] ui: backup job details: show notification-mode instead of legacy keys

2025-07-14 Thread Lukas Wagner
On 2025-07-14 10:30, Gabriel Goller wrote: > On 14.07.2025 09:26, Lukas Wagner wrote: >> >> >> On  2025-07-11 17:04, Gabriel Goller wrote: >>> proxmox-biome didn't like this patch :( >>> >>> >> >>   $ make check >>   [] >>   Checked 327 files in 23ms. No fixes applied. >> >> >> All good on m

Re: [pve-devel] [PATCH manager v1 1/3] fix #5244 pveceph: install: add new repository for offline installation

2025-07-14 Thread Aaron Lauterer
sent a v2 rebased on current indentations https://lore.proxmox.com/pve-devel/20250714083838.68483-1-a.laute...@proxmox.com/T/#t On 2025-05-28 18:46, Aaron Lauterer wrote: by adding a 4th repository option called 'offline'. If set, the ceph installation step will not touch the repository confi

Re: [pve-devel] [PATCH v2 3/3] pveceph: print repo metadata when installing from manual

2025-07-14 Thread Shannon Sterz
On Mon Jul 14, 2025 at 10:38 AM CEST, Aaron Lauterer wrote: > By printing the site and component, the person installing it manuall has > a final check to see if the correct repository is being used. > > Signed-off-by: Aaron Lauterer > --- > > Notes: > I intially tried to get the repo definitio

[pve-devel] [PATCH manager] www: backup job detail: style fixups using proxmox-biome

2025-07-14 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- Notes: Mea culpa, I did not know that 'make check' does not check for formatting issues. www/manager6/dc/BackupJobDetail.js | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc/BackupJobDetail.js b/www/manager6/dc/Bac

[pve-devel] [PATCH pve-manager 1/1] api/ui: show/return alternative interface names

2025-07-14 Thread Dominik Csapak
in api listing for all interfaces, and in the GET call for an individual interface. If we don't show them, the user might be confused if the bridge ports and interface names don't correlate. enables the additional alternative names column in the network view on the gui. Signed-off-by: Dominik Cs

[pve-devel] [PATCH widget-toolkit 1/1] network: optionally show alternative interface names

2025-07-14 Thread Dominik Csapak
add a new (hidden by default) column for the interface names, and show them when editing an existing interface with such alternative names. Signed-off-by: Dominik Csapak --- src/node/NetworkEdit.js | 19 +++ src/node/NetworkView.js | 20 2 files changed, 39 i

Re: [pve-devel] [PATCH FOLLOW-UP storage 1/3] helpers: make qemu_img* storage config independent

2025-07-14 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 14.07.2025 > 08:34 CEST geschrieben: > > > >> sub qemu_img_resize { > >>-    my ($scfg, $path, $format, $size, $timeout) = @_; > >>+    my ($scfg, $path, $format, $size, $preallocation, $timeout) = > @_; > > you have forgot to remove the $scfg param, so > it's b

Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 14.07.2025 > 10:42 CEST geschrieben: > > > >>6. it's fairly easy to accidentally create qcow2-formatted LVM > >>volumes, as opposed to the requirement to enable a non-UI storage > >>option at storage creation time for dir storages, we might want to > >>add some w

Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread Thomas Lamprecht
Am 14.07.25 um 13:04 schrieb Fabian Grünbichler: >> so I think that a warning in the UI is fine enough if qcow2 format is >> selected. > would probably need to go into a few places then (allocating a disk, > moving it, restore of backup - at least?) We might be able to add it relatively centrally

Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 14.07.2025 > 10:18 CEST geschrieben: > > > >>4. all snapshot volumes on extsnap dir storages will print warnings > >>like > >> > >>`this volume filename is not supported anymore` > >> > >>when hitting `parse_namedir` - those can likely be avoided by > >>skipping

Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread Fabian Grünbichler
> Thomas Lamprecht hat am 14.07.2025 13:11 CEST > geschrieben: > > > Am 14.07.25 um 13:04 schrieb Fabian Grünbichler: > >> so I think that a warning in the UI is fine enough if qcow2 format is > >> selected. > > would probably need to go into a few places then (allocating a disk, > > moving i

Re: [pve-devel] [PATCH proxmox-backup-qemu 1/1] restore: make chunk loading more parallel

2025-07-14 Thread Adam Kalisz via pve-devel
--- Begin Message --- Looks good to me. On the Ryzen setup with 10G network between PVE and PBS, NVMe storage and default settings (50G image with 95% random): default (4 threads, 16 futures): 995 MB/s 8 threads, 16 futures: 1023 MB/s 8 threads, 32 futures: 989 MB/s This link has a lower latency

[pve-devel] [PATCH manager/widget-toolkit 0/2] show altenative interface names in the web ui

2025-07-14 Thread Dominik Csapak
This series goes on top of Stefan Hahnreich's last series[0], but it seems there is still some things missing from INotify (to e.g. set the altnames via the api), so maybe the helper I introduce in the pve-manager patch will be unnecessary, depending if parsing the interfaces file will already retu

Re: [pve-devel] [PATCH manager v2] ui: node: use plug icon for node shutdown

2025-07-14 Thread Dominik Csapak
I don't think we'll prevent all users from mis-clicking the button with this change, but having a different Icon can probably avoid *some* confusion. I don't really like that this icon would imply we 'pull the plug', but there is sadly not really a better icon that is different from the shutdown

Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread Thomas Lamprecht
Am 14.07.25 um 13:15 schrieb Fabian Grünbichler: >> Thomas Lamprecht hat am 14.07.2025 13:11 CEST >> geschrieben: >> Albeit, taking a step back, I'm not so sure if that really helps the user? >> I.e., what's something actionable they can do when seeing such a warning? >> Is it just to signal "thi

Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread Fabian Grünbichler
> Thomas Lamprecht hat am 14.07.2025 13:27 CEST > geschrieben: > > > Am 14.07.25 um 13:15 schrieb Fabian Grünbichler: > >> Thomas Lamprecht hat am 14.07.2025 13:11 CEST > >> geschrieben: > >> Albeit, taking a step back, I'm not so sure if that really helps the user? > >> I.e., what's someth

[pve-devel] [PATCH manager v8 2/3] ui: vm create wizard: allow importing disks

2025-07-14 Thread Dominik Csapak
by adding a new 'import' button in the disk tab, which adds the same input panel as the one we have when doing an 'Import Hard Disk' for an existing VM. partially fixes #2424 Signed-off-by: Dominik Csapak --- www/manager6/panel/MultiDiskEdit.js | 36 + www/manager6/q

[pve-devel] [PATCH manager v8 3/3] ui: import storage content: allow importing of vm disk images

2025-07-14 Thread Dominik Csapak
By enabling the import button for qcow2/vmdk/raw files, and showing a window with a VMID selector and the disk edit panel. Change the edit panel so that when we give an explicit volume id directly, we don't let the user select one. Instead it show it in a displayfield. Signed-off-by: Dominik Csap

[pve-devel] [PATCH manager v8 0/3] allow importing vm disk images on the UI

2025-07-14 Thread Dominik Csapak
this is a continuation of my previous series [0] It enables importing disks on the UI in the HardwareView of a vm, in the create wizard, and in the storage content view. I split the patches so that the wizard and storage content view one are separate, so they can be reviewed independently. I res

[pve-devel] [PATCH manager v8 1/3] ui: qemu hd edit: allow importing a disk from the import storage

2025-07-14 Thread Dominik Csapak
from the hardware view of a virtual machine, by adding a new 'Import Hard Disk' option in the 'Add' menu. It replaces the standard storage selector by a import storage selector, the file selector for the image to be imported, and a target storage selector. partially fixes #2424 Signed-off-by: Do

Re: [pve-devel] applied: [PATCH ifupdown2] d/patches: add patch for transparent handling of interface altnames

2025-07-14 Thread Christoph Heiss
On Fri Jul 11, 2025 at 8:09 PM CEST, Thomas Lamprecht wrote: > On Fri, 11 Jul 2025 18:25:12 +0200, Christoph Heiss wrote: >> tl;dr: add transparent altname support by caching links under their >> primary name as well as any potential altname, and translating all >> interface names from the config i

[pve-devel] [PATCH pve-docs] fix #4717: Expanded the section on VM templates

2025-07-14 Thread Alexander Abraham
The documentation on VM templates has been expanded and explanations added about advantages/disadvantages, how they can be worked with and how to create them. Signed-off-by: Alexander Abraham --- qm.adoc | 79 +++-- 1 file changed, 77 insertion

[pve-devel] [PATCH] fix #6315: Add a field for a storage description

2025-07-14 Thread Alexander Abraham
A field was added in the UI for users to enter a description for an added storage and a column was added in the storage overview for viewing the description of an added storage. Signed-off-by: Alexander Abraham --- www/manager6/dc/StorageView.js | 6 ++ www/manager6/storage/Base.js | 13 +

Re: [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist

2025-07-14 Thread Shan Shaji
Ping On Tue May 13, 2025 at 12:32 PM CEST, Shan Shaji wrote: > The app was crashing on iOS when trying to access the biometric storage > to access the saved password. The crash was due to a missing key inside > the `Info.plist` file [0]. This patch fixes it by adding the missing > `NSFaceIDUsageDe

[pve-devel] [PATCH] fix #6315: Add a description field for storage

2025-07-14 Thread Alexander Abraham
A description field was added to the schema for different types of storage inside their respective plugins. Signed-off-by: Alexander Abraham --- src/PVE/Storage/BTRFSPlugin.pm | 2 ++ src/PVE/Storage/CIFSPlugin.pm| 2 ++ src/PVE/Storage/CephFSPlugin.pm | 2 ++ src/PVE/Storage/

Re: [pve-devel] [PATCH pve-docs] fix #4717: Expanded the section on VM templates

2025-07-14 Thread Shannon Sterz
On Mon Jul 14, 2025 at 2:41 PM CEST, Alexander Abraham wrote: > The documentation on VM templates has been expanded and > explanations added about advantages/disadvantages, how > they can be worked with and how to create them. generally we prefer commit message to use the present imperative. so:

Re: [pve-devel] [PATCH manager/widget-toolkit 0/2] show altenative interface names in the web ui

2025-07-14 Thread Dominik Csapak
On 7/14/25 15:49, Christoph Heiss wrote: Tested the series, came across two thing: Given e.g. the following interface: 11: ens8: mtu 1500 qdisc [..] link/ether 01:02:03:04:05:06 brd ff:ff:ff:ff:ff:ff altname nic8 altname enxdeadff02d073 and the following /etc/netw

Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

2025-07-14 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > > 4. all snapshot volumes on extsnap dir storages will print > > > warnings > > > like > > > > > > `this volume filename is not supported anymore` > > > > > > when hitting `parse_namedir` - those can likely be avoided by > > > skipping the warning if the name matches the

[pve-devel] [PATCH FOLLOW-UP storage 01/10] lvm snapshot: activate volume

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 4b60e32..54070d1 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlug

[pve-devel] [PATCH FOLLOW-UP storage 03/10] plugin: volume_export: don't allow export of external snapshots

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- not yet implemented Signed-off-by: Alexandre Derumier --- src/PVE/Storage/Plugin.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index aee145f..06d258e 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Stora

[pve-devel] [PATCH FOLLOW-UP storage 02/10] common: fix qemu_img_resize

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/Common.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.pm index 71d123a..746a262 100644 --- a/src/PVE/Storage/Common.pm +++ b/src/PVE/Storage/C

[pve-devel] [PATCH FOLLOW-UP storage 05/10] lvmplugin: snapshot: use relative path for backing image

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index cb5fd37..9aadbc2 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/P

[pve-devel] [PATCH FOLLOW-UP storage 08/10] plugin: lvmplugin: add parse_snap_name

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 17 - src/PVE/Storage/Plugin.pm| 17 + 2 files changed, 25 insertions(+), 9 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 0

[pve-devel] [PATCH FOLLOW-UP storage 07/10] lvmplugin: add volume_snapshot_info

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- and remove public methods: get_snapname_from_path get_snap_volname Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 76 ++-- src/PVE/Storage/Plugin.pm| 41 --- 2 files changed, 73 insertions(+), 44 dele

[pve-devel] [PATCH FOLLOW-UP storage 10/10] lvmplugin: add external-snapshots option && forbid creation of qcow2 volumes without it

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 6e77eb3..1f5a5f1 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMP

[pve-devel] [PATCH FOLLOW-UP storage 04/10] lvmplugin: alloc_snap_image: die if file_size_info return empty size

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 54070d1..cb5fd37 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlug

[pve-devel] [PATCH FOLLOW-UP storage 09/10] plugin : improve parse_namedir warning

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- display the volname skip warning for external snapshot name Signed-off-by: Alexandre Derumier --- src/PVE/Storage/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 59ffa5e..439e4c3 10064

[pve-devel] [PATCH FOLLOW-UP storage 06/10] plugin|lvmplugin: don't allow volume rename if external snapshots exist.

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Just to safe, as this is already check higher in the stack. Technically, it's possible to implement snapshot file renaming, and update backing_file info with "qemu-img rebase -u". Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 6 ++ src/PVE/Storag

[pve-devel] [PATCH FOLLOW-UP qemu-server 1/1] api2: move_disk: use parse_volname to find old volume format

2025-07-14 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/API2/Qemu.pm | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 2e6358e4..dbc08737 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -4677,11 +4