On 2025-07-14 10:30, Gabriel Goller wrote: > On 14.07.2025 09:26, Lukas Wagner wrote: >> >> >> On 2025-07-11 17:04, Gabriel Goller wrote: >>> proxmox-biome didn't like this patch :( >>> >>> >> >> $ make check >> [....] >> Checked 327 files in 23ms. No fixes applied. >> >> >> All good on my end, could you provide some more detail? What is the issue? > > There is a formatting issue. `make check` only runs the linter, not the > formatter. Try `proxmox-biome check ./www/manager6`.
Ah, didn't know that there was both, lint and check for biome. TIL. I'll send a patch for the formatting fix. > > Make we should change the Makefile to run `proxmox-biome check`? Maybe, but I think a separate make target could make more sense than including it in `make check`. The latter is also run during a package build process and it would be quite annoying to fail that because of a trivial formatting issue. We also don't do that for Rust, neither for clippy nor rustfmt. What definitely would make sense is to add biome format/check --write to the `make tidy` target, at the moment we seem to only run perltidy there. -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
