--- Begin Message ---
> > > 4. all snapshot volumes on extsnap dir storages will print
> > > warnings
> > > like
> > >
> > > `this volume filename is not supported anymore`
> > >
> > > when hitting `parse_namedir` - those can likely be avoided by
> > > skipping the warning if the name matches the snapshot format and
> > > external-snapshots are enabled..
>
> Do you have seen a case where it's displayed ?
>
> because I never call parse_volname() with a $snapvolname, only with
> the
> main $volname. (because we don't want to display snapshots volumes in
> volumes list for example)
>>IIRC a simple `pvesm list <storage>` does..
sub list_images don't use parse_volname/parse_namedir but
foreach my $fn (<$imagedir/[0-9][0-9]*/*>) {
next if $fn !~ m!^(/.+/(\d+)/([^/]+\.($fmts)))$!;
$fn = $1; # untaint
so the snapshots files are listed.
The warning '`this volume filename is not supported anymore`', is
coming after in the api, where PVE::Storage::check_volume_access is
called on each volume listed. (and check_volume_access is calling
parse_volname).
I'm not sure if list_images filtering should be improved now that are
more strict ?
lvm for example, have a basic :
next if $volname !~ m/^vm-(\d+)-/;
for now, I'll fix the parse_namedir
--- End Message ---
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
