[pve-devel] [PATCH pve-manager 7/7] utils: avoid line-break in pending changes message

2025-04-05 Thread Gabriel Goller
Remove line-break on sdn "pending configuration" message on removed sdn objects. Signed-off-by: Stefan Hanreich Co-authored-by: Gabriel Goller Signed-off-by: Gabriel Goller --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www

Re: [pve-devel] [PATCH corosync] corosync.service: add patch to reduce log spam in broken network setups

2025-04-05 Thread Thomas Lamprecht
Am 04.04.25 um 10:14 schrieb Maximiliano Sandoval: > Friedrich Weber writes: ... > An option that might require lower maintenance would be to ship a > service file override, e.g. at > /lib/systemd/system/corosync.service.d/set-log-rate-limit.conf with > contents: > > ``` > [Service] > LogRateL

Re: [pve-devel] [PATCH pve-docs 1/1] fabrics: add initial documentation for sdn fabrics

2025-04-05 Thread Gabriel Goller
On 31.03.2025 10:44, Shannon Sterz wrote: On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote: [snip] I agree with everthing above. + +Router-ID Selection +^^^ + +Each node in a fabric needs a unique router ID, which is an IPv4 (or IPv6 in +OpenFabric) address in dotted-

[pve-devel] [PATCH v8 container 6/7] restore tar archive: check potentially untrusted archive

2025-04-05 Thread Wolfgang Bumiller
From: Fiona Ebner 'tar' itself already protects against '..' in component names and strips absolute member names when extracting (if not used with the --absolute-names option) and in general seems sane for extracting. Additionally, the extraction already happens in the user namespace associated t

[pve-devel] [PATCH storage/manager v2] allow upload & import of qcow2 in the web UI

2025-04-05 Thread Dominik Csapak
most of the building blocks are already there: * we can have qcow2 files in an import storage * we can import qcow2 files via the api from such a storage this series fills in the missing bits & pieces: * allow uploading qcow2 files into an import storage via the webgui * adding the possibility to

[pve-devel] [PATCH storage v9 07/29] extract backup config: delegate to backup provider for storages that support it

2025-04-05 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- src/PVE/Storage.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index 10a4abc..7174f0f 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -1759,6 +1759,17 @@ sub extract_vzdump_config {

[pve-devel] [PATCH qemu-server 2/2] vnc: connect to audio device if there is one

2025-04-05 Thread Dominik Csapak
this is in preparation of noVNC audio support. For that to work we have to connect vnc to the audiodev, else qemu does not know which device to encode audio from. Since we only can have one audio device, simply use that if it exists. This works simultaneously for SPICE and VNC. Live migration is n

Re: [pve-devel] About PVE Backup Integration Guide

2025-04-05 Thread Fiona Ebner
Note there is a v6 of the patch series now [0]. Am 01.04.25 um 09:02 schrieb Prashant Patil: > We have gone through plugins POD material; we have few questions from > very little understanding about plugins: > > 1. Storage plugin > 1. What is the main purpose of storage plugin? The storage

Re: [pve-devel] [PATCH ifupdown2 1/1] Correctly handle IPv6 addresses in vxlan

2025-04-05 Thread Andrew via pve-devel
--- Begin Message --- Just noticed I didn’t reply to this before - the patch set in ifupdown2 does not actually address IPv6 local tunnel IPs at all. > On Jan 23, 2025, at 04:26, Stefan Hanreich wrote: > > Hi, it seems like ifupdown2 will be merging a PR for VXLAN IPv6 support > in the near fut

Re: [pve-devel] About PVE Backup Integration Guide

2025-04-05 Thread Fiona Ebner
Am 01.04.25 um 10:52 schrieb Prashant Patil: > When does Proxmox VE backend calls functions from the plugin? The > backup/restore tasks/jobs are configured in our Backup Solution hence > this question. During running a Proxmox VE backup job or backup/restore invocation via API. If you manage the j

[pve-devel] [PATCH zfsonlinux 6/8] d/control: libzfslinux-dev Depends: libtirpc-dev, zlib1g-dev (Closes: #1095855)

2025-04-05 Thread Stoiko Ivanov
follows debian-upstream commit e6dc49f60a43045ef87cf683305e03c864274aac Originally-by: наб Signed-off-by: Stoiko Ivanov --- debian/control | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 6ee22da9e..5a3ac6867 100644 --- a/debian/contr

[pve-devel] [PATCH v8 qemu-server 06/11] image convert: collect options in hash argument

2025-04-05 Thread Wolfgang Bumiller
From: Fiona Ebner In preparation to add another option and to improve style for the callers. One of the test cases that specified $is_zero_initialized is for a non-existent storage, so the option was not added there. Signed-off-by: Fiona Ebner --- No changes to v7. PVE/QemuServer.pm

[pve-devel] [PATCH qemu-server v9 13/29] backup: implement backup for external providers

2025-04-05 Thread Fiona Ebner
The state of the VM's disk images at the time the backup is started is preserved via a snapshot-access block node. Old data is moved to the fleecing image when new guest writes come in. The snapshot-access block node, as well as the associated bitmap in case of incremental backup, will be made avai

Re: [pve-devel] [PATCH v4 pve-storage 1/5] qcow2: add external snapshot support

2025-04-05 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >   > @@ -716,7 +721,11 @@ sub filesystem_path { >   > my $dir = $class->get_subdir($scfg, $vtype); >   > -    $dir .= "/$vmid" if $vtype eq 'images'; > +    if ($scfg->{snapext} && $snapname) { > + $name = $class->get_snap_volname($volname, $snapname); > +    } else { >

Re: [pve-devel] [PATCH v4 qemu-server 11/11] qcow2: add external snapshot support

2025-04-05 Thread Fabian Grünbichler
commit description missing here as well.. I haven't tested this (or the first patches doing the blockdev conversion) yet, but I see a few bigger design/architecture issues left (besides FIXMEs for missing pieces that previously worked ;)): - we should probably move the decision whether a snapsh

[pve-devel] [PATCH 4/4] run cargo fmt with edition 2024

2025-04-05 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- proxmox-ve-config/src/firewall/cluster.rs | 6 -- proxmox-ve-config/src/firewall/common.rs | 4 ++-- proxmox-ve-config/src/firewall/ct_helper.rs| 2 +- proxmox-ve-config/src/firewall/guest.rs| 4 ++-- proxmox-ve-co

Re: [pve-devel] [RFC PATCH http-server] fix #6230: increase allowed post size

2025-04-05 Thread Thomas Lamprecht
Am 12.03.25 um 14:27 schrieb Dominik Csapak: > In some situations, e.g. having a large resource mapping, the UI can > generate a request that is bigger than the current limit of 64KiB. > > Our files in pmxcfs can grow up to 1 MiB, so theoretically, a single > mapping can grow to that size. In prac

[pve-devel] [PATCH storage v5 12/32] extract backup config: delegate to backup provider for storages that support it

2025-04-05 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- src/PVE/Storage.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index 41d91a1..6041ccb 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -1759,6 +1759,17 @@ sub extract_vzdump_config {

Re: [pve-devel] [PATCH v1 pve-storage 5/8] pluginbase: document hooks

2025-04-05 Thread Fabian Grünbichler
On March 26, 2025 3:20 pm, Max Carrara wrote: > Add docstrings for the following methods: > - on_add_hook > - on_update_hook > - on_delete_hook > > Signed-off-by: Max Carrara > --- > src/PVE/Storage/PluginBase.pm | 85 ++- > 1 file changed, 74 insertions(+), 11 de

[pve-devel] [PATCH-SERIES qemu 0/6] async snapshot improvements

2025-04-05 Thread Fiona Ebner
Most importantly, start using a dedicated IO thread for the state file when doing a live snapshot. Having the state file be in the iohandler context means that a blk_drain_all() call in the main thread or vCPU thread that happens while the snapshot is running will result in a deadlock. This chang

Re: [pve-devel] [PATCH ha-manager 09/15] manager: apply colocation rules when selecting service nodes

2025-04-05 Thread Fabian Grünbichler
On March 25, 2025 4:12 pm, Daniel Kral wrote: > Add a mechanism to the node selection subroutine, which enforces the > colocation rules defined in the rules config. > > The algorithm manipulates the set of nodes directly, which the service > is allowed to run on, depending on the type and strictne

[pve-devel] applied-series: [PATCH installer 0/4] tui, auto: re-use default zfs arc calculation from run env

2025-04-05 Thread Thomas Lamprecht
Am 28.02.25 um 10:43 schrieb Christoph Heiss: > As discovered during the PMG 8.2 release cycle and suggested by Thomas, unify > the ZFS ARC maximum calculation between GUI and TUI. > > In short; this series exports the calculated default value for the ZFS ARC > maximum size in the `run-env.json` f

Re: [pve-devel] [PATCH v4 pve-common 00/12] Introduce and Package PVE::Path & PVE::Filesystem

2025-04-05 Thread Max Carrara
On Fri Feb 7, 2025 at 3:03 PM CET, Max Carrara wrote: > Introduce and Package PVE::Path & PVE::Filesystem - v4 > == > Bump -- would be nice to get this merged if there are no other things left to address, in order to have this available for some

[pve-devel] superseded: [PATCH-SERIES qemu/storage/qemu-server/container/manager v7 00/37] backup provider API

2025-04-05 Thread Wolfgang Bumiller
Superseded-by: https://lore.proxmox.com/pve-devel/20250403123118.264974-1-w.bumil...@proxmox.com/ On Tue, Apr 01, 2025 at 07:33:58PM +0200, Fiona Ebner wrote: > v6: > https://lore.proxmox.com/pve-devel/20250331132020.105324-1-f.eb...@proxmox.com/ > v5: > https://lore.proxmox.com/pve-devel/20250

Re: [pve-devel] [PATCH v4 pve-storage 5/5] lvm: add lvremove helper

2025-04-05 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 11.03.2025 11:28 CET geschrieben: > > > ___ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > Signed-off-by: Alexandre Derumier > ---

Re: [pve-devel] [PATCH storage v4] fix #957 iscsi: improve iscsi_test_portal logic

2025-04-05 Thread Friedrich Weber
On 20/03/2025 11:15, Mira Limbeck wrote: > [...] >> >>> + # check session state instead if available >>> + my $sessions = iscsi_session($cache, $target); >>> + for my $session ($sessions->@*) { >>> + next if $session->{portal} ne $portal; >>> + return iscsi_test_session($session->

[pve-devel] [PATCH proxmox-i18n] updated Japanese language ja.po

2025-04-05 Thread ribbon--- via pve-devel
--- Begin Message --- --- ja.po.org 2025-03-20 22:22:38.644618693 +0900 +++ ja.po 2025-03-20 23:21:15.603578886 +0900 @@ -8,7 +8,7 @@ "Project-Id-Version: proxmox translations\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: Wed Feb 26 10:16:22 2025\n" -"PO-Revision-Date: 2024-11-19 15

[pve-devel] applied-series: [PATCH SERIES access-control/docs/manager/perl-rs/proxmox-openid v4] Make OIDC userinfo endpoint optional

2025-04-05 Thread Fabian Grünbichler
with Mira's follow-up folded in. Quoting Thomas Skinner (2025-03-24 04:37:32) > Changes since v3: > - adjust option to "query userinfo endpoint" with default enabled > > access-control: > > Thomas Skinner (1): > fix #4234: add library functions for openid optional userinfo request > > src/PV

Re: [pve-devel] [PATCH proxmox-i18n v2 2/2] make: add proxmox-datacenter-manager translations

2025-04-05 Thread Thomas Lamprecht
Am 24.01.25 um 15:37 schrieb Maximiliano Sandoval: > The catalog-{lang}.mo files are generated only with strings that are > relevant to the proxmox-datacenter-manager instead of the whole > {lang}.po file. The msgmerge command will produce all strings containing > in the {lang}.po file but the ones

Re: [pve-devel] [PATCH storage v5 1/1] import: allow upload of guest images files into import storage

2025-04-05 Thread Fiona Ebner
Am 01.04.25 um 10:23 schrieb Dominik Csapak: > so users can upload qcow2/raw/vmdk files directly in the ui > Pre-existing, but we put all uploads to /var/tmp/pveupload-XYZ first, right? This already makes some users unhappy with ISOs IIRC and for images we can expect it to get worse as those are

Re: [pve-devel] [PATCH pve-manager 6/7] fabrics: Add main FabricView

2025-04-05 Thread Gabriel Goller
On 02.04.2025 11:50, Christoph Heiss wrote: Some comments inline - did the review mostly in tandem with testing the UI, to get a better context. On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote: [..] diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js index 74728c8320e9..

[pve-devel] [PATCH zfsonlinux 3/8] d/copyright: remove files deleted by upstream

2025-04-05 Thread Stoiko Ivanov
Signed-off-by: Shengqi Chen (cherry picked from commit d9b0863953ff843f103bb45e33c410d4e0db5c24) Signed-off-by: Stoiko Ivanov --- debian/copyright | 7 --- 1 file changed, 7 deletions(-) diff --git a/debian/copyright b/debian/copyright index 4ac98c266..6beb70757 100644 --- a/debian/copyrigh

[pve-devel] [PATCH container v5 29/32] restore tar archive: check potentially untrusted archive

2025-04-05 Thread Fiona Ebner
'tar' itself already protects against '..' in component names and strips absolute member names when extracting (if not used with the --absolute-names option) and in general seems sane for extracting. Additionally, the extraction already happens in the user namespace associated to the container. So

[pve-devel] [PATCH qemu-server v5 21/32] backup: future-proof checks for QEMU feature support

2025-04-05 Thread Fiona Ebner
The features returned by the 'query-proxmox-support' QMP command are booleans, so just checking for definedness is not enough in principle. In practice, a feature is currently always true if defined. Still, fix the checks, should the need to disable support for a feature ever arise in the future an

[pve-devel] [PATCH v8 qemu-server 10/11] backup: support 'missing-recreated' bitmap action

2025-04-05 Thread Wolfgang Bumiller
From: Fiona Ebner A new 'missing-recreated' action was added on the QEMU side. Signed-off-by: Fiona Ebner --- No changes to v7. PVE/VZDump/QemuServer.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 676dad2..894e337 100644 ---

[pve-devel] [PATCH v8 qemu-server 08/11] backup: implement restore for external providers

2025-04-05 Thread Wolfgang Bumiller
From: Fiona Ebner First, the provider is asked about what restore mechanism to use. Currently, only 'qemu-img' is possible. Then the configuration files are restored, the provider gives information about volumes contained in the backup and finally the volumes are restored via 'qemu-img convert'.

[pve-devel] applied: [PATCH novnc] backport correct fix for extra keys

2025-04-05 Thread Thomas Lamprecht
Am 25.03.25 um 08:53 schrieb Dominik Csapak: > Instead of our own fix for the extra keys, backport the proper one from > upstream. As mentioned in the commit message, this also fixes > the clibpoard textarea margin. > > We can drop this patch then when we update to a new upstream release > with th

[pve-devel] [PATCH storage/manager v5] allow down/upload & import of images in the web UI

2025-04-05 Thread Dominik Csapak
most of the building blocks are already there: * we can have image files in an import storage * we can import image files via the api from such a storage this series fills in the missing bits & pieces: * allow uploading/downloading image files into an import storage via the webgui * adding the pos

Re: [pve-devel] [PATCH proxmox-ve-rs 16/17] ve-config: add section-config to frr types conversion

2025-04-05 Thread Christoph Heiss
On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote: > [..] > Signed-off-by: Gabriel Goller > --- > proxmox-ve-config/Cargo.toml| 7 + > proxmox-ve-config/debian/control| 37 ++- > proxmox-ve-config/src/sdn/fabric/mod.rs | 416 > 3 files change

Re: [pve-devel] [PATCH v1 pve-storage 8/8] pluginbase: document import and export methods

2025-04-05 Thread Fiona Ebner
Am 01.04.25 um 10:40 schrieb Fabian Grünbichler: > On March 26, 2025 3:20 pm, Max Carrara wrote: >> +=head3 $plugin->volume_export(\%scfg, $storeid, $fh, $volname, $format [, >> $snapshot, $base_snapshot, $with_snapshots]) >> + >> +=head3 $plugin->volume_export(...) >> + >> +Exports a volume or a

[pve-devel] applied-series: [PATCH manager 1/4] node: options: add config option for ballooning target

2025-04-05 Thread Thomas Lamprecht
Am 12.03.25 um 16:15 schrieb Friedrich Weber: > The option is intended for the percentage of host memory that pvestatd > uses as the target for automatic memory allocation (ballooning). > > Signed-off-by: Friedrich Weber > --- > PVE/NodeConfig.pm | 8 > 1 file changed, 8 insertions(+) >

[pve-devel] applied-series: [PATCH manager/storage 0/2] fix #3716: allow downloading iso/vztmpl/ova via https in proxied environments

2025-04-05 Thread Thomas Lamprecht
Am 26.03.25 um 11:51 schrieb Friedrich Weber: > A user in enterprise support reported (and users also reported elsewhere [1] > [2]) that ISO downloads via https currently do not work in environments using > a > proxy configured via the datacenter option `http_proxy`, if the connection to > the ISO

[pve-devel] [POC storage v5 13/32] add backup provider example

2025-04-05 Thread Fiona Ebner
The example uses a simple directory structure to save the backups, grouped by guest ID. VM backups are saved as configuration files and qcow2 images, with backing files when doing incremental backups. Container backups are saved as configuration files and a tar file or squashfs image (added to test

Re: [pve-devel] [PATCH pve-network 09/17] sdn: running: apply fabrics config

2025-04-05 Thread Stefan Hanreich
On 4/2/25 12:41, Fabian Grünbichler wrote: > On March 28, 2025 6:13 pm, Gabriel Goller wrote: >> From: Stefan Hanreich >> >> Save the fabrics configuration in the running configuration, when >> applying the SDN configuration. This causes the FRR configuration to >> be actually generated for the

[pve-devel] [PATCH storage v6 10/37] add storage_has_feature() helper function

2025-04-05 Thread Fiona Ebner
Which looks up whether a storage supports a given feature in its 'plugindata'. This is intentionally kept simple and not implemented as a plugin method for now. Should it ever become more complex requiring plugins to override the default implementation, it can later be changed to a method. Suggest

[pve-devel] [PATCH qemu-server v15 6/12] migration: check_local_resources for virtiofs

2025-04-05 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank --- v15: * removed unnecessary "if ($entry->{dirid})" check PVE/QemuServer.pm

Re: [pve-devel] [PATCH docs v1] package repos: revise Ceph section, introduce 2 attributes

2025-04-05 Thread Aaron Lauterer
On 2025-03-25 12:19, Alexander Zeidler wrote: On Mon Mar 24, 2025 at 5:50 PM CET, Aaron Lauterer wrote: On 2025-02-10 11:36, Alexander Zeidler wrote: * Remove duplicated text to maintain clarity * Mention available installation methods (web-based wizard, CLI tool) * Create a table to s

Re: [pve-devel] [PATCH v1 pve-storage 7/8] pluginbase: document volume operations

2025-04-05 Thread Max Carrara
On Mon Mar 31, 2025 at 5:12 PM CEST, Fabian Grünbichler wrote: > On March 26, 2025 3:20 pm, Max Carrara wrote: > > Add docstrings for the following methods: > > - list_volumes > > - get_volume_attribute > > - update_volume_attribute > > - volume_size_info > > - volume_resize > > - volume_snapshot >

Re: [pve-devel] [PATCH proxmox-ve-rs v2 1/1] ve-config: move types to proxmox-network-types

2025-04-05 Thread Christoph Heiss
Just a quick note: On Tue Apr 1, 2025 at 3:36 PM CEST, Stefan Hanreich wrote: [..] > diff --git a/proxmox-ve-config/src/firewall/types/address.rs > b/proxmox-ve-config/src/firewall/types/address.rs > index 9b73d3d..548b813 100644 > --- a/proxmox-ve-config/src/firewall/types/address.rs > +++ b/pro

[pve-devel] [PATCH container v5 28/32] create: factor out compression option helper

2025-04-05 Thread Fiona Ebner
In preparation to re-use it for checking potentially untrusted archives. Signed-off-by: Fiona Ebner --- src/PVE/LXC/Create.pm | 51 +-- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index 8c54

[pve-devel] [PATCH pve-firmware] iwlwifi-extra: update list of forced inclusions

2025-04-05 Thread Stoiko Ivanov
Recent Intel bluetooth chipsets are not working, due to missing firmware (e.g. ibt-0180-0041 for a Meteor Lake based Intel NUC 14). Updating the list based on the file list from the firmware-iwlwifi package in debian sid (and bookworm-backports)[0] should fix this and a few related issues. Follow

Re: [pve-devel] [PATCH proxmox v3 2/2] network-types: add hostname type

2025-04-05 Thread Stefan Hanreich
Thanks for your review - comments inline On 4/4/25 09:31, Wolfgang Bumiller wrote: > On Tue, Apr 01, 2025 at 04:52:44PM +0200, Stefan Hanreich wrote: >> Add a type for representing Linux hostnames. These are the same >> constraints as the installer enforces [1]. Lowercasing is fine as >> well, sin

[pve-devel] [PATCH v8 qemu 10/10] PVE backup: backup-access-api: explicit bitmap-mode parameter

2025-04-05 Thread Wolfgang Bumiller
This allows to explicitly request to re-create a bitmap under the same name. Signed-off-by: Wolfgang Bumiller --- New in v8 pve-backup.c | 17 - qapi/block-core.json | 20 +++- 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/pve-backup.c b

Re: [pve-devel] [PATCH proxmox-ve-rs 1/1] clippy: elided lifetime has a name

2025-04-05 Thread Maximiliano Sandoval
Gabriel Goller writes: > bump, still applies If I am not mistaken, this could use `+ use<'a>` instead of `+ 'a`. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/1] close #3181: ui: display guest name in confirm dialogs

2025-04-05 Thread Michael Köppl
The confirmation dialogs of the following actions are affected by this change: * Remove * Clone * Migrate * Snapshot * Snapshot rollback * Backup VM/CT from config view * Restore VM/CT from config view The VM/CT name is considered optional in all handled cases. If it is undefined, the parentheses

[pve-devel] [PATCH manager v5 3/3] ui: qemu hd edit: allow importing a disk from the import storage

2025-04-05 Thread Dominik Csapak
adds a checkbox 'import image' above the storage selector which: * hides the original storage selector * shows a 'source storage' selector * shows a 'import file' selector * shows a 'target storage' selector Since the wizard and the hd edit share this panel, this also works in the wizard. Signed-

Re: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

2025-04-05 Thread Thomas Lamprecht
Am 24.03.25 um 14:04 schrieb Jing Luo: > I just found that this is technically a systemd thing: at boot time, > systemd creates the symlinks /var/run -> /run and /var/lock -> > /run/lock, this > is written in /usr/lib/tmpfiles.d/var.conf and > /usr/lib/tmpfiles.d/legacy.conf, > which has been tru

[pve-devel] [PATCH manager v4 3/3] ui: qemu hd edit: allow importing a disk from the import storage

2025-04-05 Thread Dominik Csapak
adds a checkbox 'import image' above the storage selector which: * hides the original storage selector * shows a 'source storage' selector * shows a 'import file' selector * shows a 'target storage' selector Since the wizard and the hd edit share this panel, this also works in the wizard. Signed-

[pve-devel] [PATCH storage v5 07/32] add storage_has_feature() helper function

2025-04-05 Thread Fiona Ebner
Which looks up whether a storage supports a given feature in its 'plugindata'. This is intentionally kept simple and not implemented as a plugin method for now. Should it ever become more complex requiring plugins to override the default implementation, it can later be changed to a method. Suggest

Re: [pve-devel] [PATCH qemu] PVE backup: backup access api: simplify bitmap logic

2025-04-05 Thread Fiona Ebner
Superseded by: https://lore.proxmox.com/pve-devel/20250404094041.153518-1-f.eb...@proxmox.com/ improving the QAPI doc a bit ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC PATCH] ui: lxc: set nesting to false for privileged container during creation

2025-04-05 Thread Thomas Lamprecht
Thanks for this patch, some comments inline. Am 18.03.25 um 17:14 schrieb Michael Köppl: > The current implementation is slightly misleading. When creating a > privileged container, the nesting checkbox is disabled but keeps its > current state. However, nesting is not enabled for privileged conta

[pve-devel] [PATCH proxmox-perl-rs 4/7] perl-rs: sdn: implement OSPF interface file configuration generation

2025-04-05 Thread Gabriel Goller
Add function to generate /etc/network/interfaces configuration for OpenFabric nodes: - Auto-create dummy interfaces with proper router-id - Configure interface addresses and IP forwarding - Support for both IPv4 and IPv6 addressing on both dummy and other interfaces Signed-off-by: Gabriel Golle

[pve-devel] [PATCH v1 pve-storage 7/8] pluginbase: document volume operations

2025-04-05 Thread Max Carrara
Add docstrings for the following methods: - list_volumes - get_volume_attribute - update_volume_attribute - volume_size_info - volume_resize - volume_snapshot - volume_snapshot_info - volume_rollback_is_possible - volume_snapshot_rollback - volume_snapshot_delete - volume_snapshot_needs_fsfreeze -

[pve-devel] [PATCH proxmox-openid v4 1/1] fix #4411: openid: add library code for generic id token claim support

2025-04-05 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- proxmox-openid/src/lib.rs | 55 +-- 1 file changed, 47 insertions(+), 8 deletions(-) diff --git a/proxmox-openid/src/lib.rs b/proxmox-openid/src/lib.rs index fe65fded..bf8c650b 100644 --- a/proxmox-openid/src/lib.rs +++ b/prox

Re: [pve-devel] [PATCH qemu-server v7 6/9] api: enable live migration for marked mapped pci devices

2025-04-05 Thread Dominik Csapak
On 4/3/25 15:00, Thomas Lamprecht wrote: Am 11.03.25 um 14:20 schrieb Dominik Csapak: They have to be marked as 'live-migration-capable' in the mapping config, and the driver and qemu must support it. For the gui checks, we now return the whole object of the mapped resources, which includes inf

[pve-devel] [PATCH proxmox-perl-rs 1/7] perl-rs: sdn: initial fabric infrastructure

2025-04-05 Thread Gabriel Goller
Add SDN fabric support with OpenFabric and OSPF configuration parsing. Implements PerlSectionConfig wrapper and Perl module exports for fabric configuration management. Signed-off-by: Gabriel Goller --- pve-rs/Cargo.toml | 6 - pve-rs/Makefile | 1 + pve-rs/src/lib.rs

[pve-devel] [POC storage v7 16/37] add backup provider example

2025-04-05 Thread Fiona Ebner
The example uses a simple directory structure to save the backups, grouped by guest ID. VM backups are saved as configuration files and qcow2 images, with backing files when doing incremental backups. Container backups are saved as configuration files and a tar file or squashfs image (added to test

[pve-devel] [PATCH manager v5 31/32] ui: backup: also check for backup subtype to classify archive

2025-04-05 Thread Fiona Ebner
In anticipation of future storage plugins that might not have PBS-specific formats or adhere to the vzdump naming scheme for backups. Signed-off-by: Fiona Ebner --- www/manager6/Utils.js | 10 ++ www/manager6/grid/BackupView.js| 4 ++-- www/manager6/storage/BackupView.j

Re: [pve-devel] [PATCH qemu-server v14 5/12] fix #1027: virtio-fs support

2025-04-05 Thread Fabian Grünbichler
On March 4, 2025 12:57 pm, Markus Frank wrote: > add support for sharing directories with a guest vm. > > virtio-fs needs virtiofsd to be started. > In order to start virtiofsd as a process (despite being a daemon it is > does not run in the background), a double-fork is used. > > virtiofsd shoul

[pve-devel] [PATCH qemu-server] config: add system and service credentials support

2025-04-05 Thread Maximiliano Sandoval
Allows to pass system and service credentials to a VM. See [1] for a description of credentials. This can be potentially used to provision a VM as per [2]. Values can be passed either as plain text or as a base64 encoded string when the base64 flag is set. A VM configuration file which, for exampl

[pve-devel] [PATCH pve-manager 3/4] notification: replication: add common properties to template data

2025-04-05 Thread Lukas Wagner
The new PVE::Notify::common_template_data helper gives us a hash of properties which should be available in all notifications (hostname, fqdn, cluster-name at this moment). This commit makes sure that replication notifications have these available. Signed-off-by: Lukas Wagner --- PVE/API2/Replic

Re: [pve-devel] [PATCH storage v5 09/32] plugin: introduce new_backup_provider() method

2025-04-05 Thread Wolfgang Bumiller
Just a short high level nit today, will have to look more closely at this and the series the next days: There's a `new()` which takes an $scfg + $storeid. But later there are some methods taking `$self` (which usually means the thing returned from `new()`), which also get a `$storeid` as addition

Re: [pve-devel] [PATCH v4 pve-storage 3/5] storage: vdisk_free: remove external snapshots

2025-04-05 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 11.03.2025 11:28 CET geschrieben: > > > ___ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > Signed-off-by: Alexandre Derumier > ---

[pve-devel] [PATCH container v6 31/37] backup: implement restore for external providers

2025-04-05 Thread Fiona Ebner
First, the provider is asked about what restore mechanism to use. Currently, 'directory' and 'tar' are possible. The 'directory' mechanism is for restoring from a directory containing the container's full filesystem structure, which is restored by piping from a privileged tar cf - to tar xf - in th

Re: [pve-devel] [PATCH cluster/docs/manager/network/proxmox{, -ve-rs, -firewall, -perl-rs} 00/52] Add SDN Fabrics

2025-04-05 Thread Friedrich Weber
On 03/04/2025 16:03, Stefan Hanreich wrote: > > > On 4/3/25 15:44, Friedrich Weber wrote: - when removing a fabric, the IP addresses defined on the interfaces remain until the next reboot. I guess the reason is that ifupdown2 doesn't remove IP addresses when the corresponding stanz

[pve-devel] [PATCH zfsonlinux 5/8] d/control: remove transitional dummy package spl

2025-04-05 Thread Stoiko Ivanov
debian upstream did this in 2021, but I overlooked that back then[0]. [0] https://salsa.debian.org/zfsonlinux-team/zfs/-/commit/50841f137b225746a549d3dac98cc6b05a39e4dd Signed-off-by: Stoiko Ivanov --- Makefile | 1 - debian/control | 19 --- 2 files changed, 20 deletion

Re: [pve-devel] [PATCH manager v14 10/12] ui: add resource mapping view for directories

2025-04-05 Thread Laurențiu Leahu-Vlăducu
Some comments inline Otherwise, please consider: Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu On 04.03.25 12:58, Markus Frank wrote: Signed-off-by: Markus Frank --- v14: * return HTML encoded comment www/manager6/Makefile | 1 + www/manager6/dc/Conf

Re: [pve-devel] [PATCH storage/manager v3] allow upload & import of qcow2 in the web UI

2025-04-05 Thread Dominik Csapak
On 3/26/25 12:41, Fiona Ebner wrote: Am 26.03.25 um 11:47 schrieb Dominik Csapak: On 3/26/25 11:37, Fiona Ebner wrote: Am 25.03.25 um 16:14 schrieb Dominik Csapak: most of the building blocks are already there: * we can have qcow2 files in an import storage * we can import qcow2 files via the

[pve-devel] [PATCH pve-network 11/17] api: add fabrics subfolder

2025-04-05 Thread Gabriel Goller
From: Stefan Hanreich Add a new subfolder that contains the API methods for the sdn fabrics. We also add a method for listing all fabrics of all types as a GET endpoint, with the respective schemas. It supports the same filtering options as the other SDN GET endpoints (pending / running). We als

[pve-devel] [PATCH proxmox-firewall 1/1] firewall: nftables: migrate to proxmox-network-types

2025-04-05 Thread Gabriel Goller
From: Stefan Hanreich The fabrics patch series moved some generic network types into its own crate, so they can be reused across crates. Migrate proxmox-firewall to use the new proxmox-network-types crate instead of proxmox_ve_config. Signed-off-by: Stefan Hanreich Signed-off-by: Gabriel Goller

Re: [pve-devel] [PATCH corosync] corosync.service: add patch to reduce log spam in broken network setups

2025-04-05 Thread Maximiliano Sandoval
Friedrich Weber writes: > If I read the journald.conf docs [1] right, the default interval is 30s > and the burst value is 1 multiplied by a factor depending on the > free disk space, I guess 4-6 on reasonable setups -- this is a lot of > messages, but as you mention probably fine for limit

[pve-devel] [PATCH v8 storage 2/8] common: add deallocate helper function

2025-04-05 Thread Wolfgang Bumiller
From: Fiona Ebner For punching holes via fallocate. This will be useful for the external backup provider API to discard parts of the source. The 'file-handle' mechanism there uses a fuse mount, which does not implement the BLKDISCARD ioctl, but does implement fallocate. Signed-off-by: Fiona Ebne

Re: [pve-devel] applied: [PATCH installer] proxmox-chroot: replace nix::(u)mount calls with external (u)mount

2025-04-05 Thread Christoph Heiss
On Fri Apr 4, 2025 at 10:28 AM CEST, Thomas Lamprecht wrote: > Am 11.03.25 um 14:27 schrieb Christoph Heiss: >> Comes with a reduction of 52 -> 40 in terms of crate dependencies for >> proxmox-chroot, 198 -> 192 for a full workspace build. >> >> Currently, this is done inconsistently anyway, i.e. t

Re: [pve-devel] [PATCH guest-common v7 1/2] mapping: pci: check the mdev configuration on the device too

2025-04-05 Thread Dominik Csapak
On 4/3/25 11:40, Thomas Lamprecht wrote: Am 11.03.25 um 14:20 schrieb Dominik Csapak: but that lives int he 'global' part of the mapping config, not in a specific mapping. To check that, add it to the $configured_props from there. this requires all call sites to be adapted otherwise the check w