[pve-devel] [PATCH cluster v14 1/12] add mapping/dir.cfg for resource mapping

2025-03-04 Thread Markus Frank
Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). This dir.cfg is used to map directory IDs to paths on selected hosts. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: nothing changed src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2

[pve-devel] [PATCH qemu-server v14 5/12] fix #1027: virtio-fs support

2025-03-04 Thread Markus Frank
add support for sharing directories with a guest vm. virtio-fs needs virtiofsd to be started. In order to start virtiofsd as a process (despite being a daemon it is does not run in the background), a double-fork is used. virtiofsd should close itself together with QEMU. There are the parameters

[pve-devel] [PATCH manager v14 08/12] api: add resource map api endpoints for directories

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: * added missing imports/uses * addressed style nits and improved formatting PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 308 ++ PVE/API2/Cluster/Mapping/Makefile | 1 +

[pve-devel] [PATCH qemu-server v14 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: * nothing changed PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 648b28cd..5caef7ba 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -24

[pve-devel] [PATCH guest-common v14 2/12] add dir mapping section config

2025-03-04 Thread Markus Frank
Adds a config file for directories by using a 'map' property string for each node mapping. Next to node & path, there is the optional announce-submounts parameter which forces virtiofsd to report a different device number for each submount it encounters. Without it, duplicates may be created becau

[pve-devel] [PATCH manager v14 11/12] ui: form: add selector for directory mappings

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * nothing changed www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2 files changed, 64 insertions(+) create mode 100644 www/manager6/form/DirMapSelector.js diff --git a/www/manager6/Makefile

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v14 0/12] virtiofs

2025-03-04 Thread Markus Frank
Virtio-fs is a shared file system that enables sharing a directory between host and guest VMs. It takes advantage of the locality of virtual machines and the hypervisor to get a higher throughput than the 9p remote file system protocol. build-order: 1. cluster 2. guest-common 3. docs 4. qemu-serve

[pve-devel] [PATCH manager v14 09/12] ui: add edit window for dir mappings

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * disallow commas and equal signs in path until the path can be quoted in property strings www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 214 ++ 2 files changed, 215 insertions(+) create mode 10064

[pve-devel] [PATCH qemu-server v14 4/12] control: add virtiofsd as runtime dependency for qemu-server

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: * nothing changed debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 81f0fad6..eda357a5 100644 --- a/debian/control +++ b/debian/control @@ -55,6 +55,7 @@ Depends: dbus,

[pve-devel] [PATCH docs v14 3/12] add doc section for the shared filesystem virtio-fs

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * addressed formulation nits * added paragraph about expose-acl & expose-xattr qm.adoc | 99 +++-- 1 file changed, 97 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 4bb8f2c..86b3877 1006

[pve-devel] [PATCH manager v14 12/12] ui: add options to add virtio-fs to qemu config

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * disable expose-xattr when expose-acl is set * added missing writeback cache option www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 + www/manager6/qemu/VirtiofsEdit.js | 137 +

[pve-devel] [PATCH manager v14 10/12] ui: add resource mapping view for directories

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * return HTML encoded comment www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 + www/manager6/dc/DirMapView.js | 42 +++ 3 files changed, 53 insertions(+) create mode 100644 www/manager6/dc/Dir

[pve-devel] [PATCH widget-toolkit v2] window: ACMEDomains: show error dialog on domain limit

2025-03-04 Thread Christoph Heiss
Currently, this just fails silently for users and only logs an error to the console. Improve the error message & show an alert dialog on failure. This affects both PMG & PBS, as they use the exact same codepath/panel. Originally reported in the forum: https://forum.proxmox.com/threads/acme-max

Re: [pve-devel] [PATCH proxmox-firewall 1/2] fix: firewall: apply `nt_conntrack_allow_invalid` to all chains

2025-03-04 Thread Stefan Hanreich
default-in is also checking for conntrack status, so we should put this there as well. Other than that consider this: Tested-by: Stefan Hanreich Reviewed-by: Stefan Hanreich On 2/20/25 16:14, Hannes Laimer wrote: > ... on the guest table. There is no reason to not repect that option > on those

Re: [pve-devel] [PATCH manager] fix #6138: ui: storage content: use locale for sorting filenames

2025-03-04 Thread Dominik Csapak
On 3/4/25 14:05, Fiona Ebner wrote: Am 05.02.25 um 14:22 schrieb Dominik Csapak: by using 'localeCompare'. Assume the files 'a', 'B' and 'c'. The current default sorting results in : 'B' 'a' 'c' (C collation) With this patch we use locale dependent sorting, so the browser/client setting cont

[pve-devel] applied: [PATCH docs v2] pveum: switch OATH 2.0 to the correct OAuth 2.0; use pve not Proxmox

2025-03-04 Thread Thomas Lamprecht
Am 04.03.25 um 15:49 schrieb Shannon Sterz: > this switches the use of OATH 2.0 to the correct spelling of OAuth > 2.0. > > it also makes it clear that the OpenID Connect Discovery protocol is > used by Proxmox VE the product, not Proxmox the company. otherwise, > users could have gotten the impre

[pve-devel] [PATCH docs 2/7] installation: prepare medium: revise subchapter

2025-03-04 Thread Alexander Zeidler
* Consistently use "medium" (singular), as only one is needed for installation (filename "pve-installation-media.adoc" not renamed) * Revise the introduction: ** Remove CD-ROM (too little storage space) but keep DVD ** Copy to it the installer attributes from subchapter "Using the {pve} Insta

[pve-devel] [PATCH docs 4/7] installer: revise introduction

2025-03-04 Thread Alexander Zeidler
* Describe what the installer does, this was earlier included in the installation introduction * Mention the importance of a redundant disk setup * s/CD-ROM/DVD/ * Rephrase and expand the boot tip Signed-off-by: Alexander Zeidler --- pve-installation.adoc | 55 ++---

[pve-devel] [PATCH docs 3/7] installation: revise introduction

2025-03-04 Thread Alexander Zeidler
* Mention all currently available install options and link to them (interactive installer, unattended, on top of Debian) * Remove installer details and link to the installer, where the information will be included by a subsequent patch ( "installer: revise introduction"). Signed-off-by: Alex

[pve-devel] [PATCH docs 7/7] installer: revise intro of advanced ZFS/BTRFS configuration options

2025-03-04 Thread Alexander Zeidler
* ZFS: Restructure the sentence. * BTRFS: Explain the swap configuration options in a little more detail. Signed-off-by: Alexander Zeidler --- pve-installation.adoc | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/pve-installation.adoc b/pve-installation.adoc i

[pve-devel] [PATCH v1 docs 0/7] Revise installation chapter

2025-03-04 Thread Alexander Zeidler
Alexander Zeidler (7): system-requirements: revise subchapter and provide more details installation: prepare medium: revise subchapter installation: revise introduction installer: revise introduction installer: revise boot menu description and introduce sections installer: revise instal

[pve-devel] [PATCH docs 5/7] installer: revise boot menu description and introduce sections

2025-03-04 Thread Alexander Zeidler
* Introduce sections and subsections to enable proper readability * Move existing information up to the introduction and rephrase it where appropriate * Move the TUI screenshot so that it is placed next to both TUI modes Signed-off-by: Alexander Zeidler --- pve-installation.adoc | 37 +

[pve-devel] [PATCH docs 6/7] installer: revise installation steps and introduce sections

2025-03-04 Thread Alexander Zeidler
* Introduce sections and subsections to enable better readability. * Move screenshots to their corresponding installation step and add blank lines for proper formatting. Notable changes: Step 1: * Since the EULA is only available when mounting the ISO file or booting the prepared installer me

Re: [pve-devel] [PATCH manager] fix #6138: ui: storage content: use locale for sorting filenames

2025-03-04 Thread Fiona Ebner
Am 05.02.25 um 14:22 schrieb Dominik Csapak: > by using 'localeCompare'. > > Assume the files 'a', 'B' and 'c'. The current default sorting results > in : > > 'B' > 'a' > 'c' > > (C collation) > > With this patch we use locale dependent sorting, so the browser/client > setting controls how it's

[pve-devel] applied: [RFC proxmox-kernel-helper] zz-proxmox-boot: check removable status

2025-03-04 Thread Thomas Lamprecht
Am 04.03.25 um 11:55 schrieb Fabian Grünbichler: > if a fallback bootloader is installed, but the Grub packages are not set > up to manage it, inform the user about it. this setup is problematic if > the fallback bootloader is used as boot option (now or in the future), > so it's best to fix it up

Re: [pve-devel] [PATCH manager] fix #6138: ui: storage content: use locale for sorting filenames

2025-03-04 Thread Thomas Lamprecht
Am 04.03.25 um 14:14 schrieb Dominik Csapak: >> While we're at it, should/can we make sorting numerically work too? >> There is a 'numeric' option we could set, not sure if that's better or >> not here and if that is intended to work for mixed strings like >> soemthing9.yaml, something10.yaml or on

[pve-devel] [PATCH manager v2] fix #6138: ui: storage content: use locale for sorting

2025-03-04 Thread Dominik Csapak
by using 'localeCompare'. Assume the files 'a', 'B' and 'c'. The current default sorting results in : 'B' 'a' 'c' (C collation) With this patch we use locale dependent sorting, so the browser/client setting controls how it's sorted. For example with english, the list becomes: 'a' 'B' 'c' Whic

Re: [pve-devel] [PATCH manager] fix #6138: ui: storage content: use locale for sorting filenames

2025-03-04 Thread Dominik Csapak
superseded by v2: https://lore.proxmox.com/pve-devel/20250304141452.2594160-1-d.csa...@proxmox.com/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server v14 6/12] migration: check_local_resources for virtiofs

2025-03-04 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: * nothing changed PVE/QemuServer.pm

Re: [pve-devel] [PATCH widget-toolkit] window: ACMEDomains: show error dialog on domain limit

2025-03-04 Thread Christoph Heiss
v2: https://lore.proxmox.com/pve-devel/20250304120312.720783-1-c.he...@proxmox.com/ On Wed Jan 29, 2025 at 12:26 PM CET, Christoph Heiss wrote: > Currently, this just fails silently for users and only logs an error to > the console. Improve the error message & show an alert dialog on > failure. >

[pve-devel] [PATCH docs 1/7] system-requirements: revise subchapter and provide more details

2025-03-04 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- pve-system-requirements.adoc | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc index 8a982a8..82d9be5 100644 --- a/pve-system-requirements.adoc +++ b/p

[pve-devel] FW: About PVE Backup Integration Guide

2025-03-04 Thread Prashant Patil via pve-devel
--- Begin Message --- Hello All, Hope this email finds you well. At Arctera/Veritas, we are exploring the addition of support for data protection of Proxmox environments within our backup product. We would like to know if there is a detailed backup/restore API guide available that could serve a

Re: [pve-devel] [PATCH docs] pveum: switch OATH 2.0 to the correct OAuth 2.0; use pve not Proxmox

2025-03-04 Thread Shannon Sterz
On Thu Feb 27, 2025 at 11:00 AM CET, Thomas Lamprecht wrote: > Am 27.02.25 um 10:42 schrieb Shannon Sterz: >> this > > this what? sent a v2 to fix this: Superseeded-by: https://lore.proxmox.com/pve-devel/20250304144927.235339-1-s.st...@proxmox.com/ > >> >> Signed-off-by: Shannon Sterz >> --- >

[pve-devel] [PATCH docs v2] pveum: switch OATH 2.0 to the correct OAuth 2.0; use pve not Proxmox

2025-03-04 Thread Shannon Sterz
this switches the use of OATH 2.0 to the correct spelling of OAuth 2.0. it also makes it clear that the OpenID Connect Discovery protocol is used by Proxmox VE the product, not Proxmox the company. otherwise, users could have gotten the impression that data is processed on company servers. Signed

Re: [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation

2025-03-04 Thread Gabriel Goller
On 28.02.2025 14:57, Thomas Lamprecht wrote: Am 14.02.25 um 14:39 schrieb Gabriel Goller: This adds the intermediate, type-checked fabrics config. This one is parsed from the SectionConfig and can be converted into the Frr-Representation. The short description of the patch is good, but I would

Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM

2025-03-04 Thread Lou Lecrivain via pve-devel
--- Begin Message --- De : Hannes Dürr Envoyé : mercredi 19 février 2025 17:36 À : Proxmox VE development discussion Cc : Lecrivain, Lou (WDZ) Objet : [!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM   Sorry it took me so long to reply. * Pl

Re: [pve-devel] About PVE Backup Integration Guide

2025-03-04 Thread Thomas Lamprecht
Hello Prashant, Am 04.03.25 um 16:47 schrieb Prashant Patil: > Hello All, > Hope this email finds you well. > > At Arctera/Veritas, we are exploring the addition of support for data > protection of Proxmox environments within our backup product. We would like > to know if there is a detailed ba

Re: [pve-devel] [PATCH docs 1/7] system-requirements: revise subchapter and provide more details

2025-03-04 Thread Shannon Sterz
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote: > Signed-off-by: Alexander Zeidler > --- > pve-system-requirements.adoc | 29 - > 1 file changed, 20 insertions(+), 9 deletions(-) > > diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc >

[pve-devel] applied: [PATCH dab-pve-appliances] pmg: use non-virtual package for dbus

2025-03-04 Thread Thomas Lamprecht
Am 04.03.25 um 12:15 schrieb Stoiko Ivanov: > missed updating the patch before sending. > > Fixes: 524c142 ("fix #5700: pmg: add dbus to installed packages") > Signed-off-by: Stoiko Ivanov > --- > sorry for the noise - noticed while checking out Thomas' improvment to > patch 1 - thx for that! >

Re: [pve-devel] About PVE Backup Integration Guide

2025-03-04 Thread Prashant Patil via pve-devel
--- Begin Message --- Thank you, Thomas, for your prompt response to this. We would like to know following things: 1. How much part of the plugins method is done? 2. How soon we can start the integration? 3. Is there any plugin method's documentation already available? If yes, could y

[pve-devel] [PATCH-SERIES guest-common/manager/qemu-server/container 00/12] backup/restore: improve missing drive and owned CD-ROM handling

2025-03-04 Thread Fiona Ebner
Missing drive handling during restore: Currently, the configuration line for a drive that is marked for backup (i.e. 'backup' flag not explicitly set to 0), but missing from the restore map will be added verbatim to the restored configuration. As reported in the community forum [0], this can caus

[pve-devel] [PATCH manager 02/12] api: backup: adapt to new get_backup_volumes() signature

2025-03-04 Thread Fiona Ebner
See commit "abstract config: make get_backup_volumes() method more flexible" in the pve-guest-common repository. Signed-off-by: Fiona Ebner --- PVE/API2/Backup.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index f37e2393..0f6a3

[pve-devel] [PATCH qemu-server 05/12] test: restore config: use diff to make failure human-readable

2025-03-04 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- test/run_qemu_restore_config_tests.pl | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/test/run_qemu_restore_config_tests.pl b/test/run_qemu_restore_config_tests.pl index 1e1e8072..231975c6 100755 --- a/test/run_qemu_restore_config_te

[pve-devel] [PATCH qemu-server 06/12] test: restore config: add config with missing disks

2025-03-04 Thread Fiona Ebner
Record the behavior for missing disks in the backup. Signed-off-by: Fiona Ebner --- test/restore-config-expected/140.conf | 17 + test/restore-config-input/140.conf| 18 ++ test/run_qemu_restore_config_tests.pl | 2 +- 3 files changed, 36 insertions(+), 1 del

[pve-devel] [PATCH guest-common 01/12] abstract config: make get_backup_volumes() method more flexible

2025-03-04 Thread Fiona Ebner
Add the VM ID to the parameters for the get_backup_volumes() method. Like this, implementations can distinguish between owned and non-owned volumes. Signed-off-by: Fiona Ebner --- src/PVE/AbstractConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/AbstractConfig

[pve-devel] [PATCH qemu-server 03/12] cloudinit: avoid undefined value warning when no searchdomain is defined

2025-03-04 Thread Fiona Ebner
No functional change intended. Signed-off-by: Fiona Ebner --- PVE/QemuServer/Cloudinit.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer/Cloudinit.pm b/PVE/QemuServer/Cloudinit.pm index f1143aeb..5c6eb153 100644 --- a/PVE/QemuServer/Cloudinit.pm +++ b/PVE/Qemu

[pve-devel] [PATCH qemu-server 07/12] test: restore config: test behavior for disks with absolute paths

2025-03-04 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- test/restore-config-expected/110.conf | 16 test/restore-config-input/110.conf| 18 ++ test/run_qemu_restore_config_tests.pl | 2 +- 3 files changed, 35 insertions(+), 1 deletion(-) create mode 100644 test/restore-config-expect

[pve-devel] [PATCH qemu-server 10/12] backup: include owned CD-ROM volumes

2025-03-04 Thread Fiona Ebner
Currently, all volumes with a 'media=cdrom' marker are excluded from backup. For owned volumes, this is very surprising. Treat owned CD-ROM volumes like other volumes and consider the 'backup' marker instead. Cloud-init volumes are owned, but still skipped, because they are generated from the conf

[pve-devel] [PATCH qemu-server 11/12] destroy vm: add reminder to also remove owned CD-ROMs starting with PVE 9

2025-03-04 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index f937b1d7..98cf2c1c 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2131,6 +2131,7 @@ sub destroy_vm { my $volids = {}; my $remove_o

[pve-devel] [PATCH qemu-server 09/12] backup: adapt to new get_backup_volumes() signature

2025-03-04 Thread Fiona Ebner
See commit "abstract config: make get_backup_volumes() method more flexible" in the pve-guest-common repository. Signed-off-by: Fiona Ebner --- PVE/QemuConfig.pm| 2 +- PVE/VZDump/QemuServer.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuConfig.pm b/PVE

[pve-devel] [PATCH dab-pve-appliances 2/2] fix #5700: pmg: add dbus to installed packages

2025-03-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian-12-bookworm-pmg-8-64/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/debian-12-bookworm-pmg-8-64/Makefile b/debian-12-bookworm-pmg-8-64/Makefile index 55e6424..0f4a70a 100644 --- a/debian-12-bookworm-pmg-8-64/Makefile +++ b/debian-12-bookworm-

[pve-devel] [PATCH qemu-server 08/12] backup restore: improve missing drive handling

2025-03-04 Thread Fiona Ebner
Currently, the configuration line for a drive that is marked for backup (i.e. 'backup' flag not explicitly set to 0), but missing from the restore map will be added verbatim to the restored configuration. As reported in the community forum [0], this can cause issues with a VM with a configured EFI

[pve-devel] [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template

2025-03-04 Thread Stoiko Ivanov
the request seems sensible, and dbus is usually present on current debian systems. the regular debian-template is not affected, because it installs all packages with priority standard (dbus has priority standard) minimally tested the result locally. Stoiko Ivanov (2): pmg: reformat dab install

[pve-devel] [PATCH container 12/12] backup: adapt to new get_backup_volumes() signature

2025-03-04 Thread Fiona Ebner
See commit "abstract config: make get_backup_volumes() method more flexible" in the pve-guest-common repository. Signed-off-by: Fiona Ebner --- src/PVE/LXC/Config.pm | 2 +- src/PVE/VZDump/LXC.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC/Config.pm b/src/P

[pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

2025-03-04 Thread Maximiliano Sandoval
Whenever a filesystem is selected we show the size selection stack page. At the moment entering any raid setup, then entering the Advanced Options page and then selecting any non-raid setup will show the raiddisk page since it is still the visible child. Reported-by: Alexander Zeidler Signed-off

[pve-devel] [RFC proxmox-kernel-helper] zz-proxmox-boot: check removable status

2025-03-04 Thread Fabian Grünbichler
if a fallback bootloader is installed, but the Grub packages are not set up to manage it, inform the user about it. this setup is problematic if the fallback bootloader is used as boot option (now or in the future), so it's best to fix it up before a problem occurs. for proxmox-boot-tool managed E

[pve-devel] [PATCH installer] grub: set debconf value to indicate --removable install

2025-03-04 Thread Fabian Grünbichler
else we risk that the fallback boot manager and the rest of the Grub components in /boot run out of sync, which can break booting on systems that use that fallback entry instead of the regular one.. this debconf variable is read by grub-efi-amd64 and shim(-signed) postinst script, if set, `--force

Re: [pve-devel] [PATCH pve-network 08/11] add api endpoints for fabrics

2025-03-04 Thread Stefan Hanreich
please add descriptions to the properties, it serves as the documentation and we also cannot autogenerate the Rust types for the API methods. Some methods only have type => 'object' as return type. It would be good to properly document the properties of those as well for the same reasons as above.

Re: [pve-devel] [PATCH pve-manager 09/11] sdn: add Fabrics view

2025-03-04 Thread Stefan Hanreich
On 2/14/25 14:39, Gabriel Goller wrote: > Add the FabricsView in the sdn category of the datacenter view. The > FabricsView allows to show all the fabrics on all the nodes of the > cluster. > > Co-authored-by: Stefan Hanreich > Signed-off-by: Gabriel Goller > --- > PVE/API2/Cluster.pm

[pve-devel] applied: [PATCH installer] grub: set debconf value to indicate --removable install

2025-03-04 Thread Thomas Lamprecht
Am 04.03.25 um 10:45 schrieb Fabian Grünbichler: > else we risk that the fallback boot manager and the rest of the Grub > components > in /boot run out of sync, which can break booting on systems that use that > fallback entry instead of the regular one.. > > this debconf variable is read by grub

[pve-devel] [PATCH qemu-server 04/12] drive: move vm_is_volid_owner() and try_deallocate_drive() helpers to Drive module

2025-03-04 Thread Fiona Ebner
While at it, avoid making the if conditions/lines for the try_deallocate_drive() callers even longer, and bring the code in-line with the style guide. No functional change intended. Signed-off-by: Fiona Ebner --- PVE/API2/Qemu.pm| 8 ++-- PVE/QemuServer.pm | 42 +++---

[pve-devel] [PATCH dab-pve-appliances 1/2] pmg: reformat dab install invocation and sort entries

2025-03-04 Thread Stoiko Ivanov
no semantic change intended. adding new packages causes a bit of churn in the diff otherwise Signed-off-by: Stoiko Ivanov --- debian-12-bookworm-pmg-8-64/Makefile | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/debian-12-bookworm-pmg-8-64/Makefile b/debian

[pve-devel] applied: [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template

2025-03-04 Thread Thomas Lamprecht
Am 04.03.25 um 11:44 schrieb Stoiko Ivanov: > the request seems sensible, and dbus is usually present on current debian > systems. > > the regular debian-template is not affected, because it installs all > packages with priority standard (dbus has priority standard) > > minimally tested the resul

Re: [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation

2025-03-04 Thread Stefan Hanreich
On 2/14/25 14:39, Gabriel Goller wrote: > This adds the intermediate, type-checked fabrics config. This one is > parsed from the SectionConfig and can be converted into the > Frr-Representation. > > Co-authored-by: Stefan Hanreich > Signed-off-by: Gabriel Goller > --- > proxmox-ve-config/Car

[pve-devel] [PATCH dab-pve-appliances] pmg: use non-virtual package for dbus

2025-03-04 Thread Stoiko Ivanov
missed updating the patch before sending. Fixes: 524c142 ("fix #5700: pmg: add dbus to installed packages") Signed-off-by: Stoiko Ivanov --- sorry for the noise - noticed while checking out Thomas' improvment to patch 1 - thx for that! debian-12-bookworm-pmg-8-64/Makefile | 2 +- 1 file changed,

Re: [pve-devel] [PATCH manager] pvestatd: improve broadcast of node version-info

2025-03-04 Thread Thomas Lamprecht
Am 27.02.25 um 16:11 schrieb Fabian Grünbichler: >> Fiona Ebner hat am 27.02.2025 16:00 CET geschrieben: >> Am 27.02.25 um 15:52 schrieb Fabian Grünbichler: >>> we could make it detectable by including a timestamp? that way, if using >>> stale information is (not) okay, that decision can be made b

Re: [pve-devel] [PATCH pve-manager 10/11] sdn: add fabric edit/delete forms

2025-03-04 Thread Stefan Hanreich
comments inline On 2/14/25 14:39, Gabriel Goller wrote: > Add the add/edit/delete modals for the FabricsView. This allows us to > create, edit, and delete fabrics, nodes, and interfaces. > > Co-authored-by: Stefan Hanreich > Signed-off-by: Gabriel Goller > --- > www/manager6/sdn/fabrics/Common

[pve-devel] [PATCH docs 1/3] storage: make description of storage CLI examples more consistent

2025-03-04 Thread Daniel Kral
Make the text for `pvesm scan` and `pvesm add` command examples more consistent by introducing `pvesm scan` with "You can get ... with", as it is already done for other storage plugins, and changing from past tense to present tense in existing descriptions for the `pvesm add` as recommended in the

[pve-devel] [PATCH docs 3/3] storage: add remaining pvesm scan command examples

2025-03-04 Thread Daniel Kral
Add an example for the `pvesm scan` command to storage plugins, i.e. GlusterFS and PBS, where it exists in the CLI but is not mentioned yet in the documentation. Signed-off-by: Daniel Kral --- pve-storage-glusterfs.adoc | 7 +++ pve-storage-pbs.adoc | 11 +-- 2 files changed,

[pve-devel] [PATCH docs 2/3] storage: change to newer pvesm scan subcommands in examples

2025-03-04 Thread Daniel Kral
Update the examples to use the newer `pvesm scan` subcommands instead of their backwards compatibility aliases to encourage new users to use the new subcommand. Signed-off-by: Daniel Kral --- pve-storage-lvm.adoc | 2 +- pve-storage-lvmthin.adoc | 2 +- pve-storage-nfs.adoc | 2 +- pve-s

Re: [pve-devel] [PATCH proxmox-perl-rs 04/11] fabrics: add CRUD and generate fabrics methods

2025-03-04 Thread Stefan Hanreich
comments inline On 2/14/25 14:39, Gabriel Goller wrote: > Add CRUD and generate fabrics method for perlmod. These can be called > from perl with the raw configuration to edit/read/update/delete the > configuration. It also contains functions to generate the frr config > from the passed SectionConf

Re: [pve-devel] [PATCH docs 2/7] installation: prepare medium: revise subchapter

2025-03-04 Thread Shannon Sterz
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote: > * Consistently use "medium" (singular), as only one is needed for > installation (filename "pve-installation-media.adoc" not renamed) > > * Revise the introduction: > ** Remove CD-ROM (too little storage space) but keep DVD > ** Copy t

Re: [pve-devel] [PATCH proxmox-ve-rs 02/11] add proxmox-frr crate with frr types

2025-03-04 Thread Gabriel Goller
On 03.03.2025 17:29, Stefan Hanreich wrote: This uses stuff from a later patch, doesn't it? Shouldn't the order of patches 2 and 3 be flipped? oops, yeah mb. [snip] diff --git a/proxmox-frr/src/lib.rs b/proxmox-frr/src/lib.rs new file mode 100644 index ..ceef82999619 --- /dev/null

Re: [pve-devel] [PATCH stable-7 guest-common] storage tunnel: correctly set disk-import parameters

2025-03-04 Thread Thomas Lamprecht
Am 12.02.25 um 11:55 schrieb Fabian Grünbichler: > do we still want to bump this? do we also want to include other recent > fixes for remote migration if we do so? Not a huge fan, but it would be fine for me as long as they are targeted; ensuring upgrade is easy reduces pressure for requiring an L

[pve-devel] applied: [PATCH manager v2] fix #6138: ui: storage content: use locale for sorting

2025-03-04 Thread Thomas Lamprecht
Am 04.03.25 um 15:14 schrieb Dominik Csapak: > by using 'localeCompare'. > > Assume the files 'a', 'B' and 'c'. The current default sorting results > in : > > 'B' > 'a' > 'c' > > (C collation) > > With this patch we use locale dependent sorting, so the browser/client > setting controls how it's