Signed-off-by: Markus Frank <m.fr...@proxmox.com> --- v14: * disallow commas and equal signs in path until the path can be quoted in property strings
www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 214 ++++++++++++++++++++++++++++++ 2 files changed, 215 insertions(+) create mode 100644 www/manager6/window/DirMapEdit.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile index c94a5cdf..4b8677e3 100644 --- a/www/manager6/Makefile +++ b/www/manager6/Makefile @@ -138,6 +138,7 @@ JSSRC= \ window/TreeSettingsEdit.js \ window/PCIMapEdit.js \ window/USBMapEdit.js \ + window/DirMapEdit.js \ window/GuestImport.js \ ha/Fencing.js \ ha/GroupEdit.js \ diff --git a/www/manager6/window/DirMapEdit.js b/www/manager6/window/DirMapEdit.js new file mode 100644 index 00000000..2856f4c4 --- /dev/null +++ b/www/manager6/window/DirMapEdit.js @@ -0,0 +1,214 @@ +Ext.define('PVE.window.DirMapEditWindow', { + extend: 'Proxmox.window.Edit', + + mixins: ['Proxmox.Mixin.CBind'], + + cbindData: function(initialConfig) { + let me = this; + me.isCreate = !me.name; + me.method = me.isCreate ? 'POST' : 'PUT'; + me.hideMapping = !!me.entryOnly; + me.hideComment = me.name && !me.entryOnly; + me.hideNodeSelector = me.nodename || me.entryOnly; + me.hideNode = !me.nodename || !me.hideNodeSelector; + return { + name: me.name, + nodename: me.nodename, + }; + }, + + submitUrl: function(_url, data) { + let me = this; + let name = me.isCreate ? '' : me.name; + return `/cluster/mapping/dir/${name}`; + }, + + title: gettext('Add Dir mapping'), + + onlineHelp: 'resource_mapping', + + method: 'POST', + + controller: { + xclass: 'Ext.app.ViewController', + + onGetValues: function(values) { + let me = this; + let view = me.getView(); + values.node ??= view.nodename; + + let name = values.name; + let description = values.description; + let deletes = values.delete; + + delete values.description; + delete values.name; + delete values.delete; + + if (PVE.Parser.parseBoolean(values['announce-submounts'])) { + values['announce-submounts'] = 1; + } + + let map = []; + if (me.originalMap) { + map = PVE.Parser.filterPropertyStringList(me.originalMap, (e) => e.node !== values.node); + } + if (values.path) { + // TODO: Remove this when property string supports quotation of properties + if (!/^\/[^;,=()]+/.test(values.path)) { + let errMsg = 'these symbols are currently not allowed in path: ;,=()'; + Ext.Msg.alert(gettext('Error'), errMsg); + throw errMsg; + } + map.push(PVE.Parser.printPropertyString(values)); + } + values = { map }; + + if (description) { + values.description = description; + } + if (deletes && !view.isCreate) { + values.delete = deletes; + } + if (view.isCreate) { + values.id = name; + } + + return values; + }, + + onSetValues: function(values) { + let me = this; + let view = me.getView(); + me.originalMap = [...values.map]; + let configuredNodes = []; + PVE.Parser.filterPropertyStringList(values.map, (e) => { + configuredNodes.push(e.node); + e['announce-submounts'] = PVE.Parser.parseBoolean(e['announce-submounts']) ? 1 : 0; + if (e.node === view.nodename) { + values = e; + } + return false; + }); + + me.lookup('nodeselector').disallowedNodes = configuredNodes; + + return values; + }, + + init: function(view) { + let me = this; + + if (!view.nodename) { + //throw "no nodename given"; + } + }, + }, + + items: [ + { + xtype: 'inputpanel', + onGetValues: function(values) { + return this.up('window').getController().onGetValues(values); + }, + + onSetValues: function(values) { + return this.up('window').getController().onSetValues(values); + }, + + columnT: [ + { + xtype: 'displayfield', + reference: 'directory-hint', + columnWidth: 1, + value: 'Make sure the directory exists.', + cbind: { + disabled: '{hideMapping}', + hidden: '{hideMapping}', + }, + userCls: 'pmx-hint', + }, + ], + + column1: [ + { + xtype: 'pmxDisplayEditField', + fieldLabel: gettext('Name'), + cbind: { + editable: '{!name}', + value: '{name}', + submitValue: '{isCreate}', + }, + name: 'name', + allowBlank: false, + }, + { + xtype: 'pveNodeSelector', + reference: 'nodeselector', + fieldLabel: gettext('Node'), + name: 'node', + cbind: { + disabled: '{hideNodeSelector}', + hidden: '{hideNodeSelector}', + }, + allowBlank: false, + }, + ], + + column2: [ + { + xtype: 'fieldcontainer', + defaultType: 'radiofield', + layout: 'fit', + cbind: { + disabled: '{hideMapping}', + hidden: '{hideMapping}', + }, + items: [ + { + xtype: 'textfield', + name: 'path', + reference: 'path', + value: '', + emptyText: gettext('/some/path'), + cbind: { + nodename: '{nodename}', + disabled: '{hideMapping}', + }, + allowBlank: false, + fieldLabel: gettext('Path'), + }, + { + xtype: 'proxmoxcheckbox', + name: 'announce-submounts', + fieldLabel: gettext('announce-submounts'), + value: '1', + deleteEmpty: false, + }, + ], + }, + ], + + columnB: [ + { + xtype: 'fieldcontainer', + defaultType: 'radiofield', + layout: 'fit', + cbind: { + disabled: '{hideComment}', + hidden: '{hideComment}', + }, + items: [ + { + xtype: 'proxmoxtextfield', + fieldLabel: gettext('Comment'), + submitValue: true, + name: 'description', + deleteEmpty: true, + }, + ], + }, + ], + }, + ], +}); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel