Re: [pve-devel] [PATCH manager/nvidia-vgpu-helper v3 0/6] reduce setup steps for nvidia vgpu drivers

Looks mostly good and tested fine, but still a two comments: * IMHO patch 5/5 could be squashed into 3/5 (no need add code that gets changed immediately afterwards) * did you read thomas message for the service file last time around? https://lore.proxmox.com/pve-devel/fa1425a5-c8c8-4bed-81

Re: [pve-devel] [RFC PATCH installer] fix #5973: auto: first boot: allow snake- and kebabcased property names

On Tue Jan 28, 2025 at 3:38 PM CET, Thomas Lamprecht wrote: > Am 05.12.24 um 15:07 schrieb Daniel Kral: [..] > > - with `cert-fingerprint` (which works correctly as expected), and > > - with `cert_fingerprint` (which will fail at a parser error with the > > newest Proxmox VE 8.3-1 ISO). > > This is

Re: [pve-devel] [PATCH manager/nvidia-vgpu-helper v3 0/6] reduce setup steps for nvidia vgpu drivers

On 1/29/25 14:08, Dominik Csapak wrote: Looks mostly good and tested fine, but still a two comments: * IMHO patch 5/5 could be squashed into 3/5 (no need add code that gets changed immediately   afterwards) * did you read thomas message for the service file last time around?   https://lore.

[pve-devel] [PATCH widget-toolkit] window: ACMEDomains: show error dialog on domain limit

Currently, this just fails silently for users and only logs an error to the console. Improve the error message & show an alert dialog on failure. This affects PMG & BS, as they use the exact same codepath/panel. Originally reported in the forum [0]. [0] https://forum.proxmox.com/threads/acme-max

[pve-devel] SPAM: [PATCH pve-manager] ui: add dialog for nautobot IPAM plugin

--- Begin Message --- Co-Authored-by: jonatan crystall Signed-off-by: lou lecrivain --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 5 +++ www/manager6/sdn/ipams/NautobotEdit.js | 52 ++ 3 files changed, 58 insertions(+) creat

Re: [pve-devel] [PATCH perl-rs v2 4/5] fix #4234: openid: adjust openid verification function for userinfo option

> Thomas Skinner hat am 29.01.2025 04:35 CET geschrieben: > > > On Fri, Jan 24, 2025 at 3:17 AM Fabian Grünbichler > wrote: > > > > On December 16, 2024 5:14 am, Thomas Skinner wrote: > > > Signed-off-by: Thomas Skinner > > > --- > > > pve-rs/src/openid/mod.rs | 9 +++-- > > > 1 file cha

[pve-devel] [PATCH qemu-server v2 7/9] refactor: move rng related code into its own module

Signed-off-by: Filip Schauer --- PVE/QemuServer.pm | 83 +++- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/RNG.pm | 135 3 files changed, 145 insertions(+), 74 deletions(-) create mode 100644 PVE/QemuServer/RNG.pm diff --g

[pve-devel] [PATCH manager v2 3/9] introduce hardware rng mapping api

Signed-off-by: Filip Schauer --- PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/HWRNG.pm | 286 ++ PVE/API2/Cluster/Mapping/Makefile | 5 +- 3 files changed, 296 insertions(+), 2 deletions(-) create mode 100644 PVE/API2/Cluster/Mapping/HWRNG.pm

[pve-devel] [PATCH cluster/guest-common/manager/qemu-server v2 0/9] fix #5657: allow configuring RNG device as non-root user

Allow users with the VM.Config.HWType privilege to configure VirtIO RNG devices on VMs with either /dev/urandom or /dev/random as the entropy source. Further introduce hardware RNG device mapping to be able to selectively allow non-root users with the Mapping.Use privilege to configure hardware RN

[pve-devel] [PATCH manager v2 4/9] introduce hardware rng scanning api

Signed-off-by: Filip Schauer --- PVE/API2/Hardware.pm | 7 ++ PVE/API2/Hardware/HWRNG.pm | 47 ++ PVE/API2/Hardware/Makefile | 1 + 3 files changed, 55 insertions(+) create mode 100644 PVE/API2/Hardware/HWRNG.pm diff --git a/PVE/API2/Hardware.pm b

[pve-devel] [PATCH guest-common v2 1/9] mapping: add a hardware RNG mapping config

Signed-off-by: Filip Schauer --- src/Makefile | 1 + src/PVE/Mapping/HWRNG.pm | 147 +++ 2 files changed, 148 insertions(+) create mode 100644 src/PVE/Mapping/HWRNG.pm diff --git a/src/Makefile b/src/Makefile index cbc40c1..ae62b7d 100644 --- a/

[pve-devel] [PATCH cluster v2 2/9] cfs: add 'mapping/hwrng.cfg' to observed files

Observe the configuration file for hardware RNG mappings. Signed-off-by: Filip Schauer --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index e0e3ee9..684b481 100644 --- a/src/PVE/Cluster.pm +++ b/src

[pve-devel] [PATCH qemu-server v2 9/9] let VirtIO RNG devices source entropy from mapped HWRNGs

This allows a user with the Mapping.Modify privilege on /mapping/hwrng to configure a hardware RNG mapping. A less privileged user with the Mapping.Use privilege can then pass the mapped hardware RNG device as an entropy source to a VirtIO RNG device. Signed-off-by: Filip Schauer --- PVE/API2/Qe

[pve-devel] [PATCH qemu-server v2 8/9] allow non-root users to set /dev/u?random as an RNG source

Allow non-root users with the VM.Config.HWType privilege to configure /dev/urandom & /dev/random as an entropy source for a VirtIO RNG device. /dev/hwrng remains restricted to the root user. Signed-off-by: Filip Schauer --- PVE/API2/Qemu.pm | 42 ++ PVE/Q

[pve-devel] [PATCH manager v2 6/9] ui: allow use of mapped hardware RNGs as entropy sources for VMs

Signed-off-by: Filip Schauer --- www/manager6/Makefile | 1 + www/manager6/form/HWRNGMapSelector.js | 99 +++ www/manager6/qemu/HardwareView.js | 9 ++- www/manager6/qemu/RNGEdit.js | 79 ++--- 4 files changed, 159 insertions(

[pve-devel] [PATCH manager v2 5/9] ui: add hardware RNG resource mapping

Signed-off-by: Filip Schauer --- www/manager6/Makefile | 2 + www/manager6/data/PermPathStore.js | 1 + www/manager6/dc/Config.js | 10 ++ www/manager6/dc/HWRNGMapView.js | 76 ++ www/manager6/window/HWRNGMapEdit.js | 149

Re: [pve-devel] [PATCH qemu-server] fix #5657: allow configuring RNG device as non-root user

Superseded by: https://lore.proxmox.com/pve-devel/20250129155339.164696-1-f.scha...@proxmox.com/ On 24/10/2024 13:16, Fabian Grünbichler wrote: we could also define some sort of mapping-like thing for the hardware RNG to allow semi-privileged users to pass it through, after a highly privileged u

Re: [pve-devel] [RFC PATCH http-server 1/2] add error message into http body

Am 28.01.25 um 15:46 schrieb Dominik Csapak: > (short question: is going from rfc -> v2 alright with you? or should i do > rfc -> v1 -> v2 in the future? looking at my past series i did both, but would > like to do that consistently. maybe it's even a thing to write in the dev > docs?) Good quest