On 1/29/25 14:08, Dominik Csapak wrote:
Looks mostly good and tested fine, but still a two comments:
* IMHO patch 5/5 could be squashed into 3/5 (no need add code that gets changed
immediately
afterwards)
* did you read thomas message for the service file last time around?
https://lore.proxmox.com/pve-devel/fa1425a5-c8c8-4bed-814f-25169759e...@proxmox.com/
patch 4/5 does not have a commit message, so this would be good
and as thomas said the sleep 5 could be replaced by a short script that
checks the actual condition (IIRC if the correct nvidia daemon is loaded,
I would have to check if you need that info
(not sure if these are blockers though from @Thomas' side)
actually, i just found an issue with the newer kernel detection:
i installed `proxmox-kernel-6.11` and ran the tool
it prompted me to install:
proxmox-headers-6.11.11-1-pve
Would you like to install them now (y/n)?
but if we only install this package, the next 6.11 update will not get the
correct headers,
we instead have to install the package 'proxmox-headers-6.11'
so we only should ever look at the 'x.yy' of the kernel, otherwise users
ran into an issue later on
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
