Looks mostly good and tested fine, but still a two comments:
* IMHO patch 5/5 could be squashed into 3/5 (no need add code that gets changed immediately afterwards) * did you read thomas message for the service file last time around? https://lore.proxmox.com/pve-devel/fa1425a5-c8c8-4bed-814f-25169759e...@proxmox.com/ patch 4/5 does not have a commit message, so this would be good and as thomas said the sleep 5 could be replaced by a short script that checks the actual condition (IIRC if the correct nvidia daemon is loaded, I would have to check if you need that info (not sure if these are blockers though from @Thomas' side) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
