[pve-devel] [PATCH qemu-server v3] fix #3588: helper: consider NIC count for config-specific timeout

2024-11-26 Thread Hannes Laimer
There have been some reports about `qm start` timeouts on VMs that have a lot of NICs assigned. This patch considers the number of NICs when calculating the config-specific timeout. Since the increase in start time is linearly related to the number of NICs, a constant timeout increment per NIC was

[pve-devel] [PATCH pve-kernel/master 2/2] revert Ubuntu patch disabling IOMMU functionality for Skylake iGPU

2024-11-26 Thread Stoiko Ivanov
This change breaks passthrough of the iGPU on older Intel Plattforms (Skylake) https://forum.proxmox.com/threads/.157266 The patch was orignally applied by Ubuntu upstream for an issue unrelated to passthrough - flickering of the display with these chips, where some comments suggest that setting i

[pve-devel] [PATCH pve-kernel/master 1/2] fix #5926: cherry-pick ACS-quirk fix from linux-stable/6.11.7

2024-11-26 Thread Stoiko Ivanov
the latest linux-stable pull I found in ubuntu-oracular was for 6.11.5 - this fix here seems targeted enough. see also the discussion upstream: https://lore.kernel.org/all/20241029163317.ga216...@nvidia.com/ Signed-off-by: Stoiko Ivanov --- ...nable_acs-support-for-the-ACS-quirks.patch | 68

[pve-devel] [PATCH storage v5 3/7] api: content: support moving backups between path based storages

2024-11-26 Thread Filip Schauer
This commit adds the "backup+size" export format. When this format is used, the data stream starts with metadata of the backup (protected flag & notes) followed by the contents of the backup archive. Signed-off-by: Filip Schauer --- src/PVE/API2/Storage/Content.pm | 15 ++-- src/PVE/Stor

[pve-devel] [PATCH storage v5 2/7] api: content: implement moving a volume between storages

2024-11-26 Thread Filip Schauer
Add the ability to move an iso, snippet or vztmpl between storages and nodes. Use either curl to call the API method: ``` curl https://$APINODE:8006/api2/json/nodes/$SOURCENODE/storage/$SOURCESTORAGE/content/$SOURCEVOLUME \ --insecure --cookie "$( --- src/PVE/API2/Storage/Content.pm | 111

[pve-devel] [PATCH storage v5 0/7] support moving volumes between storages

2024-11-26 Thread Filip Schauer
Add the ability to move a backup, ISO, container template, snippet, or OVA/OVF between storages and nodes via an API method. Moving a VMA backup to a Proxmox Backup Server requires the proxmox-vma-to-pbs package to be installed. Currently only VMA backups can be moved to a Proxmox Backup Server and

[pve-devel] [PATCH storage v5 6/7] pvesm: add a move-volume command

2024-11-26 Thread Filip Schauer
The method can be called from the PVE shell with `pvesm move-volume`: ``` pvesm move-volume [--target-node ] [--delete] ``` For example to move a VMA backup to a Proxmox Backup Server: ``` pvesm move-volume \ local:backup/vzdump-qemu-100-2024_06_25-13_08_56.vma.zst pbs ``` Or move a cont

[pve-devel] [PATCH storage v5 1/7] plugin: allow volume import of iso, snippets, vztmpl and import

2024-11-26 Thread Filip Schauer
Extend volume import functionality to support 'iso', 'snippets', 'vztmpl', and 'import' types, in addition to the existing support for 'images' and 'rootdir'. This is a prerequisite for the ability to move ISOs, snippets and container templates between nodes. Existing behavior for importing VM dis

[pve-devel] [PATCH storage v5 4/7] storage: introduce decompress_archive_into_pipe helper

2024-11-26 Thread Filip Schauer
Extract the file decompression code into its own reusable subroutine. Signed-off-by: Filip Schauer --- src/PVE/Storage.pm | 64 +- 1 file changed, 40 insertions(+), 24 deletions(-) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index ae190cd..5d

[pve-devel] [PATCH storage v5 5/7] support moving VMA backups to PBS

2024-11-26 Thread Filip Schauer
Extend the move API to support moving VMA backups to a Proxmox Backup Server. Signed-off-by: Filip Schauer --- debian/control | 1 + src/PVE/API2/Storage/Content.pm | 53 +++ src/PVE/Storage/PBSPlugin.pm| 65 + 3 files

[pve-devel] [PATCH storage v5 7/7] storage migrate: avoid ssh when moving a volume locally

2024-11-26 Thread Filip Schauer
Avoid the overhead of SSH when moving a volume between storages on the same node. Signed-off-by: Filip Schauer --- src/PVE/Storage.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index 5d25a2a..c1f383a 100755 --- a/src/PVE/Stor

Re: [pve-devel] [PATCH v4 storage 2/6] api: content: implement moving a volume between storages

2024-11-26 Thread Filip Schauer
On 20/09/2024 16:27, Daniel Kral wrote: Also if I'm not missing something, this could also use a `format => 'pve-volume-id'`, but I can see that it isn't used in any other route in that module and is also only used in `PVE::Storage::Plugin::LVMPlugin`, `PVE::Storage::CLI::pvesm` and `pve-conta

Re: [pve-devel] [PATCH v4 storage 0/6] support moving volumes between storages

2024-11-26 Thread Filip Schauer
Superseded by: https://lists.proxmox.com/pipermail/pve-devel/2024-November/066993.html On 18/09/2024 16:49, Filip Schauer wrote: Add the ability to move a backup, ISO, container template or snippet between storages and nodes via an API method. Moving a VMA backup to a Proxmox Backup Server requi

[pve-devel] [PATCH pve-kernel/master 0/2] fix two small issues with IOMMU in certain setups

2024-11-26 Thread Stoiko Ivanov
stubled across https://bugzilla.proxmox.com/show_bug.cgi?id=5926 which mentioned kernel-issues related to the 8.3.0 release - so took a quick look. While I think that the issues were not directly related to 8.3 (or the kernel version shipped with it (see bugzilla)) - one issue seemed to be easily

[pve-devel] [PATCH installer] unconfigured.sh: set kernel.printk to level warn

2024-11-26 Thread Stoiko Ivanov
we got a few reports of kernel-output drawing over the TUI-installer. (e.g. when ZFS loads for the pool-cleanup, also mkfs.xfs sometimes triggers a message being printed). As the information gets logged in the kernel ringbuffer (`dmesg`) anyways, there's little gain on having it displayed on the c

[pve-devel] applied: [PATCH installer] auto: do not allow btrfs as root-fs if not enabled in the setup

2024-11-26 Thread Thomas Lamprecht
Am 26.11.24 um 14:27 schrieb Christoph Heiss: > Add a check such that this combination is not possible, if not enabled > for the specific iso. > > Signed-off-by: Christoph Heiss > --- > proxmox-auto-installer/src/utils.rs | 13 + > 1 file changed, 13 insertions(+) > > applied, with

[pve-devel] [PATCH qemu-server] fix vm shutdown when agent conf is enabled but is not running in the vm

2024-11-26 Thread Fabio Fantoni via pve-devel
--- Begin Message --- Checking only vm configuration for choose the shutdown method causes it to always fail, after reaching the timeout, if the qemu agent option in the vm configuration is enabled but the agent is not installed and active in the guest. As I seen in the windows vm the agent also cr

Re: [pve-devel] SPAM: [Security] Arbitrary file reading via maliciousVM config

2024-11-26 Thread James Brown via pve-devel
--- Begin Message --- This is not a spam. ---Original--- From: "James Brown via pve-devel"https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel--- End Message --- ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/c

[pve-devel] SPAM: [Security] Arbitrary file reading via malicious VM config

2024-11-26 Thread James Brown via pve-devel
--- Begin Message --- I suspect a security flaw within ESXi VM import. If a malicious actor forges a VMWare VM config with root paths such as /var/log/auth.log, could lead to potential data leak if the import task is executed.--- End Message --- ___ pve

Re: [pve-devel] [PATCH qemu-server v2] fix #3588: helper: consider NIC count for config-specific timeout

2024-11-26 Thread Hannes Laimer
On 11/25/24 16:15, Fiona Ebner wrote: Am 21.11.24 um 16:13 schrieb Hannes Laimer: diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm index 0afb6317..1888487e 100644 --- a/PVE/QemuServer/Helpers.pm +++ b/PVE/QemuServer/Helpers.pm @@ -167,6 +167,15 @@ sub config_aware_timeout {

Re: [pve-devel] applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys

2024-11-26 Thread Shannon Sterz
On Mon Nov 25, 2024 at 11:19 PM CET, Thomas Lamprecht wrote: > Am 25.11.24 um 11:22 schrieb Lukas Wagner: >> Ping for patches 3-6, these were never applied. >> They do not add any functional changes, but only aim to improve >> code style and add some tests. >> > > > I applied them now, thanks! > >

Re: [pve-devel] applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys

2024-11-26 Thread Thomas Lamprecht
Am 26.11.24 um 10:27 schrieb Shannon Sterz: > actually i needed to adapt this to add support for attachments, which > require reworking the multipart logic a bit too. i can factor that out > into it's own `proxmox-sendmail` crate or similar and make > `proxmox-notify`'s sendmail endpoint use that t

Re: [pve-devel] [PATCH ifupdown2 1/1] Correctly handle IPv6 addresses in vxlan

2024-11-26 Thread Andrew via pve-devel
--- Begin Message --- Hello, Yes, I’ve signed the CLA. You’re welcome to take it over to fix the style issues. At least for Trixie it seems like PVE staying on ifupdown2 would make sense, given how tightly integrated it’s syntax is with SDN. Andrew > On Nov 25, 2024, at 05:25, Stefan Hanrei

[pve-devel] [PATCH container 1/1] Optional mapped devices at vm boot

2024-11-26 Thread moddingfox via pve-devel
--- Begin Message --- From: Tyst Marin This change intends to add support for optional mapped usb devices. Currently if a mapped device is unplugged vm boot will fail, tihs will provide an option to ignore specified missing devices. This keeps the default behavior while allowing for optional dev

[pve-devel] [PATCH] Add UI option for boot optional mapped usb device

2024-11-26 Thread moddingfox via pve-devel
--- Begin Message --- From: Tyst Marin This is intended to work with a seprately submitted patch to qemu-server which enables the behavior Signed-off-by: Tyst Marin --- www/manager6/qemu/USBEdit.js | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/www/manag

[pve-devel] applied-series: [pbs-devel] [PATCH proxmox-backup v3 11/14] api: notification: add API routes for webhook targets

2024-11-26 Thread Thomas Lamprecht
Am 08.11.24 um 15:41 schrieb Lukas Wagner: > Copied and adapted from the Gotify ones. > > Signed-off-by: Lukas Wagner > Tested-By: Stefan Hanreich > --- > src/api2/config/notifications/mod.rs | 2 + > src/api2/config/notifications/webhook.rs | 175 +++ > 2 files change

[pve-devel] [PATCH docs] fix #5928: docs: fix storage replication possible issues section

2024-11-26 Thread Timothy Nicholson
This patch rephrases one of the "possible issues" in storage replication, as described in [0]. [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5928 Signed-off-by: Timothy Nicholson --- pvesr.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesr.adoc b/pvesr.adoc index

[pve-devel] [PATCH installer] auto: do not allow btrfs as root-fs if not enabled in the setup

2024-11-26 Thread Christoph Heiss
Add a check such that this combination is not possible, if not enabled for the specific iso. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/src/utils.rs | 13 + 1 file changed, 13 insertions(+) diff --git a/proxmox-auto-installer/src/utils.rs b/proxmox-auto-installer/src