Am 27/10/2023 um 08:58 schrieb Thomas Lamprecht:
> Am 25/10/2023 um 15:07 schrieb Folke Gleumes:
>> Changes v1 -> v2:
>> Switched from including the eab credentials in the info hash,
>> to passing them in their own variable. This still unfortunately still
>> breaks the api, but doesn't potentially
Am 23/10/2023 um 14:40 schrieb Stefan Lendl:
> I am currently working on the SDN feature. This is an initial review of
> the patch series and I am trying to make a strong case against ephemeral
> DHCP IP reservation.
Stefan Hanreich's reply to the cover letter already mentions upserts, those
will
On Wed, Oct 25, 2023 at 07:09:00PM +0200, Thomas Lamprecht wrote:
>
> Am 25/10/2023 um 10:28 schrieb Christoph Heiss:
> > On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel
> > wrote:
> >
> > Currently, this isn't planned, although - since that setting is exposed
> > afte
Am 25.10.23 um 18:01 schrieb DERUMIER, Alexandre:
>>> Unused disks can just be migrated
>>> offline via storage_migrate(), or?
>
> currently unused disk can't be migrate through the http tunnel for
> remote-migration
>
> 2023-10-25 17:51:38 ERROR: error - tunnel command
> '{"format":"raw","migra
The .deb fails to build with this patch applied,
`proxmox-installer-common/` must also be copied to the build directory
(see `$(BUILDIR)` target in the Makefile).
On Wed, Oct 25, 2023 at 06:00:00PM +0200, Aaron Lauterer wrote:
>
> It will be used for code shared among the different crates in the
Could be squased into the previous patch IMO if you do send a v2, but
not a blocker either for me if not.
In any case:
Reviewed-by: Christoph Heiss
On Wed, Oct 25, 2023 at 06:00:11PM +0200, Aaron Lauterer wrote:
>
> Signed-off-by: Aaron Lauterer
> ---
> proxmox-tui-installer/src/setup.rs |
Simple code move/copy, so LGTM.
Reviewed-by: Christoph Heiss
On Wed, Oct 25, 2023 at 06:00:01PM +0200, Aaron Lauterer wrote:
>
> Copy code that is common to its own crate.
>
> Signed-off-by: Aaron Lauterer
> ---
> proxmox-installer-common/Cargo.toml | 2 +
> proxmox-installer-commo
Date: Fri, 27 Oct 2023 13:00:49 +0200
>From 96fee0866727a1188b1debd805c625c598816b98 Mon Sep 17 00:00:00 2001
This patch series defines IPs, once allocated by the IPAM as persistant
until the vNIC is removed from the VM or the VM is destroyed.
The dnsmasq ethers file is a pure product of the IPAM
Date: Fri, 27 Oct 2023 13:00:49 +0200
>From 96fee0866727a1188b1debd805c625c598816b98 Mon Sep 17 00:00:00 2001
This patch series defines IPs, once allocated by the IPAM as persistant
until the vNIC is removed from the VM or the VM is destroyed.
The dnsmasq ethers file is a pure product of the IPAM
Signed-off-by: Stefan Lendl
---
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm| 23 +++
src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 16
2 files changed, 39 insertions(+)
diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
index af109
Makes dnsmasq stateless and can be generated from the IPAM.
On dhcp_add_ip always generate the entire ethers file.
Signed-off-by: Stefan Lendl
---
src/PVE/Network/SDN/Dhcp.pm | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/PVE/Network/
Signed-off-by: Stefan Lendl
---
src/PVE/LXC.pm| 8
src/lxc-pve-poststop-hook | 1 -
2 files changed, 9 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index bd8eb63..a7de9b8 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -916,14 +916,6 @@ sub vm_stop_cleanup {
Signed-off-by: Stefan Lendl
---
PVE/QemuServer.pm | 2 --
vm-network-scripts/pve-bridgedown | 4
2 files changed, 6 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6c1e463..710259b 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6143,8 +6143,
removes an error from journal when newly DHCP server is configured
Signed-off-by: Stefan Lendl
---
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
index 6f8b1c4..39e4cce 100644
add DHCP mapping on vNIC add/update and VM clone (new mac)
remove DHCP mapping on vNIC delete and VM destroy
Signed-off-by: Stefan Lendl
---
PVE/API2/Qemu.pm | 25 +
PVE/QemuServer.pm | 2 ++
2 files changed, 27 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qe
--- Begin Message ---
25.10.2023 17:45, Dominik Csapak пишет:
One nit inline, but that could be fixed up when applying too probably?
Hi, Dominik!
Thanks for review! Should I send v6 with the fix for hash?
--
Best regards, Yuri Konotopov
--- End Message ---
_
Sorry, Sending this again because I noticed that I messed up the subject
prefixes for the patches.
This patch series defines IPs, once allocated by the IPAM as persistant
until the vNIC is removed from the VM or the VM is destroyed.
The dnsmasq ethers file is a pure product of the IPAM database
Makes dnsmasq stateless and can be generated from the IPAM.
On dhcp_add_ip always generate the entire ethers file.
Signed-off-by: Stefan Lendl
---
src/PVE/Network/SDN/Dhcp.pm | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/PVE/Network/
removes an error from journal when newly DHCP server is configured
Signed-off-by: Stefan Lendl
---
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
index 6f8b1c4..39e4cce 100644
add DHCP mapping on vNIC add/update and VM clone (new mac)
remove DHCP mapping on vNIC delete and VM destroy
Signed-off-by: Stefan Lendl
---
PVE/API2/Qemu.pm | 25 +
PVE/QemuServer.pm | 2 ++
2 files changed, 27 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qe
Signed-off-by: Stefan Lendl
---
src/PVE/LXC.pm| 8
src/lxc-pve-poststop-hook | 1 -
2 files changed, 9 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index bd8eb63..a7de9b8 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -916,14 +916,6 @@ sub vm_stop_cleanup {
Signed-off-by: Stefan Lendl
---
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm| 23 +++
src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 16
2 files changed, 39 insertions(+)
diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
index af109
Signed-off-by: Stefan Lendl
---
PVE/QemuServer.pm | 2 --
vm-network-scripts/pve-bridgedown | 4
2 files changed, 6 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6c1e463..710259b 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6143,8 +6143,
Had a lot of in-person discussions with Aaron over the last few weeks
over this.
There are no real functional changes here that would impact users,
merely a code move.
Each inidivdual patch (except #1, see my answer on that) builds cleanly
on top of current master. The one dependency (see below)
Signed-off-by: Christoph Heiss
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 111fe4b..e792e0e 100644
--- a/Makefile
+++ b/Makefile
@@ -43,6 +43,7 @@ $(BUILDDIR):
proxinstall \
proxmox-low-level-installer \
proxmox-tui-inst
Am 23/10/2023 um 19:45 schrieb Yuri Konotopov:
> With this patch Proxmox now tries to login to all discovered portals in
> case some of them are not logged yet.
> In case of multipath configuration when initially configured portal is
> missing for some reason Proxmox don't lose iscsi storage now an
Stefan Hanreich writes:
> Those methods are used by the DHCP plugins to attain the next free
> IP address for a given DHCP range, as well as delete all entries with
> a certain MAC address.
>
> Signed-off-by: Stefan Hanreich
> ---
> src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 64 ++
Am 27/10/2023 um 13:29 schrieb Stefan Lendl:
> Sorry, Sending this again because I noticed that I messed up the subject
> prefixes for the patches.
I'd also prefer having such series as separate thread, not in reply to another
(already big) series..
Also, if I didn't overlook something, you nowhe
Do it on vnet update instead throwing a warning at config generation.
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Zones/EvpnPlugin.pm
b/src/PVE/Network/SDN/Zones/EvpnPlugin.
It is on top of Stefan Hanreich's patch series therefore I replied here
as I consider it a continuation of his efforts.
Thomas Lamprecht writes:
> Am 27/10/2023 um 13:29 schrieb Stefan Lendl:
>> Sorry, Sending this again because I noticed that I messed up the subject
>> prefixes for the patche
Am 27/10/2023 um 13:52 schrieb Thomas Lamprecht:
> Am 27/10/2023 um 13:29 schrieb Stefan Lendl:
>> Sorry, Sending this again because I noticed that I messed up the subject
>> prefixes for the patches.
>
> I'd also prefer having such series as separate thread, not in reply to another
> (already big
Am 27/10/2023 um 13:54 schrieb Stefan Lendl:
> It is on top of Stefan Hanreich's patch series therefore I replied here
> as I consider it a continuation of his efforts.
Please state that the next time.
Also, please avoid top posting on the mailing list and trim your replies!
https://git-send-ema
Thomas Lamprecht writes:
> Am 23/10/2023 um 14:40 schrieb Stefan Lendl:
>> I am currently working on the SDN feature. This is an initial review of
>> the patch series and I am trying to make a strong case against ephemeral
>> DHCP IP reservation.
>
> Stefan Hanreich's reply to the cover letter a
>
> Furthermore, every interaction with the IPAM requires a cluster-wide
> lock on the IPAM. Having a central cluster-wide lock on every VM
> start/stop/migrate will significantly limit parallel operations.
> Event
> starting two VMs in parallel will be limited by this central lock. At
> boot try
Hi Alexandre, I am proposing a slightly different view.
I think it's better to keep all IPs, managed by the IPAM in the IPAM and
the VM only configures as DHCP.
I would implement the 4 mentioned events (vNIC create, destroy, start,
stop) in the SDN module and limit interactions between VM config
Message initial
De: Stefan Lendl
À: "DERUMIER, Alexandre"
Cc: pve-devel@lists.proxmox.com
Objet: Re: [pve-devel] [WIP v2 cluster/network/manager/qemu-
server/container 00/10] Add support for DHCP servers to SDN
Date: 27/10/2023 14:53:25
Hi Alexandre, I am proposing a slightly
Am 25/10/2023 um 11:55 schrieb Maximiliano Sandoval R:
> Signed-off-by: Maximiliano Sandoval R
> ---
> ha-manager.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
But as talked off-list, I made a follow-up that reworked that whole
paragraph, it had a few small
37 matches
Mail list logo
