Could be squased into the previous patch IMO if you do send a v2, but
not a blocker either for me if not.
In any case:
Reviewed-by: Christoph Heiss <c.he...@proxmox.com>
On Wed, Oct 25, 2023 at 06:00:11PM +0200, Aaron Lauterer wrote:
>
> Signed-off-by: Aaron Lauterer <a.laute...@proxmox.com>
> ---
> proxmox-tui-installer/src/setup.rs | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/proxmox-tui-installer/src/setup.rs
> b/proxmox-tui-installer/src/setup.rs
> index 211a96b..efcabed 100644
> --- a/proxmox-tui-installer/src/setup.rs
> +++ b/proxmox-tui-installer/src/setup.rs
> @@ -1,13 +1,10 @@
> use std::{
> collections::HashMap,
> fmt,
> - fs::File,
> - io::BufReader,
> net::IpAddr,
> - path::Path,
> };
>
> -use serde::{Deserialize, Serialize, Serializer};
> +use serde::{Serialize, Serializer};
>
> use crate::options::InstallerOptions;
> use proxmox_installer_common::{
> @@ -129,13 +126,6 @@ impl From<InstallerOptions> for InstallConfig {
> }
> }
>
> -pub fn read_json<T: for<'de> Deserialize<'de>, P: AsRef<Path>>(path: P) ->
> Result<T, String> {
> - let file = File::open(path).map_err(|err| err.to_string())?;
> - let reader = BufReader::new(file);
> -
> - serde_json::from_reader(reader).map_err(|err| format!("failed to parse
> JSON: {err}"))
> -}
> -
> fn serialize_disk_opt<S>(value: &Option<Disk>, serializer: S) ->
> Result<S::Ok, S::Error>
> where
> S: Serializer,
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
