Am 27/10/2023 um 08:58 schrieb Thomas Lamprecht: > Am 25/10/2023 um 15:07 schrieb Folke Gleumes: >> Changes v1 -> v2: >> Switched from including the eab credentials in the info hash, >> to passing them in their own variable. This still unfortunately still >> breaks the api, but doesn't potentially expose secrets and is >> cleaner then purging the values from the hash afterwards. > > yeah, IMO the signature of that method is still not really ideal, i.e., > adding that as explicit param is a lateral move and still breaks ABI, so > meh, and I'd prefer
argh, sent to early, but bascially what I write in my reply to v1: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059670.html _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
