[pve-devel] [PATCH manager] ceph osd: ui: show PGs per OSD

2023-02-14 Thread Aaron Lauterer
By switching from 'ceph osd tree' to the 'ceph osd df tree' mon API equivalent , we get the same data structure with more information per OSD. One of them is the number of PGs stored on that OSD. The number of PGs per OSD is an important number, for example when trying to figure out why the perfor

[pve-devel] applied: Re: [PATCH qemu 1/2] d/rules: add missing export for CFLAGS

2023-02-14 Thread Thomas Lamprecht
On 10/02/2023 10:39, Fiona Ebner wrote: > Otherwise, they don't affect the build of QEMU at all. > > Signed-off-by: Fiona Ebner > --- > debian/rules | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! not sure how many use the `noopt`, on debugging - for what it's mostly useful, bu

[pve-devel] applied-series: Re: [PATCH qemu-server 1/4] hotplug: disk: mark aio as non-hotpluggable

2023-02-14 Thread Thomas Lamprecht
On 10/02/2023 15:19, Fiona Ebner wrote: > Previously, changing aio would be applied to the configuration, but > the drive would still be using the old setting. > > Signed-off-by: Fiona Ebner > --- > PVE/QemuServer.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied series,

Re: [pve-devel] minor typo zfs -> zpool

2023-02-14 Thread Thomas Lamprecht
Hi, On 11/02/2023 00:54, Roland via pve-devel wrote: > > syscmd("zpool set bootfs=$zfspoolname/ROOT/$zfsrootvolname > $zfspoolname") == 0 || > die "zfs set bootfs failed\n"; > > that should have been: > > die "zpool set boofs failed\n"; Thanks for the report, fixed but kept boofs as bootfs ;-)

Re: [pve-devel] fosdem talk: k8s CRIU live migration support

2023-02-14 Thread Thomas Lamprecht
On 12/02/2023 10:16, DERUMIER, Alexandre wrote: > > It seem than k8s finally support CRIU live migration > > https://fosdem.org/2023/schedule/event/container_kubernetes_criu/ > interesting > > I don't known about lxc, but maybe is it finally working too ? with a limited feature set maybe, ar

[pve-devel] applied: Re: [PATCH V2 manager] fix #4335: report: add datacenter.cfg to output

2023-02-14 Thread Thomas Lamprecht
On 13/02/2023 10:19, Max Carrara wrote: > Includes the contents of /etc/pve/datacenter.cfg > in the cluster section. > > Signed-off-by: Max Carrara > --- > Changes from v1: > * Output of `/etc/pve/datacenter.cfg` is now in the cluster section, >as discussed[1] > > [1] https://lists.proxmox.

Re: [pve-devel] [PATCH container 1/2] net: Add `link_down` config to allow setting interfaces as disconnected

2023-02-14 Thread Christoph Heiss
Thanks for the review! On Mon, Feb 13, 2023 at 03:31:32PM +0100, Wolfgang Bumiller wrote: > On Mon, Feb 13, 2023 at 02:56:59PM +0100, Christoph Heiss wrote: > > [..] > > > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > > index ce6d5a5..039a476 100644 > > --- a/src/PVE/LXC.pm > > +++ b/src/PVE/LX

Re: [pve-devel] [PATCH qemu-server] feature #3937: config: store user in meta property

2023-02-14 Thread Thomas Lamprecht
On 13/02/2023 11:24, Leo Nunner wrote: > Adds a field to the "meta" config property which stores the user who > created the VM. Should also get this finally added to CTs, I know it's a bit unfair to add the burden to this patch series, but otherwise we might never add it.. > > Signed-off-by: Le

[pve-devel] applied: Re: [PATCH v2 widget-toolkit] ui: SMART: show SMART data in correct columns

2023-02-14 Thread Thomas Lamprecht
On 13/02/2023 12:12, Matthias Heiserer wrote: > Signed-off-by: Matthias Heiserer > --- > > Changes from v2: > make expression more compact > > > src/window/DiskSmart.js | 17 ++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > applied, thanks! _

Re: [pve-devel] [PATCH container 1/2] net: Add `link_down` config to allow setting interfaces as disconnected

2023-02-14 Thread Thomas Lamprecht
On 13/02/2023 14:56, Christoph Heiss wrote: > +link_down => { > + type => 'boolean', > + description => 'Whether this interface should be disconnected (like > pulling the plug).', > + optional => 1, > +}, I'd prefer using kebab-case over snake_case for new properties, or do we

Re: [pve-devel] [PATCH docs] vzdump: document the new cluster-wide config file

2023-02-14 Thread Thomas Lamprecht
On 09/02/2023 10:27, Leo Nunner wrote: > + change the wording from "Global configuration" to "Node-wide > configuration" > > Signed-off-by: Leo Nunner > --- > The wording was previously already changed by Fiona but hasn't been > merged yet: > > https://lists.proxmox.com/pipermail/pve-devel/2022-

Re: [pve-devel] [PATCH container 1/2] net: Add `link_down` config to allow setting interfaces as disconnected

2023-02-14 Thread Christoph Heiss
On Tue, Feb 14, 2023 at 10:52:15AM +0100, Thomas Lamprecht wrote: > On 13/02/2023 14:56, Christoph Heiss wrote: > > +link_down => { > > + type => 'boolean', > > + description => 'Whether this interface should be disconnected (like > > pulling the plug).', > > + optional => 1, > > +},

Re: [pve-devel] [PATCH container 1/2] net: Add `link_down` config to allow setting interfaces as disconnected

2023-02-14 Thread Thomas Lamprecht
On 14/02/2023 11:10, Christoph Heiss wrote: >> besides from that, the patch here contains quite some unrelated whitespace >> changes, please avoid that. > That was intentional (as noted), since there are trailing whitespaces > all over the file, which can be somewhat annoying if one's editor > auto

[pve-devel] applied: Re: [PATCH docs] pveum: remove `auth` part from Keycloak issuer URL

2023-02-14 Thread Thomas Lamprecht
On 09/02/2023 11:29, Lukas Wagner wrote: > Keycloak seems to have dropped the `auth` part at some point in the past. from some other references it seems to have happened in 18.0, but I did not find a clear releases/news list, so hard to tell for sure - anyhow, I got my local instance I upgraded ~

Re: [pve-devel] [PATCH manager] ceph osd: ui: show PGs per OSD

2023-02-14 Thread Thomas Lamprecht
On 14/02/2023 09:13, Aaron Lauterer wrote: > By switching from 'ceph osd tree' to the 'ceph osd df tree' mon API > equivalent , we get the same data structure with more information per the change looks almost too neat for using a completely different command, a bit fishy, but hey, if it works (rou

[pve-devel] [PATCH manager] ui: ldap: fix `Parameter verification error`

2023-02-14 Thread Lukas Wagner
...when editing LDAP realm sync settings and only a single property is empty and thus to be deleted (e.g. values.delete = "filter"). If `delete` is a simple string and not an array, `PVE.Utils.delete_if_default` simply creates a comma-separated list, (e.g. value.delete = "filter,sync-attributes").

Re: [pve-devel] [PATCH manager] ceph osd: ui: show PGs per OSD

2023-02-14 Thread Aaron Lauterer
I compared the returned values, but did not benchmark it. I'll follow up with the results. On 2/14/23 14:19, Thomas Lamprecht wrote: On 14/02/2023 09:13, Aaron Lauterer wrote: By switching from 'ceph osd tree' to the 'ceph osd df tree' mon API equivalent , we get the same data structure with m

Re: [pve-devel] [PATCH manager] ceph osd: ui: show PGs per OSD

2023-02-14 Thread Aaron Lauterer
Seems like the `osd df tree` call is about 25% slower, plus minus. Tested on our AMD test cluster that is currently set up with 3 nodes with 4 OSDs each. 50k iterations. root@jura1:~# ./bench.pl Rate osd-df-treeosd-tree osd-df-tree 9217/s ---27% osd-tree

Re: [pve-devel] [PATCH manager] ceph osd: ui: show PGs per OSD

2023-02-14 Thread Thomas Lamprecht
Am 14/02/2023 um 17:14 schrieb Aaron Lauterer: > Seems like the `osd df tree` call is about 25% slower, plus minus. > > Tested on our AMD test cluster that is currently set up with 3 nodes with 4 > OSDs each. 50k iterations. > > root@jura1:~# ./bench.pl >    Rate osd-df-treeosd-t