On 14/02/2023 11:10, Christoph Heiss wrote:
>> besides from that, the patch here contains quite some unrelated whitespace
>> changes, please avoid that.
> That was intentional (as noted), since there are trailing whitespaces
> all over the file, which can be somewhat annoying if one's editor
> automatically trims trailing whitespaces on save purposefully.
> But I will omit that from the next revision, fine by me.

I never said that fixing it is wrong, but it's completely unrelated for
your change, and thus noise - please do that in a separate patch upfront
for the next revision, then it could have been already applied now ;-)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to