On Tue, Feb 14, 2023 at 10:52:15AM +0100, Thomas Lamprecht wrote:
> On 13/02/2023 14:56, Christoph Heiss wrote:
> > + link_down => {
> > + type => 'boolean',
> > + description => 'Whether this interface should be disconnected (like
> > pulling the plug).',
> > + optional => 1,
> > + },
>
> I'd prefer using kebab-case over snake_case for new properties, or do
> we really gain anything here (e.g., qemu-server related infra reuse?)
Not that I would see. This was very much inspired by the qemu-server API
and would provide some form of "uniformity" between those two, but I
will change that for v2. kebap-case is nicer anyway.
>
> besides from that, the patch here contains quite some unrelated whitespace
> changes, please avoid that.
That was intentional (as noted), since there are trailing whitespaces
all over the file, which can be somewhat annoying if one's editor
automatically trims trailing whitespaces on save purposefully.
But I will omit that from the next revision, fine by me.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
