Re: [pve-devel] [pmg-devel] [PATCH pmg-api v2 5/7] revised task log download function in the PMG backend

2022-09-08 Thread Stefan Sterz
On 9/7/22 10:56, Daniel Tschlatscher wrote: > With the newly added button in the tasklog the implementation for the > PMG server needs to be adapted. I saw an opportunity here to clear > some redundant code for displaying the tasklog and replace it with a > call to dump_logfile(), akin to how this

Re: [pve-devel] [pmg-devel] [PATCH http/common/manager/wt/backup/pmg v2] fix: #3971 Tasklog download button

2022-09-08 Thread Stefan Sterz
On 9/7/22 10:56, Daniel Tschlatscher wrote: > This patch series' aim is to add a download button in the tasklog- > viewer GUI so that users may access all parts of the tasklog more > easily (The tasklog-viewer only displays 50 lines at a time). > > For this change in the GUI (proxmox-widget-toolki

[pve-devel] [PATCH pve-flutter-frontend 02/10] increase compileSdkVersion to 32

2022-09-08 Thread Dominik Csapak
current version of webview_flutter_android (2.10.0) needs it Signed-off-by: Dominik Csapak --- android/app/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/app/build.gradle b/android/app/build.gradle index d287d5b..27e8d55 100644 --- a/android/app/build.gr

[pve-devel] [PATCH proxmox-login-manager 3/3] improve colors of login screen

2022-09-08 Thread Dominik Csapak
default primary color was a purple hue that did not really fit with our theme. That was used on highlighting form fields and the progress indicator. I replaced it with orange since that fits nicely with the rest of the look and feel also removed the use of accentColor int he ProxmoxProgressOverlay

[pve-devel] [PATCH pve-flutter-frontend 06/10] move to ElevatedButton from RaisedButton

2022-09-08 Thread Dominik Csapak
flutter 3.0 removed RaisedButton Signed-off-by: Dominik Csapak --- lib/widgets/firstWelcomeScreen/pve_welcome_last.dart | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/widgets/firstWelcomeScreen/pve_welcome_last.dart b/lib/widgets/firstWelcomeScreen/pve_welcome_l

[pve-devel] [PATCH pve-flutter-frontend 09/10] fix guest backup widget start display

2022-09-08 Thread Dominik Csapak
when we changed from ScaffoldState to ScaffoldMessengerState, we missed that we have to wrap the scaffold in a ScaffoldMessenger, otherwise there is no current state and we never could show a snack we also have to do the null safety of the 'nodesVZDumpCreateBackup' differently, since we get a Futu

[pve-devel] [PATCH pve-flutter-frontend 04/10] move to OutlinedButton from OutlineButton

2022-09-08 Thread Dominik Csapak
flutter 3.0 removed OutlineButton in favor of OutlinedButton. also change the default text color to white, and drop an unnecessary padding in one case Signed-off-by: Dominik Csapak --- lib/main.dart | 10 ++ .../firstWelcomeScreen/pve_welcome_faq.dart

[pve-devel] [PATCH proxmox-login-manager 2/3] migrate from FlatButton to TextButton

2022-09-08 Thread Dominik Csapak
since flutter 3 removed FlatButton. For this we have to do the colors a little different, so i moved the color/disabledColor into the textButtonTheme, which does not modify anything else here. Signed-off-by: Dominik Csapak --- lib/proxmox_login_form.dart | 33 +++-- l

[pve-devel] [PATCH proxmox-login-manager/pve-flutter-frontend] fixes & update to flutter 3.3

2022-09-08 Thread Dominik Csapak
updates to the code for flutter 3.3 and includes some fixes & improvements i included aarons patches from december to make it easier to apply the changes necesseary for flutter 3.3 are proxmox-login-manager: 2/3 pve-flutter-frontend: 2/10 - 6/10 patches after that are only fixes & improvements (

[pve-devel] [PATCH pve-flutter-frontend 03/10] fix null handling in MainActivity.kt

2022-09-08 Thread Dominik Csapak
in newer flutter versions, call.arguments() can return null, so handle that Signed-off-by: Dominik Csapak --- .../kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/app/src/main/kotlin/com/proxmox/app/pve_flutt

[pve-devel] [PATCH pve-flutter-frontend 10/10] fix options view when ostype is null

2022-09-08 Thread Dominik Csapak
can happen when no ostype is set in the config (defaults to 'other') Signed-off-by: Dominik Csapak --- lib/widgets/pve_qemu_options_widget.dart | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/widgets/pve_qemu_options_widget.dart b/lib/widgets/pve_qemu_options_widget.

[pve-devel] [PATCH pve-flutter-frontend 07/10] improve colors for indicator/toggles

2022-09-08 Thread Dominik Csapak
so that it fits better with our color schemes instead of using the flutter defaults (which are especially bad in dark mode for our scheme) Signed-off-by: Dominik Csapak --- lib/main.dart | 4 1 file changed, 4 insertions(+) diff --git a/lib/main.dart b/lib/main.dart index d467626..c9b862e

[pve-devel] [PATCH pve-flutter-frontend 08/10] fix typo Opague -> Opaque

2022-09-08 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- lib/widgets/firstWelcomeScreen/pve_welcome_faq.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/widgets/firstWelcomeScreen/pve_welcome_faq.dart b/lib/widgets/firstWelcomeScreen/pve_welcome_faq.dart index 470d118..f2be574 100644 --- a/

[pve-devel] [PATCH proxmox-login-manager 1/3] login_form: keep Continue button above Android softnav

2022-09-08 Thread Dominik Csapak
From: Aaron Lauterer By placing the items in a SafeArea we avoid having the "Continue" button behind the Android soft navigation buttons. Signed-off-by: Aaron Lauterer Signed-off-by: Dominik Csapak --- lib/proxmox_login_form.dart | 265 ++-- 1 file changed, 135

[pve-devel] [PATCH pve-flutter-frontend 05/10] move to TextButton from FlatButton

2022-09-08 Thread Dominik Csapak
flutter 3.0 removed FlatButton Signed-off-by: Dominik Csapak --- lib/pages/main_layout_slim.dart | 2 +- lib/widgets/pve_console_menu_widget.dart | 4 +-- lib/widgets/pve_first_welcome_screen.dart | 32 --- lib/widgets/pve_guest_backup_widget.dart |

[pve-devel] [PATCH pve-flutter-frontend 01/10] avoid elements hiding behind Android softnav buttons

2022-09-08 Thread Dominik Csapak
From: Aaron Lauterer In a few places we had elements hiding behind the Android soft nav buttons at the bottom. Those were: * Qemu HW overview list * Qemu Power Control menu * LXC and Qemu Options list Placing them within a SafeArea avoids that. Signed-off-by: Aaron Lauterer Signed-off-by: Dom

Re: [pve-devel] [pmg-devel] [PATCH pmg-api v2 5/7] revised task log download function in the PMG backend

2022-09-08 Thread Daniel Tschlatscher
On 9/8/22 11:36, Stefan Sterz wrote: > On 9/7/22 10:56, Daniel Tschlatscher wrote: >> With the newly added button in the tasklog the implementation for the >> PMG server needs to be adapted. I saw an opportunity here to clear >> some redundant code for displaying the tasklog and replace it with

[pve-devel] applied-series: [PATCH proxmox-login-manager/pve-flutter-frontend] fixes & update to flutter 3.3

2022-09-08 Thread Thomas Lamprecht
Am 08/09/2022 um 11:55 schrieb Dominik Csapak: > updates to the code for flutter 3.3 and includes some fixes & improvements > > i included aarons patches from december to make it easier to apply > > the changes necesseary for flutter 3.3 are > proxmox-login-manager: 2/3 > pve-flutter-frontend: 2/

Re: [pve-devel] [PATCH manager] fix #2435: GUI: LXC summary: Add privileged status and os type

2022-09-08 Thread Thomas Lamprecht
Can you please split this into two commits, first the unpriv one and then the OS type one? Am 08/08/2022 um 13:48 schrieb Matthias Heiserer: > --- > > I'm a bit unsure about the icons, there are probably better ones, but I > couldn't > think of/find any. One alternative for OS type would be the