[pve-devel] applied: [PATCH manager] ceph install wizard: fix #3597: don't autofill network

2022-06-08 Thread Thomas Lamprecht
Am 02/06/2022 um 15:30 schrieb Stefan Hrdlicka: > Tried it and works as expected. > > I can't answer the original mail, since I joined the mailing list a bit later > :). Really no biggie, but FYI, it depends on the capabillities of your mail client/MUA but normally you'd only need to add a "In-

[pve-devel] [PATCH proxmox-widget-toolkit 1/1] ui: disks: add 'mounted' column

2022-06-08 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/panel/DiskList.js | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js index eb8b1a8..76d92cd 100644 --- a/src/panel/DiskList.js +++ b/src/panel/DiskList.js @@ -35,7 +35,7 @@ Ext.define('pmx-

[pve-devel] [PATCH pve-storage 1/1] api2: disks: add mounted boolean field

2022-06-08 Thread Hannes Laimer
... and remove '(mounted)' from usage string Signed-off-by: Hannes Laimer --- PVE/API2/Disks.pm | 1 + PVE/Diskmanage.pm | 7 +++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Disks.pm b/PVE/API2/Disks.pm index b618057..bde6132 100644 --- a/PVE/API2/Disks.pm +++ b/P

[pve-devel] [PATCH proxmox-widget-toolkit/pve-storage] replace '(mounted)' string by boolean field

2022-06-08 Thread Hannes Laimer
The mounted status of a disk/partition is now a separate column instead of the '(mounted)' that is added to the usage string. This change seems reasonable on its own, but it is mostly so the UI works properly with the data that will be returned from the PBS api. We could also return the mountpoint

Re: [pve-devel] [PATCH v5 qemu-server 7/9] api2: qemu : don't display cloudinit value

2022-06-08 Thread Fabian Ebner
Am 16.05.22 um 18:07 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Qemu.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 1d5b66f..57a75fc 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -1227,

Re: [pve-devel] [PATCH v5 qemu-server 0/9] cloudinit pending behaviour change

2022-06-08 Thread Fabian Ebner
Am 16.05.22 um 18:07 schrieb Alexandre Derumier: > Changelog v5: > > - move cloudinit fast_plug_option generation outside vmconfig_hotplug_pending > - remove cloudinit section from vm_config api > - vzdump : skip cloudinit section > - migration: check target node version && forbid migration if to

Re: [pve-devel] [PATCH v5 qemu-server 9/9] migration: test targetnode min version for cloudinit section

2022-06-08 Thread Fabian Ebner
Am 16.05.22 um 18:07 schrieb Alexandre Derumier: > @@ -122,6 +123,13 @@ sub prepare { > # test if VM exists > my $conf = $self->{vmconf} = PVE::QemuConfig->load_config($vmid); > > +my $version = get_node_pvecfg_version($self->{node}); > +my $cloudinit_config = $conf->{cloudinit}

Re: [pve-devel] [PATCH manager] fix #3961: pveam: error if storage doesn't exist on 'list'

2022-06-08 Thread Oguz Bektas
ping ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [RFC/PATCH v2 qemu 1/3] PVE-Backup: create jobs: correctly cancel in error scenario

2022-06-08 Thread Wolfgang Bumiller
On Wed, May 25, 2022 at 01:59:37PM +0200, Fabian Ebner wrote: > The first call to job_cancel_sync() will cancel and free all jobs in > the transaction, so ensure that it's called only once and get rid of > the job_unref() that would operate on freed memory. > > It's also necessary to NULL backup_s

[pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning

2022-06-08 Thread Daniel Bowder
These five patches add the ability to pin a QEMU VMs processes to a defined set of CPU cores. The changes required spanned multiple repos and have all been included in these five patches. The patches add "cpuset" as an option in the qm configuration file and enable the editing of this parameter

[pve-devel] [PATCH 4/5] fix #3593: Added vm core pinning proxmox-widget-toolkit

2022-06-08 Thread Daniel Bowder
Signed-off-by: Daniel Bowder --- The fourth patch adds a javascript type for CPUSet. This type can use a regex match to (mostly) ensure the user types a correct cpuset. There are some fringe cases where the CPUSet can pass the CPUSet_match, but then fail the checks in patch three. (e.g. 0,5-4

[pve-devel] [PATCH 2/5] fix #3593: Added vm core pinning pve-guest-common

2022-06-08 Thread Daniel Bowder
Signed-off-by: Daniel Bowder --- The second patch adds a utility function to obtain the pid of the VM, then calls taskset on that pid with the cpuset in the qm conf. This execution of taskset pins the VMs process to the defined cpu cores. This utility function acts similarly to the exec_hooksc

[pve-devel] [PATCH 1/5] fix #3593: Added vm core pinning pve-docs

2022-06-08 Thread Daniel Bowder
Signed-off-by: Daniel Bowder --- The first patch adds an entry to the qm conf adding a new option: cpuset. The cpuset here is the same cpuset used by the taskset application for pinning a process to a cpu core. This can be found in `man cpuset`, or https://linux.die.net/man/7/cpuset qm.conf.

[pve-devel] [PATCH 3/5] fix #3593: Added vm core pinning qemu-server

2022-06-08 Thread Daniel Bowder
Signed-off-by: Daniel Bowder --- The third patch adds cpuset as a valid object in the qm conf file. A new type is created called 'pve-cpuset' so that the cpuset can go through some validation before passing it to the taskset command. The exec_taskset command is executed just after the 'post-st

[pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager

2022-06-08 Thread Daniel Bowder
Signed-off-by: Daniel Bowder --- The fifth patch adds the cpuset value to the GUI under the VM.Config.Options panel. The cpuset is set as a vtype of CPUSet so that it can be checked by the regex match in the fouth patch. This was modeled after the existing 'name' option, where the labels and t

Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning

2022-06-08 Thread Matthias Heiserer
On 08.06.2022 13:54, Daniel Bowder wrote: These five patches add the ability to pin a QEMU VMs processes to a defined set of CPU cores. The changes required spanned multiple repos and have all been included in these five patches. The patches add "cpuset" as an option in the qm configuration fi

Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning

2022-06-08 Thread Daniel Bowder
> Thank you for your patches! You are welcome. > Regarding the formatting: Please make sure to follow our Perl and > Javascript style guides [0][1] and the Developer Documentation [2]. All > your patches use a nonconformant indentation :/ I do apologize for that. I read [0] and [2] in their entire

Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning

2022-06-08 Thread Matthias Heiserer
On 08.06.2022 15:21, Daniel Bowder wrote: Thank you for your patches! You are welcome. Regarding the formatting: Please make sure to follow our Perl and Javascript style guides [0][1] and the Developer Documentation [2]. All your patches use a nonconformant indentation :/ I do apologize for t

Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning

2022-06-08 Thread Daniel Bowder
> Yes, exactly! Make sure to also add a version in the commit message(e.g: > "[pve-devel] [PATCH v2 pve-manager 4/5] fix #3593"), and describe which > changes were made since the last version. You can take a look at other > mails so see how it is done: > https://lists.proxmox.com/pipermail/pve-deve

Re: [pve-devel] [PATCH 1/5] fix #3593: Added vm core pinning pve-docs

2022-06-08 Thread Matthias Heiserer
On 08.06.2022 13:54, Daniel Bowder wrote: Signed-off-by: Daniel Bowder --- The first patch adds an entry to the qm conf adding a new option: cpuset. The cpuset here is the same cpuset used by the taskset application for pinning a process to a cpu core. This can be found in `man cpuset`, or

Re: [pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager

2022-06-08 Thread Matthias Heiserer
On 08.06.2022 13:54, Daniel Bowder wrote: Signed-off-by: Daniel Bowder --- The fifth patch adds the cpuset value to the GUI under the VM.Config.Options panel. The cpuset is set as a vtype of CPUSet so that it can be checked by the regex match in the fouth patch. This was modeled after the exis

Re: [pve-devel] [PATCH 3/5] fix #3593: Added vm core pinning qemu-server

2022-06-08 Thread Matthias Heiserer
I'm not sure where it comes from, but when starting a VM, the task log receives a bunch of messages on changed affinity: pid 95121's current affinity list: 0-7 pid 95121's new affinity list: 2,3 pid 95122's current affinity list: 0-7 pid 95122's new affinity list: 2,3 pid 95123's current affinit

[pve-devel] [PATCH V2 SERIES storage/manager/docs 0/3] add ZFS dRAID creation

2022-06-08 Thread Stefan Hrdlicka
V1 -> V2: # pve-storage * formating change * fixing typos & wording * added check if dRAID options draidspares & draiddata are used for something else then setting up a dRAID # pve-manager * add a viewModel and use a binding for visiblity * remove controller # pve-docs * fix many typos * reword

[pve-devel] [PATCH V2 storage 1/3] fix #3967: enable ZFS dRAID creation via API

2022-06-08 Thread Stefan Hrdlicka
It is possible to set the number of spares and the size of data stripes via draidspares & dreaddata parameters. Signed-off-by: Stefan Hrdlicka --- PVE/API2/Disks/ZFS.pm | 44 ++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Disks/

[pve-devel] [PATCH V2 manager 2/3] fix #3967: enable ZFS dRAID creation in WebGUI

2022-06-08 Thread Stefan Hrdlicka
add fields for additional settings required by ZFS dRAID Signed-off-by: Stefan Hrdlicka --- www/manager6/node/ZFS.js | 44 1 file changed, 44 insertions(+) diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js index 5b3bdbda..5276ff84 100644 -

[pve-devel] [PATCH V2 pve-docs 3/3] fix #3967: add ZFS dRAID documentation

2022-06-08 Thread Stefan Hrdlicka
add some basic explanation how ZFS dRAID works including links to openZFS for more details add documentation for two dRAID parameters used in code Signed-off-by: Stefan Hrdlicka --- local-zfs.adoc | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) d

Re: [pve-devel] [PATCH V2 storage 1/3] fix #3967: enable ZFS dRAID creation via API

2022-06-08 Thread Thomas Lamprecht
Am 08/06/2022 um 17:34 schrieb Stefan Hrdlicka: > It is possible to set the number of spares and the size of > data stripes via draidspares & dreaddata parameters. > looks functional but din't test it, some api design suggestions and small style nits inline. > Signed-off-by: Stefan Hrdlicka >