On October 25, 2024 10:04 pm, DERUMIER, Alexandre wrote:
> Message initial
> De: Fabian Grünbichler
> À: Proxmox VE development discussion ,
> "DERUMIER, Alexandre"
> Cc: Giotta Simon RUAGH
> Objet: Re: [pve-devel] [PATCH v2 pve-storage 1/2] add
--- Begin Message ---
Message initial
De: Fabian Grünbichler
À: Proxmox VE development discussion ,
"DERUMIER, Alexandre"
Cc: Giotta Simon RUAGH
Objet: Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external snasphot
support
Date: 24/10/2024 11:48:03
> Giotta Si
--- Begin Message ---
>
>
> But even with that, you can still have performance impact.
> So yes, I think they are really usecase for workload when you only
> need
> snapshot time to time (before an upgrade for example), but max
> performance with no snaphot exist.
>>my main point here is - all o
t discussion
> >>Cc: Alexandre Derumier
> >>Objet: Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external
> >>snasphot support
> >>Date: 23/10/2024 12:12:46
> >>
> >>some high level comments:
> >>
> >>I am not sure how much
> Giotta Simon RUAGH via pve-devel hat am
> 24.10.2024 09:59 CEST geschrieben:
> > I mean, if we don't allow .raw files to be snapshotted then this problem
> > doesn't exist ;)
>
> Quick comment from the bleacher; Adding a mechanism to shapshot raw disks
> might solve the TPM (tpmstate) snap
> Fabian Grünbichler hat am 23.10.2024 12:12 CEST
> geschrieben:
>
>
> some high level comments:
>
> I am not sure how much we gain here with the raw support? it's a bit
> confusing to have a volid ending with raw, with the current volume and all
> but the first snapshot actually being sto
Alexandre Derumier
> >>Objet: Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external
> >>snasphot support
> >>Date: 23/10/2024 12:12:46
> >>
> >>some high level comments:
> >>
> >>I am not sure how much we gain here with the raw suppor
--- Begin Message ---
Hi Fabian,
thanks for the review !
>> Message initial
>>De: Fabian Grünbichler
>>À: Proxmox VE development discussion
>>Cc: Alexandre Derumier
>>Objet: Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external
>>snasphot
some high level comments:
I am not sure how much we gain here with the raw support? it's a bit confusing
to have a volid ending with raw, with the current volume and all but the first
snapshot actually being stored in qcow2 files, with the raw file being the
"oldest" snapshot in the chain..
if
--- Begin Message ---
Signed-off-by: Alexandre Derumier
---
src/PVE/Storage/DirPlugin.pm | 1 +
src/PVE/Storage/Plugin.pm| 225 +++
2 files changed, 201 insertions(+), 25 deletions(-)
diff --git a/src/PVE/Storage/DirPlugin.pm b/src/PVE/Storage/DirPlugin.pm
i
10 matches
Mail list logo
