Useful to detect whether a system is running version 0.6.0 or 0.6.1 of
the package which changed to the `ntfs3` driver from the `ntfs` driver.
Signed-off-by: Maximiliano Sandoval
---
PVE/API2/APT.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index
This is not fully integrated at the moment.
The documentation for the `fencing` option in datacenter.cfg suggests
that /etc/pve/ha/fence.cfg can used for configuring fence devices but
such a config file is not documented anywhere.
Signed-off-by: Maximiliano Sandoval
---
ha-manager.adoc | 2
Having a hardware watchdog is not a requirement, we move it out of the
list so it is not as prominent.
Signed-off-by: Maximiliano Sandoval
---
ha-manager.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ha-manager.adoc b/ha-manager.adoc
index 7f7f0bb..5fdd5cf 100644
.
Maximiliano Sandoval (2):
ha-manager: remove hardware fencing from requirements
ha-manager: move hardware watchdog out of the requirements list
ha-manager.adoc | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--
2.39.5
___
pve-devel mailing
The sole purpose of this commit is to make the following commit's diff
easier to read.
Signed-off-by: Maximiliano Sandoval
---
src/watchdog-mux.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c
index b4bcc0c..a9
variable names in the second commit could use some feedback. The way the
warning timeout is defined was arbitrary (10 seconds before the fence).
Maximiliano Sandoval (3):
watchdog: separate if in two parts
watchdog: warn when about to expire
watchdog: sync journal after sending expiration related
Signed-off-by: Maximiliano Sandoval
---
src/watchdog-mux.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c
index a9017b3..e14c768 100644
--- a/src/watchdog-mux.c
+++ b/src/watchdog-mux.c
@@ -29,15 +29,24 @@
#define
One sync comes after warning that the watchdog is about to expire, and a
second right after the watchdog expires.
To maximize the chances the log will contain entries relevant to a fence
event. This would be extremely useful for detecting whether a node
fenced.
Signed-off-by: Maximiliano
Signed-off-by: Maximiliano Sandoval
---
src/PVE/DataCenterConfig.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
index a3db78e..205b784 100644
--- a/src/PVE/DataCenterConfig.pm
+++ b/src/PVE/DataCenterConfig.pm
Signed-off-by: Maximiliano Sandoval
---
www/manager6/window/Restore.js | 10 ++
1 file changed, 10 insertions(+)
diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
index 22900868..8d6dfabe 100644
--- a/www/manager6/window/Restore.js
+++ b/www/manager6/window
owser) and its information is lost
without this change.
Signed-off-by: Maximiliano Sandoval
---
www/manager6/window/LoginWindow.js | 8
1 file changed, 8 insertions(+)
diff --git a/www/manager6/window/LoginWindow.js
b/www/manager6/window/LoginWindow.js
index a1ba3cdb..066c053a 100644
Fabian Grünbichler writes:
> On April 15, 2025 11:38 am, Maximiliano Sandoval wrote:
>> We only create this directory while installing the package. If a user
>> deletes /var/log then they will lose access to the web UI.
>
> until the reinstall or upgrade the packag
We only create this directory while installing or upgrading the package.
If a user deletes /var/log then they will lose access to the web UI
until they either reinstall or upgrade pve-manager.
Signed-off-by: Maximiliano Sandoval
---
Differences from v1:
- Unconditionally call mkdir+chown if
We only create this directory while installing the package. If a user
deletes /var/log then they will lose access to the web UI.
Signed-off-by: Maximiliano Sandoval
---
bin/pveproxy | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/bin/pveproxy b/bin
Signed-off-by: Maximiliano Sandoval
---
Some minor adjustments I found. Nothing urgent.
es.po | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/es.po b/es.po
index 2506f23..5e8c75e 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr ""
"Pro
Previously a password "bär12345" would be stored as "b�r12345".
Signed-off-by: Maximiliano Sandoval
---
This has the potential for breaking existing setups. However, given that it is
not possible to create such a storage in the first place (without performing a
rare e
Signed-off-by: Maximiliano Sandoval
---
es.po | 190 +++---
1 file changed, 88 insertions(+), 102 deletions(-)
diff --git a/es.po b/es.po
index 1f2556a..a6d7288 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr ""
"Pro
Signed-off-by: Maximiliano Sandoval
---
es.po | 43 ---
1 file changed, 20 insertions(+), 23 deletions(-)
diff --git a/es.po b/es.po
index afa25b1..2506f23 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-Version: proxm
server address.
>
> Reported-by: Christian Ebner
> Signed-off-by: Christoph Heiss
I am a bit late here, I tested this patch with either one or three NICs
and with and without a working DHCP server. I did not notice any
regression.
Tested-by: Maximiliano Sandoval
_
t;: "ci",
+ "côte d'ivoire": "ci",
"denmark": "dk",
"djibouti": "dj",
"dominica": "dm",
@@ -2590,8 +2590,8 @@
"romania": "ro",
"russian federation": &q
Friedrich Weber writes:
> If I read the journald.conf docs [1] right, the default interval is 30s
> and the burst value is 1 multiplied by a factor depending on the
> free disk space, I guess 4-6 on reasonable setups -- this is a lot of
> messages, but as you mention probably fine for limit
desktop.org/software/systemd/man/latest/systemd.system-credentials.html
Suggested-by: Wolfgang Bumiller
Signed-off-by: Maximiliano Sandoval
---
Differences from RFC:
- Fixed multiple points from the feedback in the RFC
- Uses "systemd-cred$i" instead of "systemd-credential.$name&qu
Gabriel Goller writes:
> bump, still applies
If I am not mistaken, this could use `+ use<'a>` instead of `+ 'a`.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Maximiliano Sandoval
---
proxmox-ve-config/src/firewall/cluster.rs | 6 --
proxmox-ve-config/src/firewall/common.rs | 4 ++--
proxmox-ve-config/src/firewall/ct_helper.rs| 2 +-
proxmox-ve-config/src/firewall/guest.rs| 4 ++--
proxmox-ve
Signed-off-by: Maximiliano Sandoval
---
proxmox-ve-config/src/firewall/parse.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/proxmox-ve-config/src/firewall/parse.rs
b/proxmox-ve-config/src/firewall/parse.rs
index 7bf00c0..8cf4757 100644
--- a/proxmox-ve-config/src
See
https://doc.rust-lang.org/nightly/edition-guide/rust-2024/rpit-lifetime-capture.html.
Signed-off-by: Maximiliano Sandoval
---
proxmox-ve-config/src/firewall/bridge.rs | 2 +-
proxmox-ve-config/src/sdn/config.rs | 12 ++--
proxmox-ve-config/src/sdn/ipam.rs| 2 +-
3
Fabian Grünbichler writes:
> On September 24, 2024 4:35 pm, Maximiliano Sandoval wrote:
>> Allows to pass systemd credentials to a VM. See [1] for a description of
>> systemd credentials. This can be potentially used to provision a VM as
>> per [2]. Values can be passed
Friedrich Weber writes:
> Since c761053 ("Check packets come from the correct interface
> https://github.com/corosync/corosync/issues/750";) in kronosnet,
> corosync will produce log messages in certain broken network setups.
> See inner patch for details. Drawing attention to such setups is
>
since the
visible-child (and visible-child-name) property still points to it.
Reported-by: Alexander Zeidler
Signed-off-by: Maximiliano Sandoval
---
Differences from v1:
- Improve commit message
- Describe better the reproducer in the commit
proxinstall | 1 +
1 file changed, 1 insertion
Thomas Lamprecht writes:
> Am 01.04.25 um 15:09 schrieb Maximiliano Sandoval:
>> The commit message should be updated, I will do that if there is a need
>> for v2.
>
> Can you please either send out a v2 or propose a new commit message that I
> can just copy+past
Thomas Lamprecht writes:
> Am 03.04.25 um 09:49 schrieb Thomas Lamprecht:
>> Am 02.04.25 um 16:36 schrieb Maximiliano Sandoval:
>>> Allows to pass system and service credentials to a VM. See [1] for a
>>> description of credentials. This can be potentially used to p
Thomas Lamprecht writes:
> Am 02.04.25 um 16:36 schrieb Maximiliano Sandoval:
>> Allows to pass system and service credentials to a VM. See [1] for a
>> description of credentials. This can be potentially used to provision a
>> VM as per [2]. Values can be passed either
Stefan Hanreich writes:
> Add a type for representing Linux hostnames. These are the same
> constraints as the installer enforces [1]. Lowercasing is fine as
> well, since practically everything treats hostnames case-insensitively
> as RFC 952 stipulates:
>
>> No distinction is made between upp
"Christoph Heiss" writes:
> On Tue Mar 4, 2025 at 11:49 AM CET, Maximiliano Sandoval wrote:
>> Whenever a filesystem is selected we show the size selection stack page.
>>
>> At the moment entering any raid setup, then entering the Advanced
>> Options page
Signed-off-by: Maximiliano Sandoval
---
Cargo.toml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Cargo.toml b/Cargo.toml
index dc7f312..2d3f50d 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -9,7 +9,7 @@ resolver = "2"
[workspace.package]
authors = ["Proxm
Max Carrara writes:
> Add docstrings for the following methods:
> - on_add_hook
> - on_update_hook
> - on_delete_hook
>
> Signed-off-by: Max Carrara
> ---
> src/PVE/Storage/PluginBase.pm | 85 ++-
> 1 file changed, 74 insertions(+), 11 deletions(-)
>
> diff --g
Max Carrara writes:
> Add docstrings for the following methods:
> - check_connection
> - activate_storage
> - deactivate_storage
> - status
> - cluster_lock_storage
> - parse_volname
> - get_subdir
> - filesystem_path
> - path
> - find_free_diskname
>
> Signed-off-by: Max Carrara
> ---
> src/
ow_bug.cgi?id=5420#c0
> [6]
> https://lore.proxmox.com/pve-devel/a03631a3-fe78-7f6f-137d-7ee6fdf8f...@proxmox.com/
> [7]
> https://git.proxmox.com/?p=proxmox.git;a=blob;f=proxmox-notify/src/endpoints/webhook.rs;h=34dbac5488;hb=7abd2da759d#l266
> [8]
> https://lore.proxm
Thomas Lamprecht writes:
> btw. instead of pinging a series unconditionally a better approach might
> be to use that as an opportunity to self-test the whole series, i.e. apply
> them locally and see if all works out; that would have made most issues of
> this series visible.
> If that succeede
Maximiliano Sandoval writes:
> Maximiliano Sandoval writes:
>
>> Maximiliano Sandoval writes:
>>
>>> Maximiliano Sandoval writes:
>>>
>>>> Maximiliano Sandoval writes:
>>>>
>>>>> Maximiliano Sandoval writes:
>&g
At the moment, the color of the preview tag won't match the final tag
once it is added if the tag contained uppercase letters. With this patch
the color in the tag being created will match the color of the final tag
added to a guest.
Signed-off-by: Maximiliano Sandoval
---
www/manager6
Maximiliano Sandoval writes:
> Splitting the strings adds extra work to translators as they now have
> less context to work with.
>
> Signed-off-by: Maximiliano Sandoval
ping.
___
pve-devel mailing list
pve-devel@lists.proxm
Maximiliano Sandoval writes:
> Whenever a filesystem is selected we show the size selection stack page.
>
> At the moment entering any raid setup, then entering the Advanced
> Options page and then selecting any non-raid setup will show the
> raiddisk page since it is still th
Fixes the manual_pattern_char_comparison clippy lint.
Signed-off-by: Maximiliano Sandoval
---
pve-rs/src/tfa.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pve-rs/src/tfa.rs b/pve-rs/src/tfa.rs
index 66dca3d..2cd7396 100644
--- a/pve-rs/src/tfa.rs
+++ b/pve-rs/src
Signed-off-by: Maximiliano Sandoval
---
pve-rs/Cargo.toml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pve-rs/Cargo.toml b/pve-rs/Cargo.toml
index 64a7e92..81a8396 100644
--- a/pve-rs/Cargo.toml
+++ b/pve-rs/Cargo.toml
@@ -4,7 +4,7 @@ version = "0.9.2"
descript
Maximiliano Sandoval writes:
> Signed-off-by: Maximiliano Sandoval
I forgot to run rustfmt after switching to 2024 🙊.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Maximiliano Sandoval
---
Cargo.toml | 2 +-
rustfmt.toml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Cargo.toml b/Cargo.toml
index 0f4e3b0..5a8e1d0 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -6,7 +6,7 @@ authors = [
"Lukas Wagner ",
With rust 2024 edition.
Signed-off-by: Maximiliano Sandoval
---
src/main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main.rs b/src/main.rs
index 4662ffa..795b0f2 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -23,9 +23,9 @@ use std::path::Path;
use anyhow::Error
Signed-off-by: Maximiliano Sandoval
---
pmg-rs/Cargo.toml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pmg-rs/Cargo.toml b/pmg-rs/Cargo.toml
index 2499f40..a6f4bb1 100644
--- a/pmg-rs/Cargo.toml
+++ b/pmg-rs/Cargo.toml
@@ -4,7 +4,7 @@ version = "0.7.7"
descript
pve-rs/libpve-rs-perl_0.9.2_amd64.buildinfo
pve-rs/libpve-rs-perl_0.9.2_amd64.changes
pve-rs/libpve-rs-perl_0.9.2_amd64.deb
Signed-off-by: Maximiliano Sandoval
---
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 635276e..4c74514 100644
--- a
Dbus has a limit of 512 connections by default and signals should be
disconnected as soon as they are not needed anymore.
This should alleviate https://bugzilla.proxmox.com/show_bug.cgi?id=5876.
Signed-off-by: Maximiliano Sandoval
---
Differences from v1:
- remove two guards on
Wolfgang Bumiller writes:
> On Mon, Mar 03, 2025 at 03:42:53PM +0100, Maximiliano Sandoval wrote:
>> Dbus has a limit of 512 connections by default and signals should be
>> disconnected as soon as they are not needed anymore.
>>
>> This should alleviate h
-off-by: Maximiliano Sandoval
---
proxinstall | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxinstall b/proxinstall
index fe7e29f..5e61e9b 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1358,6 +1358,7 @@ sub create_hdoption_view {
$options_stack->set_visible_child_name("
Dbus has a limit of 512 connections by default and signals should be
disconnected as soon as they are not needed anymore.
This should alleviate https://bugzilla.proxmox.com/show_bug.cgi?id=5876.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Systemd.pm | 34
..before running systemctl. Allows for building packages in containers
not managed by systemd.
Signed-off-by: Maximiliano Sandoval
---
debian/pve-ha-manager.postinst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/pve-ha-manager.postinst b/debian/pve-ha
Splitting the strings adds extra work to translators as they now have
less context to work with.
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/OSD.js| 6 +++---
www/manager6/dc/OptionView.js | 2 +-
www/manager6/panel/BackupAdvancedOptions.js | 2
Signed-off-by: Maximiliano Sandoval
---
examples/guest-example-hookscript.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/guest-example-hookscript.pl
b/examples/guest-example-hookscript.pl
index adeed59e..13460250 100755
--- a/examples/guest-example-hookscript.pl
Signed-off-by: Maximiliano Sandoval
---
html/pmg/extract3-spam.htm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/html/pmg/extract3-spam.htm b/html/pmg/extract3-spam.htm
index 6b3551a..62bf009 100644
--- a/html/pmg/extract3-spam.htm
+++ b/html/pmg/extract3-spam.htm
Signed-off-by: Maximiliano Sandoval
---
es.po | 35 +--
1 file changed, 13 insertions(+), 22 deletions(-)
diff --git a/es.po b/es.po
index 7304b45..4ec64d0 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-Version: proxmox
"Shannon Sterz" writes:
> On Fri Jan 24, 2025 at 3:37 PM CET, Maximiliano Sandoval wrote:
>> The catalog-{lang}.mo files are generated only with strings that are
>> relevant to the proxmox-datacenter-manager instead of the whole
>> {lang}.po file. The msgmerge c
Maximiliano Sandoval writes:
> Maximiliano Sandoval writes:
>
>> Maximiliano Sandoval writes:
>>
>>> Maximiliano Sandoval writes:
>>>
>>>> Maximiliano Sandoval writes:
>>>>
>>>>> The catalog-{lang}.mo files are ge
ir/$volume");
>> return if $name ne $basename;
>> - return if !defined $snap_name;
>> $code->($snap_name);
>> });
>> }
>
> but I need to ask about this patch first.
Requiring the argument to be defined sounds sensible for a he
g_string_append_printf should only be used when there is something to
format.
Signed-off-by: Maximiliano Sandoval
---
Some micro optimizations for GStrings usage.
The following script can be used to verify the claim that the replacements are
drop-in:
```c
/* test.c */
#include
int
main
Signed-off-by: Maximiliano Sandoval
---
src/pmxcfs/logger.c | 2 +-
src/pmxcfs/status.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/pmxcfs/logger.c b/src/pmxcfs/logger.c
index 0be4be6..d6e281f 100644
--- a/src/pmxcfs/logger.c
+++ b/src/pmxcfs/logger.c
@@ -201,7
Signed-off-by: Maximiliano Sandoval
---
src/pmxcfs/status.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index e76c150..7533057 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/status.c
@@ -973,7 +973,7
A minor comment bellow.
Stefan Hanreich writes:
> When the firewall key wasn't present in the network device
> configuration of a guest, the firewall defaulted to on instead of off.
> Since the UI omitted the firewall setting in the API calls when it is
> unchecked, there was no way for the fi
the force (-f)
flag, and in such case the received_uuid property is lost. Since we know
the images are only set to rw for the duration of the move, it is safe
to set the flag forcefully and then in a future commit add the
received_uuid property by force.
Signed-off-by: Maximiliano Sandoval
In this context a subvolume means a BTRFS subvolume.
`$volume\@$snap_name` would be for example
`btrfs_volume/images/102/vm-102-disk-0@snap_name`.
Signed-off-by: Maximiliano Sandoval
---
Differences from v3:
- Rename regex
- Delete now useless foreach_suvbol helper
Differences from v2
This method is not used anymore.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Storage/BTRFSPlugin.pm | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm
index bd93cc0..c82d5f7 100644
--- a/src
Replaces the current use without changes. The `$dir` variable is not
used anymore at that moment so it is defined later.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Storage/BTRFSPlugin.pm | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/PVE/Storage
It was originally introduced as $snapshot to match the argument name of
foreach_subvol, we rename it here to make it clear that it only contains
the snapshot name.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Storage/BTRFSPlugin.pm | 8
1 file changed, 4 insertions(+), 4 deletions
The regex only lists snapshots.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Storage/BTRFSPlugin.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm
index 9fc51ef..bd93cc0 100644
--- a/src/PVE/Storage
disk `vm-100-disk-1` which is also listed
by the dir_glib_foreach.
By using the helper we only iterate over the snapshots of the guest.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Storage/BTRFSPlugin.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/PVE/St
disk `vm-100-disk-1` which is also listed
by the dir_glib_foreach.
By using the helper we only iterate over the snapshots of the guest.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Storage/BTRFSPlugin.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/PVE/St
In this context a subvolume means a BTRFS subvolume.
`$volume\@$snap_name` would be for example
`btrfs_volume/images/102/vm-102-disk-0@snap_name`.
Signed-off-by: Maximiliano Sandoval
---
Differences from v2:
- Split into multiple commits
- Simplify patch
- Use only the snapshot name in the
Replaces the current use without changes. The `$dir` variable is not
used anymore at that moment so it is defined later.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Storage/BTRFSPlugin.pm | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/PVE/Storage
the force (-f)
flag, and in such case the received_uuid property is lost. Since we know
the images are only set to rw for the duration of the move, it is safe
to set the flag forcefully and then in a future commit add the
received_uuid property by force.
Signed-off-by: Maximiliano Sandoval
the force (-f)
flag, and in such case the received_uuid property is lost. Since we know
the images are only set to rw for the duration of the move, it is safe
to set the flag forcefully and then in a future commit add the
received_uuid property by force.
Signed-off-by: Maximiliano Sandoval
disk `vm-100-disk-1` which is also listed
by the dir_glib_foreach.
This change adds a helper foreach_snapshot_of_subvol which only lists
snapshots for the current volume.
The helper is also implemented in the other place where we iterate over
snapshots.
Signed-off-by: Maximiliano San
Fiona Ebner writes:
> Am 09.07.24 um 13:51 schrieb Maximiliano Sandoval:
>> Suppose we are doing a snapshot of disk 0 for VM 100. The
>> dir_glob_foreach runs over $path=/subvolume/images/100, lists all
>> snapshot names and appends their names to the path of the dis
Fabian Grünbichler writes:
> I think we do need to ship the file in both places before 9.0 and switch
> over to using the new location (i.e., almost what this patch does), and
> then we can drop the old location with 9.0 since we know that no
> reference to the old location should still be in us
>From the previous commit.
Signed-off-by: Maximiliano Sandoval
---
test/cfg2cmd/bootorder-empty.conf.cmd| 2 +-
test/cfg2cmd/bootorder-legacy.conf.cmd | 2 +-
test/cfg2cmd/bootorder.conf.cmd | 2 +-
test/cfg2cmd/efidisk
fit the use case here, see [FHS 5.8].
For the sake of preventing race conditions we ship both versions until
version 9.
[FHS 4.7]: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html
[FHS 5.8]: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s08.html
Signed-off-by: Maximiliano
Maximiliano Sandoval writes:
> Maximiliano Sandoval writes:
>
>> Maximiliano Sandoval writes:
>>
>>> Maximiliano Sandoval writes:
>>>
>>>> The catalog-{lang}.mo files are generated only with strings that are
>>>> relevant to the pr
Maximiliano Sandoval writes:
> Maximiliano Sandoval writes:
>
>> Maximiliano Sandoval writes:
>>
>>> The catalog-{lang}.mo files are generated only with strings that are
>>> relevant to the proxmox-datacenter-manager instead of the whole
>>> {lan
Some small comments bellow.
Alexander Abraham writes:
> Elaborated on the intended differences between the output
> formats "text" and "json" for the "--output-format" option
> of the "pvesh" utility.
>
> Signed-off-by: Alexander Abraham
> ---
> output-format.adoc | 12 +---
> 1 file
Maximiliano Sandoval writes:
> Maximiliano Sandoval writes:
>
>> The catalog-{lang}.mo files are generated only with strings that are
>> relevant to the proxmox-datacenter-manager instead of the whole
>> {lang}.po file. The msgmerge command will produce all strings co
Maximiliano Sandoval writes:
> The catalog-{lang}.mo files are generated only with strings that are
> relevant to the proxmox-datacenter-manager instead of the whole
> {lang}.po file. The msgmerge command will produce all strings containing
> in the {lang}.po file but the ones
Maximiliano Sandoval writes:
>> Instead of relying on the device_change_handler callback (which saves
>> the config) we manually set the text to the right value.
>>
>> Signed-off-by: Maximiliano Sandoval
>> ---
>
> I am not completely sure if this patch s
Signed-off-by: Maximiliano Sandoval
---
The longest translation of "At least one rule does not match" has only 4 more
characters than the original, this is not a problem for the size we have
available as in most cases the rules carry even longer text.
src/window/NotificationMatcherEd
lural forms.
Signed-off-by: Maximiliano Sandoval
---
.gitmodules| 9 +
Makefile | 33 ++---
debian/control | 8 +++-
debian/pdm-i18n.install| 1 +
proxmox-datacenter-manager | 1 +
proxmox-yew
Thomas Lamprecht writes:
> Am 22.01.25 um 13:22 schrieb Maximiliano Sandoval:
>> Maximiliano Sandoval writes:
>>> One thing to note is that xtr, unlike our script to extract translations
>>> will add comments, context, and plural forms.
>>
>> I forgot to
For concatenating .pot files. From [1]:
> To concatenate POT files, better use xgettext, not msgcat, because
> msgcat would choke on the undefined charsets in the specified POT
> files.
[1] https://www.gnu.org/software/gettext/manual/html_node/msgcat-Invocation.html
Signed-off-by: Ma
Thomas Lamprecht writes:
> Am 22.01.25 um 13:22 schrieb Maximiliano Sandoval:
>> Maximiliano Sandoval writes:
>>> One thing to note is that xtr, unlike our script to extract translations
>>> will add comments, context, and plural forms.
>>
>> I forgot to
Maximiliano Sandoval writes:
> The catalog-{lang}.mo files are generated only with strings that are
> relevant to the proxmox-datacenter-manager instead of the whole
> {lang}.po file. The msgmerge command will produce all strings containing
> in the {lang}.po file but the ones
lural forms.
Signed-off-by: Maximiliano Sandoval
---
At the moment this won't compile without changes to proxmox-yew-widget-toolkit
since the msgid "Warning" is both used for a plural and singular string. Adding
a context to the plural variant fixes this:
```diff
modified src
For concatenating .pot files. From [1]:
> To concatenate POT files, better use xgettext, not msgcat, because
> msgcat would choke on the undefined charsets in the specified POT
> files.
[1] https://www.gnu.org/software/gettext/manual/html_node/msgcat-Invocation.html
Signed-off-by: Ma
Maximiliano Sandoval writes:
> Splitting translatable strings deprives translators for context which
> might be needed for getting the correct tenses or genders. See [1] for
> example.
>
> [1]
> https://wiki.gnome.org/TranslationProject(2f)DevGuidelines(2f)Never(20)split
Jing Luo via pve-devel writes:
> -extended description over several lines (indended by space) may follow.
> +extended description over several lines (intended by space) may follow.
I think this should be "indented" instead of indended or intended.
> @@ -517,7 +517,7 @@ All generated templates
> Instead of relying on the device_change_handler callback (which saves
> the config) we manually set the text to the right value.
>
> Signed-off-by: Maximiliano Sandoval
> ---
I am not completely sure if this patch series preserves the intentional
UI flow. Some testing w
1 - 100 of 318 matches
Mail list logo
