[pve-devel] [PATCH manager] api: apt: Return valid utf8 on update

2025-09-25 Thread Maximiliano Sandoval
/var/lib/pve-manager/pkgupdates would also have the wrong encoding. This patch fixes both issues. Reported-by: Lukas Wagner Signed-off-by: Maximiliano Sandoval --- One unfortunate problem for reproducing this issue is that this particular package is already on the latest version on the Proxmox VE

Re: [pve-devel] [PATCH i18n] fix Czech translation of "Order Certificates Now"

2025-09-23 Thread Maximiliano Sandoval
Filip Schauer writes: > The previous translation incorrectly suggested that "Order Certificates > Now" means sorting the certificates. > > Signed-off-by: Filip Schauer Thanks! It was applied at [1]. [1] https://git.proxmox.com/?p=proxmox-i18n.git;a=commitdiff;h=adb69d857352ef2c691d3a0dc618532

Re: [pve-devel] [PATCH docs] pvecm: redundancy: explicitly mention subnets

2025-09-20 Thread Maximiliano Sandoval
s also used in the "Separate Cluster Network" section). > > Signed-off-by: Friedrich Weber Looks good to me. Reviewed-by: Maximiliano Sandoval -- Maximiliano ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] superseded: [PATCH docs] lvm storage: state snapshot-as-volume-chain is a technology preview

2025-09-12 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > This matches the description in the Changelog for Proxmox VE 9 [1]. > > [1] https://pve.proxmox.com/wiki/Roadmap#Proxmox_VE_9.0 > > Signed-off-by: Maximiliano Sandoval superseded by https://lore.proxmox.com/all/20250912075341.109185-1-m.sando

[pve-devel] [PATCH docs v2 1/2] lvm storage: state snapshot-as-volume-chain is a technology preview

2025-09-12 Thread Maximiliano Sandoval
This matches the description in the Changelog for Proxmox VE 9 [1]. [1] https://pve.proxmox.com/wiki/Roadmap#Proxmox_VE_9.0 Signed-off-by: Maximiliano Sandoval --- Differences from v1: - Document that snapshots as volume chain cannot be used with TPM images pve-storage-lvm.adoc | 2 ++ 1

[pve-devel] [PATCH docs v2 2/2] lvm storage: document TPM snaphshot limitations

2025-09-12 Thread Maximiliano Sandoval
Users who read about this feature unexpectedly run into this limitation. Signed-off-by: Maximiliano Sandoval --- pve-storage-lvm.adoc | 4 1 file changed, 4 insertions(+) diff --git a/pve-storage-lvm.adoc b/pve-storage-lvm.adoc index fc2a8ef..6499978 100644 --- a/pve-storage-lvm.adoc

Re: [pve-devel] [PATCH docs] lvm storage: state snapshot-as-volume-chain is a technology preview

2025-09-06 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Thomas Lamprecht writes: > >> Am 29.08.25 um 14:24 schrieb Maximiliano Sandoval: >>> This matches the description in the Changelog for Proxmox VE 9 [1]. >>> >>> [1] https://pve.proxmox.com/wiki/Roadmap#Proxmox_VE_9.0 >&

Re: [pve-devel] [PATCH docs] lvm storage: state snapshot-as-volume-chain is a technology preview

2025-09-04 Thread Maximiliano Sandoval
Thomas Lamprecht writes: > Am 29.08.25 um 14:24 schrieb Maximiliano Sandoval: >> This matches the description in the Changelog for Proxmox VE 9 [1]. >> >> [1] https://pve.proxmox.com/wiki/Roadmap#Proxmox_VE_9.0 >> >> Signed-off-by: Maximiliano Sandoval &g

[pve-devel] [PATCH manager] api: apt: Return valid utf8 on changelog

2025-09-02 Thread Maximiliano Sandoval
This was displayed wrongly on the web UI and when calling pvesh get /nodes/localhost/apt/changelog One potential example of such a package was bind9-dnsutils where the character `ř` was rendered as `Å`. Reported-by: Lukas Wagner Signed-off-by: Maximiliano Sandoval --- PVE/API2/APT.pm | 3

[pve-devel] [PATCH qemu-server v2 2/6] block job: mirror: follow guest-fsfreeze setting

2025-09-02 Thread Maximiliano Sandoval
This is used when performing a full-clone of a running VM. Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuServer/BlockJob.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm index 633c0b34..b6e2d51f

[pve-devel] superseded: [PATCH container/guest-common/qemu-server 0/3] log when freezing or thawing the guest's fs

2025-09-02 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > At the moment taking a snapshot without RAM does not log whether there was a > freeze/thaw. > > This does not add an extra log line when making a Backup in snapshot mode. Superseded by https://lore.proxmox.com/pve-devel/20250902124524.3680

[pve-devel] [PATCH guest-common v2 1/1] replication: remove logging when freezing/thawing

2025-09-02 Thread Maximiliano Sandoval
This is handled now by the class' __snapshot_freeze. Signed-off-by: Maximiliano Sandoval --- src/PVE/Replication.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm index ba4c2c1..1b31ae2 100644 --- a/src/PVE/Replication.pm +++ b/sr

[pve-devel] [PATCH container v2 1/1] log when freezing/thawing filesystem

2025-09-02 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/PVE/LXC/Config.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index e4d0365..79a87b8 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -204,10 +204,12 @@ sub __snapshot_freeze

[pve-devel] [PATCH qemu-server v2 5/6] block job: mirror: reword fsfreeze log entry

2025-09-02 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuServer/BlockJob.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm index b6e2d51f..229146b3 100644 --- a/src/PVE/QemuServer/BlockJob.pm +++ b/src/PVE

[pve-devel] [PATCH qemu-server v2 6/6] deprecate freeze-fs-on-backup qga setting

2025-09-02 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuServer.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index cdd44eb0..b8416b4c 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -161,8 +161,10 @@ my

[pve-devel] [PATCH qemu-server v2 1/6] add a guest-fsfreeze qga setting

2025-09-02 Thread Maximiliano Sandoval
and clones. Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuServer.pm| 11 +++ src/PVE/VZDump/QemuServer.pm | 6 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index f263fedb..cdd44eb0 100644 --- a/src/PVE

[pve-devel] [PATCH qemu-server v2 3/6] fix #1964: follow guest-fsfreeze setting on check freeze needed

2025-09-02 Thread Maximiliano Sandoval
This is used by replication and snapshots. Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuConfig.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm index e0853d65..51593b60 100644 --- a/src/PVE/QemuConfig.pm +++ b/src

[pve-devel] [PATCH container/guest-common/qemu-server v2 0/8] fix #1964: Add a setting to globally disable freezing a guest

2025-09-02 Thread Maximiliano Sandoval
Backup in snapshot mode. Differences from v1: - Add setting to enable/disable fsfreeze commands - Change wording in one log message qemu-server: Maximiliano Sandoval (6): add a guest-fsfreeze qga setting block job: mirror: follow guest-fsfreeze setting fix #1964: follow guest-fsfreeze

[pve-devel] [PATCH qemu-server v2 4/6] log when issuing a guest-fsfreeze command

2025-09-02 Thread Maximiliano Sandoval
These messages appear during replication or snapshots. Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuConfig.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm index 51593b60..679c3893 100644 --- a/src/PVE/QemuConfig.pm +++ b/src/PVE

[pve-devel] [PATCH storage] pvesm: Report units in status subcommant

2025-08-29 Thread Maximiliano Sandoval
The units used are not documented in the man page. Signed-off-by: Maximiliano Sandoval --- src/PVE/CLI/pvesm.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/CLI/pvesm.pm b/src/PVE/CLI/pvesm.pm index 860e46f8..06bc4c9f 100755 --- a/src/PVE/CLI/pvesm.pm +++ b/src

[pve-devel] [PATCH docs] lvm storage: state snapshot-as-volume-chain is a technology preview

2025-08-29 Thread Maximiliano Sandoval
This matches the description in the Changelog for Proxmox VE 9 [1]. [1] https://pve.proxmox.com/wiki/Roadmap#Proxmox_VE_9.0 Signed-off-by: Maximiliano Sandoval --- pve-storage-lvm.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pve-storage-lvm.adoc b/pve-storage-lvm.adoc index

Re: [pve-devel] [PATCH manager 0/2] add ceph and virt-viewer svg again

2025-08-29 Thread Maximiliano Sandoval
Shannon Sterz writes: > these were accidentally dropped on apply due to long lines, so reformat > them and add them back. > > Shannon Sterz (2): > ui: add virt viewer svg again > ui: add ceph logo svg again I tested this quickly and it fixed `make deb` on master. Test

Re: [pve-devel] [PATCH qemu-server 1/1] log when issues a guest-fsfreeze command

2025-08-29 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Signed-off-by: Maximiliano Sandoval > --- > src/PVE/QemuConfig.pm | 2 ++ > 1 file changed, 2 insertions(+) This was found by: Reported-by: Friedrich Weber -- Maximiliano ___ pve-devel mailing li

[pve-devel] [PATCH qemu-server 1/1] log when issues a guest-fsfreeze command

2025-08-29 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuConfig.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm index e0853d65..4ff6f347 100644 --- a/src/PVE/QemuConfig.pm +++ b/src/PVE/QemuConfig.pm @@ -307,9 +307,11 @@ sub __snapshot_freeze

[pve-devel] [PATCH container/guest-common/qemu-server 0/3] log when freezing or thawing the guest's fs

2025-08-29 Thread Maximiliano Sandoval
At the moment taking a snapshot without RAM does not log whether there was a freeze/thaw. This does not add an extra log line when making a Backup in snapshot mode. qemu-server: Maximiliano Sandoval (1): log when issues a guest-fsfreeze command src/PVE/QemuConfig.pm | 2 ++ 1 file changed

[pve-devel] [PATCH guest-common 1/1] replication: remove logging when freezing/thawing

2025-08-29 Thread Maximiliano Sandoval
This is handled now by the class' __snapshot_freeze. Signed-off-by: Maximiliano Sandoval --- src/PVE/Replication.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm index ba4c2c1..1b31ae2 100644 --- a/src/PVE/Replication.pm +++ b/sr

[pve-devel] [PATCH container 1/1] log when freezing/thawing filesystem

2025-08-29 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/PVE/LXC/Config.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index e4d0365..79a87b8 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -204,10 +204,12 @@ sub __snapshot_freeze

[pve-devel] [PATCH manager v2 2/2] api: ceph: set bytes_used's renderer to bytes

2025-08-29 Thread Maximiliano Sandoval
This will make pveceph pool ls report the 'Used' column specifying its units: $ pveceph pool ls --noborder ... Used ... 2.07 MiB ... 108.61 KiB Signed-off-by: Maximiliano Sandoval --- PVE/API2/Ceph/Pool.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Ceph/Pool.pm

[pve-devel] [PATCH manager v2 1/2] ui: set proxmoxRRDChart's unit at storage summary

2025-08-29 Thread Maximiliano Sandoval
any ambiguity about whether "G" refers to GiB or GB. Signed-off-by: Maximiliano Sandoval --- Differences from v1: - Use lowercase in commit name - Add a second commit changing the renderer of the bytes_used www/manager6/storage/Summary.js | 1 + 1 file changed, 1 insertion(+) dif

[pve-devel] [PATCH qemu-server] document hugepages option

2025-08-28 Thread Maximiliano Sandoval
Given that there is no 0 enum, we remove the word "disabled" from the docs. We also document that the unit is MiB. Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuServer.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/Qem

[pve-devel] applied: [PATCH i18n v2 1/1] update German translations

2025-08-27 Thread Maximiliano Sandoval
Michael Köppl writes: > Signed-off-by: Michael Köppl > --- > I think the translation for "Now refreshing" is a bit clumsy. Maybe > someone's more creative regarding this one, but personally I'd prefer to > change the original text to "Refreshing..." and translate it as > "Aktualisiert..." or som

[pve-devel] [RFC PATCH docs] qm: document when fs-freeze is issued for VMs

2025-08-14 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- I might be missing some condition so I am sending this to gather feedback. I will grep the code with more gusto on monday to see if I am missing anything. For the moment this is only about VMs and we are missing information for containers. qm.adoc | 17

Re: [pve-devel] [PATCH docs v2] pvesr: Document replication network setting

2025-08-14 Thread Maximiliano Sandoval
"Shannon Sterz" writes: > On Mon Jul 21, 2025 at 4:44 PM CEST, Maximiliano Sandoval wrote: >> Signed-off-by: Maximiliano Sandoval >> --- >> Differences from v1: >> - s/live guest migration/guest migration/ >> >> pvesr.adoc | 18 +

[pve-devel] [PATCH manager] ui: Set proxmoxRRDChart's unit at storage summary

2025-08-13 Thread Maximiliano Sandoval
any ambiguity about whether "G" refers to GiB or GB. Signed-off-by: Maximiliano Sandoval --- www/manager6/storage/Summary.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/storage/Summary.js b/www/manager6/storage/Summary.js index 8809603b..b263cb87 100644 --- a/www/man

[pve-devel] [PATCH installer] gui: remove G_SLICE=always-malloc usage

2025-08-07 Thread Maximiliano Sandoval
] https://gitlab.gnome.org/GNOME/glib/-/releases/2.75.3 Signed-off-by: Maximiliano Sandoval --- Makefile| 10 +- proxinstall | 4 xinitrc | 2 +- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index 878c4bd..ad79925 100644 --- a/Makefile

[pve-devel] applied: [PATCH proxmox-i18n 1/1] update german translation

2025-08-05 Thread Maximiliano Sandoval
Stefan Hanreich writes: > Some small fixes for the german translation of the SDN fabrics. > > Signed-off-by: Stefan Hanreich > --- > de.po | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/de.po b/de.po > index 8808913..6fad2ba 100644 > --- a/de.po > +++ b/de.po > @@

Re: [pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free

2025-08-01 Thread Maximiliano Sandoval
ested this series against a 9.0 (beta) cluster and I didn't see anything off while writing data to the pmxcfs. I also did a light review of the code and it looks good. Tested-by: Maximiliano Sandoval Reviewed-by: Maximiliano Sandoval -- Maximiliano ___

Re: [pve-devel] [PATCH proxmox-i18n 2/2] po2js: add ngettext support

2025-07-31 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > @@ -112,6 +136,20 @@ function gettext(buf) { > } > return data[0] || buf; > } > + > +function ngettext(singular, plural, n) { > +const msg_idx = Number($plural_forms); > +const digest = fnv31a(singular);

[pve-devel] [PATCH proxmox-i18n 1/2] format with proxmox-perltidy

2025-07-31 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- po2js.pl | 69 ++-- 1 file changed, 32 insertions(+), 37 deletions(-) diff --git a/po2js.pl b/po2js.pl index ee5bbd1..c5268d7 100755 --- a/po2js.pl +++ b/po2js.pl @@ -26,14 +26,10 @@ sub fnv31a { my

[pve-devel] [PATCH proxmox-i18n 2/2] po2js: add ngettext support

2025-07-31 Thread Maximiliano Sandoval
node/Plural-forms.html Signed-off-by: Maximiliano Sandoval --- po2js.pl | 52 +--- 1 file changed, 45 insertions(+), 7 deletions(-) diff --git a/po2js.pl b/po2js.pl index c5268d7..d5a78a6 100755 --- a/po2js.pl +++ b/po2js.pl @@ -35,6 +35,10 @@

[pve-devel] superseded: [PATCH backup/manager/pmg-gui/pmg-yew-quarantine-gui/proxmox-datacenter-manager/widget-toolkit/yew-mobile-gui/yew-widget-toolkit v2 00/16] Improve translatable strings

2025-07-30 Thread Maximiliano Sandoval
Thomas Lamprecht writes: > Am 30.07.25 um 14:51 schrieb Shannon Sterz: >> other than the nits i send, consider this: > > > If you send another revision of this I'd welcome it if it's a separate > series per repo. As while the changes are related they are not building > on top of each other or the

[pve-devel] [PATCH yew-widget-toolkit v3 1/1] improve translatable strings

2025-07-30 Thread Maximiliano Sandoval
Regarding the "may" change: we error when the fields are empty, hence must is more appropriate. Signed-off-by: Maximiliano Sandoval --- src/widget/form/field.rs| 2 +- src/widget/form/number.rs | 4 ++-- src/widget/form/selector.rs | 2 +- src/widget/form/textarea.rs | 2 +

[pve-devel] [PATCH proxmox-datacenter-manager v3 2/2] improve translatable strings

2025-07-30 Thread Maximiliano Sandoval
The string "Mixed Subscriptions" is already in our pot files. We also remove a newline that leaked into the pot file. Signed-off-by: Maximiliano Sandoval --- ui/src/dashboard/remote_panel.rs | 2 +- ui/src/dashboard/subscription_info.rs | 5 ++--- 2 files changed, 3 insert

[pve-devel] [PATCH proxmox-datacenter-manager v3 1/2] add context to translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- ui/src/dashboard/top_entities.rs | 1 + ui/src/pve/qemu.rs | 2 ++ ui/src/remotes/add_wizard.rs | 1 + 3 files changed, 4 insertions(+) diff --git a/ui/src/dashboard/top_entities.rs b/ui/src/dashboard/top_entities.rs index af3f853

[pve-devel] [PATCH backup/manager/proxmox-datacenter-manager/widget-toolkit/yew-widget-toolkit v3 00/11] Improve translatable strings

2025-07-30 Thread Maximiliano Sandoval
- Fix capitalization of WebAuthn - Generally improve translations pve-manager: Maximiliano Sandoval (3): add context to translatable strings improve some translatable strings use Unicode not equal sign in translatable strings www/manager6/dc/MetricServerView.js | 2

[pve-devel] [PATCH backup v3 3/3] use WebAuthn in translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- www/config/WebauthnView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/config/WebauthnView.js b/www/config/WebauthnView.js index 131964b8c..a954d8ac6 100644 --- a/www/config/WebauthnView.js +++ b/www/config/WebauthnView.js

[pve-devel] [PATCH manager v3 2/3] improve some translatable strings

2025-07-30 Thread Maximiliano Sandoval
Regarding the change in Restore.js: In certain languages (e.g. Spanish) CT and VM would have different genders, hence it is not possible to use the same string. The `b` in batch size is not very obvious. Signed-off-by: Maximiliano Sandoval --- www/manager6/dc/MetricServerView.js | 2 +- www

[pve-devel] [PATCH backup v3 1/3] add translators comments to some translations

2025-07-30 Thread Maximiliano Sandoval
These will be displayed in translator editors and provide context for translators. Signed-off-by: Maximiliano Sandoval --- www/tape/DriveStatus.js | 1 + www/window/DataStoreEdit.js | 1 + www/window/S3ClientEdit.js | 2 ++ 3 files changed, 4 insertions(+) diff --git a/www/tape

[pve-devel] [PATCH backup v3 2/3] improve some translatable strings

2025-07-30 Thread Maximiliano Sandoval
The 'S3 Refresh' string is already in our pot files. Signed-off-by: Maximiliano Sandoval --- www/Utils.js | 2 +- www/window/InfluxDbEdit.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/Utils.js b/www/Utils.js index ccdae522c..55365b1f0 10

[pve-devel] [PATCH widget-toolkit v3 2/2] use WebAuthn in translatable string

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/window/AddWebauthn.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/window/AddWebauthn.js b/src/window/AddWebauthn.js index 7123f4b..115e6e3 100644 --- a/src/window/AddWebauthn.js +++ b/src/window/AddWebauthn.js @@ -227,7

[pve-devel] [PATCH manager v3 1/3] add context to translatable strings

2025-07-30 Thread Maximiliano Sandoval
These will be displayed in translator editors and provide context for translators. Signed-off-by: Maximiliano Sandoval --- www/manager6/grid/BackupView.js | 1 + www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 3 +++ www/manager6/sdn/zones/VxlanEdit.js | 1

[pve-devel] [PATCH widget-toolkit v3 1/2] add context to translatable strings

2025-07-30 Thread Maximiliano Sandoval
These will be displayed in translator editors and provide context for translators. Signed-off-by: Maximiliano Sandoval --- src/Utils.js| 2 ++ src/form/MultiDiskSelector.js | 1 + src/panel/NotificationConfigView.js | 1 + src/window/ZFSDetail.js | 1

[pve-devel] [PATCH manager v3 3/3] use Unicode not equal sign in translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- www/manager6/dc/PCIMapView.js | 2 +- www/manager6/dc/USBMapView.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc/PCIMapView.js b/www/manager6/dc/PCIMapView.js index 6ea23a45..96dae52c 100644 --- a/www/manager6/dc

[pve-devel] superseded: [PATCH backup/manager/pmg-gui/widget-toolkit 0/4] Add context to multiple translatable strings. These will be displayed by

2025-07-30 Thread Maximiliano Sandoval
"Shannon Sterz" writes: > On Mon Jul 21, 2025 at 1:35 PM CEST, Maximiliano Sandoval wrote: >> translator editors and will appear in po files as >> >> ``` >> #. TRANSLATORS: Stands for Complete Sequence Number Packet, see >> #. >> https://datatrac

[pve-devel] [PATCH yew-widget-toolkit v2 1/1] improve translatable strings

2025-07-30 Thread Maximiliano Sandoval
We error when the fields are empty, hence must is more appropiate. Signed-off-by: Maximiliano Sandoval --- src/widget/form/field.rs| 2 +- src/widget/form/number.rs | 4 ++-- src/widget/form/selector.rs | 2 +- src/widget/form/textarea.rs | 2 +- 4 files changed, 5 insertions(+), 5

[pve-devel] [PATCH backup v2 1/3] add translators comments to some translations

2025-07-30 Thread Maximiliano Sandoval
These will be displayed in translator editors and provide context for translators. Signed-off-by: Maximiliano Sandoval --- www/tape/DriveStatus.js | 1 + www/window/DataStoreEdit.js | 1 + www/window/S3ClientEdit.js | 2 ++ 3 files changed, 4 insertions(+) diff --git a/www/tape

[pve-devel] [PATCH pmg-yew-quarantine-gui v2 1/1] improve some translatable strings

2025-07-30 Thread Maximiliano Sandoval
This is a body and should use sentence capitalization. Signed-off-by: Maximiliano Sandoval --- src/page_not_found.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/page_not_found.rs b/src/page_not_found.rs index cc3b2d7..d777a82 100644 --- a/src/page_not_found.rs +++ b

[pve-devel] [PATCH proxmox-datacenter-manager v2 1/2] add context to translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- ui/src/dashboard/top_entities.rs | 1 + ui/src/pve/qemu.rs | 2 ++ ui/src/remotes/add_wizard.rs | 1 + 3 files changed, 4 insertions(+) diff --git a/ui/src/dashboard/top_entities.rs b/ui/src/dashboard/top_entities.rs index af3f853

[pve-devel] [PATCH backup v2 3/3] use WebAuthn in translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- www/config/WebauthnView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/config/WebauthnView.js b/www/config/WebauthnView.js index 131964b8c..a954d8ac6 100644 --- a/www/config/WebauthnView.js +++ b/www/config/WebauthnView.js

[pve-devel] [PATCH backup v2 2/3] improve some translatable strings

2025-07-30 Thread Maximiliano Sandoval
The 'S3 Refresh' string is already in our pot files. Signed-off-by: Maximiliano Sandoval --- www/Utils.js | 2 +- www/window/InfluxDbEdit.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/Utils.js b/www/Utils.js index ccdae522c..55365b1f0 10

[pve-devel] [PATCH pmg-gui v2 2/2] use WebAuthn in translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- js/TFAView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/TFAView.js b/js/TFAView.js index ca8ceb0..fd69222 100644 --- a/js/TFAView.js +++ b/js/TFAView.js @@ -3,7 +3,7 @@ Ext.define('PMG.WebauthnConfigEdit', {

[pve-devel] [PATCH manager v2 1/3] add context to translatable strings

2025-07-30 Thread Maximiliano Sandoval
These will be displayed in translator editors and provide context for translators. Signed-off-by: Maximiliano Sandoval --- www/manager6/grid/BackupView.js | 1 + www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 3 +++ www/manager6/sdn/zones/VxlanEdit.js | 1

[pve-devel] [PATCH backup/manager/pmg-gui/pmg-yew-quarantine-gui/proxmox-datacenter-manager/widget-toolkit/yew-mobile-gui/yew-widget-toolkit v2 00/16] Improve translatable strings

2025-07-30 Thread Maximiliano Sandoval
-failures #: pve-manager/www/manager6/sdn/fabrics/openfabric/FabricEdit.js:61 msgid "CSNP Interval" msgstr "Intervalo de CSNP" ``` - Fix typos - Use Unicode for not equal sign - Fix capitalization of WebAuthn - Generally improve translations pve-manager: Maximiliano Sandoval (

[pve-devel] [PATCH widget-toolkit v2 3/3] use WebAuthn in translatable string

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/window/AddWebauthn.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/window/AddWebauthn.js b/src/window/AddWebauthn.js index 7123f4b..115e6e3 100644 --- a/src/window/AddWebauthn.js +++ b/src/window/AddWebauthn.js @@ -227,7

[pve-devel] [PATCH proxmox-datacenter-manager v2 2/2] improve translatable strings

2025-07-30 Thread Maximiliano Sandoval
The string "Mixed Subscriptions" is already in our pot files. We also remove a newline that leaked into the pot file. Signed-off-by: Maximiliano Sandoval --- ui/src/dashboard/remote_panel.rs | 2 +- ui/src/dashboard/subscription_info.rs | 5 ++--- 2 files changed, 3 insert

[pve-devel] [PATCH pve-yew-mobile-gui v2 1/1] improve translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/pages/page_lxc_status/config_panel.rs| 2 +- src/pages/page_node_status/services_panel.rs | 4 ++-- src/pages/page_qemu_status/hardware_panel.rs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pages/page_lxc_status

[pve-devel] [PATCH manager v2 2/3] improve some translatable strings

2025-07-30 Thread Maximiliano Sandoval
In certain languages (e.g. spanish) CT and VM would have different genders, hence it is not possible to use the same string. Signed-off-by: Maximiliano Sandoval --- www/manager6/dc/MetricServerView.js | 2 +- www/manager6/window/Restore.js | 11 +-- 2 files changed, 6 insertions

[pve-devel] [PATCH pmg-gui v2 1/2] add context to translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- js/MailProxyDKIMPanel.js | 2 ++ js/Utils.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/js/MailProxyDKIMPanel.js b/js/MailProxyDKIMPanel.js index 267a58b..ae81c89 100644 --- a/js/MailProxyDKIMPanel.js +++ b/js/MailProxyDKIMPanel.js

[pve-devel] [PATCH widget-toolkit v2 2/3] add context to translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/Utils.js| 2 ++ src/panel/NotificationConfigView.js | 1 + src/window/ZFSDetail.js | 1 + 3 files changed, 4 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index 92cbf28..27fb69c 100644 --- a/src/Utils.js

[pve-devel] [PATCH manager v2 3/3] use Unicode not equal sign in translatable strings

2025-07-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- www/manager6/dc/PCIMapView.js | 2 +- www/manager6/dc/USBMapView.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc/PCIMapView.js b/www/manager6/dc/PCIMapView.js index 6ea23a45..96dae52c 100644 --- a/www/manager6/dc

[pve-devel] [PATCH widget-toolkit v2 1/3] add context to translatable strings

2025-07-30 Thread Maximiliano Sandoval
These will be displayed in translator editors and provide context for translators. Signed-off-by: Maximiliano Sandoval --- src/form/MultiDiskSelector.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/form/MultiDiskSelector.js b/src/form/MultiDiskSelector.js index 50e819b..51c3858

[pve-devel] [PATCH proxmox-i18n] tr: set correct plural form

2025-07-30 Thread Maximiliano Sandoval
From https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html zero is plural in Turkish. Signed-off-by: Maximiliano Sandoval --- tr.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tr.po b/tr.po index df41619..d76719e 100644 --- a/tr.po +++ b/tr.po @@ -15,7

[pve-devel] superseded: [PATCH storage v2] fix #5181: pbs: store and read passwords as unicode

2025-07-30 Thread Maximiliano Sandoval
Thomas Lamprecht writes: > Am 23.07.25 um 15:00 schrieb Shannon Sterz: >> -->8 snip 8<-- >>> -PVE::Tools::file_set_contents($pwfile, "$password\n"); >>> +PVE::Tools::file_set_contents($pwfile, "$password\n", undef, 1); >> i know this is pre-existing, but i'd feel more comfortable forcing

[pve-devel] [PATCH storage v3] fix #5181: pbs: store and read passwords as unicode

2025-07-30 Thread Maximiliano Sandoval
iting the right password in /etc/pve/priv/{storage}.pw and this fix is compatible with that. It is documented at https://pbs.proxmox.com/docs/backup-client.html#environment-variables that the Backup Server password must be valid utf-8. Signed-off-by: Maximiliano Sandoval --- Differences from v2: - S

Re: [pve-devel] [pbs-devel] applied: [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible

2025-07-23 Thread Maximiliano Sandoval
Thomas Lamprecht writes: > On Wed, 23 Jul 2025 13:50:15 +0200, Christian Ebner wrote: >> Commit 90723828 ("api: backup: add no-cache flag to bypass local >> datastore cache") introduced the additional flag to request bypassing >> of the datastore cache by the Proxmox Backup Server. >> >> The fla

Re: [pve-devel] [PATCH ha-manager] watchdog-mux: Restore if guard for watchdog updates

2025-07-23 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > In commit c26b474 the if condition was removed in favor of the if guard > on the higher level. However, this introduced functional change, the > watchdog now updates immediately after update_watchdog is set to 0, > potentially causing fencing after

[pve-devel] [PATCH ha-manager] watchdog-mux: Restore if guard for watchdog updates

2025-07-23 Thread Maximiliano Sandoval
incorrect because updating the watchdog after declaring no more updates makes no logical sense. Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c index 889cea2..272060d 100644

[pve-devel] applied: [PATCH i18n] Arabic translation update

2025-07-23 Thread Maximiliano Sandoval
Moayad Almalat writes: > --- > ar.po | 1055 +++-- > 1 file changed, 419 insertions(+), 636 deletions(-) Thanks, applied at 9154934c251d31772ea4f0731d86520f4606a882. -- Maximiliano ___ pve-deve

[pve-devel] [PATCH proxmox-i18n] makefile: Set locale for sort

2025-07-23 Thread Maximiliano Sandoval
s a version of LC_ALL which only affects collation. Signed-off-by: Maximiliano Sandoval --- With this patch: $ make update && git diff --stat ... 36 files changed, 21133 insertions(+), 17192 deletions(-) Before: $ make update && git diff --stat ... 37 f

[pve-devel] [PATCH docs v2] pvesr: Document replication network setting

2025-07-21 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- Differences from v1: - s/live guest migration/guest migration/ pvesr.adoc | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/pvesr.adoc b/pvesr.adoc index 9ad02f5..186a1bd 100644 --- a/pvesr.adoc +++ b/pvesr.adoc

[pve-devel] [PATCH docs] pvesr: Document replication network setting

2025-07-21 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- pvesr.adoc | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/pvesr.adoc b/pvesr.adoc index 9ad02f5..9715bea 100644 --- a/pvesr.adoc +++ b/pvesr.adoc @@ -184,11 +184,19 @@ This ID must only be specified manually if the

[pve-devel] [PATCH manager 1/1] add context to some translations

2025-07-21 Thread Maximiliano Sandoval
These will be displayed in translator editors and provide context for translators. Signed-off-by: Maximiliano Sandoval --- www/manager6/grid/BackupView.js | 1 + www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 3 +++ www/manager6/sdn/zones/VxlanEdit.js | 1

[pve-devel] [PATCH backup/manager/pmg-gui/widget-toolkit 0/4] Add context to multiple translatable strings. These will be displayed by

2025-07-21 Thread Maximiliano Sandoval
;CSNP Interval" msgstr "Intervalo de CSNP" ``` pve-manager: Maximiliano Sandoval (1): add context to some translations www/manager6/grid/BackupView.js | 1 + www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 3 +++ www/manager6/sdn/zones/VxlanEdit.js

[pve-devel] [PATCH backup 1/1] add context to some translations

2025-07-21 Thread Maximiliano Sandoval
These will be displayed in translator editors and provide context for translators. Signed-off-by: Maximiliano Sandoval --- www/tape/DriveStatus.js | 1 + www/window/DataStoreEdit.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js index

[pve-devel] [PATCH widget-toolkit 1/1] add context to some translations

2025-07-21 Thread Maximiliano Sandoval
These will be displayed in translator editors and provide context for translators. Signed-off-by: Maximiliano Sandoval --- src/form/MultiDiskSelector.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/form/MultiDiskSelector.js b/src/form/MultiDiskSelector.js index 50e819b..51c3858

[pve-devel] [PATCH pmg-gui 1/1] add context to some translations

2025-07-21 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- js/MailProxyDKIMPanel.js | 2 ++ js/Utils.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/js/MailProxyDKIMPanel.js b/js/MailProxyDKIMPanel.js index 022513a..3e388e8 100644 --- a/js/MailProxyDKIMPanel.js +++ b/js/MailProxyDKIMPanel.js

[pve-devel] applied: [PATCH] update Japanese translations for ja.po

2025-07-18 Thread Maximiliano Sandoval
ribbon--- via pve-devel writes: > Update Japanese translatioon. > > Thanks! applied at f1b7b49aeb35d97f58649346b6fb75f8bcbc0465. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-deve

[pve-devel] applied: [PATCH proxmox-i18n] update Spanish translations

2025-07-18 Thread Maximiliano Sandoval
applied at 14e6b0c7558ec996197c6badffb94f3733a0af09. Maximiliano Sandoval writes: > Signed-off-by: Maximiliano Sandoval > --- > es.po | 140 ++ > 1 file changed, 52 insertions(+), 88 deletions(-) > > diff --git a/es.

[pve-devel] applied: [PATCH i18n] update German translation

2025-07-18 Thread Maximiliano Sandoval
Shannon Sterz writes: > Signed-off-by: Shannon Sterz > --- > de.po | 139 ++ > 1 file changed, 52 insertions(+), 87 deletions(-) Applied at 47bf9cf86858d8bdd3e8502b415dd273fc6e9325, thanks!

[pve-devel] [PATCH proxmox-i18n] update Spanish translations

2025-07-18 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- es.po | 140 ++ 1 file changed, 52 insertions(+), 88 deletions(-) diff --git a/es.po b/es.po index 7c100e2..5a01002 100644 --- a/es.po +++ b/es.po @@ -8,7 +8,7 @@ msgstr "" "Pro

[pve-devel] [PATCH manager 1/1] ui: dc/options: allow to edit cluster wide replication settings

2025-07-18 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- www/manager6/dc/OptionView.js | 28 1 file changed, 28 insertions(+) diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js index 94f299a3..772c5379 100644 --- a/www/manager6/dc/OptionView.js +++ b/www

[pve-devel] [PATCH cluster/manager 0/2] ui: add datacenter replication network option

2025-07-18 Thread Maximiliano Sandoval
,network=10.10.10.161/24 cluster: Maximiliano Sandoval (1): datacenter config: Actually write the replication config src/PVE/DataCenterConfig.pm | 4 1 file changed, 4 insertions(+) manager: Maximiliano Sandoval (1): ui: dc/options: allow to edit cluster wide replication settings

[pve-devel] [PATCH cluster 1/1] datacenter config: Actually write the replication config

2025-07-18 Thread Maximiliano Sandoval
We get the following error without this patch: ``` $ pvesh set /cluster/options 400 validation error in '/etc/pve/datacenter.cfg' replication: type check ('string') failed - got HASH ``` Signed-off-by: Maximiliano Sandoval --- src/PVE/DataCenterConfig.pm | 4 1 file c

[pve-devel] [PATCH ha-manager v3 6/6] watchdog-mux: Remove wrapping if guard

2025-07-04 Thread Maximiliano Sandoval
We check for the same condition in the wrapping if-block added in the previous commit making these redundant. Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 44 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/src

[pve-devel] [PATCH ha-manager v3 0/6] watchdog-mux: sync log to disk before and after expiring

2025-07-04 Thread Maximiliano Sandoval
that would call the sync and then exit() Differences from v1: - Define the warning cuttoff based on the 60 second timeout - Change log messages and constant names - When not immediately fencing, run journal sync in double fork Maximiliano Sandoval (6): watchdog-mux: Use #define for 60s timeout

[pve-devel] [PATCH ha-manager v3 4/6] watchdog-mux: sync journal right after fence warning

2025-07-04 Thread Maximiliano Sandoval
Since this journal entry can be logged multiple times in the lifespan on the process, we double fork to prevent accumulating zombie processes. Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/watchdog-mux.c b

[pve-devel] [PATCH ha-manager v3 5/6] watchdog-mux: break out of loop when updates are disabled

2025-07-04 Thread Maximiliano Sandoval
review process. Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c index 11571ec..4e2bdc6 100644 --- a/src/watchdog-mux.c +++ b/src/watchdog-mux.c @@ -253,7 +253,7 @@ int main(void

[pve-devel] [PATCH ha-manager v3 1/6] watchdog-mux: Use #define for 60s timeout

2025-07-04 Thread Maximiliano Sandoval
This change allows to have a second constant defined in terms of this one. Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c index e324c20..d38116b 100644 --- a/src/watchdog

[pve-devel] [PATCH ha-manager v3 2/6] watchdog-mux: split if block in two if blocks

2025-07-04 Thread Maximiliano Sandoval
The sole purpose of this commit is to make the following commit's diff easier to read. Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c index d38116b..2b8cebf 1

[pve-devel] [PATCH ha-manager v3 3/6] watchdog-mux: warn when about to expire

2025-07-04 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c index 2b8cebf..0518e86 100644 --- a/src/watchdog-mux.c +++ b/src/watchdog-mux.c @@ -30,15 +30,23 @@ #define

  1   2   3   4   5   >