Thomas Lamprecht <t.lampre...@proxmox.com> writes:
> btw. instead of pinging a series unconditionally a better approach might > be to use that as an opportunity to self-test the whole series, i.e. apply > them locally and see if all works out; that would have made most issues of > this series visible. > If that succeeded, then asking someone directly for an end-to-end test > and/or review before sending the second ping or so out would also be more > productive IMO, as a tested-by gives maintainers at least some basic > assurance that the whole thing works in principle... > this fails with errors like > > proxmox-yew-comp.pot:185: duplicate message definition... > proxmox-widget-toolkit.pot:2081: ...this is the location of the first > definition > > Which is a result from the former file having this combined: > > msgid "Warning" > msgid_plural "Warnings" > msgstr[0] "" > msgstr[1] "" > > While the latter has it split: > > msgid "Warning" > msgstr "" > > msgid "Warnings" > msgstr "" > > There are others if this is fixed. I see no reference to other patches or > steps > we need to apply/take before this series, so what's the idea here? The requirements are: - https://lore.proxmox.com/pdm-devel/20250122150132.426276-1-m.sando...@proxmox.com/ - https://lore.proxmox.com/yew-devel/20250127094651.139204-1-m.sando...@proxmox.com/ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
