[pve-devel] [PATCH pve-firewall v6 01/10] sdn: add vnet firewall configuration

2024-11-20 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich Reviewed-by: Wolfgang Bumiller Tested-by: Hannes Dürr --- src/PVE/Firewall.pm | 127 ++-- src/PVE/Firewall/Helpers.pm | 12 2 files changed, 132 insertions(+), 7 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE

[pve-devel] [PATCH pve-firewall v8 3/5] sdn: always include SDN configuration

2024-11-20 Thread Stefan Hanreich
If the cluster configuration does not exist, but in other firewall configuration files there are rules referencing SDN IPsets, validation for those rules fails, because the cluster configuration does not contain the SDN IPSets. This is because generic_fw_config_parser returns an empty hash when the

[pve-devel] [PATCH proxmox-i18n] it: updated translation

2024-11-20 Thread Gabriel Goller
Updated all the tag-related translations to drop the plural "s", which doesn't exist in italian. Also fixed some typos included in an earlier patch. Fixes: b87af6f3ccb6 ("update Italian translations") Signed-off-by: Gabriel Goller --- it.po | 26 +- 1 file changed, 13 ins

Re: [pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-20 Thread Gabriel Goller
On 19.11.2024 12:37, Christian Ebner wrote: Signed-off-by: Christian Ebner --- it.po | 126 +++--- 1 file changed, 41 insertions(+), 85 deletions(-) diff --git a/it.po b/it.po index a1a5c48..da5516c 100644 --- a/it.po +++ b/it.po @@ -7743,9 +77

[pve-devel] applied-series: [PATCH installer 1/3] common: allow lowercase and uppercase zfs raid levels

2024-11-20 Thread Thomas Lamprecht
Am 20.11.24 um 19:24 schrieb Daniel Kral:> Allows the ZFS RAID levels to be either lowercase or uppercase when > deserializing them from string values, i.e. currently only the config > value of `zfs.raid` in auto-installer answer files. > > This partly fixes a regression, where deserializing the

[pve-devel] [PATCH installer 2/3] common: allow lowercase and uppercase btrfs raid levels

2024-11-20 Thread Daniel Kral
Allows the BTRFS RAID levels to be either lowercase or uppercase when deserializing them from string values, i.e. currently only the config value of `btrfs.raid` in auto-installer answer files. Signed-off-by: Daniel Kral --- When we're already at it, let's do the same for btrfs... Here's the out

[pve-devel] [PATCH installer 1/3] common: allow lowercase and uppercase zfs raid levels

2024-11-20 Thread Daniel Kral
Allows the ZFS RAID levels to be either lowercase or uppercase when deserializing them from string values, i.e. currently only the config value of `zfs.raid` in auto-installer answer files. This partly fixes a regression, where deserializing the `zfs.raid` property in answer files were only possib

[pve-devel] [PATCH installer 3/3] common: make btrfs disk options uppercase for consistency

2024-11-20 Thread Daniel Kral
As XFS and ZFS are spelled in uppercase letters in the installer UI and BTRFS is usually written in this way too, make the BTRFS string uppercase too for consistency wrt to the other options. Signed-off-by: Daniel Kral --- I just noticed this while booting up the PVE installer and as it (vaguely)

Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages

2024-11-20 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- Ok. Here is the error message: referenced path 'Ubuntu 24.04 (64bit)-disk001.vmdk' is invalid (500) Hope this helps. Thanks Em qua., 20 de nov. de 2024 às 13:32, Gilberto Ferreira via pve-devel < pve-devel@lists.proxmox.com> escreveu: > > > > -- Forwarded messa

[pve-devel] [PATCH docs] pvesdn: remove superfluous the

2024-11-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- sorry, I somehow missed that 'the' which shouldn't be there pvesdn.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 1541e54..5d5d27b 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -391,7 +391,7 @@ to take ef

[pve-devel] applied: [PATCH docs] pvesdn: remove superfluous the

2024-11-20 Thread Thomas Lamprecht
Am 20.11.24 um 17:39 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > sorry, I somehow missed that 'the' which shouldn't be there > > pvesdn.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! Changed the commit subject to "sdn: port isolation: rem

Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages

2024-11-20 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- Hi there. Sorry for the email, but I tested this import option with an Ubuntu ova which has space in the vmdk name and I believe that could lead to errors. I had downloaded from here: https://razaoinfo.dl.sourceforge.net/project/osboxes/v/vb/55-U-u/OVA-Versions/24.04/Ubuntu-24

Re: [pve-devel] Proposal: support for atomic snapshot of all VM disks at once

2024-11-20 Thread Ivaylo Markov via pve-devel
--- Begin Message --- Hello, I've been caught up in other things and it's been a while, but as I was collating and testing my proposed changes, I came across this again and thought I'd clarify something. On 08/10/2024 13:50, Max Carrara wrote: I was directed here to discuss this proposal and

[pve-devel] applied: [PATCH proxmox-i18n] updated Japanese language ja.po

2024-11-20 Thread Thomas Lamprecht
Am 19.11.24 um 17:32 schrieb Seiji Makino: > Fixed Japanese translation. > > Signed-off-by: Seiji Makino > --- > ja.po | 408 ++ > 1 file changed, 183 insertions(+), 225 deletions(-) > > just for the record: I applied this one already yes

[pve-devel] applied: [PATCH docs 2/3] pvesdn: add note to port isolation to use firewall in clusters

2024-11-20 Thread Thomas Lamprecht
Am 20.11.24 um 13:02 schrieb Aaron Lauterer: > since port isolation is only local on the host. To get better port > isolation, the VNET firewall can be used. > > Signed-off-by: Aaron Lauterer > --- > pvesdn.adoc | 4 > 1 file changed, 4 insertions(+) > > applied, thanks! ___

[pve-devel] applied: [PATCH docs 1/3] pvesdn: add chapter reference for sdn firewall

2024-11-20 Thread Thomas Lamprecht
Am 20.11.24 um 13:02 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > pvesdn.adoc | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/ma

[pve-devel] applied: [PATCH i18n] update Arabic translation

2024-11-20 Thread Thomas Lamprecht
Am 20.11.24 um 13:37 schrieb Moayad Almalat: > Signed-off-by: Moayad Almalat > --- > ar.po | 1163 +++-- > 1 file changed, 469 insertions(+), 694 deletions(-) > > applied, thanks! ___ pve-devel mai

[pve-devel] applied: [pve-network] d/postinst: do not break, if ipam-file moves fail

2024-11-20 Thread Thomas Lamprecht
Am 20.11.24 um 15:13 schrieb Stoiko Ivanov: > failing a package-install does not help repairing the situation - so > inform the user about the issue instead of erroring out. The copy > could fail if a node is not quorate, so writes in /etc/pve are a bit > more likely to fail > adapts the change int

[pve-devel] applied: [PATCH proxmox-perl-rs 1/1] firewall: sdn: ignore EPERM when reading the legacy IPAM file

2024-11-20 Thread Thomas Lamprecht
Am 20.11.24 um 15:47 schrieb Stefan Hanreich: > On fresh installations, neither the new nor the old IPAM db file > exist. This triggers our fallback code path and leads to errors in the > syslog on fresh installs where there is no IPAM database. This happens > whenever a firewall API call is made.

[pve-devel] [PATCH proxmox-i18n] updated Japanese language ja.po

2024-11-20 Thread Seiji Makino
Fixed Japanese translation. Signed-off-by: Seiji Makino --- ja.po | 408 ++ 1 file changed, 183 insertions(+), 225 deletions(-) diff --git a/ja.po b/ja.po index f45611f..133ee31 100644 --- a/ja.po +++ b/ja.po @@ -15,11 +15,10 @@ msgstr ""

[pve-devel] applied-series: [PATCH docs/firewall/manager v8 0/5] autogenerate ipsets for sdn objects

2024-11-20 Thread Thomas Lamprecht
Am 19.11.24 um 16:36 schrieb Stefan Hanreich: > pve-firewall: > > Stefan Hanreich (3): > add support for loading sdn firewall configuration > ipsets: return sdn ipsets from api > sdn: always include SDN configuration > > src/PVE/API2/Firewall/Cluster.pm | 12 +++- > src/PVE/API2/Firewa

[pve-devel] [PATCH docs/firewall/manager/network v6 00/10] add forward chain firewalling for hosts and vnets

2024-11-20 Thread Stefan Hanreich
## Introduction This patch series introduces a new direction for firewall rules: forward. Additionally this patch series introduces defining firewall rules on a vnet level. ## Use Cases For hosts: * hosts utilizing NAT can define firewall rules for NATed traffic * hosts utilizing EVPN zones can

[pve-devel] applied: [PATCH installer v2] first-boot: multi-user: start after product-specific API proxy

2024-11-20 Thread Thomas Lamprecht
Am 19.11.24 um 16:13 schrieb Christoph Heiss: > First of, multi-user.target does not seem to really provide any (strong) > ordering guarantee, it seems. > > Instead, let the "fully-up" ordering from the auto-installer depend on > the product-specific API proxy instead. > > That way, it is ensured

[pve-devel] [PATCH proxmox-perl-rs 1/1] firewall: sdn: ignore EPERM when reading the legacy IPAM file

2024-11-20 Thread Stefan Hanreich
On fresh installations, neither the new nor the old IPAM db file exist. This triggers our fallback code path and leads to errors in the syslog on fresh installs where there is no IPAM database. This happens whenever a firewall API call is made. Because of this, we choose to ignore EPERM when readin

[pve-devel] [pve-network] d/postinst: do not break, if ipam-file moves fail

2024-11-20 Thread Stoiko Ivanov
failing a package-install does not help repairing the situation - so inform the user about the issue instead of erroring out. The copy could fail if a node is not quorate, so writes in /etc/pve are a bit more likely to fail adapts the change introduced in d0628df ("debian: migrate legacy mac/ipam c

[pve-devel] [PATCH proxmox-i18n] es: update translations

2024-11-20 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- es.po | 111 +- 1 file changed, 48 insertions(+), 63 deletions(-) diff --git a/es.po b/es.po index e7ec7ca..85f8d0a 100644 --- a/es.po +++ b/es.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: proxm

[pve-devel] [PATCH proxmx-nvidia-vgpu-helper 1/2] debian/control: adjust description and pve-manager dependency

2024-11-20 Thread Hannes Duerr
remove the dependency of proxmox-dkms, since this package does not exist, and add the dependency of pve-manager, which should be installed with every reasonable Proxmox VE installation, so that the package can already be installed during the installation. Signed-off-by: Hannes Duerr --- debian/c

Re: [pve-devel] [PATCH docs 1/3] pvesdn: add chapter reference for sdn firewall

2024-11-20 Thread Stefan Hanreich
Talked with Aaron off-list about the changes, lgtm Reviewed-by: Stefan Hanreich On 11/20/24 13:02, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > pvesdn.adoc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/pvesdn.adoc b/pvesdn.adoc > index 8bd004e..2e24dd2 100644 > ---

[pve-devel] [PATCH manager 3/3] ui: sdn firewall: add online help

2024-11-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/sdn/FirewallPanel.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/sdn/FirewallPanel.js b/www/manager6/sdn/FirewallPanel.js index 9683a680..d6859d10 100644 --- a/www/manager6/sdn/FirewallPanel.js +++ b/www/manager6/sdn/FirewallP

[pve-devel] [PATCH docs 1/3] pvesdn: add chapter reference for sdn firewall

2024-11-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pvesdn.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/pvesdn.adoc b/pvesdn.adoc index 8bd004e..2e24dd2 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -707,6 +707,7 @@ For more information please consult the documentation of xref:pvesdn_ipam_plugin_pveip

[pve-devel] [PATCH docs 2/3] pvesdn: add note to port isolation to use firewall in clusters

2024-11-20 Thread Aaron Lauterer
since port isolation is only local on the host. To get better port isolation, the VNET firewall can be used. Signed-off-by: Aaron Lauterer --- pvesdn.adoc | 4 1 file changed, 4 insertions(+) diff --git a/pvesdn.adoc b/pvesdn.adoc index 2e24dd2..1541e54 100644 --- a/pvesdn.adoc +++ b/pvesd

Re: [pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-20 Thread Thomas Lamprecht
Am 19.11.24 um 13:09 schrieb Shannon Sterz: >>> This is intentional since that is the description for the systemd state, not >>> sure if it makes to translate that in this case? >> Maybe, but perhaps then it makes sense to remove the english string? I >> mean there are more similar strings which do

Re: [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB

2024-11-20 Thread Mira Limbeck
On 11/19/24 12:55, Maximiliano Sandoval wrote: > > Mira Limbeck writes: > >> Signed-off-by: Mira Limbeck >> --- >> Proxmox/Install.pm | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm >> index c64e1d4..da8fb55 100644 >> --- a/Proxmox/Instal

[pve-devel] [PATCH docs/firewall/manager v7 0/4] autogenerate ipsets for sdn objects

2024-11-20 Thread Stefan Hanreich
This patch series adds support for autogenerating ipsets for SDN objects. It autogenerates ipsets for every VNet as follows: * ipset containing all IP ranges of the VNet * ipset containing all gateways of the VNet * ipset containing all IP ranges of the subnet - except gateways * ipset containing

[pve-devel] [PATCH proxmx-nvidia-vgpu-helper 2/2] add script to help with the installation of the nvidia vgpu dependencies

2024-11-20 Thread Hannes Duerr
The script should help with the dependency installation for the nvidia vgpu driver, also if the driver is already installed but the system has been updated Signed-off-by: Hannes Duerr --- pve-install-nvidia-vgpu-deps | 66 1 file changed, 66 insertions(+) cr

[pve-devel] [PATCH proxmx-nvidia-vgpu-helper 0/2] reduce setup steps for nvidia vgpu drivers

2024-11-20 Thread Hannes Duerr
The patches apply to the repository proxmox-nvidia-vgpu-helper which is currently only available in my staff folder `staff/h.duerr/proxmox-nvidia-vgpu-helper`. The aim of the repository is to reduce the necessary installation steps for the Nvidia VGPU drivers [0]. The repository contains an install

[pve-devel] applied: [PATCH docs] qm: import: use consistent capitalization for web UI

2024-11-20 Thread Thomas Lamprecht
Am 20.11.24 um 11:46 schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > qm.adoc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmo

[pve-devel] [PATCH docs] qm: import: use consistent capitalization for web UI

2024-11-20 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- qm.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 2ffa4ef..94fdd4e 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1682,8 +1682,8 @@ OVA/OVF Import To import OVA/OVF files, you first need a File-based storage with the

[pve-devel] applied: [PATCH manager] aplinfo: update turnkey linux key after expiry

2024-11-20 Thread Thomas Lamprecht
Am 20.11.24 um 10:17 schrieb Fabian Grünbichler: > same key, updated expiry (`sq packet dump`, re-ordering the packets to > minimize > the diff): > > applied, but slightly expanded the commit message, thanks! ___ pve-devel mailing list pve-devel@lis

Re: [pve-devel] [PATCH manager] aplinfo: update turnkey linux key after expiry

2024-11-20 Thread Fabian Grünbichler
forgot to include this bit - I retrieved the (updated) key from https://ftp.halifax.rwth-aachen.de/turnkeylinux/metadata/release-key.txt (i.e., the copy on their mirror). > Fabian Grünbichler hat am 20.11.2024 10:17 CET > geschrieben: > > > same key, updated expiry (`sq packet dump`, re-ord

[pve-devel] [PATCH storage] file_size_info: check format for untrusted files

2024-11-20 Thread Dominik Csapak
so we fail early for files disguising as a different format (e.g. vhdx). One can't use such files anyway since we explicitly add the expected format to disks, so this only gives an earlier and prettier error when e.g. importing an OVA file with such a badly named disk image. Signed-off-by: Dominik

[pve-devel] [PATCH manager] aplinfo: update turnkey linux key after expiry

2024-11-20 Thread Fabian Grünbichler
same key, updated expiry (`sq packet dump`, re-ordering the packets to minimize the diff): diff --git a/old b/new index be331bd..253924d 100644 --- a/old +++ b/new @@ -52,3 +52,36 @@ Signature Packet, old CTB, 316 bytes Digest prefix: CDF9 Level: 0 (signature over data) +Signatu

Re: [pve-devel] [PATCH manager v2] ui: resource tree: add collapse/expand all button

2024-11-20 Thread Dominik Csapak
On 11/19/24 20:56, Thomas Lamprecht wrote: Am 19.11.24 um 10:49 schrieb Dominik Csapak: adds two buttons to the tree: expand all and collapse all Signed-off-by: Dominik Csapak --- changes from v1: * use two buttons (negates the need for all the event handling and checking) * use plain plus/min

Re: [pve-devel] [PATCH manager v2] ui: resource tree: add collapse/expand all button

2024-11-20 Thread Dominik Csapak
sent a v3 with stacked button, but IMHO they're too small: https://lore.proxmox.com/pve-devel/20241120085605.670102-1-d.csa...@proxmox.com/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-d

[pve-devel] [PATCH manager v3] ui: resource tree: add collapse/expand all button

2024-11-20 Thread Dominik Csapak
adds two buttons to the tree: expand all and collapse all stack them above each other. This makes it necesary to reduce the font-size so the whole icon is visible. Signed-off-by: Dominik Csapak --- changes from v2: * stack the buttons * add css classes to make the icons so small that they're vis