On 2/8/24 17:46, Aaron Lauterer wrote:
On 2/8/24 15:18, Christoph Heiss wrote:
Sorry for not including this in the first email.
On Tue, Jan 23, 2024 at 06:00:49PM +0100, Aaron Lauterer wrote:
[..]
diff --git a/proxmox-auto-installer/src/fetch_plugins/partition.rs
b/proxmox-auto-installer/
Am 27.11.23 um 12:39 schrieb Philipp Hufnagl:
> Because it is needed later in this patch series, the method
> pbs_api_connect is moved earlyer in the code
Typo: /earlyer/earlier/ (also in the title)
>
> Signed-off-by: Philipp Hufnagl
> ---
> src/PVE/Storage/PBSPlugin.pm | 63 ++
Am 27.11.23 um 12:39 schrieb Philipp Hufnagl:
> It would be nice to reuse an existing PBS connection for scan_datastore.
> Because scan_datastore is used multiple in the code, it can not be
> changed without breaking existing code.
>
I'm no fan of the second sentence. You do change it with the pa
Am 27.11.23 um 12:40 schrieb Philipp Hufnagl:
> Parts contained in activate_storage are needed to be run to fix #5008,
> however, implementing a namespace check there would cause unneeded
> overhead.
>
> Therefore, this patch extracts the method check_datastore_exists from
> activate storage.
>
>
Am 27.11.23 um 12:40 schrieb Philipp Hufnagl:
> This adds a check if the datastore and the namespace is valid when a
> user attempts to add a new PBS datastore.
>
> Since the namespace only can be checked after the datastore is
> validated, the datastore will be checked as well, regardless that it
This commit adds the '/etc/pve/ceph' directory to our overall expected
Ceph configuration.
This directory is meant to store cluster-wide, non-private
configuration files used by Ceph applications and services that are
executed with lower privileges, such as 'ceph-crash.service'.
The existence of
Because continued lines (lines following lines that end with '\')
preserve whitespace, this commit removes any leading whitespace that
is added by our config writer.
This is done in order to make continued lines look less "awkward" when
manually changing values in 'ceph.conf' after the file has be
Ceph's docs state the following [0]:
> The backslash character `\` is used as the line-continuation marker
> that combines the next line with the current one.
This commit implements the support of such line-continuations in our
parser.
The line following a line ending with a '\' has its whitespac
This commit changes the code style of subroutine `write_ceph_config`
to match our style guide [0] more.
Furthermore, the repeated calls to the inner subroutine are replaced
with a loop, while the regular expressions used by the inner sub are
now quoted with `qr` to prevent any accidental mis-quoti
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new
bin/Makefile | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/bin/Makefile b/bin/Makefile
index b221e4b1..180a91b5 100644
--- a/bin/Makefile
+++ b/bin/Makefile
@@ -25,6 +25,10 @@ SCRIPTS =\
This adds support for writing arbitrary sections to 'ceph.conf' while
ensuring that already written sections are not duplicated.
Sections that are associated with the client, for example
'[client.foo]', are written directly after the '[client]' section.
Signed-off-by: Max Carrara
---
Changes v1
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on the contents of
'/var/lib/ceph/crash'.
This patch therefore also recursively updates the permissions of
'/var/lib/ceph/crash'.
Signed-off-by: Max Carrara
---
Changes v1 --> v2:
*
Due to Ceph dropping privileges when running the 'ceph-crash' daemon
[0], it is necessary to allow the daemon to authenticate with its
cluster in a safe manner.
In order to avoid exposing sensitive keyrings or somehow escalating
its privileges again, 'ceph-crash' is therefore provided with its own
This marks version 03 of the patch series "Fix #4759: Configure
Permissions for ceph-crash.service". Older versions can be found below.
Notable changes since v2
* The 'ceph.conf' parser in pve-storage is now equivalent to Ceph's
and even supports continued lines
*
1. Comments, irrespective of whether they start with '#' or ';' are
now treated the same. Otherwise, sections and key-value pairs with
a trailing comment starting with ';' are still parsed. Consider
this example:
[some.section] # inline comment after section
foo = bar ; in
This patch makes it so that `ceph-crash` attempts to use the
non-host-specific keyring before anything else, which avoids
unnecessary error messages landing in the systemd-journal in our case.
Signed-off-by: Max Carrara
Reviewed-by: Fabian Grünbichler
---
Changes v1 --> v2:
* new
Changes v2 --
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on the contents of
'/var/lib/ceph/crash'.
This patch therefore also recursively updates the permissions of
'/var/lib/ceph/crash'.
Signed-off-by: Max Carrara
---
Changes v1 --> v2:
*
in order to group related sections together.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new; originally patch 07 of series v2, now adapted to this series
src/PVE/CephConfig.pm | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/PVE/CephConfig.pm b/src
This patch makes it so that `ceph-crash` attempts to use the
non-host-specific keyring before anything else, which avoids
unnecessary error messages landing in the systemd-journal in our case.
Signed-off-by: Max Carrara
Reviewed-by: Fabian Grünbichler
---
Changes v1 --> v2:
* new
Changes v2 --
Am 21.11.23 um 13:47 schrieb Dominik Csapak:
> and keep the functionality in ResourceTree as generic as possible.
>
> We achieve this by having an 'itemMap' function that can split one item
> from the store into multiple to add to the tree.
>
> for the updates, we have to have an 'idMapFn' (to ge
Am 01.09.23 um 11:05 schrieb Filip Schauer:
> Do not use the 'noacl' mount option when mounting a container disk with
> an ext4 file system. The option was removed from the kernel in commit
> 2d544ec923db
>
> Signed-off-by: Filip Schauer
> ---
> src/PVE/LXC.pm | 10 +++---
> 1 file changed,
On 15/02/2024 14:16, Thomas Lamprecht wrote:
[...]
>
> applied, thanks!
>
> as talked off-list, ceph is really not trying to reduce confusion potential
> doing things like:
>
> install -D -m 644 etc/sysctl/90-ceph-osd.conf
> $(DESTDIR)/etc/sysctl.d/30-ceph-osd.conf
>
> I.e., having it checked
--- Begin Message ---
On Thu, Feb 15, 2024 at 07:20:51PM +0100, Dietmar Maurer wrote:
> > The information gathered by the API call comes from the systemd
> > journal. While 'Syslog' could be interpreted as a shorthand for
> > "System Log", it's better to be explicit to avoid any confusion.
>
> > -
--- Begin Message ---
On Fri, Feb 16, 2024 at 10:25:22AM +0100, Dietmar Maurer wrote:
> > while I don't mind (at all!) that that part of the UI/API is labelled
> > syslog (I don't think it's hard to understand that it gives you the system
> > logs of that node, and "syslog" is a bit like "Kleenex
ping 🙂 still applies on latest master. Also tested it again to make sure
that no other changes interfered with it in the meanwhile.
On 1/8/24 11:43, Lukas Wagner wrote:
> ping
>
> On 11/23/23 17:09, Lukas Wagner wrote:
>> - Switch order of 'mailto' and 'mailnotification' field
>> - When mod
ping - still applies on master. Retested it quickly, also seems to work fine.
On 1/8/24 11:43, Lukas Wagner wrote:
> ping
>
> On 12/14/23 10:48, Lukas Wagner wrote:
>> Deleting a built-in target/matcher does not remove it, but resets it
>> to its default settings. This was not really obvious from
> while I don't mind (at all!) that that part of the UI/API is labelled syslog
> (I don't think it's hard to understand that it gives you the system logs of
> that node, and "syslog" is a bit like "Kleenex" in that regard ;)) - I do
> have to disagree here ;) journald does a lot more than just c
Am 16.02.24 um 10:01 schrieb Fabian Grünbichler:
>
>> Fiona Ebner hat am 16.02.2024 09:29 CET geschrieben:
>> Am 15.02.24 um 19:20 schrieb Dietmar Maurer:
The information gathered by the API call comes from the systemd
journal. While 'Syslog' could be interpreted as a shorthand for
>>
Superseded-by:
https://lists.proxmox.com/pipermail/pve-devel/2024-February/061778.html
On 12/13/23 17:37, Lukas Wagner wrote:
> This patch series attempts to improve the user experience when creating
> notification matchers.
>
> Some of the noteworthy changes:
> - Fixup inconsistent 'hostname'
Signed-off-by: Lukas Wagner
---
notifications.adoc | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index 0eeed6a..912b048 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -221,11 +221,16 @@ configurable sch
Signed-off-by: Lukas Wagner
---
notifications.adoc | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index 57053c8..0eeed6a 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -289,19 +289,22 @@ Notification
Notification match rules are able to match based on the job id, so it
makes sense to display it to the user.
Signed-off-by: Lukas Wagner
---
www/manager6/grid/Replication.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid
This might be useful if somebody wants to match on the new
'backup-job' field in a notification match rule.
Signed-off-by: Lukas Wagner
---
www/manager6/Utils.js | 4
www/manager6/dc/Backup.js | 11 +++
2 files changed, 15 insertions(+)
diff --git a/www/manager6/Utils.js b/www
This allows users to create notification match rules for specific
replication jobs, if they so desire.
Signed-off-by: Lukas Wagner
---
PVE/API2/Replication.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm
index 0dc944c9..703
This allows us to access us the backup job id in the send_notification
function, where we can set it as metadata for the notification.
Signed-off-by: Lukas Wagner
---
PVE/API2/VZDump.pm | 8
PVE/Jobs/VZDump.pm | 4 +++-
PVE/VZDump.pm | 6 +++---
3 files changed, 14 insertions(+), 4
This is useful for creating matchers based on the 'backup-job'
metadata field.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Backup.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 4beb84c0..fb4df0a7 100644
---
This patch series attempts to improve the user experience when creating
notification matchers.
Some of the noteworthy changes:
- Fixup inconsistent 'hostname' field. Some notification events sent
the hostname including a domain, while other did not.
This series unifies the behavior, now the
This should make the code more cohesive and easier to follow.
No functional changes.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
src/window/NotificationMatcherEdit.js | 186 +-
1 file changed, 92 insertions(+), 94 deletions(-)
diff --git a/src/windo
These changes introduce combogrid pickers for the 'field' and 'value'
form elements for 'match-field' match rules. The 'field' picker shows
a list of all known metadata fields, while the 'value' picker shows a
list of all known values, filtered depending on the current value of
'field'.
The list o
Also introduce a local viewModel that is linked to a parent viewModel,
allowing us to move the formulas to the panel.
This should make the code more cohesive and easier to follow.
No functional changes.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
src/window/NotificationMatc
Also introduce a local viewModel that is linked to a parent viewModel,
allowing us to move the formulas to the panel.
This should make the code more cohesive and easier to follow.
No functional changes.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
src/window/NotificationMatc
This new API route returns known notification metadata fields and
a list of known possible values. This will be used by the UI to
provide suggestions when adding/modifying match rules.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 152 ++
1 file
This was a bit inconsistent between the different notification types:
- APT/VZDump included the domain part
- fence notifications did not
A decision has been made to unify this by removing the domain part
from APT/VZDump notifications.
Signed-off-by: Lukas Wagner
---
notifications.adoc | 2
This allows one configure the clear trigger to be shown, even if
'allowBlank' is set false. This can be useful if one has a
non-editable combogrid where the value is set to something not
present in the store. Example: Match rule editing, one selects
a backup job to be match. If the backup job is re
- The man page warns about the usage of `hostname -f`, since a host
may have multiple domains (or none at all)
- The fallback PVE::INotify::nodename() already only returned the
hostname without the domain part
- Fencing notifications didn't include the domain part anyway
This may result i
Signed-off-by: Lukas Wagner
---
www/manager6/Utils.js | 12
1 file changed, 12 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 4c8bf9d3..80c8f0f6 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -2042,6 +2042,18 @@ Ext.define('PVE.Util
The field contains the hostname of the host (without any domain part)
which sends the notification. This field can be used in match-field
match rules.
Signed-off-by: Lukas Wagner
---
PVE/API2/Replication.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/API2/Replication.pm b/PVE/API2/
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Backup.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 70903bdc..4beb84c0 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -569,7 +569,6 @@ Ext.define('PVE.dc
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index 7047f0b1..68fdda2a 100644
--- a/PVE/API2/Cluster/Notifications.pm
+++ b/PVE/API2/Clu
> Fiona Ebner hat am 16.02.2024 09:29 CET geschrieben:
> Am 15.02.24 um 19:20 schrieb Dietmar Maurer:
> >> The information gathered by the API call comes from the systemd
> >> journal. While 'Syslog' could be interpreted as a shorthand for
> >> "System Log", it's better to be explicit to avoid an
Am 15.02.24 um 19:20 schrieb Dietmar Maurer:
>> The information gathered by the API call comes from the systemd
>> journal. While 'Syslog' could be interpreted as a shorthand for
>> "System Log", it's better to be explicit to avoid any confusion.
>
>> -title: 'Syslog',
>> +
51 matches
Mail list logo
