On 15/02/2024 14:16, Thomas Lamprecht wrote: [...] > > applied, thanks! > > as talked off-list, ceph is really not trying to reduce confusion potential > doing things like: > > install -D -m 644 etc/sysctl/90-ceph-osd.conf > $(DESTDIR)/etc/sysctl.d/30-ceph-osd.conf > > I.e., having it checked in as 90-... but installing it as 30-..
Seems like the rpm installs it as 90-ceph-osd.conf though :) https://github.com/ceph/ceph/blob/fda8b5acbd7381dc4d86d7df5389e22aacffec22/ceph.spec.in#L1526 > And while I think the argument for "admin could have overrides that this > affects", which you mentioned that Fabian brought up off-list, is fine, > but is just as true on initial installation. > > What might be better is one (or some) of: [...]> - drop our odd disabling of the `net.bridge.bridge-nf-call-iptables` For PVE this might make sense independently of what ceph-osd postinst does. We've been explicitly disabling the setting since 2012 though [1] -- will try to find out if this is still needed. If we drop it, would this be a breaking chance and need to wait for PVE 9? [1] https://git.proxmox.com/?p=pve-cluster.git;a=commit;h=501839cac97f68d4dcba21df6fb3797b976e9e56 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
