Am 15/11/2022 um 16:17 schrieb Fabian Grünbichler:
> this one is worded differently than the rest (maybe):
>
> 'none' no tags are modifiable.
> 'list' tags from 'user-allow-list' are modifiable.
> 'existing' like list, but already existing tags of resource are also
> modifiable.
> 'free' no tag r
Am 16/11/2022 um 05:13 schrieb Alexandre Derumier:
> max supported queues tx + rx = 256, so 128 for combined
> https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg03917.html
do you really use such a relatively high amount of queues in practice?
The patch even mentions that on x86 one can onl
Am 10/11/2022 um 15:37 schrieb Fiona Ebner:
> In preparation for scheduling based on static information, where the
> scoring of nodes depends on information from the service's
> VM/CT configuration file (and the $sid is required to query that).
>
> Signed-off-by: Fiona Ebner
> ---
> src/PVE/HA/M
Am 11/11/2022 um 10:28 schrieb Fiona Ebner:
> Am 10.11.22 um 15:37 schrieb Fiona Ebner:
>> @@ -206,11 +207,30 @@ my $valid_service_states = {
>> sub recompute_online_node_usage {
> So I was a bit worried that recompute_online_node_usage() would become
> too inefficient with the new add_service_usa
Am 10/11/2022 um 15:37 schrieb Fiona Ebner:
> for reading the resource scheduler settings.
>
> Signed-off-by: Fiona Ebner
> ---
> src/PVE/HA/Env.pm | 7 +++
> src/PVE/HA/Env/PVE2.pm | 12
> src/PVE/HA/Sim/Env.pm | 9 +
> 3 files changed, 28 insertions(+)
>
> dif
Signed-off-by: Alexandre Derumier
---
www/manager6/qemu/NetworkEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index b39cffdc..ccce14ff 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/
max supported queues tx + rx = 256, so 128 for combined
https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg03917.html
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 3b64
> +sub score_nodes_to_start_service {
> + my ($self, $sid, $service_node) = @_;
> +
> + my $score_list = eval {
> + my $service_usage = get_service_usage($self, $sid,
> $service_node);
> + $self->{scheduler}-
> >score_nodes_to_start_service($service_usage);
> + };
> + if (m
Thanks Fiona for your hard work on this !
I'm going to review/test them this week.
I'm not an expert in Rust, but I think I'll be able to read the code
Just a question, how do you choose the weight of different criteria ?
I think in the second patch, I see:
+static ref PVE_HA_TOPSIS_CRIT
On November 15, 2022 2:02 pm, Dominik Csapak wrote:
> helper to check permissions for tag setting/updating/deleting
> for both container and qemu-server
>
> gets the list of allowed tags from the DataCenterConfig and the current
> user permissions, and checks for each tag that is added/removed if
On November 15, 2022 2:02 pm, Dominik Csapak wrote:
> by adding a 'user-tag-privileges' and 'admin-tags' option.
> The first sets the policy by which "normal" users (with
> 'VM.Config.Options' on the respective guest) can create/delete tags
> and the second is a list of tags only settable by 'admin
On 11/15/22 13:17, Fiona Ebner wrote:
Am 15.11.22 um 11:55 schrieb Stefan Hrdlicka:
@@ -2341,10 +2346,10 @@ sub destroy_vm {
my $volid = $drive->{file};
return if !$volid || $volid =~ m|^/|;
-
- die "base volume '$volid' is still in use by linked cloned\n
Am 15/11/2022 um 14:23 schrieb Dominik Csapak:
> when the mode changes, we set the pool selector visible/hidden, but
> we never disabled/enabled it. this tripped up the dirty state of the
> form always showing the reset button as enabled.
>
> to fix it, properly enable/disable it
>
> Signed-off-b
Am 10/11/2022 um 15:37 schrieb Fiona Ebner:
> to be used for static resource scheduling.
>
> In container's vmstatus(), the 'cores' option takes precedence over
> the 'cpulimit' one, but it felt more accurate to prefer 'cpulimit'
> here.
>
> Signed-off-by: Fiona Ebner
> ---
> src/PVE/HA/Resourc
when the mode changes, we set the pool selector visible/hidden, but
we never disabled/enabled it. this tripped up the dirty state of the
form always showing the reset button as enabled.
to fix it, properly enable/disable it
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Backup.js | 2 ++
1 f
Am 10/11/2022 um 15:37 schrieb Fiona Ebner:
> pve-manager:
>
> Fiona Ebner (3):
> pvestatd: broadcast static node information
> cluster resources: add cgroup-mode to node properties
> ui: lxc/qemu: cpu edit: make cpuunits depend on node's cgroup version
applied these three
___
also allows to search for tags in the GlobalSearchField where each tag is
treated like a seperate field, so it weighs more if the user searches for
the exact string of a single tag
Signed-off-by: Dominik Csapak
ui: ResourceGrid: render tags
with the 'full' styling
Signed-off-by: Dominik Csapak
and update the treenodes when the tags change.
since we change the vm node text (which we pass through to the config
panel), we have to change how we generate the text there slightly
(otherwise that would include the rendered tags)
Signed-off-by: Dominik Csapak
---
www/manager6/data/ResourceStor
displays a single tag, with the ability to edit inline on click (when
the mode is set to editable). This brings up a list of globally available tags
for simple selection.
this is a basic ext component, with 'i' tags for the icons (handle and
add/remove button) and a span (for the tag text)
shows
this provides a basic grid to edit a list of tag color overrides.
We'll use this for editing the datacenter.cfg overrides and the
browser storage overrides.
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css | 5 +
www/manager6/Makefile | 1 +
www/manager6/Utils.
this is a wrapper container for holding a list of (editable) tags
intended to be used in the lxc/qemu status toolbar
to add a new tag, we reuse the 'pmxTag' class, but overwrite some of
its behaviour and css classes so that it properly adds tags
also handles the drag/drop feature for the tags in
add the tags in the status line, and add a button for adding new ones
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/Config.js | 32 ++--
www/manager6/qemu/Config.js | 31 +--
2 files changed, 59 insertions(+), 4 deletions(-)
diff --g
namely for 'tag-tree-style' and 'tag-colors'.
display the tag overrides directly as they will appear as tags
Signed-off-by: Dominik Csapak
---
changes from v9:
* now also sets PVE.UIOptions
* adapt to change of updateTagSettings
www/manager6/Utils.js | 20
www/manager6/dc/OptionVie
helpers to
* generate a color from a string consistently
* generate a html tag for a tag
* related css classes
contrast is calculated according to SAPC draft:
https://github.com/Myndex/SAPC-APCA
which is likely to become a w3c guideline in the future and seems
to be a better algorithm for this
S
and move the use of the console from VersionInfo to here, since
this will be the future place for ui related backend options.
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 12 +++-
www/manager6/Workspace.js | 2 ++
www/manager6/dc/OptionView.js | 4 ++--
3 files
stores the color-map into a global list of overrides. on update, also parse
the values from the browser localstore. Also emits a GlobalEvent
'loadedUiOptions' so that e.g. the tags can listen to that and refresh their
colors
also saves the list of 'allowed-tags' into PVE.Utils
Signed-off-by: Domi
which contains ui relevant options, like the console preference and tag-style
also contains the list of allowed tags
Signed-off-by: Dominik Csapak
---
PVE/API2.pm | 61 +
1 file changed, 61 insertions(+)
diff --git a/PVE/API2.pm b/PVE/API2.pm
from GuestHelpers. This function checks all necessary permissions and
raises an exception if the user does not have the correct ones.
This is necessary for the new 'privileged' tags and 'user-tag-access'
permissions to work.
Signed-off-by: Dominik Csapak
---
changes from v9:
* use GuestHelpers::
by querying 'lock' and 'tags' with 'get_guest_config_properties'
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
index 49e319a5c..34a6e08cd 100644
--- a/PVE/API2/Cluster.p
to fix selection behavior for Ext.dd.DragZone.
Signed-off-by: Dominik Csapak
---
src/Toolkit.js | 16
1 file changed, 16 insertions(+)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index 4381f46..2f4a01a 100644
--- a/src/Toolkit.js
+++ b/src/Toolkit.js
@@ -686,6 +686,22 @@ Ext.d
for getting multiple properties from the in memory config of the
guests in one go. Keep the existing IPC call as is for backward
compatibility and add this as separate, new one.
It basically behaves the same as
CFS_IPC_GET_GUEST_CONFIG_PROPERTY, but takes a list of properties
instead and returns m
ui-options/datacenter.cfg return an 'ordering' option. parse that and
use it to order the tags when viewing.
when having that enabled, drag & drop when editing is disabled and the
tags will be inserted at the right place. when saving, the sorted
order will be written into the config
Signed-off-by
by adding a 'user-tag-privileges' and 'admin-tags' option.
The first sets the policy by which "normal" users (with
'VM.Config.Options' on the respective guest) can create/delete tags
and the second is a list of tags only settable by 'admins'
('Sys.Modify' on '/')
also add a helper 'get_allowed_tag
a field which contains just a list of textfields, e.g. useful for a list
of simple tags
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/ListField.js | 165 +
2 files changed, 166 insertions(+)
create mode 100644 www/man
helper to check permissions for tag setting/updating/deleting
for both container and qemu-server
gets the list of allowed tags from the DataCenterConfig and the current
user permissions, and checks for each tag that is added/removed if
the user has permissions to modify it
'normal' tags require '
its a property string containing 'tree-shape' and 'colors'
the colors are formatted like this:
:[:]
Signed-off-by: Dominik Csapak
---
data/PVE/DataCenterConfig.pm | 37
1 file changed, 37 insertions(+)
diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/Dat
from GuestHelpers. This function checks all necessary permissions and
raises an exception if the user does not have the correct ones.
This is necessary for the new 'privileged' tags and 'user-tag-access'
permissions to work.
Signed-off-by: Dominik Csapak
---
changes from v9:
* use GuestHelpers::
such that the admin can decide if the tags should be sorted in the gui
Signed-off-by: Dominik Csapak
---
new in v10
data/PVE/DataCenterConfig.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm
index ae138f9..658cfd9 100644
--
this series brings the already existing 'tags' for ct/vms to the gui:
* tags can be edited in the status toolbar of the guest
* existing tags will be shown in the tree/global search/resource grids
* when editing a tag, a list of tags will be shown
* by default, the color is (consistently) autogener
akin to get_guest_config_property, but with a list of properties.
uses the new CFS_IPC_GET_GUEST_CONFIG_PROPERTIES
also adds the same NOTEs regarding parsing/permissions to the comment
of get_guest_config_property
Signed-off-by: Dominik Csapak
---
data/PVE/Cluster.pm | 27 ++
Am 15/11/2022 um 11:18 schrieb Fiona Ebner:
> for backwards compatibility. Otherwise, e.g. listing backup jobs with
> pvesh get /cluster/backup is broken. And suddenly not having the
> property anymore would be a breaking API change.
>
> Signed-off-by: Fiona Ebner
> ---
>
> I didn't see any othe
Am 10/11/2022 um 11:36 schrieb Dominik Csapak:
> file-restore has a 'timeout' parameter and if that is exceeded, returns
> an error with the http code 503 Service Unavailable
>
> When the web ui encounters such an error, it retries the listing a few
> times before giving up.
>
> To make use of th
Am 10/11/2022 um 11:36 schrieb Dominik Csapak:
> since commit
> ba690c40 ("file-restore: remove 'json-error' parameter from list_files")
>
> in proxmox-backup, the file-restore binary will return the error as json
> when called with '--output-format json' (which we do in PVE::PBSClient)
>
> here,
Am 10/11/2022 um 11:36 schrieb Dominik Csapak:
> under some conditions, like when calling it in the api where we have
> a 30s pveproxy limit, we want to make use of the '--timeout' parameter
> of the file-restore binary, but we may want to call it in the future
> where we don't want add timeout.
>
Am 15.11.22 um 11:55 schrieb Stefan Hrdlicka:
> @@ -2341,10 +2346,10 @@ sub destroy_vm {
>
> my $volid = $drive->{file};
> return if !$volid || $volid =~ m|^/|;
> -
> - die "base volume '$volid' is still in use by linked cloned\n"
> - if PVE
Signed-off-by: Stefan Hrdlicka
---
src/PVE/LXC.pm | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index fe68f75..635cf44 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -668,7 +668,7 @@ sub update_lxc_config {
# some init s
V1 -> V2:
# overall
* matched detaching/removing drives behavior for VM & containers
It currently works this way:
- Detach drive
- drive shows up as unused
- remove drive
- drive will be removed without removing data (obviously)
# pve-storage
* added storage_exists function for matching
detach of a mount point with a removed underlying storage causes it to
be labeled as a an 'unused disk'
remove of a 'unused disk' with a removed underlying storage causes it to
be removed from the configuration
Signed-off-by: Stefan Hrdlicka
---
src/PVE/LXC/Config.pm | 6 +-
1 file changed,
Add a checkbox to the remove dialog of LXC containers and VMs to force
deleting a container/VM if the storage it uses has been removed.
Signed-off-by: Stefan Hrdlicka
---
www/manager6/lxc/Config.js | 1 +
www/manager6/qemu/Config.js | 1 +
www/manager6/window/SafeDestr
if a storage is not available a volume will be added to the container
config as unused. before it would just disappear from the config
Signed-off-by: Stefan Hrdlicka
---
PVE/QemuServer.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.
Signed-off-by: Stefan Hrdlicka
---
PVE/API2/Qemu.pm | 8
PVE/QemuServer.pm | 23 ---
2 files changed, 24 insertions(+), 7 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 30348e6..2a0806f 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1
Make it possible to delete a container whoes underlying storage is no
longer available. This will just write an warning instead of dying.
Without setting the option ignore-storage-errors=1 a delete will still
fail, like it did before the changes. With this option set it will try to
delete the volu
The commit message should include the why too of course rather than just
having it in the code comments:
Am 15.11.22 um 11:18 schrieb Fiona Ebner:
> for backwards compatibility.
When moving the job base plugin to pve-common, the behavior for parsing
the job config changed slightly, and 'id' was n
for backwards compatibility. Otherwise, e.g. listing backup jobs with
pvesh get /cluster/backup is broken. And suddenly not having the
property anymore would be a breaking API change.
Signed-off-by: Fiona Ebner
---
I didn't see any other places that rely on the $job->{id} to be set.
The other ba
Since VZDump/JobBase.pm in guest-common doesn't declare that it has an
option 'id', this is unused anyway and the auto-inject logic wouldn't
trigger.
Alternatively, the 'id' option could be added in VZDump/JobBase.pm (as
optional, because existing jobs.cfg don't contain the id as a property
within
applied & bumped, thanks
will take a look at how to get the tests runnable better
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
repo created & packaged, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
a small nit inline
On 11/14/22 10:43, Dominik Csapak wrote:
'normal' tags require 'VM.Config.Options' on '/vm/', but not
allowed tags (either limited with 'user-tag-access' or 'privileged-tags'
in the datacenter config) require 'Sys.Modify' on '/'
this patch implements the proper checks on addi
Am 10/11/2022 um 11:36 schrieb Dominik Csapak:
> by adding 'dynamic-memory' parameter that controls if we automatically
> increase the memory of the guest vm or not
>
> Signed-off-by: Dominik Csapak
> ---
> new in v4
>
> not really happy with the 'clippy allow', but imho there is no obvious way
59 matches
Mail list logo
