The commit message should include the why too of course rather than just having it in the code comments:
Am 15.11.22 um 11:18 schrieb Fiona Ebner: > for backwards compatibility. When moving the job base plugin to pve-common, the behavior for parsing the job config changed slightly, and 'id' was not automatically set as a job property anymore. > Otherwise, e.g. listing backup jobs with > pvesh get /cluster/backup is broken. And suddenly not having the > property anymore would be a breaking API change. > Sorry for the noise. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
