Am 18.06.21 um 08:56 schrieb Wolfgang Bumiller:
On 06/18/2021 8:53 AM Fabian Ebner wrote:
Am 18.06.21 um 08:44 schrieb Wolfgang Bumiller:
On 06/18/2021 8:42 AM Fabian Ebner wrote:
+Some((last, rest)) => match rest.split_last() {
+Some((second_to_last, _rest
> On 06/18/2021 8:53 AM Fabian Ebner wrote:
>
>
> Am 18.06.21 um 08:44 schrieb Wolfgang Bumiller:
> >
> >> On 06/18/2021 8:42 AM Fabian Ebner wrote:
> +Some((last, rest)) => match rest.split_last() {
> +Some((second_to_last, _rest)) => {
> +
Am 18.06.21 um 08:44 schrieb Wolfgang Bumiller:
On 06/18/2021 8:42 AM Fabian Ebner wrote:
+Some((last, rest)) => match rest.split_last() {
+Some((second_to_last, _rest)) => {
+(*last == "org" && *second_to_last == "debian")
+
Am 17.06.21 um 16:16 schrieb Fabian Grünbichler:
On June 11, 2021 1:43 pm, Fabian Ebner wrote:
useful for major upgrades. The stable branch can enable the upgrade, and bump
the minor version, while the master branch will adapt to the new release and
bump the major version. Each product can depen
> On 06/18/2021 8:42 AM Fabian Ebner wrote:
> >> +Some((last, rest)) => match rest.split_last() {
> >> +Some((second_to_last, _rest)) => {
> >> +(*last == "org" && *second_to_last == "debian")
> >> +|| (*last == "com" && *se
Am 17.06.21 um 10:39 schrieb Wolfgang Bumiller:
some non-blocking cleanups in case you do another version:
On Fri, Jun 11, 2021 at 01:43:53PM +0200, Fabian Ebner wrote:
which checks for bad suites and official URIs.
Signed-off-by: Fabian Ebner
---
Changes from v5:
* split out host_from_
On 06.05.21 14:16, Fabian Ebner wrote:
> Changes from v4:
> * dropped already applied patches
> * added a few small follow-ups and preparation:
> * set loading mask early enough
> * switch to two-column layout
> * changes for the main patch:
> * fix labels and ge
verbatim copy symbols from debian upstream [0] at commit
e28b972f4fa6c6c3195d362008d14c4e5a3ec219
[0] https://salsa.debian.org/zfsonlinux-team/zfs.git
Signed-off-by: Stoiko Ivanov
---
debian/libnvpair3linux.symbols | 236 ++
debian/libuutil3linux.symbols | 261 +++
debian/libzfs4linux
On June 11, 2021 1:43 pm, Fabian Ebner wrote:
> which checks for bad suites and official URIs.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Changes from v5:
> * split out host_from_uri helper and also handle userinfo and port
> * test an offical URI with port
> * match all *.debian.org
On June 11, 2021 1:43 pm, Fabian Ebner wrote:
> useful for major upgrades. The stable branch can enable the upgrade, and bump
> the minor version, while the master branch will adapt to the new release and
> bump the major version. Each product can depend on the the new major version
> after branchi
* Pull in the changes to the automatic scrub cronjob from
debian-upstream [0] commit
f6d45405df0a2ed2748975667e8ea50714034d13
* Add a script and cronjob for regular trimming of pools
* Change the logic to scrub/trim pools based on a per pool('s root
dataset property)
pulled the changes in as
mostly taken from debian-upstream
Signed-off-by: Stoiko Ivanov
---
debian/libzfsbootenv1linux.lintian-overrides | 4 ++--
debian/zfs-test.lintian-overrides| 14 +-
debian/zfs-zed.lintian-overrides | 4
debian/zfsutils-linux.lintian-overrides | 16 +
(adapted from debian-upstream [0] commit
b8999dc6ed1c821d5ca0e6474d7d57718b700dbf)
[0] https://salsa.debian.org/zfsonlinux-team/zfs/
Signed-off-by: Stoiko Ivanov
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 57d8eefb
Closes BTS#983401.
- Overwrite dangling symlinks on install
- Does not clobber symlinks on removal
Signed-off-by: Antonio Russo
(cherry picked from commit b024d59f5976ea75ac9a0b48612b7032d24513ee)
Signed-off-by: Stoiko Ivanov
---
debian/zfs-zed.postinst | 2 +-
debian/zfs-zed.prerm| 4 ++
Signed-off-by: Antonio Russo
(cherry picked from commit 1564c05d0dfa30bef120f86529a3f026538e4c4e)
Signed-off-by: Stoiko Ivanov
---
debian/zfs-initramfs.triggers | 1 -
1 file changed, 1 deletion(-)
delete mode 100644 debian/zfs-initramfs.triggers
diff --git a/debian/zfs-initramfs.triggers b/de
cherry picked from debian-upstream [0]
(cherry picked from commit dbe70331081033bbedfa52d641f82e784972f6cf)
Originally-by: Antonio Russo
Signed-off-by: Stoiko Ivanov
[0] https://salsa.debian.org/zfsonlinux-team/zfs/
Signed-off-by: Stoiko Ivanov
---
debian/control | 3 ++-
1 file changed, 2 i
Signed-off-by: Stoiko Ivanov
---
Makefile | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Makefile b/Makefile
index bc168cda..a3d730d5 100644
--- a/Makefile
+++ b/Makefile
@@ -17,7 +17,7 @@ zfs-zed_${ZFSPKGVER}_amd64.deb\
zfs-initramfs
Signed-off-by: Stoiko Ivanov
---
Makefile | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index a3d730d5..6c1f642c 100644
--- a/Makefile
+++ b/Makefile
@@ -8,15 +8,20 @@ ZFSSRC=upstream
ZFS_DEB1= libnvpair3linux_${ZFSPKGVER}_amd64.deb
ZFS_DE
automatically generated -dbgsym packages has become the default
(see dh_strip(1) and [0]).
While we have no direct need to migrate, it helps in avoiding
debhelper bug 939164 (see [1]), when migrating to debhelper-compat 12.
(alternative option would be to depend on debhelper from backports, or
to s
in postinst. During the transition from ZFS 0.8.x to 2.0.0 zvol_wait,
which is called by zfs-volume-wait.service was changed to also output
the redacted_snap property of the datasets.
This property does not exist if the kernelmodule is still 0.8.x,
causing an error to be printed to the journal.
Si
Signed-off-by: Stoiko Ivanov
---
debian/zfsutils-linux.lintian-overrides | 3 ---
1 file changed, 3 deletions(-)
diff --git a/debian/zfsutils-linux.lintian-overrides
b/debian/zfsutils-linux.lintian-overrides
index 8918b1e7..67254c84 100644
--- a/debian/zfsutils-linux.lintian-overrides
+++ b/deb
The symbols zfs_ract_(read|write) were added to libzpool in upstream
403703d57a3c6503cd7a6a7a9fbc2de215d4de57
and are exported, despite only having a sensible implementation in
FreeBSD.
Signed-off-by: Stoiko Ivanov
---
debian/libzpool4linux.symbols | 2 ++
1 file changed, 2 insertions(+)
diff
(cherry picked from debian-upstream [0] commits
d0ba1164dcf8e566a5134d8fadef4c84d5afdf6c and
3ddeaa236e758e3dee7a9eedac66a001a11953c3)
[0] https://salsa.debian.org/zfsonlinux-team/zfs/
Signed-off-by: Stoiko Ivanov
---
debian/zfs-zed.postrm | 17 +
1 file changed, 17 insertions(+)
Signed-off-by: Stoiko Ivanov
---
debian/compat | 1 -
debian/control | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
delete mode 100644 debian/compat
diff --git a/debian/compat b/debian/compat
deleted file mode 100644
index f599e28b..
--- a/debian/compat
+++ /dev/null
@@ -1 +0,
cherry picked from debian upstream [0]
(cherry picked from commit d37e013ff5f7b811b235c62ea5c2c10828aceb7b)
Originally-by: Mo Zhou
Signed-off-by: Stoiko Ivanov
[0] https://salsa.debian.org/zfsonlinux-team/zfs/
Signed-off-by: Stoiko Ivanov
---
debian/control | 5 +
1 file changed, 5 inser
This patchset started out as what is now the last commit:
trying not to uselessly restart the zfs-services (like
zfs-volume-wait.service) upon upgrading, since it lead to quite a few
scary looking (but harmless) journal entries.
since this was already fixed in upstream debian's packaging I tried
t
On 06.05.21 10:59, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> de.po | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cg
On 24.05.21 14:58, Alexandre Derumier wrote:
> ---
> fr.po | 925 +-
> 1 file changed, 333 insertions(+), 592 deletions(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox
those two static acl paths were missing in the selector
Signed-off-by: Dominik Csapak
---
www/manager6/data/PermPathStore.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/data/PermPathStore.js
b/www/manager6/data/PermPathStore.js
index 051da3cf..1dc276b6 100644
--- a/www/ma
save the realm list on login, and if that list exists, show that
in the acl selector, else load the list and save it
Signed-off-by: Dominik Csapak
---
not really sure about it, also maybe we should simply load it everytime?
www/manager6/data/PermPathStore.js | 32 ++
to accomodate the longer acl paths better
Signed-off-by: Dominik Csapak
---
www/manager6/dc/ACLView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/dc/ACLView.js b/www/manager6/dc/ACLView.js
index 51c247d6..65abd8cd 100644
--- a/www/manager6/dc/ACLView.js
+++ b/www/manager6
tries to load the list of defined groups and adds them to the store
Signed-off-by: Dominik Csapak
---
also not really sure about it either, if we save the realmlist, maybe
the grouplist too? or as i already wrote, load the realmlist everytime
too?
www/manager6/data/PermPathStore.js | 20 +++
On 17.05.21 12:12, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak
> ---
> .../0001-add-PVE-specific-JS-code.patch | 27 ---
> ...002-add-custom-fbresize-event-on-rfb.patch | 2 +-
> ...nge-scaling-when-toggling-fullscreen.patch | 2 +-
> ...rectory-for-fetching-imag
On 12.05.21 14:32, Fabian Ebner wrote:
> There's also support for ending a task with warnings now, so the logic "status
> not 'OK' means error" does not work anymore.
>
> Signed-off-by: Fabian Ebner
> ---
> src/PVE/Tools.pm | 8
> 1 file changed, 8 insertions(+)
>
>
applied, thanks!
On 10.05.21 14:18, Fabian Ebner wrote:
> common:
>
> Fabian Ebner (4):
> network: is_ip_in_cidr: correctly handle the CIDR being a singleton
> range
> network: is_ip_in_cidr: avoid warning when versions don't match
> network: add canonical_ip function
> network: add unique_ips function
On 6/17/21 14:33, Fabian Grünbichler wrote:
On June 17, 2021 2:28 pm, Dominik Csapak wrote:
my $bootproto = '';
@@ -213,7 +214,7 @@ sub setup_network {
if ($d->{ip6} eq 'auto') {
$data .= "IPV6_AUTOCONF=yes\n";
}
- if ($d->{ip6} eq '
On 09.06.21 12:22, Lorenz Stechauner wrote:
> after an error while copying the file to its destination the local
> path of the destination was unlinked in every case, even when on the
> destination was copied to via scp.
>
> Signed-off-by: Lorenz Stechauner
> ---
> PVE/API2/Storage/Status.pm | 5
On 01.06.21 08:43, Fabian Ebner wrote:
> to avoid potential problems with stringified numbers in Javascript and
> elsewehere.
>
> The vmid was not always an integer as the return schema expects, namely
> when there was an opt_vmid argument, because the 'ne' comparision coerced the
> vmid to be a s
On 01.06.21 08:43, Fabian Ebner wrote:
> In the case of a running container with cgroupv2, swap would be a string,
> causing a
> size.toFixed is not a function
> error for the format_size call in the containers's "Summary" page in the UI.
>
> The vmids from config_list() are already integers a
On June 17, 2021 2:28 pm, Dominik Csapak wrote:
> hi,
>
> did not took a look at the whole patch, but
> some things stood out, comments inline
>
> On 6/16/21 20:23, Denis Knauf wrote:
>> NetworkManager is used on RHEL8 and similar distributions like CentOS8,
>> AlmaLinux8 and RockyLinux8.
>> On R
hi,
did not took a look at the whole patch, but
some things stood out, comments inline
On 6/16/21 20:23, Denis Knauf wrote:
NetworkManager is used on RHEL8 and similar distributions like CentOS8,
AlmaLinux8 and RockyLinux8.
On RHEL7/CentOS7 it was not mandatory, but possible to use
NetworkManag
On 09.06.21 06:37, Alexandre Derumier wrote:
>
applied, thanks! squashed in a fix for the indentation (tab vs. 8 spaces).
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
cleaned up the locking situation with config files as Fabian G.
suggested in the review.
use the 'create_and_lock_config' helper in the beginning to ensure that
the target CTID is available, and that the target config is locked from
the beginning. in case any error happens during the initial check
Signed-off-by: Oguz Bektas
---
v4->v5:
* split
src/PVE/API2/LXC.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index c2312f4..4dd692d 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -1451,7 +1451,7 @@ __PACKAGE__->re
Signed-off-by: Oguz Bektas
---
v4->v5:
* no change
src/PVE/API2/LXC.pm | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index ade109b..c2312f4 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -1554,6 +1554,15 @@ __PACKAGE__->reg
add post clone hook, and fix #3443 to clear machine-id for cloned
containers
v4->v5:
* split patches for easy review/backport
* also lock when moving config to target node
* move create_and_lock_config outside the eval, this should be checked
before the other ones
Oguz Bektas (4):
setup: add
for now it calls the new clear_machine_id function.
this way when new containers are created they will have a unique
/etc/machine-id.
Signed-off-by: Oguz Bektas
---
v4->v5:
* no change
src/PVE/LXC/Setup.pm | 12
src/PVE/LXC/Setup/Base.pm | 31 +++
On June 17, 2021 10:58 am, Fabian Ebner wrote:
> Suggested-by: Thomas Lamprecht
> Signed-off-by: Fabian Ebner
> ---
> debian/postinst | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/debian/postinst b/debian/postinst
> index 963ad06..9dbb3b9 100644
> --- a/debian/p
thanks for catching (serves me right for testing with break initially
and only a single file ;))
On June 17, 2021 10:58 am, Fabian Ebner wrote:
> which makes the continue not behave as intended.
>
> Reported by shellcheck: SC2106: This [i.e. continue] only exits the subshell
> caused by the (..)
which makes the continue not behave as intended.
Reported by shellcheck: SC2106: This [i.e. continue] only exits the subshell
caused by the (..) group
Also factor out long message for readability.
Signed-off-by: Fabian Ebner
---
debian/postinst | 5 +++--
1 file changed, 3 insertions(+), 2 del
Suggested-by: Thomas Lamprecht
Signed-off-by: Fabian Ebner
---
debian/postinst | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/debian/postinst b/debian/postinst
index 963ad06..9dbb3b9 100644
--- a/debian/postinst
+++ b/debian/postinst
@@ -18,7 +18,12 @@ case "$1" in
changes to v2:
* using simple parser to parse user roles
* moved checks to an own sub
On 17.06.21 10:39, Lorenz Stechauner wrote:
the two checks make sure that:
* no user defined role 'PVEPoolUser' exists
* the user gets a hint for roles only containing Pool.Allocate and
not Pool.Audit
a v
the two checks make sure that:
* no user defined role 'PVEPoolUser' exists
* the user gets a hint for roles only containing Pool.Allocate and
not Pool.Audit
a very simple parser for user.cfg was implemented to be able to
parse the (in pve 6 invalid) Pool.Audit permission
Signed-off-by: Lorenz
some non-blocking cleanups in case you do another version:
On Fri, Jun 11, 2021 at 01:43:53PM +0200, Fabian Ebner wrote:
> which checks for bad suites and official URIs.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Changes from v5:
> * split out host_from_uri helper and also handle userinfo an
Am 16.06.21 um 15:11 schrieb Thomas Lamprecht:
On 16.06.21 09:26, Fabian Ebner wrote:
+case "$1" in
+ configure)
+if test -n "$2"; then
+
+# TODO: remove once PVE 8.0 is released
+if dpkg --compare-versions "$2" 'lt' '7.0-3'; then
+for file in /etc/pve/priv/*.cre
On 17.06.21 09:29, Stefan Reiter wrote:
> On 16/06/2021 20:27, Thomas Lamprecht wrote:
>> On 13.04.21 10:24, Fabian Ebner wrote:
>>> Reported in the community forum[0].
>>>
>>> In QEMU's hw/scsi/vmw_pvscsi.c in the SCSIBusInfo struct, the max_lun
>>> property
>>> is set to 0. This means that in ou
On 16/06/2021 20:27, Thomas Lamprecht wrote:
On 13.04.21 10:24, Fabian Ebner wrote:
Reported in the community forum[0].
In QEMU's hw/scsi/vmw_pvscsi.c in the SCSIBusInfo struct, the max_lun property
is set to 0. This means that in our stack, one cannot have multiple disks and
use 'scsihw: pvscs
57 matches
Mail list logo
