Am 18.06.21 um 08:56 schrieb Wolfgang Bumiller:
On 06/18/2021 8:53 AM Fabian Ebner <f.eb...@proxmox.com> wrote:
Am 18.06.21 um 08:44 schrieb Wolfgang Bumiller:
On 06/18/2021 8:42 AM Fabian Ebner <f.eb...@proxmox.com> wrote:
+ Some((last, rest)) => match rest.split_last() {
+ Some((second_to_last, _rest)) => {
+ (*last == "org" && *second_to_last == "debian")
+ || (*last == "com" && *second_to_last == "proxmox")
+ }
+ None => false,
+ },
+ None => false,
+ };
+
+ for uri in self.uris.iter() {
+ if let Some(host) = host_from_uri(uri) {
+ let domains = host.split('.').collect();
^ But instead of building a vector here, why not just do:
if host == "proxmox.com" || host.ends_with(".proxmox.com")
|| host == "debian.org" || host.ends_with(".debian.org")
{
...
}
Misses FQDNs?
Such as?
http://security.debian.org.
Why is that not caught by `.ends_with(".debian.org")`?
Because of the final dot. But it is likely very uncommon and simply
splitting by '.' leads to false results with e.g.
http://security..debian.org too, so it might not be worth worrying about...
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
