Re: [Puppet-dev] metadata.json ">= 1.x" version requirements

2017-05-30 Thread Dominic Cleal
something that I'd recommend. Thanks for the reply. I'll revisit the test in the linter then, but may add a warning back - both for the incompatibility with Puppet 4 and for the confusing syntax. -- Dominic Cleal domi...@cleal.org -- You received this message because you are sub

[Puppet-dev] metadata.json ">= 1.x" version requirements

2017-05-26 Thread Dominic Cleal
antic_puppet should disallow them, or c) if semantic_puppet may allow them but metadata-json-lint should disallow them? Cheers, -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from

Re: [Puppet-dev] Re: Nightly packages (nightlies vs. puppet5-nightly)

2017-05-15 Thread Dominic Cleal
On 12/05/17 19:14, Melissa Stone wrote: > On Fri, May 12, 2017 at 10:40 AM Michael Smith <mailto:michael.sm...@puppet.com>> wrote: > > On Friday, May 12, 2017 at 1:46:40 AM UTC-7, Dominic Cleal wrote: > > Hello, > > The second half of >

[Puppet-dev] Nightly packages (nightlies vs. puppet5-nightly)

2017-05-12 Thread Dominic Cleal
moment, or will it no longer be updated? Cheers, -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-de

Re: [Puppet-dev] Puppet 4.10.x version comparisons

2017-03-14 Thread Dominic Cleal
On 14/03/17 10:05, Dominic Cleal wrote: > It looks like there will be a new Puppet 4.10.x release series soon, > which I think is going to cause a few issues in tests for modules and in > supporting projects, due to reaching minor version 10. > [..] > I've opened a PR

[Puppet-dev] Puppet 4.10.x version comparisons

2017-03-14 Thread Dominic Cleal
ation_spec.rb#L3 I'll continue trying to open PRs where I can find issues, but would appreciate help to check modules to ensure it works on release. Cheers, -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "Puppet De

Re: [Puppet-dev] Display the contents of a yaml file

2015-09-04 Thread Dominic Cleal
an way to retrieve the rendered YAML in the regular authenticated API, only the above one intended specifically for the ENC script. The URL Eric suggested will give you lots of useful info about the host, but in JSON rather than Puppet's YAML ENC format. -- Dominic Cleal Red Hat Engineerin

Re: [Puppet-dev] Re: SELinux and Puppet Subcommands

2015-03-27 Thread Dominic Cleal
d, > they won't "stick" - there's no way to always apply these settings > without modifying init scripts or /etc/profile or the like. > > This leads into... > > > Environment variables vs configuration via a file > > Dominic Cleal indicated th

Re: [Puppet-dev] Thoughts on Module Namespace Conflicts

2015-02-12 Thread Dominic Cleal
providers is the maintained version, but it would be great to be able to mark this as such in the Forge, or even redirect to another module. -- Dominic Cleal Red Hat Engineering -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To

Re: [Puppet-dev] Thoughts on Module Namespace Conflicts

2015-02-11 Thread Dominic Cleal
eforeman_apache -- Installs To --> apache > > You get my point... I do, but just for the avoidance of doubt, and because I still get asked about it regularly, theforeman/apache is dead and has been replaced by puppetlabs/apache for a couple of releases now. Long live pl-apache :-) -- Dom

Re: [Puppet-dev] Anyone scripting around certificate authority? (puppet-dev version)

2015-01-14 Thread Dominic Cleal
y of the Puppet APIs? If so, > STOP DOING THAT! Just kidding, sorta. But it would be very interesting > to know whether you're using things like the `serial` or `inventory.txt` > files in your scripts or workflows. By default, Foreman re-uses Puppet certificates and keys, so the locati

Re: [Puppet-dev] Exiting; failed to retrieve certificate and waitforcert is disabled

2014-11-10 Thread Dominic Cleal
.14 on Ruby 2.1.0 (if I'm reading your stack trace correctly) is going to cause you no end of pain, unless you try to backport a lot of fixes. http://docs.puppetlabs.com/guides/platforms.html#ruby-versions 2.7 didn't even fully run on 1.9. -- Dominic Cleal Red Hat Engineering -- You rece

[Puppet-dev] #puppethack and Contributor Summit

2014-10-15 Thread Dominic Cleal
In case you missed it, there's an IRC-based hack day planned in December, and a contributor summit again in Ghent next year: http://puppetlabs.com/blog/puppethack-online-community-hack-day -- Dominic Cleal Red Hat Engineering -- You received this message because you are subscribed t

Re: [Puppet-dev] Running Beaker tests in a Public CI

2014-10-02 Thread Dominic Cleal
Linux is functional on the host running the container.) https://bugzilla.redhat.com/show_bug.cgi?id=1096123 has some interesting background, as EL6's libselinux didn't understand what the read-only /sys/fs/selinux mount meant. -- Dominic Cleal Red Hat Engineering -- You received this

Re: [Puppet-dev] Announce: Puppet Server 0.2.0

2014-09-26 Thread Dominic Cleal
I guess it might affect others using HTTPS from the master. -- Dominic Cleal Red Hat Engineering -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email

Re: [Puppet-dev] Announce: nightly repos available

2014-09-04 Thread Dominic Cleal
On 04/09/14 01:50, Matthaus Owens wrote: > Dominic, > Facter master just passed acceptance with trusty, so it is now > available in the nightly repos. Great, thanks. Looks like it got further, but failed on an obscure issue between the Foreman API and one of our types/providers. --

Re: [Puppet-dev] Announce: nightly repos available

2014-09-03 Thread Dominic Cleal
On 03/09/14 01:00, Kylo Ginsberg wrote: > On Fri, Aug 29, 2014 at 1:55 AM, Dominic Cleal <mailto:dclea...@redhat.com>> wrote: > > On 26/08/14 18:23, Eric Sorenson wrote: > > The repos are live now and you can try them out by following these > directi

Re: [Puppet-dev] Announce: nightly repos available

2014-08-29 Thread Dominic Cleal
On 29/08/14 09:55, Dominic Cleal wrote: > On 26/08/14 18:23, Eric Sorenson wrote: >> The repos are live now and you can try them out by following these >> directions: >> https://docs.puppetlabs.com/guides/puppetlabs_package_repositories.html#using-the-nightly-repos >

Re: [Puppet-dev] Announce: nightly repos available

2014-08-29 Thread Dominic Cleal
ster/agent setups and Foreman integration. -- Dominic Cleal Red Hat Engineering -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...

Re: [Puppet-dev] SELinux and Puppet Subcommands

2014-08-29 Thread Dominic Cleal
n. > > As you suggest, if this (and the domains to transition into) are in a > separate "support" file, this would make distribution patching piece of > cake. This would require three "echo" commands in a SPEC file (turn on, > domain for puppet master, domain f

Re: [Puppet-dev] Re: Announce: nightly repos available

2014-08-28 Thread Dominic Cleal
On 28/08/14 17:17, Henrik Lindberg wrote: > On 2014-28-08 9:13, Dominic Cleal wrote: >> On 26/08/14 18:23, Eric Sorenson wrote: >>> After the Puppet 3.5.0 release problems, we had a retrospective and tried >>> to figure out some process improvements which would have

Re: [Puppet-dev] SELinux and Puppet Subcommands

2014-08-28 Thread Dominic Cleal
On 28/08/14 10:01, Dominic Cleal wrote: > 2. names of SELinux domains are most likely governed by the distribution > rather than the Puppet project, as at least in Fedora and EL, an SELinux > policy for Puppet is shipped as part of the base targeted policy and not > as part of Puppe

Re: [Puppet-dev] SELinux and Puppet Subcommands

2014-08-28 Thread Dominic Cleal
was looking to add additional wrapper scripts > around subcommands so that a puppet_exec_t could be set for these files. > There is general concern about the confusion caused by reintroducing > separate commands, and Dominic Cleal suggested making use of Ruby's > SELinux

Re: [Puppet-dev] Announce: nightly repos available

2014-08-28 Thread Dominic Cleal
ickly. I'd encourage everybody to do something similar if they have a similar test suite, it's been very valuable. -- Dominic Cleal Red Hat Engineering -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe fr

Re: [Puppet-dev] Rubygems in Puppet modules, revisited

2014-04-28 Thread Dominic Cleal
ing gems, as we have to flush the load paths or they get cached with the currently loaded set of gems. This has only just been fixed for Puppet 3.6.0: https://tickets.puppetlabs.com/browse/PUP-1879 I can't really think of a workaround for this issue either, unless you can figure out how to r

Re: [Puppet-dev]

2014-04-07 Thread Dominic Cleal
to ensure that they are enabled and the migration is done. I prefer this option, it's clean and as Spencer said, other new features work in the same way. -- Dominic Cleal Red Hat Engineering -- You received this message because you are subscribed to the Google Groups "Puppet Develope

Re: [Puppet-dev] Directory Environments

2014-02-25 Thread Dominic Cleal
On 25/02/14 15:59, Dominic Cleal wrote: > On 21/02/14 08:41, Joshua Partlow wrote: >> Hi folks, >> >> (TL;DR: in 3.5.0+ environments will change to be named directories with >> a specific structure and configurable defaults, all to be found in a >> configured '

Re: [Puppet-dev] Directory Environments

2014-02-25 Thread Dominic Cleal
d loader should treat settings that have been overridden on the command line with higher priority than the environmentpath loader, but environments in puppet.conf at a lower priority. (I suspect in practice, this could be tricky to implement.) -- Dominic Cleal Red Hat Engineering -- You received

Re: [Puppet-dev]

2013-12-16 Thread Dominic Cleal
On 16/12/13 19:54, Andy Parker wrote: > On Mon, Dec 16, 2013 at 11:51 AM, Dominic Cleal <mailto:dcl...@redhat.com>> wrote: > > On 16/12/13 19:38, Andy Parker wrote: > > We did another PR triage hangout. There were a few people who showed > > up…and our

Re: [Puppet-dev]

2013-12-16 Thread Dominic Cleal
the hangouts are more inviting. I also need to > figure out a way of making them more prominent. What should we do to get > more people showing up? A bit more warning would be good, I missed it as the last notification went out on the same day. -- Dominic Cleal Red Hat Engineering -- Yo

Re: [Puppet-dev] Referencing other resources in parameters

2013-08-23 Thread Dominic Cleal
er resource from a provider in the compiled catalog, should be late enough in the process that it's fully accessible. Thanks for your feedback Dan and Trevor. -- Dominic Cleal Red Hat Engineering -- You received this message because you are subscribed to the Google Groups "Puppet Devel

[Puppet-dev] Referencing other resources in parameters

2013-08-21 Thread Dominic Cleal
nary, non-metaparameters and could it cause any problems? I'm thinking of layered projects such as PuppetDB, if it would be able to import catalogs containing these references. Thanks, -- Dominic Cleal Red Hat Engineering -- You received this message because you are subscribed to the Goog

Re: [Puppet-dev] Stop the new-hotness cycle..

2013-08-16 Thread Dominic Cleal
pet-dev > recently, which seems to be resulting in a lot more information making > it out. I've noticed this and I really appreciate it - thank you. Even if some of us aren't engaged in the conversation, we're soaking it up. -- Dominic Cleal Red Hat Engineering -- You receive

Re: [Puppet-dev] ruby-1.9.3 in yum.puppetlabs.com

2013-07-28 Thread Dominic Cleal
this would be for every host running an agent. However I don't see that this has much to do with the original bug, which was more luck than design that it was fixed in 1.9.3... it's not worth investigating 1.9.3 support via packages just to provide a workaround for that issue! Charl

Re: [Puppet-dev] Writing Rspec Tests w/Mocha

2013-01-18 Thread Dominic Cleal
oing to get evaluated, but not again. This means if you come to stub the *system* libuser feature in the test harness, it won't change the evaluation that's already happened for the provider's feature. I think if you're going to implement this as a provider feature, you'll h

Re: [Puppet-dev] Outcomes from weekly planning

2012-12-20 Thread Dominic Cleal
On 19/12/12 19:04, Andy Parker wrote: > On Wed, Dec 19, 2012 at 3:16 AM, Dominic Cleal <mailto:dcl...@redhat.com>> wrote: > > On 19/12/12 01:36, Andy Parker wrote: > > In addition we've been pulling in pull requests that have been related > > to th

Re: [Puppet-dev] Outcomes from weekly planning

2012-12-19 Thread Dominic Cleal
caused by something different. I'd appreciate it if this PR could be looked at soon, so it's fixed in case there's another 2.7.x release: https://projects.puppetlabs.com/issues/18187 https://github.com/puppetlabs/puppet/pull/1339 -- Dominic Cleal Red Hat Engineering -- You rece

Re: [Puppet-dev] file concat library

2012-12-18 Thread Dominic Cleal
ive concat module which works pretty well: https://github.com/onyxpoint/pupmod-concat As you say, there are good benefits to this over an exec based implementation, such as --noop support. Unfortunately there were some issues stopping it being merged in core: http://projects.puppetlabs.com/issues/768

Re: [Puppet-dev] Any advice on "Puppet::Util::Log requires a message" failure

2012-12-11 Thread Dominic Cleal
ing inside the run. > in `new'/usr/lib/ruby/site_ruby/1.8/puppet/util/log.rb:81 > in `create'/usr/lib/ruby/site_ruby/1.8/puppet/util/logging.rb:7 > in `send_log'/usr/lib/ruby/site_ruby/1.8/puppet/transaction/event.rb:38 > in > `send_log'/usr/lib/ruby/site_ruby/1.8/pupp

Re: [Puppet-dev] master first?

2012-08-01 Thread Dominic Cleal
t might make development easier and more transparent to people wondering why changes are in one version and not another. Cheers, -- Dominic Cleal Red Hat Consulting m: +44 (0)7817 878113 -- You received this message because you are subscribed to the Google Groups "Puppet Developers&quo

Re: [Puppet-dev] Accessing Puppet::Property::List elements

2012-07-28 Thread Dominic Cleal
On 18/07/12 20:58, Stefan Schulte wrote: > On Mon, Jul 16, 2012 at 11:19:52AM +0100, Dominic Cleal wrote: >> Hello, >> >> I'm currently implementing a new provider for the mounttab type (the one >> distributed in the puppetlabs/mount_providers module) in t

[Puppet-dev] Accessing Puppet::Property::List elements

2012-07-16 Thread Dominic Cleal
//forge.puppetlabs.com/domcleal/augeasproviders -- Dominic Cleal Red Hat Consulting m: +44 (0)7817 878113 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscri

Re: [Puppet-dev] why I don't feel that ENCs are very functional right now (performance)

2012-06-19 Thread Dominic Cleal
On 18/06/12 18:22, Jo Rhett wrote: > On Jun 17, 2012, at 4:22 AM, Dominic Cleal wrote: >> Yes, prior to 3.0 it is a lot slower. The reason's simple, it loads and >> parses every file unless you explicitly tell it (via lens/incl params) >> which file you intend

Re: [Puppet-dev] why I don't feel that ENCs are very functional right now (performance)

2012-06-17 Thread Dominic Cleal
incl params) which file you intend to edit. 3.0 has an optimisation (#7285) so if you use the context param then it uses this to load only the subset of files matching the context given. This should significantly speed up resources where context is given (usually the case) by eliminating a lot of I/O.

[Puppet-dev] Re: Improving Augeas' idempotence in Puppet

2012-04-06 Thread Dominic Cleal
the lens definition). I saw a comment this week from David on R.I.Pienaar's puppet-concat blog entry which shows an idea to write the tree out in the resource itself and then have the provider create it. I think this would be even easier now with hash support in the Puppet DSL. http://ww

Re: [Puppet-dev] Differing behavior between Ruby DSL & Puppet language. Bug?

2011-12-03 Thread Dominic Cleal
anguage. I think we got into a muddle looking into a spec failure - I don't think any difference exists. Thanks for the catalog comparison tip Nick, I tried this out and indeed couldn't see any difference in the representation. Cheers, -- Dominic Cleal Red Hat Consulting m: +44 (0)78

Re: [Puppet-dev] ANNOUNCE: Facter 1.6.1rc2

2011-09-13 Thread Dominic Cleal
in 1.6.1? I think it's a bad regression from 1.5.x to 1.6.0: (#8461) "Stack level too deep" when unknown fact is requested Cheers, -- Dominic Cleal Red Hat Consulting m: +44 (0)7817 878113 -- You received this message because you are subscribed to the Google Groups "

Re: [Puppet-dev] Pulling the trigger on using GitHub Pull Requests for patch submission (and internal development).

2011-08-03 Thread Dominic Cleal
ll still be accepting changes via `rake mail_patches`, > git-format-patch(1) & git-send-email(1), and attaching diffs to > Redmine tickets, though these are not the preferred method. Is it best for outstanding patches to be resubmitted via pull requests to ensure they're tracked and

Re: [Puppet-dev] [PATCH/facter 3/3] (#2157) Adding support for non-ruby files

2011-07-14 Thread Dominic Cleal
packaging for different distributions easier. At the very least, OpenCSW is going to change these paths and this will require patching. In Puppet, it's trivial to change all of the different cache and configuration directories (vardir etc.) to other locations. Cheers, -- Dominic Cleal Red

[Puppet-dev] [PATCH/facter 1/1] (#7854) Add Augeas library version fact

2011-06-26 Thread Dominic Cleal
Add fact to return the Augeas version from /augeas/version. Requires the ruby-augeas binding. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/7854 lib/facter/augeasversion.rb | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) create mode

[Puppet-dev] [PATCH/puppet 1/1] (#8011) Support temp repo URLs in pkgutil provider

2011-06-23 Thread Dominic Cleal
One or more URLs to pkgutil repositories can be supplied in the "source" attribute and are given to pkgutil via the -t option as temporary repos. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/8011 lib/puppet/provider/package/pkgutil.rb | 45 ++---

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #7307 - Added serial number fact to Solaris

2011-06-14 Thread Dominic Cleal
Sorry for the delayed response, bit of a backlog. On 19/05/11 18:46, Jacob Helwig wrote: > On Thu, 19 May 2011 09:44:47 +0100, Dominic Cleal wrote: >> >> On 19/05/11 06:41, James Turnbull wrote: >>> +Facter.add('serialnumber') do >>> +

Re: [Puppet-dev] Package type: enable/disable repo vs options (#2247 vs #4113)

2011-06-02 Thread Dominic Cleal
ailed suggestion I can outline in another post.. [1] http://projects.puppetlabs.com/issues/2247#note-36 -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this gr

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #7307 - Added serial number fact to Solaris

2011-05-19 Thread Dominic Cleal
with the OS and is an extra support tool, but I believe it's the only standard way of doing the job. You can read it out with /usr/sbin/eeprom, having written it to the nvram in the past with sneep. I think having sneep seems a sensible dependency to me though. +1 from me. -- Dominic C

Re: [Puppet-dev] Re: (#2728) Utilise Augeas SAVE_NEWFILE mode to provide a diff of any changes that augeas will make.

2011-05-18 Thread Dominic Cleal
tions on this? Try this patch instead: https://gist.github.com/979650 The /augeas/events/saved match is stubbed at the whole group of tests level so you don't need to mess with all of those tests. It's still a bit invasive, but the best you can really do with the file like it is I think

[Puppet-dev] [PATCH/puppet 1/1] (#7285) Use Augeas NO_LOAD/incl to optimise loading based on context

2011-04-29 Thread Dominic Cleal
reads and parses relevant files, instead of every known file for each resource. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/7285 lib/puppet/provider/augeas/augeas.rb | 55 +- spec/unit/provider/augeas/augeas_spec.rb | 49

Re: [Puppet-dev] Re: (#2728) Utilise Augeas SAVE_NEWFILE mode to provide a diff of any changes that augeas will make.

2011-04-28 Thread Dominic Cleal
n checking noop, it should check the resource noop? method which checks the resource's noop attribute and the global setting. I'd suggest this: if not return_value or resource.noop? close_augeas end Otherwise works and looks great - thanks for patching it! Cheers, -- Dominic

Re: [Puppet-dev] [PATCH/puppet 1/1] (#6845) Mount writes incorrect vfstab entries

2011-04-02 Thread Dominic Cleal
"Solaris" > @fields = [:device, :blockdevice, :name, :fstype, :pass, :atboot, > :options] >else -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" grou

Re: [Puppet-dev] Run specs on Solaris with 2.6.7

2011-04-02 Thread Dominic Cleal
ssue to puppet-dev. I've applied the patch from your -dev e-mail to the plain 2.6.7 checkout and the spec now passes: Finished in 0.09687 seconds 20 examples, 0 failures, 1 pending -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subs

Re: [Puppet-dev] [PATCH/puppet 23/23] (#4258) Bug fix: populating instances for aliases

2011-03-22 Thread Dominic Cleal
On 21/03/11 11:50, Dominic Cleal wrote: > On 21/03/11 09:08, Dominic Cleal wrote: >> On 21/03/11 03:54, Juerg Walz wrote: >>> diff --git a/lib/puppet/provider/package/pkgutil.rb >>> b/lib/puppet/provider/package/pkgutil.rb >>> index 350cacc..97625f2 100755 &

Re: [Puppet-dev] [PATCH/facter 1/2] (#2714) Added timeout to prtdiag resulution

2011-03-22 Thread Dominic Cleal
g util/manufacturer.rb too with this fix. Cheers, -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from

Re: [Puppet-dev] [PATCH/puppet 23/23] (#4258) Bug fix: populating instances for aliases

2011-03-21 Thread Dominic Cleal
On 21/03/11 09:08, Dominic Cleal wrote: > Hi Juerg, > > On 21/03/11 03:54, Juerg Walz wrote: >> >> Signed-off-by: Juerg Walz >> --- >> Local-branch: tickets/master/4258-dev >> lib/puppet/provider/package/pkgutil.rb |2 +- >> 1 files changed, 1 i

Re: [Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-21 Thread Dominic Cleal
gt; when executing the changes, but it's beginning to look quite complex (in > comparison) and ugly. If you can do the rename in the execute_changes from the .augnew generated in the need_to_run (within Daniel's bounds of not making it horrible!), I think you'd be making it more effici

Re: [Puppet-dev] [PATCH/puppet 23/23] (#4258) Bug fix: populating instances for aliases

2011-03-21 Thread Dominic Cleal
ll package name (CSWsvn) when an alias was present (subversion). I'll go back and test both cases at some point and perhaps we can create a test to show the issue. Cheers, -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subs

[Puppet-dev] [PATCH/puppet 2/2] (#4258) Use pkgutil -a to reliably determine package common names/aliases

2011-03-18 Thread Dominic Cleal
til_spec test to show various edge cases. Signed-off-by: Dominic Cleal --- lib/puppet/provider/package/pkgutil.rb | 86 --- spec/unit/provider/package/pkgutil_spec.rb | 60 +-- 2 files changed, 117 insertions(+), 29 deletions(-) diff --git a/lib/p

[Puppet-dev] [PATCH/puppet 1/2] (#4258) Update pkgutil spec for recent impl changes

2011-03-18 Thread Dominic Cleal
Fix test output of pkgutil for commands using --single Fix expected upgrade command to match impl Signed-off-by: Dominic Cleal --- spec/unit/provider/package/pkgutil_spec.rb | 22 +- 1 files changed, 9 insertions(+), 13 deletions(-) diff --git a/spec/unit/provider/package

Re: [Puppet-dev] Re: [PATCH/puppet 19/19] (#4258) pkgutil provider: better handling of short package names

2011-03-18 Thread Dominic Cleal
On 15/03/11 13:24, Dominic Cleal wrote: > On 10/03/11 08:03, Juerg Walz wrote: >> Thanks for the feedback, Dominic. >> I've never actually ran it with debugging turned on (again, I'm fairly >> new to Puppet, and Ruby). I need to read up on the prefetching and >

Re: [Puppet-dev] Re: [PATCH/puppet 19/19] (#4258) pkgutil provider: better handling of short package names

2011-03-15 Thread Dominic Cleal
ies for short names. I think this is pretty much unavoidable unless pkgutil can output both long names and short names. -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To po

Re: [Puppet-dev] [PATCH/puppet 19/19] (#4258) pkgutil provider: better handling of short package names

2011-03-09 Thread Dominic Cleal
t::Type::Package::ProviderPkgutil: Executing '/opt/csw/bin/pkgutil -c --single CSWgawk' I've tried setting :alias instead with the short name, but this doesn't seem to work for prefetched resources. Should we be returning two different resources while prefetching? -- Domini

[Puppet-dev] [PATCH/puppet 4/4] (#6494) Add setm command to Augeas provider

2011-02-25 Thread Dominic Cleal
The Augeas setm command can set the value of multiple nodes in a single operation. Takes a base path, then a subnode path expression (relative to the base) and then the value itself. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/6494 lib/puppet/provider/augeas/augeas.rb

[Puppet-dev] [PATCH/puppet 2/4] (#6494) Add defnode command to Augeas provider

2011-02-25 Thread Dominic Cleal
Uses Augeas' defnode command which creates a variable pointing to a node, creating it with 'set' if it doesn't already exist. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/6494 lib/puppet/provider/augeas/augeas.rb |5 + spec/unit/provider/augeas/a

[Puppet-dev] [PATCH/puppet 1/4] (#6494) Add defvar command to Augeas provider

2011-02-25 Thread Dominic Cleal
Uses Augeas' native defvar command to define variables for certain expressions that can then be referenced later with $variable. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/6494 lib/puppet/provider/augeas/augeas.rb |5 + spec/unit/provider/augeas/augeas_sp

[Puppet-dev] [PATCH/puppet 3/4] (#6494) Add mv command to Augeas provider

2011-02-25 Thread Dominic Cleal
Moves the first node to the position of the second, deleting it and its children if it already exists. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/6494 lib/puppet/provider/augeas/augeas.rb |6 ++ spec/unit/provider/augeas/augeas_spec.rb | 10 ++ 2 files

Re: [Puppet-dev] [PATCH/puppet 2/2] (#6324) Add spec for SMF service provider

2011-02-19 Thread Dominic Cleal
as fairly brittle trying to stub the whole thing. While changing the test I found an error message for importing manifests was calling a non-existent method, so that's fixed too and is tested. Commits are here: https://github.com/domcleal/puppet/tree/tickets/master/6324 -- Dominic Clea

[Puppet-dev] [PATCH/puppet 1/2] (#6324) Always fall back to svcadm enable except for the maintenance state

2011-02-18 Thread Dominic Cleal
If state is running, using svcadm enable is harmless and prevents errors with execute(). Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/6324 lib/puppet/provider/service/smf.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/puppet/provider/service

[Puppet-dev] [PATCH/puppet 2/2] (#6324) Add spec for SMF service provider

2011-02-18 Thread Dominic Cleal
Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/6324 spec/unit/provider/service/smf_spec.rb | 133 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100755 spec/unit/provider/service/smf_spec.rb diff --git a/spec/unit/provider

Re: [Puppet-dev] [PATCH/puppet 1/1] (#6324) Always fall back to svcadm enable except for the maintenance state

2011-02-18 Thread Dominic Cleal
On 15/02/11 21:21, Luke Kanies wrote: > Good catch, and definitely a good idea. > > I don't suppose you feel like creating a set of SMF tests for this? :) I've given it a go, but getting the rspec to work was a steep learning curve! I'll resend the patches. -- Dominic

[Puppet-dev] [PATCH/puppet 1/1] (#6324) Always fall back to svcadm enable except for the maintenance state

2011-02-15 Thread Dominic Cleal
If state is running, using svcadm enable is harmless and prevents errors with execute(). Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/6324 lib/puppet/provider/service/smf.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/puppet/provider/service

[Puppet-dev] [PATCH/facter 1/1] Fixed #5950 - Solaris ipaddress incorrect after bonding failure

2011-01-20 Thread Dominic Cleal
Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/5950 lib/facter/ipaddress.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/facter/ipaddress.rb b/lib/facter/ipaddress.rb index a08f26b..c053251 100644 --- a/lib/facter/ipaddress.rb +++ b/lib/facter

Re: [Puppet-dev] New Type for managing /etc/project on Solaris

2010-12-08 Thread Dominic Cleal
nse of not being able to specify attributes of a built-in project as individual resources. -- Dominic Cleal Red Hat Consulting m: +44 (0)7818 512168 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email

[Puppet-dev] [PATCH/facter 1/2] (#1423) Refactoring OpenBSD vmstat call to utility method

2010-12-03 Thread Dominic Cleal
Moved vmstat exec to Facter::Memory::Util so it can used to retrieve free memory in the same way on Solaris. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/1423 lib/facter/memory.rb |8 +--- lib/facter/util/memory.rb | 10 ++ 2 files changed, 11 insertions

[Puppet-dev] [PATCH/facter 2/2] (#1423) Memory facts for Solaris

2010-12-03 Thread Dominic Cleal
Add total memory from prtconf output, free from vmstat plus swap free and total from swap -l listing. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/1423 lib/facter/memory.rb | 43 +++ 1 files changed, 43 insertions(+), 0 deletions

Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-03 Thread Dominic Cleal
On 01/12/10 13:10, Paul Nasrat wrote: > On 1 December 2010 10:49, Dominic Cleal wrote: >> On 01/12/10 10:32, Dominic Cleal wrote: >>> Memory and swap values are now given in standard units via additional facts >>> (e.g. memorysize_mb) as well as the most appropriate u

Re: [Puppet-dev] [PATCH/facter 1/1] (#1423) Memory facts for Solaris

2010-12-03 Thread Dominic Cleal
On 02/12/10 23:27, Paul Berry wrote: > On Tue, Nov 30, 2010 at 4:27 AM, Dominic Cleal <mailto:dcl...@redhat.com>> wrote: > > Add total memory from prtconf output, free from vmstat plus swap > free and > total from swap -l listing. > >

Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-01 Thread Dominic Cleal
On 01/12/10 10:32, Dominic Cleal wrote: > Memory and swap values are now given in standard units via additional facts > (e.g. memorysize_mb) as well as the most appropriate unit as before. Please note that this conflicts with the patch I submitted yesterday for #1423 (Solaris memory facts),

[Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-01 Thread Dominic Cleal
Memory and swap values are now given in standard units via additional facts (e.g. memorysize_mb) as well as the most appropriate unit as before. Standard units provided are B and MB. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/2066 lib/facter/memory.rb | 70

[Puppet-dev] [PATCH/facter 1/1] (#1423) Memory facts for Solaris

2010-11-30 Thread Dominic Cleal
Add total memory from prtconf output, free from vmstat plus swap free and total from swap -l listing. Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/1423 lib/facter/memory.rb | 51 ++-- lib/facter/util/memory.rb | 12 ++ 2

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixed #4258 - Added pkgutil package provider for Solaris

2010-11-29 Thread Dominic Cleal
On 29/11/10 12:59, Dominic Cleal wrote: > Fixed #4258 - Added pkgutil package provider for Solaris This is an attempt to tie up the pkgutil patches from James, Maciej Bliziński, Rudy Gevaert and me. There has also been a thread running on puppet-users[1] which includes the pkgutil author (Pe

[Puppet-dev] [PATCH/puppet 1/1] Fixed #4258 - Added pkgutil package provider for Solaris

2010-11-29 Thread Dominic Cleal
Signed-off-by: Dominic Cleal --- Local-branch: tickets/master/4258 lib/puppet/provider/package/pkgutil.rb | 127 1 files changed, 127 insertions(+), 0 deletions(-) create mode 100755 lib/puppet/provider/package/pkgutil.rb diff --git a/lib/puppet/provider

[Puppet-dev] [PATCH/facter 1/1] (#5325) Manufacturer and product name on SPARC

2010-11-19 Thread Dominic Cleal
Use prtdiag output on Solaris/SPARC to determine manufacturer and productname as smbios is unavailable. Signed-off-by: Dominic Cleal --- Local-branch: ticket/master/5325 lib/facter/manufacturer.rb |2 ++ lib/facter/util/manufacturer.rb | 20 2 files changed, 22