On 14/03/17 10:05, Dominic Cleal wrote: > It looks like there will be a new Puppet 4.10.x release series soon, > which I think is going to cause a few issues in tests for modules and in > supporting projects, due to reaching minor version 10. > [..] > I've opened a PR against rspec-puppet > (https://github.com/rodjek/rspec-puppet/pull/479) to fix some internal > checks and its own specs, and puppetlabs_spec_helper looks to be fine.
Merged, just awaiting release. > stdlib is an example of a module that has a lot of tests with affected > version comparisons: > https://github.com/puppetlabs/puppetlabs-stdlib/blob/db8c1fbb2394d93fe3156b17c840455f1b3e2c76/spec/functions/deprecation_spec.rb#L3 https://github.com/puppetlabs/puppetlabs-stdlib/pull/737 opened to fix these tests, and David's opened https://tickets.puppetlabs.com/browse/MODULES-4528 for tracking any issues in other supported modules. Vox Pupuli modules look entirely unaffected to me. > I'll continue trying to open PRs where I can find issues, but would > appreciate help to check modules to ensure it works on release. puppet-syntax 2.4.0's been released with a fix, so I think the only supporting gems affected are it and rspec-puppet. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/0f62956c-ec02-a12e-ee5f-6e79fb2f07db%40cleal.org. For more options, visit https://groups.google.com/d/optout.
