Hi Juerg,

Thanks for the extra patches, comment below.

On 08/03/11 06:10, Juerg Walz wrote:
> Local-branch: tickets/master/4258-dev
>  lib/puppet/provider/package/pkgutil.rb |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/puppet/provider/package/pkgutil.rb 
> b/lib/puppet/provider/package/pkgutil.rb
> index 0e2056b..4a87932 100755
> --- a/lib/puppet/provider/package/pkgutil.rb
> +++ b/lib/puppet/provider/package/pkgutil.rb
> @@ -56,7 +56,7 @@ Puppet::Type.type(:package).provide :pkgutil, :parent => 
> :sun, :source => :sun d
>  
[ snip ]
> +      if justme !~ /^[A-Z]+/
> +        hash[:name].sub! /^[A-Z]+/, ''
> +      end
> +

I'm not sure if this is correct behaviour if we're prefetching resources
as Puppet now has to call out to pkgutil for every long package name
specified.  Take this for example:

    package { [ "CSWgawk", "less" ]:
        ensure => present,
    }

It now logs:

debug: Prefetching pkgutil resources for package
debug: Puppet::Type::Package::ProviderPkgutil: Executing
'/opt/csw/bin/pkgutil -c'
debug: Puppet::Type::Package::ProviderPkgutil: Executing
'/opt/csw/bin/pkgutil -c --single CSWgawk'

I've tried setting :alias instead with the short name, but this doesn't
seem to work for prefetched resources.  Should we be returning two
different resources while prefetching?

-- 
Dominic Cleal
Red Hat Consulting
m: +44 (0)7818 512168

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to 
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to