davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
REPOSITORY
rKWIN KWin
BRANCH
color-picker-effect
REVISION DETAIL
https://phabricator.kde.org/D3480
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rKWIN KWin
BRANCH
screenshot-effect-cleanup
REVISION DETAIL
https://phabricator.kde.org/D3493
EMAIL PREFERENCES
https://phabricator.kde.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN2cc55e40779e: [effects] Add a colorpicker effect
(authored by graesslin).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3480?vs=8490&id=8497
REVISION DETAIL
https
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINb42eb9a31061: [effects] Cleanup screenshot effect
(authored by graesslin).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3493?vs=8495&id=8496
REVISION DETAIL
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rKDEPLASMAADDONS1bca39d22941: [applets] Support KWin/Wayland
in ColorPicker (authored by graesslin).
REPOSITORY
rKDEPLASMAADDONS Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D348
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINadbd9fc54aa1: Initialise all variables for WindowVertex.
(authored by davidedmundson).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3453?vs=8395&id=8499
REVISION D
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINaae24bb07d60: Don't register a new service for
screenshots (authored by davidedmundson).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3357?vs=8133&id=8500
REVISION
davidedmundson updated this revision to Diff 8501.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Add a scale method to the backends and proxy this to wl_output
Also add a --scale argument for testing
REPOSITORY
rKWIN KWin
CHANGES SI
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3494
AFFECTED FILES
scene_qpainter.c
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3495
AFFECTED FILES
plugins/platform
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3497
AFFECTED FILES
plugins/platform
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
In theory we shouldn't need to scale input, however when in windowed mode
we need to conve
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
TEST PLAN
For the first time, actually plugged in my high DPI laptop.
Tested both 1x and 2x windows on 2 re
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Cursors are drawn low level, so need to go from global compositor space to
device space
(
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3500
AFFECTED FILES
plugins/platform
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3501
AFFECTED FILES
abstract_egl_bac
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
WindowVertex contains the x position and also the relative texture x position
Our textu
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
TEST PLAN
Opened a module in system settings that uses QtQuick, confirmed it's the
right size
REPOSITORY
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
We need to set the viewport so that we scale from device pixels to global
compositor space.
davidedmundson updated this revision to Diff 8514.
davidedmundson added a comment.
Updated as per request with app name
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3425?vs=8328&id=8514
BRANCH
master
REVISION DETAIL
https://phab
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
There are two types of constraints supported:
1. Pointer confin
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE9314abc1c842: Expose rowCount as data role in
TaskGroupingProxyModel. (authored by hein).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP47ae1a50e0bd: Publish delegate geometry when
ChildCount increases. (authored by hein).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3483
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/464/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 25 Nov 2016 13:40:39 +
Build duration: 2 min 34 sec
CHANGE SET
Revision 47ae1a50e0bdf5359452ba74876aba6
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/465/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 25 Nov 2016 13:48:08 +
Build duration: 5 min 40 sec
CHANGE SET
No changes
JUNIT RESULTS
Name
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/465/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 25 Nov 2016 13:48:08 +
Build duration: 5 min 40 sec
CHANGE SET
No changes
JUNIT RESULTS
Name
graesslin added inline comments.
INLINE COMMENTS
> scene_qpainter.cpp:311-313
> +const QRect target = QRect(toplevel->clientPos(),
> toplevel->clientSize());
> +const QRect src = QRect(toplevel->clientPos() +
> toplevel->clientContentPos(), pixmap->image().size());
> +painter->drawI
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3495
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmunds
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3497
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmunds
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> x11windowed_backend.cpp:483-484
> +for (auto it = m_windows.constBegin(); it != m_windows.constEnd(); ++it)
>
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3498
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmunds
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> drm_output.cpp:93-94
> {
> const QPoint p = globalPos - m_globalPos;
> -drmModeMoveCursor(m_backend->fd(
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> egl_x11_backend.cpp:110-111
> +
> +qreal scale = screens()->scale(screenId);
> +glViewport(-v.x(), v.heigh
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision now requires changes to proceed.
Same as for the X11 backend, you cannot just change the viewport
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in drm_output.cpp:93-94
> that just cannot work in a multi screen setup. The global pos is in combined
> coordinates and you apply here a scale for a single screen.
Yes it can. And does.
The combined co-ordinates are all a
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision now requires changes to proceed.
I'm extremely scared of changing the WindowQuad. This is opening pandora's
box. We have potentially any effect breaking here.
What
luebking added a comment.
On a general note: this terribly looks like doubling all (or a lot of) the
core logics reg. tabs - which we had in initial KDE 4 tabbing and which made
tabbing *incredibly* buggy.
I'd suggest to forward the cores tab logics and not keep local states,
counters etc.
graesslin added inline comments.
INLINE COMMENTS
> abstract_egl_backend.cpp:363
> if (GLPlatform::instance()->isGLES()) {
> +
> if (s_supportsARGB32 && (image.format() == QImage::Format_ARGB32 ||
> image.format() == QImage::Format_ARGB32_Premultiplied)) {
nitpick
> abstract_egl_b
graesslin added a comment.
I cannot help it: to me it looks wrong.
INLINE COMMENTS
> drm_output.cpp:93
> {
> const QPoint p = globalPos - m_globalPos;
> +drmModeMoveCursor(m_backend->fd(), m_crtcId, p.x() * m_scale, p.y() *
> m_scale);
const QPoint p = (globalPos - m_globalPos) *
davidedmundson added a comment.
> What about using a textureMatrix and do the mapping in the shader?
In an earlier version I did have
Scene::renderWindow
if (node == ContentLeaf) {setScale(topLevel->scale); }
which I think is effectively what you're suggesting?
It
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
This brings some more checks from Client to ShellClient. Thus the
On Thu, Nov 24, 2016 at 3:44 PM, Martin Graesslin wrote:
> Hi Jens,
>
> I'm extremely sorry, there must have been a huge misunderstanding.
>
> Most of the gestures you came up with are not at all supported. We only get
> the following touchpad gestures reported:
>
> * multi-finger pinch/rotate ges
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rKWIN KWin
BRANCH
shell-client-fix-maximize
REVISION DETAIL
https://phabricator.kde.org/D3507
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferenc
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 25 Nov 2016 15:31:14 +
Build duration: 2 min 36 sec
CHANGE SET
Revision 04a758912b906c8d79336
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
Maximize code was not yet adjusted to support decorations. Code is a
graesslin added a dependency: D3507: Properly implement maximize of ShellClient.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3508
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel
graesslin added a dependent revision: D3508: Implement
borderlessMaximizedWindows for Wayland windows.
REPOSITORY
rKWIN KWin
BRANCH
shell-client-fix-maximize
REVISION DETAIL
https://phabricator.kde.org/D3507
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 25 Nov 2016 15:35:48 +
Build duration: 16 min
CHANGE SET
Revision 4f3510bc5550d236db47b9bb98c
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 25 Nov 2016 15:35:48 +
Build duration: 16 min
CHANGE SET
Revision 4f3510bc5550d236db47b9bb98c
graesslin added a comment.
In https://phabricator.kde.org/D3502#65291, @davidedmundson wrote:
> > What about using a textureMatrix and do the mapping in the shader?
>
> In an earlier version I did have
>
> Scene::renderWindow
> if (node == ContentLeaf) {setScale(topLevel-
graesslin added a comment.
We still have a texture matrix which is used: blur effect
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3502
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, graesslin
Cc: graess
51 matches
Mail list logo
