graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> egl_x11_backend.cpp:110-111
> +
> +    qreal scale = screens()->scale(screenId);
> +    glViewport(-v.x(), v.height() - overall.height() - v.y(), 
> overall.width() * scale, overall.height() * scale);
>  }

if you change the viewport only here it will break in many other places. That 
was the reason why e.g. blur/screenshot, etc. etc. was broken with multi screen.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3500

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

Reply via email to