Re: Review Request 128642: Fix blatant bug in code that was pushed unreviewed

2016-08-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128642/#review98262 --- Can we change this to use QSignalBlocker, returning and havin

[Differential] [Closed] D2325: Don't unconditionally emit buttonPressed on profile load

2016-08-10 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL48c3dca61d7c: Don't unconditionally emit buttonPressed on profile load (authored by broulik). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2325?vs

[Differential] [Updated, 351 lines] D1989: Introduce QQuickItem to nest kwin_wayland

2016-08-10 Thread bdhruve (Bhavisha Dhruve)
bdhruve updated this revision to Diff 5781. bdhruve added a comment. Fix keyEvent code for non-X11 platforms. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5755&id=5781 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik added a comment. So, what should we do with this? Since we now have powerdevil as a separate binary we could savely do KIdleTime::instance()->removeAllIdleTimeouts(); without jeopardizing other kded modules. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://ph

[Differential] [Updated] D1989: Introduce QQuickItem to nest kwin_wayland

2016-08-10 Thread bdhruve (Bhavisha Dhruve)
bdhruve marked 28 inline comments as done. bdhruve added a comment. Mark comments as done. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_w

[Differential] [Request, 8 lines] D2387: [System Tray] Don't reserve space for expander if it's not visible

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If all system tray icons

[Differential] [Request, 4 lines] D2388: [Plasma Calendar Integration] Filter holiday regions case-insensitively

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY PlasmaCore.SortFilterMode

[Differential] [Accepted] D2388: [Plasma Calendar Integration] Filter holiday regions case-insensitively

2016-08-10 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2388 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

2016-08-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/#review98270 --- Ship it! aww, crap, didn't see that :/ thanks for noticing

Re: Selecting a Plasma logo

2016-08-10 Thread kainz.a
as there is no new mail since 2 days how can we find a new logo? 1. poll of the existing logos 2. irc/hangout meeting with plasma vdg and the icon designers 3. git push andreas

[Differential] [Accepted] D2387: [System Tray] Don't reserve space for expander if it's not visible

2016-08-10 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2387 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Request, 3 lines] D2390: [Task Manager ToolTipDelegate] Silence warning on startup

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The MPRIS data sources are que

[Differential] [Accepted] D2390: [Task Manager ToolTipDelegate] Silence warning on startup

2016-08-10 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2390 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

Re: Review Request 128642: Fix blatant bug in code that was pushed unreviewed

2016-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128642/ --- (Updated Aug. 10, 2016, 9:37 a.m.) Status -- This change has been ma

Re: Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

2016-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128641/ --- (Updated Aug. 10, 2016, 9:37 a.m.) Status -- This change has been ma

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

2016-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/ --- (Updated Aug. 10, 2016, 9:37 a.m.) Status -- This change has been ma

[Differential] [Closed] D2387: [System Tray] Don't reserve space for expander if it's not visible

2016-08-10 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEcd19257085e8: [System Tray] Don't reserve space for expander if it's not visible (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://ph

[Differential] [Closed] D2390: [Task Manager ToolTipDelegate] Silence warning on startup

2016-08-10 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPc8799879688f: [Task Manager ToolTipDelegate] Silence warning on startup (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 69 - Failure!

2016-08-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/69/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 10 Aug 2016 09:52:23 + Build duration: 2 min 29 sec CHANGE SET Revision c8799879688febeefbf6b

[Differential] [Closed] D2388: [Plasma Calendar Integration] Filter holiday regions case-insensitively

2016-08-10 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7516a8fb9dac: [Plasma Calendar Integration] Filter holiday regions case-insensitively (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https

[Differential] [Request, 243 lines] D2391: [Libtaskmanager] Add "requestOpenUrls" to open given URLs with the associated application

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Wayland untested but compiled.

[Differential] [Request, 80 lines] D2392: [Task Manager] Allow dropping files onto tasks

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows to

[Differential] [Updated] D2392: [Task Manager] Allow dropping files onto tasks

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2392 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel, lesliezhai, ali-

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

2016-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128491/#review98278 --- Ship it! Ship It! - David Edmundson On July 21, 2016, 2

[Differential] [Updated, 1,365 lines] D2381: Share logic for passing AbstractTasksModelIface methods to source model

2016-08-10 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 5795. davidedmundson added a comment. Synced comments REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2381?vs=5768&id=5795 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2381

[Differential] [Reopened] D2325: Don't unconditionally emit buttonPressed on profile load

2016-08-10 Thread oliverhenshaw (Oliver Henshaw)
oliverhenshaw reopened this revision. oliverhenshaw added a comment. This revision is now accepted and ready to land. > I can't find any evidence about the reason this was put in there in the first place. 'git blame' [1] shows that this was added for https://bugs.kde.org/show_bug.cgi?id=

[Differential] [Commented On] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > sebas wrote in xrandrconfig.cpp:556-558 > No, this part is a bit different from the above hunk, it uses the xOutput by > default, and if that is empty, falls back to kscreen's currentModeId or the > preferredModeId. but then I would reorder it

[Differential] [Commented On] D2325: Don't unconditionally emit buttonPressed on profile load

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik added a comment. I see. Thanks for your investigation. I must say, though, that I would not expect my laptop to do anything because the lid is closed after I closed the lid. Since the bug was originally caused by broken monitor detection, which is fixed in 5.7, indeed could be r

[Differential] [Updated, 21 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Sebastian Kügler
sebas updated this revision to Diff 5796. sebas added a comment. - Merge branch 'master' into sebas/modefallback - Improve conditional REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?vs=5638&id=5796 BRANCH sebas/modefallback REVISIO

[Differential] [Updated, 21 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Sebastian Kügler
sebas updated this revision to Diff 5797. sebas added a comment. - Improve conditional REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?vs=5796&id=5797 BRANCH sebas/modefallback REVISION DETAIL https://phabricator.kde.org/D2330 AFFE

[Differential] [Updated, 21 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Sebastian Kügler
sebas updated this revision to Diff 5798. sebas added a comment. BUG:366575 REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?vs=5797&id=5798 BRANCH sebas/modefallback REVISION DETAIL https://phabricator.kde.org/D2330 AFFECTED FILES

[Differential] [Closed] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREENf53805676dc0: [xrandr backend] fall back to preferred mode, fix crash (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?

[Differential] [Accepted] D2330: [xrandr backend] fall back to preferred mode, fix crash

2016-08-10 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/modefallback REVISION DETAIL https://phabricator.kde.org/D2330 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas

Re: Selecting a Plasma logo

2016-08-10 Thread Sebastian Kügler
On Wednesday, August 10, 2016 10:37:07 AM UTC kainz.a wrote: > as there is no new mail since 2 days how can we find a new logo? > > 1. poll of the existing logos > 2. irc/hangout meeting with plasma vdg and the icon designers > 3. git push I think consensus is that we're lacking an overview, hard

[Differential] [Request, 4 lines] D2393: Don't check current active session at all

2016-08-10 Thread oliverhenshaw (Oliver Henshaw)
oliverhenshaw created this revision. oliverhenshaw added reviewers: Plasma, broulik. oliverhenshaw added a subscriber: plasma-devel. oliverhenshaw set the repository for this revision to rPOWERDEVIL Powerdevil. oliverhenshaw added a project: Plasma. REVISION SUMMARY Simply use cached value so th

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

2016-08-10 Thread oliverhenshaw (Oliver Henshaw)
oliverhenshaw added a comment. In https://phabricator.kde.org/D2033#44650, @broulik wrote: > So, what should we do with this? Since we now have powerdevil as a separate binary we could savely do > > KIdleTime::instance()->removeAllIdleTimeouts(); > > without jeopardizing other k

[Differential] [Commented On] D2393: Don't check current active session at all

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > powerdevilpolicyagent.cpp:426 > } else if (!m_sdSessionInterface.isNull()) { > bool isActive = > m_sdSessionInterface.data()->property("Active").toBool(); > You still fetch the property, no? REPOSITORY rPOWERDEVIL Powerdevil R

Re: Review Request 128598: system-xxx icons are available only monochrome

2016-08-10 Thread Thomas Pfeiffer
> On Aug. 5, 2016, 8:13 a.m., Marco Martin wrote: > > don't fully understand what you want to do: > > > > not have the system icons in the breeze theme? > > having only monochrome versions in the plasma theme? > > > > kickoff system (shutdown, logout etc) icons should be monochrome as well? > >

Re: Review Request 128598: system-xxx icons are available only monochrome

2016-08-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128598/#review98284 --- Ship it! Ship It! - Marco Martin On Aug. 5, 2016, 7:07

[Differential] [Closed] D2356: [shell] Add a dbus call to activate the "main" application launcher

2016-08-10 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE267b6a8dfb4a: [shell] Add a dbus call to activate the "main" application launcher (authored by graesslin). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https:/

Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/ --- Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Ma

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review98286 --- https://phabricator.kde.org/D2121 - David Rosca On Aug. 10

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
> On Авг. 10, 2016, 4:23 след обяд, David Rosca wrote: > > https://phabricator.kde.org/D2121 So why not ship it? - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review9

Review Request 128648: [Calendar DaysModel] Don't call layoutChanged() and emit dataChanged() with roles

2016-08-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128648/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
> On Авг. 10, 2016, 4:23 след обяд, David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? > > Sebastian Kügler wrote: > Did you read Martin's comments on the phab request? I see it make sense, because it change props on focusIn before

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Sebastian Kügler
> On Aug. 10, 2016, 1:23 p.m., David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? Did you read Martin's comments on the phab request? - Sebastian --- This is an automatically g

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Thomas Lübking
> On Aug. 10, 2016, 1:23 nachm., David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? > > Sebastian Kügler wrote: > Did you read Martin's comments on the phab request? > > Anthony Fieroni wrote: > I see it make sense, because it

[Differential] [Abandoned] D1514: [Milou] Optimize sources model

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik abandoned this revision. REPOSITORY rMILOU Milou REVISION DETAIL https://phabricator.kde.org/D1514 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 65 lines] D2395: [Milou] Optimize and cleanup sources model

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, vhanda. broulik set the repository for this revision to rMILOU Milou. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Simplify queryString once, rather than

[Differential] [Request, 2 lines] D2396: [Pager] Hide minimized windows

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It didn't show minimized windo

Re: Review Request 128648: [Calendar DaysModel] Don't call layoutChanged() and emit dataChanged() with roles

2016-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128648/#review98295 --- Ship it! - David Edmundson On Aug. 10, 2016, 1:33 p.m.,

[Differential] [Accepted] D2396: [Pager] Hide minimized windows

2016-08-10 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2396 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Updated, 359 lines] D2345: use a separate configuration per look and feel

2016-08-10 Thread mart (Marco Martin)
mart updated this revision to Diff 5812. mart added a comment. - add a reloadDefaultLayout method to reset layout REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=5760&id=5812 BRANCH mart/separateLookAndFeelLayout REVISION DET

[Differential] [Commented On] D2345: use a separate configuration per look and feel

2016-08-10 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > shellcorona.cpp:550 > + > +void ShellCorona::reloadDefaultLayout() > +{ I hate this method. tough, i need a way from the kcm to reset the current layout to the default. it's quite dangerous and exporting a dbus method that effectively destroys the c

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
> On Авг. 10, 2016, 4:23 след обяд, David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? > > Sebastian Kügler wrote: > Did you read Martin's comments on the phab request? > > Anthony Fieroni wrote: > I see it make sense, because

Plasma look and feel switching

2016-08-10 Thread Marco Martin
Hi all, as i've came pretty much on a stale mate at the development of a particular feature, I'll try to describe it as better as i can, so maybe I can get some fresh ideas. branch, mart/separateLookAndFeelLayout review https://phabricator.kde.org/D2345 the behavior is: * look and feel packages

Animate removal from Positioner?

2016-08-10 Thread Michail Vourlakos
Hello, I am creating an alternative plasmoid for tasks and I would like your wisdom around QML please.. At some point of my code I am using a Grid(Positioner) and a Repeater for the tasksModel but I can not find any way to animate the removal of an item from the tasks model. There are add,

Re: Animate removal from Positioner?

2016-08-10 Thread Kai Uwe Broulik
Hi, the thing with positioners like Grid and the like is that they're dumb, ie. the item is just gone right away and thus cannot be animated. ListView keeps the item around to animate it but is probably overkill for your usecase. It could surely be done by hand but that would make it overly com

Re: Animate removal from Positioner?

2016-08-10 Thread Marco Martin
On Wednesday 10 August 2016 21:18:43 Michail Vourlakos wrote: > Hello, > > I am creating an alternative plasmoid for tasks and I would like your > wisdom around QML please.. > > > At some point of my code I am using a Grid(Positioner) and a Repeater > for the tasksModel but I can not find any wa

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/ --- (Updated Авг. 10, 2016, 9:28 след обяд) Review request for kwin, Plasma,

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Thomas Lübking
> On Aug. 10, 2016, 1:23 nachm., David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? > > Sebastian Kügler wrote: > Did you read Martin's comments on the phab request? > > Anthony Fieroni wrote: > I see it make sense, because it

[Differential] [Accepted] D2395: [Milou] Optimize and cleanup sources model

2016-08-10 Thread vhanda (Vishesh Handa)
vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rMILOU Milou REVISION DETAIL https://phabricator.kde.org/D2395 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #pl

[Powerdevil] [Bug 366608] New: Brightness keyboard action does not repeat while key is pressed under Wayland

2016-08-10 Thread Matthias Fauconneau via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366608 Bug ID: 366608 Summary: Brightness keyboard action does not repeat while key is pressed under Wayland Product: Powerdevil Version: 5.7.3 Platform: Gentoo Packages

[Differential] [Closed] D2395: [Milou] Optimize and cleanup sources model

2016-08-10 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rMILOU7bfa1a2538fc: [Milou] Optimize and cleanup sources model (authored by broulik). REPOSITORY rMILOU Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2395?vs=5810&id=5815 REVISION DETAI

Re: Selecting a Plasma logo

2016-08-10 Thread Ivan Čukić
Hi all, I've put a few of the ideas on a panel - both on a light theme, and on a dark one. Also without any icon background, and on the blue rectangle. It also has the current KDE logo for reference. https://share.kde.org/index.php/s/b9sMKE3Nl9whJiQ I'm a bit sad to say that I don't really find

[Differential] [Request, 73 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

2016-08-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adjusts th

Re: Selecting a Plasma logo

2016-08-10 Thread kainz.a
2016-08-10 23:16 GMT+02:00 Ivan Čukić : > Hi all, > > I've put a few of the ideas on a panel - both on a light theme, and on > a dark one. Also without any icon background, and on the blue > rectangle. > > It also has the current KDE logo for reference. > > https://share.kde.org/index.php/s/b9sMKE

stylesheed folders

2016-08-10 Thread kainz.a
Hi, since a few days you can find in breeze-icons the posibility that folders follow the color scheme colors. https://kdeonlinux.wordpress.com/2016/08/08/rainbow-folders/ As visual changes for folders are very importend for the user (visible in dolphin quite often) I'd like to discuss if we shou

[Differential] [Request, 749 lines] D2399: New new SDDM theme

2016-08-10 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Implements the new SDDM theme. There's a lot of hardcoded values, but the mockup asks for it.

[Differential] [Commented On] D2399: New new SDDM theme

2016-08-10 Thread apol (Aleix Pol Gonzalez)
apol added a comment. Shouldn't we be keeping the old theme for nostalgia and such? It's a theme after all. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2399 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

2016-08-10 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366608 Martin Gräßlin changed: What|Removed |Added CC||mgraess...@kde.org --- Comment #1 from Martin

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

2016-08-10 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366608 --- Comment #2 from Martin Gräßlin --- Just checked, kwin explicitly ignores key repeat events to trigger global shortcuts -- You are receiving this mail because: You are the assignee for the bug.

Re: Selecting a Plasma logo

2016-08-10 Thread Ivan Čukić
Hi, When I said that I don't really find any of these fitting as a launcher icon, I obviously excluded the K-gear logo - was thinking about the new proposals. Though, the fact that K-gear looks better than the rest might be because we are all accustomed to that one. The same goes for the current

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

2016-08-10 Thread Matthias Fauconneau via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366608 --- Comment #3 from Matthias Fauconneau --- I think not repeating global shortcuts is the correct behaviour. Still it would make sense for PowerDevil to be notified when the shortcut is released. I am not clear on how KGlobalAccel signals actions. Maybe

[Differential] [Changed Subscribers] D2345: use a separate configuration per look and feel

2016-08-10 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:550 > I hate this method. > tough, i need a way from the kcm to reset the current layout to the default. > it's quite dangerous and exporting a dbus method that effectively destroys > the current config is evil... >