----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128648/#review98295 -----------------------------------------------------------
Ship it! - David Edmundson On Aug. 10, 2016, 1:33 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128648/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 1:33 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > LayoutChanged causes QML to destroy all delegates and re-create them. Since > the number of days doesn't change but only the numbers, we can just call > dataChanged on all roles. > > Furthermore, when agenda-related data changes, only the containsEventItems > role might have changed, so only emit a change for it. > > > Diffs > ----- > > src/declarativeimports/calendar/daysmodel.cpp 169711e > > Diff: https://git.reviewboard.kde.org/r/128648/diff/ > > > Testing > ------- > > Scrolling through the calendar still properly updates the day numbers, the > selected day and "today" marker as well as the "has event items" badge. > > Scrolling quickly through the calendar is now pretty fast and smooth but the > initial lag when opening the calendar for the first time is still there. > > > Thanks, > > Kai Uwe Broulik > >
