> On Авг. 10, 2016, 4:23 след обяд, David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? > > Sebastian Kügler wrote: > Did you read Martin's comments on the phab request? > > Anthony Fieroni wrote: > I see it make sense, because it change props on focusIn before click who > triggers the bug. This is correct patch to me. > > Thomas Lübking wrote: > The bug is the sheer existence of this function which is a ridiculous > workaround for Qt *silently* ignoring the window type flag. > > Removing it there will just lower the odds that plasmashell succeeds in > setting the correct window type ever (along lowering the odds to do the > rubbish that causes the normal type) > > The ::ensureWindowType function needs to be erased and the type set > *once* explicitly after the native window is created for the window, but > before it's mapped (ie. what Qt should actually do) > > Right now, this is just messing around with the symptoms.
Workaround or not this patch is a *must*. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review98286 ----------------------------------------------------------- On Авг. 10, 2016, 4:22 след обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128647/ > ----------------------------------------------------------- > > (Updated Авг. 10, 2016, 4:22 след обяд) > > > Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco > Martin. > > > Bugs: 350826 and 365014 > https://bugs.kde.org/show_bug.cgi?id=350826 > https://bugs.kde.org/show_bug.cgi?id=365014 > > > Repository: plasma-workspace > > > Description > ------- > > ^^ > > > Diffs > ----- > > shell/desktopview.cpp 83866dc > > Diff: https://git.reviewboard.kde.org/r/128647/diff/ > > > Testing > ------- > > 1. open 1 or more non maximized windows > 2. make left clicks periodically between window and the desktop > 3. desktop is raised over opened windows *sometimes* > > > Thanks, > > Anthony Fieroni > >
