[Differential] [Request, 63 lines] D1621: [client] Ensure PlasmaWindowManagement updates active window if it goes away

2016-05-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So far when the active PlasmaWindow got unmapped or destroyed, the PlasmaWindowManagement didn't u

[Differential] [Request, 1 line] D1623: [client] Don't delete windows from PlasmaWindowModel

2016-05-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So far when the PlasmaWindowManagement went down the PlasmaWindowModel deleted all windows. This i

Re: Review Request 127943: change translation catalogue name

2016-05-17 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127943/ --- (Updated May 17, 2016, 8:25 a.m.) Review request for Plasma, Albert Astal

Review Request 127943: change translation catalogue name

2016-05-17 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127943/ --- Review request for Plasma, Albert Astals Cid and Ivan Čukić. Repository:

Re: Review Request 127943: change translation catalogue name

2016-05-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127943/#review95523 --- wrong patch? - Albert Astals Cid On May 17, 2016, 8:25 a.m

Re: Review Request 127943: change translation catalogue name

2016-05-17 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127943/ --- (Updated May 17, 2016, 8:35 a.m.) Review request for Plasma, Albert Astal

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

2016-05-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127876/ --- (Updated May 17, 2016, 9:07 a.m.) Status -- This change has been mar

Re: Review Request 127898: use selected icon when menu items are configured to be of highlight color

2016-05-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127898/ --- (Updated May 17, 2016, 9:09 a.m.) Status -- This change has been mar

khelpcentre 5.6.4 tarball contains 5.6.3

2016-05-17 Thread René J . V . Bertin
Hi, I can hardly believe noone has already noticed this, but: the 5.6.4 release tarball for the help centre contains a directory labelled 5.6.3 . I hope it's just the directory name (and the version number in the CMake file) that have not been updated? If not, that is, if the help centre didn'

Re: khelpcentre 5.6.4 tarball contains 5.6.3

2016-05-17 Thread Bhushan Shah
On Tue, May 17, 2016 at 2:45 PM, René J.V. wrote: > I can hardly believe noone has already noticed this, but: the 5.6.4 release > tarball for the help centre contains a directory labelled 5.6.3 . I hope it's > just the directory name (and the version number in the CMake file) that have > not be

[Differential] [Accepted] D1621: [client] Ensure PlasmaWindowManagement updates active window if it goes away

2016-05-17 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH active-window-cleanup REVISION DETAIL https://phabricator.kde.org/D1621 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasm

[Differential] [Accepted] D1623: [client] Don't delete windows from PlasmaWindowModel

2016-05-17 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH dont-delete-window-from-model REVISION DETAIL https://phabricator.kde.org/D1623 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graessli

Re: khelpcentre 5.6.4 tarball contains 5.6.3

2016-05-17 Thread Jonathan Riddell
On Tue, May 17, 2016 at 11:15:59AM +0200, René J.V. Bertin wrote: > I can hardly believe noone has already noticed this, but: the 5.6.4 release > tarball for the help centre contains a directory labelled 5.6.3 . I hope it's > just the directory name (and the version number in the CMake file) that

[Differential] [Updated] D1623: [client] Don't delete windows from PlasmaWindowModel

2016-05-17 Thread Martin Gräßlin
graesslin added a dependent revision: D1624: [client] Add context pointer to connects in PlasmaWindowModel. REPOSITORY rKWAYLAND KWayland BRANCH dont-delete-window-from-model REVISION DETAIL https://phabricator.kde.org/D1623 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

[Differential] [Updated] D1624: [client] Add context pointer to connects in PlasmaWindowModel

2016-05-17 Thread Martin Gräßlin
graesslin added a dependency: D1623: [client] Don't delete windows from PlasmaWindowModel. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1624 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, hein Cc: plasma

Re: Review Request 127937: Use SAX instead of DOM for Plasma::Svg stylesheet replacement

2016-05-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127937/#review95526 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 16, 2016,

[Differential] [Closed] D1600: Check user is allowed to run krunner when forwarding key events

2016-05-17 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE35a637471f82: Check user is allowed to run krunner when forwarding key events (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1600?vs=3792&id=3835#toc R

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 4 - Failure!

2016-05-17 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/4/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 10:49:44 + Build duration: 2 min 23 sec CHANGE SET Revision 342470242ff4af083cf7909aba4e4f6e098b1c2

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 90 - Still Unstable!

2016-05-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 10:49:31 + Build duration: 14 min CHANGE SET Revision 35a637471f82b70e8429bc637650ba461d5

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 5 - Fixed!

2016-05-17 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 11:07:50 + Build duration: 1 min 26 sec CHANGE SET Revision b04274f645e6e523e9485334f0e7210afce2a54

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 5 - Fixed!

2016-05-17 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 11:07:50 + Build duration: 1 min 26 sec CHANGE SET Revision b04274f645e6e523e9485334f0e7210afce2a54

Re: status of kde/plasma kiosk framework in kf5

2016-05-17 Thread Kai Uwe Broulik
Hi Thomas,  thanks a lot for your feedback! > 1.) configuration panel for activities That's a tricky one as we currently do not have QML bindings for Kiosk but I'll look into this. > 2.) the desktopmenu still shows a "leave" button and ignores action/logout I have a patch for this but we appa

[Differential] [Closed] D1624: [client] Add context pointer to connects in PlasmaWindowModel

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDcf633eabf5b7: [client] Add context pointer to connects in PlasmaWindowModel (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1624?vs=3834&id=3839#toc REPOSITORY rK

[Differential] [Closed] D1621: [client] Ensure PlasmaWindowManagement updates active window if it goes away

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDf5d75fe3e9a3: [client] Ensure PlasmaWindowManagement updates active window if it goes away (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Closed] D1623: [client] Don't delete windows from PlasmaWindowModel

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND5ad723ac8edc: [client] Don't delete windows from PlasmaWindowModel (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1623?vs=3833&id

[Differential] [Closed] D1622: [client] Ensure PlasmaWindowModel removes deleted windows

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDf39f4bf99d66: [client] Ensure PlasmaWindowModel removes deleted windows (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1622?vs=38

[Differential] [Accepted] D1576: Provide functionality of CompositingPrefs through Platform

2016-05-17 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH drop-compositingprefs REVISION DETAIL https://phabricator.kde.org/D1576 EMAIL PREFERENCES https://phabricator.kde.org/set

[Differential] [Closed] D1575: Move requiresCompositing from Application to Platform

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc45942a70c6a: Move requiresCompositing from Application to Platform (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1575?vs=3726&id=3841#toc REPOSITORY rKWIN KWin CH

[Differential] [Accepted] D1527: Make Toplevel::window() no longer virtual and introduce ::windowId()

2016-05-17 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH split-window-and-windowId REVISION DETAIL https://phabricator.kde.org/D1527 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Closed] D1576: Provide functionality of CompositingPrefs through Platform

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINd15d3a5ff12c: Provide functionality of CompositingPrefs through Platform (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1576?vs=3727&id=3842

[Differential] [Accepted] D1581: If glx is not available try to create egl backend

2016-05-17 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fallthrough-egl-if-no-glx REVISION DETAIL https://phabricator.kde.org/D1581 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Accepted] D1573: Destroy static Client helper window before application goes down

2016-05-17 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH cleanup-x11 REVISION DETAIL https://phabricator.kde.org/D1573 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graes

[Differential] [Accepted] D1581: If glx is not available try to create egl backend

2016-05-17 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. REPOSITORY rKWIN KWin BRANCH fallthrough-egl-if-no-glx REVISION DETAIL https://phabricator.kde.org/D1581 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, mart, Plasma, brouli

[Differential] [Accepted] D1573: Destroy static Client helper window before application goes down

2016-05-17 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. REPOSITORY rKWIN KWin BRANCH cleanup-x11 REVISION DETAIL https://phabricator.kde.org/D1573 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, mart, Plasma, broulik Cc: plasma-d

[Differential] [Closed] D1573: Destroy static Client helper window before application goes down

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINea4de855532d: Destroy static Client helper window before application goes down (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1573?vs=3724&id

[Differential] [Closed] D1527: Make Toplevel::window() no longer virtual and introduce ::windowId()

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN24bdfc63170a: Make Toplevel::window() no longer virtual and introduce ::windowId() (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1527?vs=360

[Differential] [Closed] D1581: If glx is not available try to create egl backend

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN48e69b77d9bd: If glx is not available try to create egl backend (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1581?vs=3743&id=3845 REVISION

[Differential] [Closed] D1582: Move the OpenGL unsafe check into the Platform

2016-05-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN7c822fadeecf: Move the OpenGL unsafe check into the Platform (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1582?vs=3744&id=3846 REVISION DE

[Differential] [Commented On] D1610: [Powermanagement Dataengine] Expose "Logout" as Sleep State

2016-05-17 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Leave calls whatever you have selected in systemsettings -> startup and shutdown -> default leave option AFAIK this setting isn't exposed to the toolbox. you can argue that if you can't logout you shouldn't be able to shutdown, but that's not how we d

Re: Review Request 127937: Use SAX instead of DOM for Plasma::Svg stylesheet replacement

2016-05-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127937/ --- (Updated May 17, 2016, 12:45 p.m.) Status -- This change has been ma

Re: status of kde/plasma kiosk framework in kf5

2016-05-17 Thread David Edmundson
I tried the toolbar setting. It does correctly block moving the toolbars. At least in the applications I tested. There is still a toggle option still in the menu to "show toolbar". This can be blocked with: action/options_show_toolbar=false It's a bit confusingly worded - you're setting the act

[Differential] [Closed] D1617: Remove unused duplicated code

2016-05-17 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPfebd9710c93a: Remove unused duplicated code (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1617?vs=3825&id=3

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 63 - Fixed!

2016-05-17 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 13:01:31 + Build duration: 7 min 15 sec CHANGE SET Revision febd9710c93aead859aa7d826fc8eef5

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 63 - Fixed!

2016-05-17 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 13:01:31 + Build duration: 7 min 15 sec CHANGE SET Revision febd9710c93aead859aa7d826fc8eef5

[Differential] [Commented On] D1610: [Powermanagement Dataengine] Expose "Logout" as Sleep State

2016-05-17 Thread broulik (Kai Uwe Broulik)
broulik added a comment. > AFAIK this setting isn't exposed to the toolbox. The toolbox calls "requestShutdown" on the PM dataengine which ends up calling KWorkspace::requestShutdown which does whatever is configured to happen then (show dialog, shutdown immediately etc) The only pl

Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- Review request for kde-workspace and Plasma. Bugs: 360666 https://bug

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95532 --- The change looks sensible to me, but I would appreciate a tes

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95533 --- Ship it! This would fix https://bugs.kde.org/show_bug.cgi?

Re: status of kde/plasma kiosk framework in kf5

2016-05-17 Thread Kai Uwe Broulik
And a follow up on your in-line comments: > action/kdesktop_rmb=false   # Whether the user can right click on a > file icon on the desktop # this only works with plasma in "folderview" mode > on real files Looking at the code this is intentional. It probably just got ported from Plasma

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- (Updated May 17, 2016, 3:20 p.m.) Review request for kde-workspace and Pl

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
> On May 17, 2016, 2:35 p.m., Martin Gräßlin wrote: > > The change looks sensible to me, but I would appreciate a test case for it. > > There are already some tests for the file dialog, so it should be easy to > > extend. There is no autotest, but have updated tests/qfiledialogtest with option

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95535 --- The test does not verify the problem. I just pulled the patch

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. ah now I see. You adjusted the test application, but not the autotest. - Martin ---

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review95537 --- > I saw that one of the justifications for the move was a dep

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review95538 --- given that Plasma integration got removed I suggest to create

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. Now I see that

DWD HIG Draft

2016-05-17 Thread Ken Vermette
Howdy! We have our first serious formal proposal for the DWD HIGs and the functionality we are looking for; here's a link to the publicly editable Google doc: https://docs.google.com/document/d/1mYzHjcuDitWmk99syjC0xzQPPmyUrpL_29_s3-2Yl_g/edit?usp=sharing I'd like to invite anyone with a stake i

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-17 Thread René J . V . Bertin
> On May 17, 2016, 4:36 p.m., Martin Gräßlin wrote: > > > I saw that one of the justifications for the move was a dependency on > > > Plasma library/ies, but I don't see any such dependencies in the latest > > > version before the move (commit 07548ac1fe7a7fb31a941473911e982fb623c07d). > > > >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-17 Thread René J . V . Bertin
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. I quite like the way things are, but yes, I've played with that idea. I guess I can simply fork `frameworkintegratio

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Jonathan Marten
> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: status of kde/plasma kiosk framework in kf5

2016-05-17 Thread David Edmundson
On Tue, May 17, 2016 at 2:58 PM, Kai Uwe Broulik wrote: > And a follow up on your in-line comments: > > > action/kdesktop_rmb=false # Whether the user can right click > on a file icon on the desktop # this only works with plasma in "folderview" > mode on real files > > Looking at the co

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-17 Thread Martin Gräßlin
> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-17 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- (Updated May 17, 2016, 6:42 p.m.) Review request for Plasma and David Fau

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/#review95548 --- Fix it, then Ship it! Much cleaner indeed ;-) Thanks. k

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-17 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- (Updated May 17, 2016, 7:40 p.m.) Review request for Plasma and David Fau

[Differential] [Closed] D1610: [Powermanagement Dataengine] Expose "Logout" as Sleep State

2016-05-17 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE2626a6ad0ac0: [Powermanagement Dataengine] Expose "Logout" as Sleep State (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1610?vs=3814&id=3848#toc REPOSITORY

[Differential] [Request, 17 lines] D1626: [Desktop Toolbox] Hide "Leave" option if "logout" KDE Action Restriction is in effect

2016-05-17 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Whether or not "logout" should

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 91 - Still Unstable!

2016-05-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/91/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 17:45:32 + Build duration: 9 min 18 sec CHANGE SET Revision 2626a6ad0ac0cf8cf8866846eeaa5

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/#review95550 --- Ship it! Ship It! - David Faure On May 17, 2016, 5:40 p

Review Request 127946: [KDeclarative] [KCMShell] Add "authorized" wrapper around KAuthorize::authorizeControlModules

2016-05-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127946/ --- Review request for Plasma. Repository: kdeclarative Description ---

Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Accepted] D1626: [Desktop Toolbox] Hide "Leave" option if "logout" KDE Action Restriction is in effect

2016-05-17 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1626 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Accepted] D1627: [System Tray] Don't try to popup empty QMenu

2016-05-17 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1627 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Request, 5 lines] D1627: [System Tray] Don't try to popup empty QMenu

2016-05-17 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY With KIOSK restrictions i

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-17 Thread Martin Gräßlin
> On May 17, 2016, 4:36 p.m., Martin Gräßlin wrote: > > > I saw that one of the justifications for the move was a dependency on > > > Plasma library/ies, but I don't see any such dependencies in the latest > > > version before the move (commit 07548ac1fe7a7fb31a941473911e982fb623c07d). > > > >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-17 Thread Martin Gräßlin
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-17 Thread Kai Uwe Broulik
> On Mai 17, 2016, 7:41 nachm., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 971 > > > > > > I think technically it's better to accept the event regardless. You > > st

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/#review95551 --- Ship it! src/scriptengines/qml/plasmoid/containmentinterf

[Differential] [Closed] D1626: [Desktop Toolbox] Hide "Leave" option if "logout" KDE Action Restriction is in effect

2016-05-17 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPd15b221a9724: [Desktop Toolbox] Hide "Leave" option if "logout" KDE Action Restriction is… (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https:

[Differential] [Closed] D1627: [System Tray] Don't try to popup empty QMenu

2016-05-17 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf87e72b98007: [System Tray] Don't try to popup empty QMenu (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D162

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 92 - Still Unstable!

2016-05-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 19:58:03 + Build duration: 10 min CHANGE SET Revision f87e72b980072fa264a1f7013cea397a9c7

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-17 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- (Updated May 17, 2016, 8:19 p.m.) Status -- This change has been mar

Re: Review Request 127943: change translation catalogue name

2016-05-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127943/#review95563 --- Looks good to me. Shit it in a week if noone has given you a

Re: Review Request 127943: change translation catalogue name

2016-05-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127943/#review95565 --- Ship it! Ship It! - David Edmundson On May 17, 2016, 8:

Re: Review Request 127943: change translation catalogue name

2016-05-17 Thread David Edmundson
> On May 17, 2016, 9:15 p.m., David Edmundson wrote: > > Ship It! EDIT. All i18nd lines in kde/workspace/plasma-desktop/kcms/activities/imports/qml need fixing and kde/workspace/plasma-desktop/kcms/activities/qml/activitiesTab/ActivitiesView.qml - David --

Where has build guide disappeared

2016-05-17 Thread Bhushan Shah
Hello, I am just wondering where https://community.kde.org/Plasma/Building have disappeared? Old links points to https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source which is I believe not same and detailed compared to previous one.. Also community.kde.org/Frameworks/Building is not

Re: Where has build guide disappeared

2016-05-17 Thread Bhushan Shah
On Wed, May 18, 2016 at 11:19 AM, Bhushan Shah wrote: > > I am just wondering where https://community.kde.org/Plasma/Building > have disappeared? Old links points to > https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source > which is I believe not same and detailed compared to previous