> On Mai 17, 2016, 7:41 nachm., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 971
> > <https://git.reviewboard.kde.org/r/127947/diff/1/?file=465098#file465098line971>
> >
> > I think technically it's better to accept the event regardless. You
> > still tried to show a context menu and you don't want the behaviour to be
> > different based on whether there happened to be any entries or not.
> >
> > If AppletInterface did this you'd end up showing a containment menu if
> > you right clicked on an applet when locked down, which would be weird.
> >
> > In this case it's purely hypothetical as there's nothing underneath a
> > ContainmentInterface anyway, so I don't really care.
Yeah, right, you still did a click; I got misguided by:
> if (!plugin || plugin->contextualActions().isEmpty()) {
>
> event->setAccepted(false);
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127947/#review95551
-----------------------------------------------------------
On Mai 17, 2016, 6:32 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127947/
> -----------------------------------------------------------
>
> (Updated Mai 17, 2016, 6:32 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> With KIOSK restrictions it can happen that a context menu would be empty. In
> this case just a shadow would show up. Do nothing in this case.
>
>
> Diffs
> -----
>
> src/scriptengines/qml/plasmoid/containmentinterface.cpp f168002
>
> Diff: https://git.reviewboard.kde.org/r/127947/diff/
>
>
> Testing
> -------
>
> AppletInterface already has similar code.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
