----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/#review95551 -----------------------------------------------------------
Ship it! src/scriptengines/qml/plasmoid/containmentinterface.cpp (line 971) <https://git.reviewboard.kde.org/r/127947/#comment64746> I think technically it's better to accept the event regardless. You still tried to show a context menu and you don't want the behaviour to be different based on whether there happened to be any entries or not. If AppletInterface did this you'd end up showing a containment menu if you right clicked on an applet when locked down, which would be weird. In this case it's purely hypothetical as there's nothing underneath a ContainmentInterface anyway, so I don't really care. - David Edmundson On May 17, 2016, 6:32 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127947/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 6:32 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > With KIOSK restrictions it can happen that a context menu would be empty. In > this case just a shadow would show up. Do nothing in this case. > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/containmentinterface.cpp f168002 > > Diff: https://git.reviewboard.kde.org/r/127947/diff/ > > > Testing > ------- > > AppletInterface already has similar code. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
