Review Request 119175: Create internal copy of kxmlrpcclient to get drkonqi to report bugs

2014-07-09 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119175/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119175: Create internal copy of kxmlrpcclient to get drkonqi to report bugs

2014-07-09 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119175/ --- (Updated July 9, 2014, 2:56 p.m.) Review request for Plasma. Changes --

Review Request 119191: Only consider a containment as finished if it actually passes a "true".

2014-07-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119191/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 119191: Only consider a containment as finished if it actually passes a "true".

2014-07-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119191/#review61958 --- Ship it! Ship It! - Marco Martin On July 9, 2014, 10:11 a.

Re: Review Request 119191: Only consider a containment as finished if it actually passes a "true".

2014-07-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119191/#review61959 --- No, don't. If an applet fails to load then we'll never say th

Re: Review Request 119191: Only consider a containment as finished if it actually passes a "true".

2014-07-09 Thread David Edmundson
> On July 9, 2014, 10:44 a.m., David Edmundson wrote: > > No, don't. > > > > If an applet fails to load then we'll never say the containment loaded and > > then we won't clear the ksplash EDIT: I'm wrong. Carry on. (off topic: Why on Earth is AppletPrivate the one responsible for emitting si

Re: Review Request 119191: Only consider a containment as finished if it actually passes a "true".

2014-07-09 Thread Aleix Pol Gonzalez
> On July 9, 2014, 10:44 a.m., David Edmundson wrote: > > No, don't. > > > > If an applet fails to load then we'll never say the containment loaded and > > then we won't clear the ksplash > > David Edmundson wrote: > EDIT: I'm wrong. Carry on. > > (off topic: Why on Earth is Apple

Re: Review Request 119191: Only consider a containment as finished if it actually passes a "true".

2014-07-09 Thread Marco Martin
> On July 9, 2014, 10:44 a.m., David Edmundson wrote: > > No, don't. > > > > If an applet fails to load then we'll never say the containment loaded and > > then we won't clear the ksplash > > David Edmundson wrote: > EDIT: I'm wrong. Carry on. > > (off topic: Why on Earth is Apple

Re: Review Request 119191: Only consider a containment as finished if it actually passes a "true".

2014-07-09 Thread Marco Martin
> On July 9, 2014, 10:44 a.m., David Edmundson wrote: > > No, don't. > > > > If an applet fails to load then we'll never say the containment loaded and > > then we won't clear the ksplash > > David Edmundson wrote: > EDIT: I'm wrong. Carry on. > > (off topic: Why on Earth is Apple

Re: Review Request 119191: Only consider a containment as finished if it actually passes a "true".

2014-07-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119191/ --- (Updated July 9, 2014, 10:52 a.m.) Status -- This change has been ma

Re: Plasma, Accessibility and Keyboard

2014-07-09 Thread Frederik Gladhorn
Just a quick follow-up: kickoff the default app launcher doesn't currently work with screen readers, even after spending some time on it. The reason is that it keeps the focus on some root item (I didn't check where it actually is). For accessibility I currently rely on getting focus changes to

Re: Plasma 5 RC

2014-07-09 Thread Sebastian Kügler
On Tuesday, July 08, 2014 18:45:41 John Layt wrote: > On 7 July 2014 10:16, Jonathan Riddell wrote: > > On Fri, Jul 04, 2014 at 10:36:00AM +0100, John Layt wrote: > >> Co-installabilty of Plasma 4 and Plasma 5 with minimal work required > >> by the distros is a must if we want to avoid the mess of

Review Request 119193: Plasma-Active: Implement a launcher for Plasma Active

2014-07-09 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119193/ --- Review request for Plasma. Repository: plasma-mobile Description --

Re: Review Request 119176: Update kickoff when user's name or face image changed

2014-07-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119176/#review61966 --- Ship it! I still don't love it, but seems to do what it has t

Re: Review Request 119176: Update kickoff when user's name or face image changed

2014-07-09 Thread Sebastian Kügler
> On July 9, 2014, 11:47 a.m., Aleix Pol Gonzalez wrote: > > I still don't love it, but seems to do what it has to do. > > > > Maybe add a comment for the temporaryEmptyFace, in case we manage to get > > better api for this in the future. I don't like it either, and we'll have to find a better

Re: Review Request 119176: Update kickoff when user's name or face image changed

2014-07-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119176/ --- (Updated July 9, 2014, noon) Status -- This change has been marked a

Re: Review Request 119193: Plasma-Active: Implement a launcher for Plasma Active

2014-07-09 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119193/#review61977 --- Hmm just looking at the list of issues, could you maybe look a

4.x transition blockage - workspace libs

2014-07-09 Thread Harald Sitter
Ahoy everyone, I recently got into a discussion about the 5.0 workspace transition and how this can be kept from having impact on 4.x applications in any form. Having looked into this I have to say that there are problems... The mail is a bit on the long side, so please bear with me. It's importa

Review Request 119199: RFC: Debugging tool for plasma

2014-07-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119199/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2014-07-09 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/ --- (Updated Июль 9, 2014, 7:52 п.п.) Review request for kde-workspace and Pl

Re: Review Request 119193: Plasma-Active: Implement a launcher for Plasma Active

2014-07-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119193/#review61993 --- Ship it! The pages should show the proper icons now after the

Re: 4.x transition blockage - workspace libs

2014-07-09 Thread Aleix Pol
On Wed, Jul 9, 2014 at 4:32 PM, Harald Sitter wrote: > Ahoy everyone, > > I recently got into a discussion about the 5.0 workspace transition > and how this can be kept from having impact on 4.x applications in any > form. Having looked into this I have to say that there are problems... > > The m

Re: Review Request 119193: Plasma-Active: Implement a launcher for Plasma Active

2014-07-09 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119193/ --- (Updated July 9, 2014, 7:51 p.m.) Status -- This change has been mar

Re: Review Request 119193: Plasma-Active: Implement a launcher for Plasma Active

2014-07-09 Thread Antonis Tsiapaliokas
> On July 9, 2014, 1:53 p.m., Eike Hein wrote: > > Hmm just looking at the list of issues, could you maybe look at the > > codebases for Kicker (Application Menu) and Folder for inspiration? Kicker > > has a application model as well (relevant for your KServiceTypeTrader > > problem) and Folde

Build failed in Jenkins: plasma-desktop_master_qt5 #438

2014-07-09 Thread KDE CI System
See Changes: [kde] Allow for colorschemes names not perfectly matching the filename [kde] Emit colour scheme changed signal after syncing schemes with KDE4 apps -- [...truncated 2562 lines..

Jenkins build is back to normal : plasma-desktop_master_qt5 #439

2014-07-09 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel