----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119193/#review61993 -----------------------------------------------------------
Ship it! The pages should show the proper icons now after the last commit. launching by index can't work, because there are proxy models involved, so never do that. exposing the desktopfile storageid and using that to launch should be fine. anywyas, i need this pushed, even if has sill some way to go, or i can't work on it :p - Marco Martin On July 9, 2014, 11:28 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119193/ > ----------------------------------------------------------- > > (Updated July 9, 2014, 11:28 a.m.) > > > Review request for Plasma. > > > Repository: plasma-mobile > > > Description > ------- > > The new launcher supports the following: > > * it can show the applications > * it can open an application. > > > Diffs > ----- > > activeshellpackage/package/contents/views/Panel.qml a6b0c41 > activeshellpackage/package/contents/views/WindowList.qml d609214 > components/mobilecomponents/CMakeLists.txt 69d6035 > components/mobilecomponents/applicationlistmodel.h PRE-CREATION > components/mobilecomponents/applicationlistmodel.cpp PRE-CREATION > activeshellpackage/package/contents/views/ApplicationList.qml PRE-CREATION > components/mobilecomponents/mobilecomponentsplugin.cpp b344ab4 > > Diff: https://git.reviewboard.kde.org/r/119193/diff/ > > > Testing > ------- > > Issues > > * The IconGrid is returning a wrong index, so we are not opening the > application, in which we clicked. > * The IconGrid scrolling seems broken. > * The TextField component doesn't get the correct focus.(open a kate in the > background, go into the launcher, the input goes to kate, not to the > TextField) > * The KServiceTypeTrader::self()->query("Application"), returns back plugins > which they are not applications. > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
