> On July 9, 2014, 10:44 a.m., David Edmundson wrote: > > No, don't. > > > > If an applet fails to load then we'll never say the containment loaded and > > then we won't clear the ksplash > > David Edmundson wrote: > EDIT: I'm wrong. Carry on. > > (off topic: Why on Earth is AppletPrivate the one responsible for > emitting signals in containemnts. That makes no sense)
Indeed, my head is spinning by reading into that code. I wanted to do something that seemed easy, doesn't look like it now. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119191/#review61959 ----------------------------------------------------------- On July 9, 2014, 10:11 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119191/ > ----------------------------------------------------------- > > (Updated July 9, 2014, 10:11 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > So far, we were only considering the fact that teh signal was being emitted, > and that's doesn't seemcorrect. > > > Diffs > ----- > > src/plasma/corona.cpp 20d61a0 > > Diff: https://git.reviewboard.kde.org/r/119191/diff/ > > > Testing > ------- > > I don't know how to test it. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
