Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-29 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/ --- (Updated Aug. 29, 2016, 5:30 p.m.) Status -- This change has been di

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-16 Thread Christoph Feck
> On Aug. 16, 2016, 2:27 a.m., Anthony Fieroni wrote: > > Ping. For 5.7.4 > > Martin Gräßlin wrote: > For master the focus in is removed. And I think that's absolutely no > stable branch material. It looks like this is also fixed with Qt 5.6 branch, see commit 17d68c4fc371c32bd58d0a94ac63

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-16 Thread Martin Gräßlin
> On Aug. 16, 2016, 4:27 a.m., Anthony Fieroni wrote: > > Ping. For 5.7.4 For master the focus in is removed. And I think that's absolutely no stable branch material. - Martin --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-15 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review98406 --- Ping. For 5.7.4 - Anthony Fieroni On Авг. 13, 2016, 8:17 п

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/ --- (Updated Авг. 13, 2016, 8:17 преди обяд) Review request for kwin, Plasma,

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Anthony Fieroni
> On Авг. 12, 2016, 2:31 след обяд, Martin Gräßlin wrote: > > Could someone please test, whether this works? > > > > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp > > index 14a25af..38c6621 100644 > > --- a/shell/desktopview.cpp > > +++ b/shell/desktopview.cpp > >

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Martin Gräßlin
> On Aug. 12, 2016, 1:31 p.m., Martin Gräßlin wrote: > > Could someone please test, whether this works? > > > > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp > > index 14a25af..38c6621 100644 > > --- a/shell/desktopview.cpp > > +++ b/shell/desktopview.cpp > > @@

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Thomas Lübking
> On Aug. 12, 2016, 11:31 vorm., Martin Gräßlin wrote: > > Could someone please test, whether this works? > > > > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp > > index 14a25af..38c6621 100644 > > --- a/shell/desktopview.cpp > > +++ b/shell/desktopview.cpp > > @

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Anthony Fieroni
> On Авг. 12, 2016, 2:31 след обяд, Martin Gräßlin wrote: > > Could someone please test, whether this works? > > > > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp > > index 14a25af..38c6621 100644 > > --- a/shell/desktopview.cpp > > +++ b/shell/desktopview.cpp > >

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Martin Gräßlin
> On Aug. 12, 2016, 1:31 p.m., Martin Gräßlin wrote: > > Could someone please test, whether this works? > > > > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp > > index 14a25af..38c6621 100644 > > --- a/shell/desktopview.cpp > > +++ b/shell/desktopview.cpp > > @@

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Anthony Fieroni
> On Авг. 12, 2016, 2:31 след обяд, Martin Gräßlin wrote: > > Could someone please test, whether this works? > > > > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp > > index 14a25af..38c6621 100644 > > --- a/shell/desktopview.cpp > > +++ b/shell/desktopview.cpp > >

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review98334 --- Could someone please test, whether this works? diff --gi

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Anthony Fieroni
> On Авг. 12, 2016, 2:05 след обяд, Anthony Fieroni wrote: > > I can't see bug in Qt implementaion of setFlags > > https://code.woboq.org/qt5/qtbase/src/plugins/platforms/xcb/qxcbwindow.cpp.html#1130 > > xcb plugin bug? > > Thomas Lübking wrote: > Afaik the entire thing operates on an undoc

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Thomas Lübking
> On Aug. 12, 2016, 11:05 vorm., Anthony Fieroni wrote: > > I can't see bug in Qt implementaion of setFlags > > https://code.woboq.org/qt5/qtbase/src/plugins/platforms/xcb/qxcbwindow.cpp.html#1130 > > xcb plugin bug? Afaik the entire thing operates on an undocumented string property to carry th

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-12 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review98330 --- I can't see bug in Qt implementaion of setFlags https://code

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Thomas Lübking
> On Aug. 10, 2016, 1:23 nachm., David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? > > Sebastian Kügler wrote: > Did you read Martin's comments on the phab request? > > Anthony Fieroni wrote: > I see it make sense, because it

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/ --- (Updated Авг. 10, 2016, 9:28 след обяд) Review request for kwin, Plasma,

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
> On Авг. 10, 2016, 4:23 след обяд, David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? > > Sebastian Kügler wrote: > Did you read Martin's comments on the phab request? > > Anthony Fieroni wrote: > I see it make sense, because

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Thomas Lübking
> On Aug. 10, 2016, 1:23 nachm., David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? > > Sebastian Kügler wrote: > Did you read Martin's comments on the phab request? > > Anthony Fieroni wrote: > I see it make sense, because it

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Sebastian Kügler
> On Aug. 10, 2016, 1:23 p.m., David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? Did you read Martin's comments on the phab request? - Sebastian --- This is an automatically g

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
> On Авг. 10, 2016, 4:23 след обяд, David Rosca wrote: > > https://phabricator.kde.org/D2121 > > Anthony Fieroni wrote: > So why not ship it? > > Sebastian Kügler wrote: > Did you read Martin's comments on the phab request? I see it make sense, because it change props on focusIn before

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
> On Авг. 10, 2016, 4:23 след обяд, David Rosca wrote: > > https://phabricator.kde.org/D2121 So why not ship it? - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review9

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review98286 --- https://phabricator.kde.org/D2121 - David Rosca On Aug. 10

Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

2016-08-10 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/ --- Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Ma