> On Авг. 12, 2016, 2:31 след обяд, Martin Gräßlin wrote:
> > Could someone please test, whether this works?
> >
> > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
> > index 14a25af..38c6621 100644
> > --- a/shell/desktopview.cpp
> > +++ b/shell/desktopview.cpp
> > @@ -226,6 +226,7 @@ bool DesktopView::event(QEvent *e)
> > switch (pe->surfaceEventType()) {
> > case QPlatformSurfaceEvent::SurfaceCreated:
> > setupWaylandIntegration();
> > + ensureWindowType();
> > break;
> > case QPlatformSurfaceEvent::SurfaceAboutToBeDestroyed:
> > delete m_shellSurface;
>
> Anthony Fieroni wrote:
> I can't get plasmashell to work in wayland on my skylake laptop, it
> crashes every time.
>
> Martin Gräßlin wrote:
> I meant to test that on X11, not on Wayland. On Wayland I can test myself
> :-)
>
> Anthony Fieroni wrote:
> How this expect to work? Multiple calls in setFlags triggers the bug, if
> we remove esureWindowType at focusIn then it *should* work.
>
> Thomas Lübking wrote:
> The implication is probably to remove it *everywhere* else.
>
> Martin Gräßlin wrote:
> yep, the idea is whether the types is set correctly after surface
> created. If it is we can remove all other calls.
On screen changes should to stay and in setWindowType too. We can remove only
on focusIn.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98334
-----------------------------------------------------------
On Авг. 10, 2016, 9:28 след обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> -----------------------------------------------------------
>
> (Updated Авг. 10, 2016, 9:28 след обяд)
>
>
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco
> Martin.
>
>
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> ^^
>
>
> Diffs
> -----
>
> shell/desktopview.cpp 83866dc
>
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
>
>
> Testing
> -------
>
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
>
>
> Thanks,
>
> Anthony Fieroni
>
>
