Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/ --- (Updated May 18, 2016, 8:42 p.m.) Status -- This change has been mar

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/#review95589 --- Ship it! Ship It! - Marco Martin On May 18, 2016, 1:20

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/ --- (Updated Mai 18, 2016, 1:20 nachm.) Review request for Plasma. Reposito

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/#review95574 --- Ship it! always accept - Marco Martin On May 17, 2016,

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/#review95551 --- Ship it! src/scriptengines/qml/plasmoid/containmentinterf

Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-17 Thread Kai Uwe Broulik
> On Mai 17, 2016, 7:41 nachm., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 971 > > > > > > I think technically it's better to accept the event regardless. You > > st

Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu

2016-05-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/ --- Review request for Plasma. Repository: plasma-framework Description ---