Re: [Piglit] [Mesa-dev] Request for Mentorship

2015-06-05 Thread Rob Clark
so, maybe a bit off topic (and maybe doesn't really help with the whole finding a mentor thing).. but a sort of wish-list thing for piglit that I've had in the back of my head is something like "tig" for piglit. I suppose it doesn't have to necessarily be a curses based UI, it could be gui.. but

Re: [Piglit] [Mesa-dev] Request for Mentorship

2015-06-10 Thread Rob Clark
On Wed, Jun 10, 2015 at 7:28 PM, Emil Velikov wrote: > On 5 June 2015 at 22:08, Rob Clark wrote: >> so, maybe a bit off topic (and maybe doesn't really help with the >> whole finding a mentor thing).. but a sort of wish-list thing for >> piglit that I've had in t

[Piglit] [HACK/RFC] make piglit-summary.py print things out in a more useful way

2015-11-25 Thread Rob Clark
Complete hack, but maybe we want to make something like this an optional way that piglit-summary dumps out results. Basically it groups all the results according to transition (ie. 'pass -> fail' or 'fail -> fail -> pass', etc., and then for each group dumps out the test environment and cmdline.

Re: [Piglit] [HACK/RFC] make piglit-summary.py print things out in a more useful way

2015-11-25 Thread Rob Clark
On Wed, Nov 25, 2015 at 1:58 PM, Dylan Baker wrote: > On Wed, Nov 25, 2015 at 11:32:48AM -0500, Rob Clark wrote: >> Complete hack, but maybe we want to make something like this an optional >> way that piglit-summary dumps out results. >> >> Basically it groups a

Re: [Piglit] [PATCH 1/8] piglit-framework-gl: Use GBM on non-intel for dmabuf creation.

2016-08-12 Thread Rob Clark
On Mon, Jul 25, 2016 at 8:43 PM, Eric Anholt wrote: > Previously the dmabuf tests only worked on the intel driver. However, > thanks to the new GBM BO mapping interface by Rob Herring, we can make > a generic framework for other drivers. So big fan of this idea (beats my earlier plan to add libd

[Piglit] [RFC] Trying to fix dmabuf/yuv tests

2016-09-04 Thread Rob Clark
Ok, so the basic problem with the YUV tests is that they currently completely ignore driver/hw pitch requirements, since the code that allocates the buffer doesn't know the pixel format, only the 'cpp'. The yuv test creates a small 4x4 yuv eglimage. If, say, the hardware requires the pitch to be

Re: [Piglit] [RFC] Trying to fix dmabuf/yuv tests

2016-09-06 Thread Rob Clark
On Tue, Sep 6, 2016 at 4:04 PM, Kristian Høgsberg wrote: > On Sun, Sep 4, 2016 at 9:34 AM, Rob Clark wrote: >> Ok, so the basic problem with the YUV tests is that they currently >> completely ignore driver/hw pitch requirements, since the code that >> allocates the buffer d

Re: [Piglit] [RFC] Trying to fix dmabuf/yuv tests

2016-09-06 Thread Rob Clark
On Tue, Sep 6, 2016 at 4:23 PM, Rob Clark wrote: >>> @@ -212,28 +247,65 @@ piglit_gbm_buf_create(unsigned w, unsigned h, >>> unsigned cpp, >>> void *dst_data; >>> void *map_data = NULL; >>> enum gbm_bo_format for

Re: [Piglit] [RFC] Trying to fix dmabuf/yuv tests

2016-09-07 Thread Rob Clark
On Tue, Sep 6, 2016 at 4:53 PM, Kristian Høgsberg wrote: > On Tue, Sep 6, 2016 at 1:32 PM, Rob Clark wrote: >> On Tue, Sep 6, 2016 at 4:23 PM, Rob Clark wrote: >>>>> @@ -212,28 +247,65 @@ piglit_gbm_buf_create(unsigned w, unsigned h, >>>>> uns

[Piglit] [PATCH] dmabuf: fix YUV tests for drivers other than intel

2016-09-07 Thread Rob Clark
(with the intel dma-buf backend) and freedreno (with the gbm dma-buf backend). In the gbm case, it requires new gbm format values for R8 and GR88, which is on mesa master as of this morning. (So I bumped the gbm version dependency to 12.1.) Signed-off-by: Rob Clark

Re: [Piglit] [RFC] Trying to fix dmabuf/yuv tests

2016-09-07 Thread Rob Clark
On Wed, Sep 7, 2016 at 3:07 PM, Emil Velikov wrote: > On Tuesday, 6 September 2016, Rob Clark wrote: >> >> On Tue, Sep 6, 2016 at 4:04 PM, Kristian Høgsberg >> wrote: > > >> >> > If we have the gbm eglimage path, why do we keep the intel specific code

Re: [Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Rob Clark
On Wed, Sep 7, 2016 at 6:59 PM, Dan Kegel wrote: > Hi! > I'd like to use piglit as a regression test for my opengl test rigs. > My plan is to run piglit a few times on each OS/card combo I need to support, > get a list of tests that reliably pass on each platform, and then > forevermore run just t

[Piglit] [PATCH v2] dmabuf: fix YUV tests for drivers other than intel

2016-09-09 Thread Rob Clark
(with the intel dma-buf backend) and freedreno (with the gbm dma-buf backend). In the gbm case, it requires new gbm format values for R8 and GR88, which is on mesa master as of this morning. (So I bumped the gbm version dependency to 12.1.) Signed-off-by: Rob Clark --- v2: drop unn

Re: [Piglit] [PATCH v2] dmabuf: fix YUV tests for drivers other than intel

2016-09-09 Thread Rob Clark
On Fri, Sep 9, 2016 at 2:30 PM, Kristian Høgsberg wrote: > On Fri, Sep 9, 2016 at 10:44 AM Rob Clark wrote: >> >> diff --git a/tests/spec/ext_image_dma_buf_import/missing_attributes.c >> b/tests/spec/ext_image_dma_buf_import/missing_attributes.c >> index d7d89e6..d1

[Piglit] [PATCH 1/2 v3] dmabuf: fix YUV tests for drivers other than intel

2016-09-10 Thread Rob Clark
(with the intel dma-buf backend) and freedreno (with the gbm dma-buf backend). In the gbm case, it requires new gbm format values for R8 and GR88, which is on mesa master as of this morning. (So I bumped the gbm version dependency to 12.1.) Signed-off-by: Rob Clark Reviewed-by: Eric Anholt R

[Piglit] [PATCH 2/2] dmabuf: fix small typo in error message

2016-09-10 Thread Rob Clark
Signed-off-by: Rob Clark Reviewed-by: Eric Anholt --- tests/util/piglit-framework-gl/piglit_drm_dma_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c b/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c index c3225c3

Re: [Piglit] [PATCH 2/2] dmabuf: fix small typo in error message

2016-09-10 Thread Rob Clark
On Sat, Sep 10, 2016 at 11:40 AM, Ilia Mirkin wrote: > On Sat, Sep 10, 2016 at 11:32 AM, Rob Clark wrote: >> Signed-off-by: Rob Clark >> Reviewed-by: Eric Anholt >> --- >> tests/util/piglit-framework-gl/piglit_drm_dma_buf.c | 2 +- >> 1 file changed, 1 inser

Re: [Piglit] [RFC 0/2] egl_android_native_fence_sync tests.

2016-10-25 Thread Rob Clark
On Tue, Oct 25, 2016 at 5:19 PM, Rafael Antognolli wrote: > Hi, > > I finally got to work on these piglit tests (took longer than I > expected). But here is an initial version, and I would like to know if > I'm going on the right direction. Particularly I would like to know > whether adding the sw

[Piglit] [PATCH] apitrace: update for new dump-images filenames

2017-01-23 Thread Rob Clark
The 'retrace: support for dumping multiple snapshots' patch changes the output filenames for dumped images to have -mrtN/-z/-s suffixes. MRT #0 is equivalent to the old behavior. --- tests/apitrace/test-trace.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/apitra

Re: [Piglit] [PATCH] apitrace: update for new dump-images filenames

2017-01-30 Thread Rob Clark
On Mon, Jan 23, 2017 at 1:51 PM, Eric Anholt wrote: > Rob Clark writes: > >> The 'retrace: support for dumping multiple snapshots' patch changes the >> output filenames for dumped images to have -mrtN/-z/-s suffixes. MRT #0 >> is equivalent to the old beha

[Piglit] [RFC] curses based interactive piglit result browser thing

2018-08-27 Thread Rob Clark
So for a while I've been wishing for a better way to view large piglit results, compared to just ./piglit-summary.py (which is pretty limited to just showing test name and status (or status transition), and html results (which are generally huge and annoying to click thru). (Or just bzless on the

Re: [Piglit] [Mesa-dev] Rename "master" branch to "main"?

2021-03-26 Thread Rob Clark
On Wed, Mar 24, 2021 at 9:15 PM Jason Ekstrand wrote: > > On March 24, 2021 22:25:10 Rob Clark wrote: > >> On Wed, Mar 24, 2021 at 3:52 PM Jordan Justen >> wrote: >>> >>> >>> On 2021-03-23 09:38:59, Eric Anholt wrote: >>>> >

Re: [Piglit] [Mesa-dev] Rename "master" branch to "main"?

2021-03-26 Thread Rob Clark
On Wed, Mar 24, 2021 at 3:52 PM Jordan Justen wrote: > > On 2021-03-23 09:38:59, Eric Anholt wrote: > > On Tue, Mar 23, 2021 at 7:02 AM Jason Ekstrand wrote: > > > > > > Trying to pick this discussion back up. Daniel Stone thinks it's a > > > half hour of API bashing to retarget all the MRs so,