On Tue, Sep 6, 2016 at 4:23 PM, Rob Clark <robdcl...@gmail.com> wrote:
>>> @@ -212,28 +247,65 @@ piglit_gbm_buf_create(unsigned w, unsigned h,
>>> unsigned cpp,
>>> void *dst_data;
>>> void *map_data = NULL;
>>> enum gbm_bo_format format;
>>> + unsigned cpp = 0, src_stride;
>>> + unsigned buf_w = w;
>>> + unsigned buf_h = h;
>>>
>>> - if (!gbm || h % 2)
>>> + if (!gbm || h % 2 || w % 2)
>>> return false;
>>>
>>> - /* It would be nice if we took in a fourcc instead of a cpp */
>>> - switch (cpp) {
>>
>> Can we just switch over to always taking a fourcc? This cpp_or_fourcc is
>> messy.
>
> I think it made a bit more sense when I started (and thought that this
> would be a smaller patch) to avoid extra churn..
>
> Maybe in the end since you have the U/V interleaved by row, we might
> not end up needing my patch. But otherwise, at this point it wouldn't
> make the patch that much larger to fix up the handful of rgb tests
oh, no, spoke too soon, we still have an issue for UV plane when hw
has alignment restriction in pixels instead of bytes..
BR,
-R
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
