[Piglit] [PATCH] array-texture: fail if any of the subtests fail rather than the last

2013-12-09 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/texturing/array-texture.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/texturing/array-texture.c b/tests/texturing/array-texture.c index 9837473..a65d919 100644 --- a/tests/texturing/array-texture.c +++ b/tests

Re: [Piglit] [PATCH] array-texture: fail if any of the subtests fail rather than the last

2013-12-20 Thread Ilia Mirkin
ping? On Sun, Dec 8, 2013 at 2:48 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > tests/texturing/array-texture.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/tests/texturing/array-texture.c b/tests/texturing/array-texture

[Piglit] [PATCH] glsl-fs-lots-of-tex: use a value that is more likely to become 3

2014-01-10 Thread Ilia Mirkin
g, so this adjusts the value to 0.011 which does get rounded to 3 on both nv50 and nvc0. Signed-off-by: Ilia Mirkin --- tests/shaders/glsl-fs-lots-of-tex.shader_test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/shaders/glsl-fs-lots-of-tex.shader_test b/tests/shaders/gl

Re: [Piglit] [PATCH] array-texture: fail if any of the subtests fail rather than the last

2014-01-13 Thread Ilia Mirkin
ping^2? On Fri, Dec 20, 2013 at 3:04 PM, Ilia Mirkin wrote: > ping? > > On Sun, Dec 8, 2013 at 2:48 AM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> tests/texturing/array-texture.c | 12 >> 1 file changed, 8 insertions(+), 4 dele

[Piglit] [PATCH] layered-rendering/gl-layer: clear textures before render

2014-01-13 Thread Ilia Mirkin
The render will only cover a single layer, and the code expects the other layers to be 0'd out, so do a big clear first. Signed-off-by: Ilia Mirkin --- tests/spec/gl-3.2/layered-rendering/gl-layer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/gl-3.2/layered-renderi

[Piglit] [PATCH] tests/gpu: actually make it be a subset of the quick tests

2014-01-15 Thread Ilia Mirkin
Commit 12cf501da67 (tests/gpu.py: Don't use execfile) accidentally switched from execfile'ing quick.py to importing tests.all. Change this to import tests.quick. Signed-off-by: Ilia Mirkin --- tests/gpu.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gpu.

[Piglit] [PATCH] core: show progress percentage indicator

2014-01-15 Thread Ilia Mirkin
This will show X% instead of 'running' in the status, that way it's easy to see how far along a particular run is. Signed-off-by: Ilia Mirkin --- Written while waiting for a piglit run to complete... framework/core.py | 14 ++ 1 file changed, 10 insertions(+), 4 del

Re: [Piglit] [PATCH] tests/gpu: actually make it be a subset of the quick tests

2014-01-15 Thread Ilia Mirkin
On Wed, Jan 15, 2014 at 10:55 AM, Kenneth Graunke wrote: > On 01/15/2014 02:28 AM, Ilia Mirkin wrote: >> Commit 12cf501da67 (tests/gpu.py: Don't use execfile) accidentally >> switched from execfile'ing quick.py to importing tests.all. Change this >> to import t

[Piglit] [PATCH] core: fix remove_tests logic

2014-01-16 Thread Ilia Mirkin
. Signed-off-by: Ilia Mirkin --- You can see the difference by running in a dry run mode with this patch and without on gpu.py. [Also the comment on the function was wrong... true keeps the test.] framework/core.py | 17 +++-- tests/gpu.py | 2 +- 2 files changed, 8 insertions(+), 11

Re: [Piglit] [PATCH] core: fix remove_tests logic

2014-01-16 Thread Ilia Mirkin
t; On Thursday, January 16, 2014 10:13:41 AM Ilia Mirkin wrote: >> The sole user is tests/gpu.py, which was passing in a predicate that >> worked (a) as a filter, and (b) expected to receive a test. However the >> implementation operated on the dict-of-dicts. Instead keep track

Re: [Piglit] [PATCH] core: fix remove_tests logic

2014-01-16 Thread Ilia Mirkin
Or perhaps I didn't understand your objection... what do you mean by 'same time'? It all happens before the tests run... are you saying you prefer having multiple intermediate copies of the dictionaries created? On Thu, Jan 16, 2014 at 6:37 PM, Ilia Mirkin wrote: > How woul

Re: [Piglit] [PATCH] core: fix remove_tests logic

2014-01-16 Thread Ilia Mirkin
st_matches on the other hand is for the user to say, "I'm working on > GL_hamsandwhich, and I only want to run those tests", or "I don't care about > glean tests, don't run those" > > On Thursday, January 16, 2014 06:42:35 PM Ilia Mirkin wrote: >&

Re: [Piglit] [PATCH] core: fix remove_tests logic

2014-01-16 Thread Ilia Mirkin
try to del too much stuff, and having an easy to understand mechanism seems more important than having something that takes the absolute smallest number of characters. > > On Thursday, January 16, 2014 07:06:46 PM Ilia Mirkin wrote: >> Another way to look at it is: >> >> He

[Piglit] [PATCH v2] core: fix remove_tests logic

2014-01-16 Thread Ilia Mirkin
this opportunity to pass in a second argument to the filter function: the full test name. This should allow future conversion of the 'del' style of filtering. Signed-off-by: Ilia Mirkin --- Dylan, I've made enough changes here that I don't feel good about applying your

Re: [Piglit] [PATCH v2] core: fix remove_tests logic

2014-01-16 Thread Ilia Mirkin
On Fri, Jan 17, 2014 at 12:26 AM, Dylan Baker wrote: > This looks pretty, good I have a few comments. > > On Thursday, January 16, 2014 11:35:01 PM Ilia Mirkin wrote: >> The sole user is tests/gpu.py, which was passing in a predicate that >> worked (a) as a filter, and (b)

[Piglit] [PATCH v3] core: fix remove_tests logic

2014-01-18 Thread Ilia Mirkin
this opportunity to pass in a second argument to the filter function: the full test path. This should allow future conversion of the 'del' style of filtering. Signed-off-by: Ilia Mirkin --- Dylan, I believe I've integrated all your suggestions with the exception of getting rid

Re: [Piglit] [PATCH v3] core: fix remove_tests logic

2014-01-19 Thread Ilia Mirkin
On Sat, Jan 18, 2014 at 5:03 AM, Dylan Baker wrote: > On Saturday, January 18, 2014 04:31:37 AM Ilia Mirkin wrote: >> The sole user is tests/gpu.py, which was passing in a predicate that >> worked (a) as a filter, and (b) expected to receive a test. However the >> implement

Re: [Piglit] [PATCH 2/2] framework/summary.py: fix memory consumption issue

2014-01-22 Thread Ilia Mirkin
ing the list generating dict.values() with the dict.itervalues() > iterators keeps memory consumption under 1%. > > Signed-off-by: Dylan Baker Reviewed-by: Ilia Mirkin > --- > framework/summary.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --gi

Re: [Piglit] [PATCH] core: show progress percentage indicator

2014-01-28 Thread Ilia Mirkin
. I had wanted to do a N/total thing instead of a percentage, but that wouldn't fit well with the old output and make it all jagged, whereas there had been some apparent effort put in towards padding stuff. > > On Wednesday, January 15, 2014 08:45:19 AM Ilia Mirkin wrote: >> This

[Piglit] [PATCH] fbo-framework: check for ARB_framebuffer_object

2014-01-29 Thread Ilia Mirkin
If we just blindly call glBindFramebuffer, that will cause the piglit test to skip. Make sure that ARB_framebuffer_object is supported first. Signed-off-by: Ilia Mirkin --- This comes up with the nv30 driver, which disables ARB_fbo due to not being able to support render targets with differing

Re: [Piglit] [PATCH 1/4] framework/dmesg: Adds a new module for dmesg

2014-01-31 Thread Ilia Mirkin
On Fri, Jan 31, 2014 at 8:02 PM, Dylan Baker wrote: > This modules implements two classes and a helper function. The two > classes are both dmesg wrapper classes, one, PosixDmesg is used on posix > systems when requested to actually do checks on dmesg. The second class, > DummyDmesg, is used to re

Re: [Piglit] [PATCH v2 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-01 Thread Ilia Mirkin
On Sat, Feb 1, 2014 at 3:30 AM, Dylan Baker wrote: > This modules implements two classes and a helper function. The two > classes are both dmesg wrapper classes, one, PosixDmesg is used on posix > systems when requested to actually do checks on dmesg. The second class, > DummyDmesg, is used to red

Re: [Piglit] [PATCH v2 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-01 Thread Ilia Mirkin
On Sat, Feb 1, 2014 at 5:13 PM, Dylan Baker wrote: > On Saturday, February 01, 2014 08:44:07 AM Ilia Mirkin wrote: >> On Sat, Feb 1, 2014 at 3:30 AM, Dylan Baker wrote: >> > This modules implements two classes and a helper function. The two >> > classes are both

Re: [Piglit] [PATCH v2 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-01 Thread Ilia Mirkin
On Sat, Feb 1, 2014 at 8:03 PM, Dylan Baker wrote: > On Saturday, February 01, 2014 06:06:21 PM Ilia Mirkin wrote: >> On Sat, Feb 1, 2014 at 5:13 PM, Dylan Baker wrote: >> > On Saturday, February 01, 2014 08:44:07 AM Ilia Mirkin wrote: >> >> On Sat, Feb 1, 2014 at

Re: [Piglit] [PATCH v2 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-02 Thread Ilia Mirkin
On Sat, Feb 1, 2014 at 10:12 PM, Dylan Baker wrote: > On Saturday, February 01, 2014 08:42:29 PM Ilia Mirkin wrote: >> On Sat, Feb 1, 2014 at 8:03 PM, Dylan Baker wrote: >> > On Saturday, February 01, 2014 06:06:21 PM Ilia Mirkin wrote: >> >> On Sat, Feb 1, 2014 at

Re: [Piglit] [PATCH] fbo-framework: check for ARB_framebuffer_object

2014-02-02 Thread Ilia Mirkin
On Thu, Jan 30, 2014 at 2:36 AM, Ilia Mirkin wrote: > If we just blindly call glBindFramebuffer, that will cause the piglit > test to skip. Make sure that ARB_framebuffer_object is supported first. BTW, an alternative is to flip it to use EXT_fbo (i.e. glBindFramebufferEXT & co), b

Re: [Piglit] [Patch v3 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-03 Thread Ilia Mirkin
On Mon, Feb 3, 2014 at 6:40 PM, Dylan Baker wrote: > This modules implements two classes and a helper function. The two > classes are both dmesg wrapper classes, one, PosixDmesg is used on posix > systems when requested to actually do checks on dmesg. The second class, > DummyDmesg, is used to red

Re: [Piglit] [Patch v3 4/4] piglit-run.py: Restrict dmesg to serial runs

2014-02-03 Thread Ilia Mirkin
running. But this effectively makes them a serial run, and at the > cost of greater code complexity. With that in mind it makes more sense > to just force --dmesg to imply -1. > > Signed-off-by: Dylan Baker Reviewed-by: Ilia Mirkin > --- > piglit-run.py | 7 ++- > 1

Re: [Piglit] [Patch v3 3/4] Use the new dmesg class

2014-02-03 Thread Ilia Mirkin
On Mon, Feb 3, 2014 at 6:40 PM, Dylan Baker wrote: > This actually makes use of the new dmesg class rather than the dmesg > functions. It touches a lot of files, but almost all of these changes > are code removal rather than code addition. > > Signed-off-by: Dylan Baker Reviewed-

Re: [Piglit] [Patch v3 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-03 Thread Ilia Mirkin
On Mon, Feb 3, 2014 at 7:39 PM, Dylan Baker wrote: > On Monday, February 03, 2014 06:53:53 PM Ilia Mirkin wrote: >> On Mon, Feb 3, 2014 at 6:40 PM, Dylan Baker wrote: >> > This modules implements two classes and a helper function. The two >> > classes are both

Re: [Piglit] [Patch v4 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-04 Thread Ilia Mirkin
On Tue, Feb 4, 2014 at 10:50 AM, Dylan Baker wrote: > This modules implements two classes and a helper function. The two > classes are both dmesg wrapper classes, one, PosixDmesg is used on posix > systems when requested to actually do checks on dmesg. The second class, > DummyDmesg, is used to re

Re: [Piglit] [Patch v4 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-04 Thread Ilia Mirkin
On Tue, Feb 4, 2014 at 11:07 AM, Dylan Baker wrote: > On Tuesday, February 04, 2014 10:59:20 AM Ilia Mirkin wrote: >> On Tue, Feb 4, 2014 at 10:50 AM, Dylan Baker >> > +if not self._last_message: >> > +# We need to ensure that there is

Re: [Piglit] [Patch v5 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-04 Thread Ilia Mirkin
heck dmesg for timestamp support. If you " > + "do not have timestamps enabled in your kernel you > " > + "get incomplete dmesg captures", RuntimeWarning) > +elif not re.match(r'\[\s*\d+\.\d+\]', self._last_messa

Re: [Piglit] [Patch v5 1/4] framework/dmesg: Adds a new module for dmesg

2014-02-04 Thread Ilia Mirkin
On Tue, Feb 4, 2014 at 1:12 PM, Dylan Baker wrote: > On Tuesday, February 04, 2014 12:43:42 PM Ilia Mirkin wrote: >> On Tue, Feb 4, 2014 at 12:35 PM, Dylan Baker > wrote: >> > This modules implements two classes and a helper function. The two >> > classes are b

Re: [Piglit] [PATCH] fbo-framework: check for ARB_framebuffer_object

2014-02-05 Thread Ilia Mirkin
On Sun, Feb 2, 2014 at 8:45 PM, Ilia Mirkin wrote: > On Thu, Jan 30, 2014 at 2:36 AM, Ilia Mirkin wrote: >> If we just blindly call glBindFramebuffer, that will cause the piglit >> test to skip. Make sure that ARB_framebuffer_object is supported first. > > BTW, an alterna

[Piglit] [PATCH] core: don't try to resolve the real path of the file

2014-02-07 Thread Ilia Mirkin
This makes it possible to run the summary on e.g. compressed files or otherwise piped in with the <( ... ) shell construct. There should be no difference between open() on a path before and after the realpath call. Signed-off-by: Ilia Mirkin --- framework/core.py | 2 -- 1 file changed

Re: [Piglit] [PATCH] core: don't try to resolve the real path of the file

2014-02-07 Thread Ilia Mirkin
On Fri, Feb 7, 2014 at 10:08 PM, Dylan Baker wrote: > On Friday, February 07, 2014 09:42:05 PM Ilia Mirkin wrote: >> This makes it possible to run the summary on e.g. compressed files or >> otherwise piped in with the <( ... ) shell construct. >> >> There should be n

[Piglit] [PATCH] framework: dmesg is expected to be a string, not a list of values

2014-02-07 Thread Ilia Mirkin
Since there are now also summary results in the wild with the list in their json, handle them correctly as well instead of printing out a stringified array. Signed-off-by: Ilia Mirkin --- framework/dmesg.py | 2 +- framework/summary.py | 6 +- 2 files changed, 6 insertions(+), 2 deletions

Re: [Piglit] [PATCH] core: don't try to resolve the real path of the file

2014-02-09 Thread Ilia Mirkin
On Mon, Feb 10, 2014 at 2:30 AM, Dylan Baker wrote: > On Friday, February 07, 2014 10:22:48 PM Ilia Mirkin wrote: >> On Fri, Feb 7, 2014 at 10:08 PM, Dylan Baker > wrote: >> > On Friday, February 07, 2014 09:42:05 PM Ilia Mirkin wrote: >> >> This makes it p

Re: [Piglit] [PATCH] core: don't try to resolve the real path of the file

2014-02-10 Thread Ilia Mirkin
On Mon, Feb 10, 2014 at 2:41 AM, Ilia Mirkin wrote: > On Mon, Feb 10, 2014 at 2:30 AM, Dylan Baker wrote: >> On Friday, February 07, 2014 10:22:48 PM Ilia Mirkin wrote: >>> On Fri, Feb 7, 2014 at 10:08 PM, Dylan Baker >> wrote: >>> > On Friday, February 07

Re: [Piglit] [PATCH] fbo-framework: check for ARB_framebuffer_object

2014-02-10 Thread Ilia Mirkin
On Thu, Feb 6, 2014 at 1:43 AM, Ilia Mirkin wrote: > On Sun, Feb 2, 2014 at 8:45 PM, Ilia Mirkin wrote: >> On Thu, Jan 30, 2014 at 2:36 AM, Ilia Mirkin wrote: >>> If we just blindly call glBindFramebuffer, that will cause the piglit >>> test to skip. Make sure tha

Re: [Piglit] [PATCH] core: don't try to resolve the real path of the file

2014-02-10 Thread Ilia Mirkin
On Mon, Feb 10, 2014 at 8:02 PM, Ken Phillis Jr wrote: > I would suggest testing this a little bit more carefully. I know that > I specifically ran into problems with this because someone may be > running piglit in a situation where the user does not have write > permissions for the piglit install

Re: [Piglit] [PATCH] fbo-framework: check for ARB_framebuffer_object

2014-02-10 Thread Ilia Mirkin
On Mon, Feb 10, 2014 at 10:23 PM, Ian Romanick wrote: > On 02/10/2014 02:06 AM, Ilia Mirkin wrote: >> On Thu, Feb 6, 2014 at 1:43 AM, Ilia Mirkin wrote: >>> On Sun, Feb 2, 2014 at 8:45 PM, Ilia Mirkin wrote: >>>> On Thu, Jan 30, 2014 at 2:36 AM, Ilia Mirkin wrote:

Re: [Piglit] [PATCH] core: don't try to resolve the real path of the file

2014-02-10 Thread Ilia Mirkin
On Tue, Feb 11, 2014 at 12:17 AM, Ken Phillis Jr wrote: > On Mon, Feb 10, 2014 at 9:15 PM, Ilia Mirkin wrote: >> I may be showing signs of idiocy here, but... I don't at all >> understand what you're saying. Could you elaborate as to the specific >> example you h

Re: [Piglit] [PATCH] core: don't try to resolve the real path of the file

2014-02-10 Thread Ilia Mirkin
On Tue, Feb 11, 2014 at 12:28 AM, Ilia Mirkin wrote: > On Tue, Feb 11, 2014 at 12:17 AM, Ken Phillis Jr wrote: >> On Mon, Feb 10, 2014 at 9:15 PM, Ilia Mirkin wrote: >>> I may be showing signs of idiocy here, but... I don't at all >>> understand what you're

Re: [Piglit] [PATCH] fbo-framework: check for ARB_framebuffer_object

2014-02-11 Thread Ilia Mirkin
On Tue, Feb 11, 2014 at 1:13 PM, Eric Anholt wrote: > Ian Romanick writes: > >> On 02/10/2014 02:06 AM, Ilia Mirkin wrote: >>> On Thu, Feb 6, 2014 at 1:43 AM, Ilia Mirkin wrote: >>>> On Sun, Feb 2, 2014 at 8:45 PM, Ilia Mirkin wrote: >>>>> On

Re: [Piglit] [PATCH] gtest: Fix bug introduced in 90a256411

2014-02-13 Thread Ilia Mirkin
esg argument. > > This patch fixes that bug. > > Signed-off-by: Dylan Baker Reviewed-by: Ilia Mirkin > > --- > framework/gtest.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/framework/gtest.py b/framework/gtest.py > index 7b474f3..00ed

[Piglit] [PATCH] framework: flush out screen prints explicitly

2014-02-14 Thread Ilia Mirkin
Without the flush, updates only happen whenever the buffer overfills, which can be tens of tests. Signed-off-by: Ilia Mirkin --- framework/log.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/framework/log.py b/framework/log.py index dcbe345..01c3a32 100644 --- a/framework/log.py +++ b

[Piglit] [PATCH] framework: keep track of running stats and display them

2014-02-14 Thread Ilia Mirkin
This will display a line that looks like: [00076/11064] fail: 1, pass: 55, skip: 19 Running Test(s): 00075 Signed-off-by: Ilia Mirkin --- framework/core.py | 11 +++ framework/log.py | 19 +++ 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/framework

[Piglit] [PATCH] framework: there are 0 completed tests at the beginning

2014-02-14 Thread Ilia Mirkin
This fixes a minor annoyance, that the test id displayed was lower than the completed count in single-threaded runs. Signed-off-by: Ilia Mirkin --- framework/log.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/log.py b/framework/log.py index ba045da..8ae7541

[Piglit] [PATCH] framework: avoid blocking joins, allowing ^C to work

2014-02-15 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- framework/core.py | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/framework/core.py b/framework/core.py index 4bcaa82..7b2083b 100644 --- a/framework/core.py +++ b/framework/core.py @@ -31,6 +31,7 @@ import sys import time

Re: [Piglit] [PATCH] log: Replace console output with a simpler output

2014-02-15 Thread Ilia Mirkin
On Sat, Feb 15, 2014 at 4:11 AM, Dylan Baker wrote: > This kind of feedback would have been really useful before it landed. It was > on the list for a couple weeks, and I let it sit after Jordan had reviewed > if for a couple of days. I'll go ahead and revert it, I'm just saying > showing up to th

[Piglit] [PATCH] framework: add a verbose flag to produce a result spew

2014-02-15 Thread Ilia Mirkin
This restores a similar output to the old one for use-cases where a spew is useful, such as when hangs can happen and the on-screen output is the only record. Signed-off-by: Ilia Mirkin --- Sorry, this is a little dirty. Can't think of a great way around it, given the current log api. Pe

Re: [Piglit] [PATCH] framework: keep track of running stats and display them

2014-02-15 Thread Ilia Mirkin
On Sat, Feb 15, 2014 at 4:45 AM, Dylan Baker wrote: > On Saturday, February 15, 2014 02:28:11 AM Ilia Mirkin wrote: >> This will display a line that looks like: >> [00076/11064] fail: 1, pass: 55, skip: 19 Running Test(s): 00075 >> >> Signed-off-by: Ilia Mirkin >&g

Re: [Piglit] [PATCH] framework: add a verbose flag to produce a result spew

2014-02-15 Thread Ilia Mirkin
On Sat, Feb 15, 2014 at 4:49 AM, Dylan Baker wrote: > On Saturday, February 15, 2014 04:15:13 AM Ilia Mirkin wrote: >> This restores a similar output to the old one for use-cases where a spew >> is useful, such as when hangs can happen and the on-screen output is the >> only

Re: [Piglit] [PATCH] framework: avoid blocking joins, allowing ^C to work

2014-02-15 Thread Ilia Mirkin
On Sat, Feb 15, 2014 at 7:37 AM, Dylan Baker wrote: > On Saturday, February 15, 2014 03:27:44 AM Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> framework/core.py | 20 ++-- >> 1 file changed, 14 insertions(+), 6 deletions(-) >> &g

Re: [Piglit] [PATCH] framework: keep track of running stats and display them

2014-02-15 Thread Ilia Mirkin
On Sat, Feb 15, 2014 at 6:43 AM, Dylan Baker wrote: > On Saturday, February 15, 2014 04:48:37 AM Ilia Mirkin wrote: >> On Sat, Feb 15, 2014 at 4:45 AM, Dylan Baker > wrote: >> > On Saturday, February 15, 2014 02:28:11 AM Ilia Mirkin wrote: >> >> This wi

Re: [Piglit] [PATCH] RFC: Example of my proposal

2014-02-15 Thread Ilia Mirkin
ut still available. On a semi-unrelated note, if you're so concerned with the speed of the log stuff, have you played around with making self.__running a set? That should speed removal up a bit... In any case, Reviewed-by: Ilia Mirkin Should I go ahead and start pushing the changes you r

[Piglit] [PATCH v2] framework: keep track of running stats and display them

2014-02-15 Thread Ilia Mirkin
This will display a line that looks like: [00076/11064] fail: 1, pass: 55, skip: 19 Running Test(s): 00075 Signed-off-by: Ilia Mirkin --- One problem that I noticed is that this might make the line go over 80 characters when running in parallel mode. If the line length is longer than the

Re: [Piglit] [PATCH] framework: avoid blocking joins, allowing ^C to work

2014-02-16 Thread Ilia Mirkin
On Sun, Feb 16, 2014 at 6:14 PM, Kenneth Graunke wrote: > On 02/15/2014 10:30 AM, Ilia Mirkin wrote: >> On Sat, Feb 15, 2014 at 7:37 AM, Dylan Baker wrote: >>> On Saturday, February 15, 2014 03:27:44 AM Ilia Mirkin wrote: >>>> Signed-off-by: Ilia Mirkin >>

Re: [Piglit] [PATCH] log: Replace console output with a simpler output

2014-02-16 Thread Ilia Mirkin
On Sun, Feb 16, 2014 at 8:29 PM, Matt Turner wrote: > On Fri, Feb 14, 2014 at 11:24 AM, Eric Anholt wrote: >> Dylan Baker writes: >> >>> This replaces the console spewer with a simpler console reporting >>> mechanism inspired by the output of ninja. This reduces code, remove all >>> singleton in

Re: [Piglit] [PATCH 2/4] framework/log.py: Make self.__summary keys explicitly

2014-02-17 Thread Ilia Mirkin
On Mon, Feb 17, 2014 at 2:45 PM, Dylan Baker wrote: > It would be an unwelcome surprise if some test returns 'fails' or 'pas', > so rather than allowing such a thing to happen, assert that the result > is actually viable. > > Signed-off-by: Dylan Baker > --- > framework/core.py| 2 +

Re: [Piglit] [PATCH 4/4] log: add verbose logger

2014-02-17 Thread Ilia Mirkin
On Mon, Feb 17, 2014 at 2:45 PM, Dylan Baker wrote: > This adds a verbose logger option, similar to that of the old piglit > logger, but with some of the flair of the new one. > > Signed-off-by: Dylan Baker > -- > framework/core.py| 17 - > framework/log.py | 56 +

Re: [Piglit] [PATCH 4/4] log: add verbose logger

2014-02-17 Thread Ilia Mirkin
On Mon, Feb 17, 2014 at 2:45 PM, Dylan Baker wrote: > diff --git a/piglit-resume.py b/piglit-resume.py > index 7b82420..5d41b9a 100755 > --- a/piglit-resume.py > +++ b/piglit-resume.py > @@ -31,6 +31,10 @@ import framework.core as core > > def main(): > parser = argparse.ArgumentParser() > +

Re: [Piglit] [PATCH 2/4] framework/log.py: Make self.__summary keys explicitly

2014-02-17 Thread Ilia Mirkin
On Mon, Feb 17, 2014 at 3:39 PM, Dylan Baker wrote: > I didn't think that list comprehensions leaked, since they're supposed to be > usable anywhere map() and filter() is used without any additional side > effects. Maybe I'm wrong though. Python 2.7.5 (default, Oct 27 2013, 05:36:27) [GCC 4.7.3]

Re: [Piglit] [PATCH 1/4] log_tests.py: Add tests from framework/log.py

2014-02-17 Thread Ilia Mirkin
On Mon, Feb 17, 2014 at 2:45 PM, Dylan Baker wrote: > Signed-off-by: Dylan Baker Reviewed-by: Ilia Mirkin > --- > framework/tests/log_tests.py | 85 > > 1 file changed, 85 insertions(+) > create mode 100644 framework/tests/log

Re: [Piglit] [PATCH 3/4] log: Rename get_current and mark_complete

2014-02-17 Thread Ilia Mirkin
On Mon, Feb 17, 2014 at 2:45 PM, Dylan Baker wrote: > This replaces very specific names with more general ones. This should be > more useful if we wanted to subclass log at some point. > > Signed-off-by: Dylan Baker Reviewed-by: Ilia Mirkin > --- > framework/core.

Re: [Piglit] [Patch v2 2/4] framework/log.py: Make self.__summary keys explicitly

2014-02-18 Thread Ilia Mirkin
- Replace list comprehension with a generator > - Remove tests that are too implementation specific > > Signed-off-by: Dylan Baker Reviewed-by: Ilia Mirkin > --- > framework/core.py| 2 +- > framework/log.py | 10 +++--- > framework/tests

Re: [Piglit] [Patch v2 4/4] log: add verbose logger

2014-02-18 Thread Ilia Mirkin
> - resume uses stored verbosity settings > > Signed-off-by: Dylan Baker Reviewed-by: Ilia Mirkin > --- > framework/core.py| 17 +++--- > framework/log.py | 54 > +--- > framework/tests/log_tes

Re: [Piglit] [PATCH] framework: avoid blocking joins, allowing ^C to work

2014-02-18 Thread Ilia Mirkin
On Tue, Feb 18, 2014 at 10:46 AM, Tom Stellard wrote: > On Sat, Feb 15, 2014 at 01:30:20PM -0500, Ilia Mirkin wrote: >> On Sat, Feb 15, 2014 at 7:37 AM, Dylan Baker wrote: >> > On Saturday, February 15, 2014 03:27:44 AM Ilia Mirkin wrote: >> >&

Re: [Piglit] [Patch v2 1/4] log_tests.py: Add tests from framework/log.py

2014-02-18 Thread Ilia Mirkin
when the system hangs. Enabling > verbose output in the new logging allows me to do this. IME, a history is good for this too -- sometimes a test does something bad, but is able to exit before the system dies. > > > Thanks, > Tom > > On Tue, Feb 18, 2014

Re: [Piglit] [Patch v2 1/4] log_tests.py: Add tests from framework/log.py

2014-02-19 Thread Ilia Mirkin
On Wed, Feb 19, 2014 at 9:57 AM, Dylan Baker wrote: > On Tuesday, February 18, 2014 07:07:19 PM Ilia Mirkin wrote: >> On Tue, Feb 18, 2014 at 6:41 PM, Tom Stellard wrote: >> > Hi Dylan, >> > >> > I've tested version 2 of this series, and I have a few >

Re: [Piglit] [Patch v2 1/4] log_tests.py: Add tests from framework/log.py

2014-02-19 Thread Ilia Mirkin
On Wed, Feb 19, 2014 at 3:13 PM, Dylan Baker wrote: > On Wednesday, February 19, 2014 02:25:15 PM Ilia Mirkin wrote: >> On Wed, Feb 19, 2014 at 9:57 AM, Dylan Baker > wrote: >> > On Tuesday, February 18, 2014 07:07:19 PM Ilia Mirkin wrote: >> >> On Tue, Feb

Re: [Piglit] [Patch v2 1/4] log_tests.py: Add tests from framework/log.py

2014-02-19 Thread Ilia Mirkin
On Wed, Feb 19, 2014 at 4:24 PM, Dylan Baker wrote: > On Wednesday, February 19, 2014 03:44:03 PM Ilia Mirkin wrote: >> On Wed, Feb 19, 2014 at 3:13 PM, Dylan Baker > wrote: >> > On Wednesday, February 19, 2014 02:25:15 PM Ilia Mirkin wrote: >> >> On Wed, Feb

Re: [Piglit] [Patch v2 1/4] log_tests.py: Add tests from framework/log.py

2014-02-19 Thread Ilia Mirkin
On Wed, Feb 19, 2014 at 4:47 PM, Dylan Baker wrote: > On Wednesday, February 19, 2014 04:39:40 PM Ilia Mirkin wrote: >> On Wed, Feb 19, 2014 at 4:24 PM, Dylan Baker > wrote: >> > On Wednesday, February 19, 2014 03:44:03 PM Ilia Mirkin wrote: >> >> On Wed, Feb

Re: [Piglit] [Patch v2 1/4] log_tests.py: Add tests from framework/log.py

2014-02-20 Thread Ilia Mirkin
On Thu, Feb 20, 2014 at 2:27 PM, Dylan Baker wrote: > On Wednesday, February 19, 2014 04:50:06 PM Ilia Mirkin wrote: >> On Wed, Feb 19, 2014 at 4:47 PM, Dylan Baker > wrote: >> > On Wednesday, February 19, 2014 04:39:40 PM Ilia Mirkin wrote: >> >> On Wed, Feb

Re: [Piglit] Convert from python2 to python3

2014-02-24 Thread Ilia Mirkin
On Mon, Feb 24, 2014 at 2:42 PM, Dylan Baker wrote: > This series makes the transition from python2 to python3. In general Out of curiousity, what's the motivation for this? I've been able to avoid python3 quite nicely thus far, all it seems to do is break compatibility with existing setups... Ad

Re: [Piglit] Convert from python2 to python3

2014-02-25 Thread Ilia Mirkin
On Tue, Feb 25, 2014 at 3:36 PM, Dylan Baker wrote: > On Tuesday, February 25, 2014 02:01:56 PM Ken Phillis Jr wrote: >> On Mon, Feb 24, 2014 at 9:10 PM, Matt Turner wrote: >> > On Mon, Feb 24, 2014 at 11:47 AM, Ilia Mirkin > wrote: >> >> On Mon, Feb 24, 2014

Re: [Piglit] [PATCH] core: don't try to resolve the real path of the file

2014-02-25 Thread Ilia Mirkin
On Tue, Feb 25, 2014 at 7:55 PM, Ken Phillis Jr wrote: > On Mon, Feb 10, 2014 at 11:34 PM, Ilia Mirkin wrote: >> To elaborate a bit on why I think I'm right, let me provide this example: >> >> $ mkdir somepath >> $ cat > somepath/script.py >> import

Re: [Piglit] [PATCH 1/2] framework: Fix standalone execution of glsl_parser_test.py

2014-02-26 Thread Ilia Mirkin
On Wed, Feb 26, 2014 at 5:43 PM, Dylan Baker wrote: > On Wednesday, February 26, 2014 22:10:08 Fabian Bieler wrote: > >> This is usefull when writing new tests using the glslparser framework. > > > > Dang, someone actually uses this...thing. I actually have patches on the > list to remove it. > >

Re: [Piglit] replace glslparsertest standalone functionality

2014-02-27 Thread Ilia Mirkin
On Thu, Feb 27, 2014 at 2:43 PM, Dylan Baker wrote: > This small series replaces glsl_parser_test.py's standalone > functionality with a small utility script for running a single > glslparsertest. > > The output of this file is less than ideal, however, that is becasue > core.Test does some very s

Re: [Piglit] replace glslparsertest standalone functionality

2014-02-27 Thread Ilia Mirkin
On Thu, Feb 27, 2014 at 4:21 PM, Dylan Baker wrote: > On Thursday, February 27, 2014 15:32:06 you wrote: >> On Thu, Feb 27, 2014 at 2:43 PM, Dylan Baker > wrote: >> > This small series replaces glsl_parser_test.py's standalone >> > functionality with a small utility script for running a single >>

Re: [Piglit] [PATCH 06/12] glsl_parser_test.py: Replace GLSLParserTest class with function

2014-03-01 Thread Ilia Mirkin
Perhaps I missed it somewhere in the series, but where do you take care of the tests/gpu.py bit which does: profile.filter_tests(lambda p, t: not isinstance(t, GLSLParserTest)) On Tue, Feb 11, 2014 at 9:11 PM, Dylan Baker wrote: > This is a rough 'port' of the class to a function. It deviates on

Re: [Piglit] [PATCH 3/7] framework/status.py: Convert from NotImplementedError to ABCMeta

2014-03-06 Thread Ilia Mirkin
On Thu, Mar 6, 2014 at 4:54 PM, Dylan Baker wrote: > Using pythons __metaclass__ = abc.ABCMeta allows us to set the abstract > Status class's __init__ to pass instead of raise NotImplementedError, I haven't investigated the reason for this, but can't come up with anything sane off-hand... why are

[Piglit] [PATCH] arb_clear_texture: add a trivial test

2014-03-06 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- This is my first foray into piglit test-writing. Let me know if I missed anything (except for better tests -- I know that this is very limited). This mechanism of transferring the texture to the screen is pretty poor -- it entirely defeats the point of

Re: [Piglit] [PATCH] arb_clear_texture: add a trivial test

2014-03-06 Thread Ilia Mirkin
On Fri, Mar 7, 2014 at 2:26 AM, Fabian Bieler wrote: > Sorry for the wrong In-reply-to-header. I can't use my email-client > properly. > On 2014-03-06 22:14, Ilia Mirkin wrote: >> >> Signed-off-by: Ilia Mirkin >> >> --- >> >> This is my firs

[Piglit] [PATCH v2] arb_clear_texture: add a trivial test

2014-03-06 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- v1 -> v2: - clear-simple -> simple - free the colors array - remove unnecessary texparameter settings - switch to probing the texels directly, avoiding the fbo dance glapi/gl.spec | 41 + tests/

Re: [Piglit] [PATCH] arb_clear_texture: add a trivial test

2014-03-07 Thread Ilia Mirkin
On Fri, Mar 7, 2014 at 2:38 PM, Eric Anholt wrote: > Ilia Mirkin writes: > >> Signed-off-by: Ilia Mirkin >> --- >> >> This is my first foray into piglit test-writing. Let me know if I missed >> anything (except for better tests -- I know that this is ve

Re: [Piglit] [PATCH] arb_clear_texture: add a trivial test

2014-03-07 Thread Ilia Mirkin
On Fri, Mar 7, 2014 at 8:02 PM, Eric Anholt wrote: > Ilia Mirkin writes: > >> On Fri, Mar 7, 2014 at 2:38 PM, Eric Anholt wrote: >>> Ilia Mirkin writes: > >>> >>> Other than that, this is a nice simple test. We're going to want an >>>

Re: [Piglit] [PATCH] arb_clear_texture: add a trivial test

2014-03-07 Thread Ilia Mirkin
On Fri, Mar 7, 2014 at 11:26 PM, Ilia Mirkin wrote: > On Fri, Mar 7, 2014 at 8:02 PM, Eric Anholt wrote: >> Ilia Mirkin writes: >> >>> On Fri, Mar 7, 2014 at 2:38 PM, Eric Anholt wrote: >>>> Ilia Mirkin writes: >> >>>> >>>> Ot

[Piglit] [PATCH v3] arb_clear_texture: add a trivial test

2014-03-07 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Fabian, since the test has changed a bunch I'm dropping your R-b. Feel free to take another look. Eric, I hope that this is all in order. I tried using the shader approach, but it didn't work (at least in part due to a missing piglit_present_results ca

[Piglit] [PATCH 1/4] fbo-blit-d24s8: avoid using textures

2014-03-13 Thread Ilia Mirkin
There's no reason to attach the teximages to the framebuffer. Instead use renderbuffers so that we don't need to depend on ARB_depth_texture. Signed-off-by: Ilia Mirkin --- tests/fbo/fbo-blit-d24s8.c | 38 +- 1 file changed, 17 insertions(+), 21

[Piglit] [PATCH 4/4] readpixels-24_8: replace teximage use with renderbuffer

2014-03-13 Thread Ilia Mirkin
This removes an implicit dependency on ARB_depth_texture (and is more efficient). Signed-off-by: Ilia Mirkin --- .../ext_packed_depth_stencil/readpixels-24_8.c | 36 ++ 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/tests/spec/ext_packed_depth_stencil

[Piglit] [PATCH 2/4] copyteximage: add ARB_depth_texture dependencies

2014-03-13 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/texturing/copyteximage.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/texturing/copyteximage.c b/tests/texturing/copyteximage.c index 0afcba5..85b2215 100644 --- a/tests/texturing/copyteximage.c +++ b/tests/texturing

[Piglit] [PATCH 3/4] texwrap: add ARB_depth_texture dependency

2014-03-13 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- tests/texturing/texwrap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/texturing/texwrap.c b/tests/texturing/texwrap.c index 05b9632..383681e 100644 --- a/tests/texturing/texwrap.c +++ b/tests/texturing/texwrap.c @@ -370,7 +370,8

Re: [Piglit] Update some docstrings v2

2014-03-15 Thread Ilia Mirkin
On Fri, Mar 14, 2014 at 7:15 PM, Dylan Baker wrote: > On Friday, March 14, 2014 06:11:55 PM Ilia Mirkin wrote: >> On Mon, Mar 10, 2014 at 9:25 PM, Dylan Baker > wrote: >> > It really isn't fair to still call this series about updating >> > docstrings, as patch

Re: [Piglit] Update some docstrings v2

2014-03-15 Thread Ilia Mirkin
On Mon, Mar 10, 2014 at 9:25 PM, Dylan Baker wrote: > It really isn't fair to still call this series about updating > docstrings, as patch 3 is a fairly substantial change. I took Ilia's > advice on that patch, and rather than using subclasses created constant > instances of the Status class to re

Re: [Piglit] [PATCH 1/4] fbo-blit-d24s8: avoid using textures

2014-03-15 Thread Ilia Mirkin
On Fri, Mar 14, 2014 at 8:24 PM, Anuj Phogat wrote: > On Thu, Mar 13, 2014 at 9:07 AM, Ilia Mirkin wrote: >> There's no reason to attach the teximages to the framebuffer. Instead >> use renderbuffers so that we don't need to depend on ARB_depth_texture. >> >

Re: [Piglit] Update some docstrings v2

2014-03-15 Thread Ilia Mirkin
On Sat, Mar 15, 2014 at 8:29 AM, Daniel Vetter wrote: > On Fri, Mar 14, 2014 at 07:41:04PM -0700, Dylan Baker wrote: >> [snip] >> > > I'll throw a patch at the end of the series, do you want me to send >> >> I'm gonna take it back, sorry. I don't know that dmesg-warn should be >> worse than warn,

Re: [Piglit] [PATCH 2/4] copyteximage: add ARB_depth_texture dependencies

2014-03-16 Thread Ilia Mirkin
] }, On Sun, Mar 16, 2014 at 10:03 AM, Marek Olšák wrote: > Did you forget GL_DEPTH_COMPONENT32 or is it not tested by this test? > > Marek > > On Thu, Mar 13, 2014 at 5:07 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> tests/texturing/copyteximage.c

  1   2   3   4   5   6   7   8   9   10   >