On Fri, Feb 7, 2014 at 10:08 PM, Dylan Baker <baker.dyla...@gmail.com> wrote: > On Friday, February 07, 2014 09:42:05 PM Ilia Mirkin wrote: >> This makes it possible to run the summary on e.g. compressed files or >> otherwise piped in with the <( ... ) shell construct. >> >> There should be no difference between open() on a path before and after >> the realpath call. >> >> Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> >> --- >> framework/core.py | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/framework/core.py b/framework/core.py >> index 45eea12..6a122f5 100644 >> --- a/framework/core.py >> +++ b/framework/core.py >> @@ -647,8 +647,6 @@ def load_results(filename): >> "main" >> >> """ >> - filename = os.path.realpath(filename) >> - >> try: >> with open(filename, 'r') as resultsfile: >> testrun = TestrunResult(resultsfile) > > I know that some people install piglit and add it's programs to their $PATH, > is this going to break any of those use cases? It didn't seem to when I tested > it, but some of those people might want to weigh in.
I can't see how it would matter one way or another. Stuff like realpath is to deal with people feeding symlinks/etc that end up pointing outside of a tree (so you want to deny that for security reasons). But perhaps there's something I'm missing... -ilia _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
