Re: [Piglit] [PATCH v2] arb_shader_image_load_store: Test format incompatible texture buffer

2018-07-20 Thread Danylo Piliaiev
On 20.07.18 02:26, Francisco Jerez wrote: Danylo Piliaiev writes: Test for the regression which happened when GL_TEXTURE_BUFFER was allowed to have incompatible format. v2: Removed unnecessary code duplication - use upload_image instead of init_level. (Francisco Jerez) Bugzilla: http

Re: [Piglit] [PATCH v2] arb_shader_image_load_store: Test format incompatible texture buffer

2018-07-20 Thread Danylo Piliaiev
On 20.07.18 17:04, Danylo Piliaiev wrote: On 20.07.18 02:26, Francisco Jerez wrote: Danylo Piliaiev writes: Test for the regression which happened when GL_TEXTURE_BUFFER was allowed to have incompatible format. v2: Removed unnecessary code duplication - use upload_image instead   of

[Piglit] [PATCH 1/4] util: Add a utility to assemble SPIR-V sources

2018-07-20 Thread Alejandro Piñeiro
From: Neil Roberts Adds piglit_assemble_spirv which invokes spirv-as to assemble a SPIR-V source. The function is based on a static helper function that was in shader_runner. --- tests/shaders/shader_runner.c | 45 ++- tests/util/piglit-shader.c| 37 ++

[Piglit] [PATCH 2/4] util: Add utilities to handle shader_test files

2018-07-20 Thread Alejandro Piñeiro
--- tests/util/CMakeLists.txt | 1 + tests/util/piglit-shader-test.c | 154 tests/util/piglit-shader-test.h | 43 +++ 3 files changed, 198 insertions(+) create mode 100644 tests/util/piglit-shader-test.c create mode 100644 tests/util/pigl

[Piglit] [PATCH 0/4] ARB_gl_spirv: xfb tests

2018-07-20 Thread Alejandro Piñeiro
Hi, this is the third series that includes tests for the ARB_gl_spirv extension. Note that this depends on the pending-to-review first series (basics+uniforms) and second (atomic counters). The three series are included on the following branch: https://github.com/Igalia/piglit/tree/arb_gl_spirv-s

[Piglit] [PATCH 4/4] arb_enhanced_layouts: Test XFB layout qualifiers via SPIR-V

2018-07-20 Thread Alejandro Piñeiro
From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts Signed-off-by: Alejandro Piñeiro --- tests/opengl.py| 22 +- .../shader_test/gs_text_two_sets_tmp

[Piglit] [PATCH 3/4] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-07-20 Thread Alejandro Piñeiro
From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts Signed-off-by: Alejandro Piñeiro --- tests/opengl.py| 1 + .../xfb_streams_without_invocations.s

[Piglit] [PATCH 1/2] shader_runner: Improve MS texture support

2018-07-20 Thread Rhys Perry
--- tests/shaders/shader_runner.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index c1d4c9265..96f009277 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -3149,

[Piglit] [PATCH 2/2] arb_bindless_texture: Add multisampled image load/store test

2018-07-20 Thread Rhys Perry
Exercises a nouveau bug on Maxwell+. --- .../images/basic-imageStore-ms.shader_test | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 tests/spec/arb_bindless_texture/execution/images/basic-imageStore-ms.shader_test diff --git a/tests/spec/arb_bindless_tex

[Piglit] [PATCH 2/2] polygon-mode: also test polygon culling

2018-07-20 Thread Brian Paul
Test polygon culling with glPolygonMode for better coverage. --- tests/general/polygon-mode.c | 87 +++- 1 file changed, 54 insertions(+), 33 deletions(-) diff --git a/tests/general/polygon-mode.c b/tests/general/polygon-mode.c index c41c392..709c6db 100644

[Piglit] [PATCH 1/2] Prevent loop unrolling in a shader test

2018-07-20 Thread Brian Paul
The GLSL compiler can easily unroll this loop and simplify the function down to a single assignment. That defeats the purpose of the test. Replace literals with uniforms to prevent unrolling. --- tests/shaders/glsl-vs-loop-break.shader_test | 8 ++-- 1 file changed, 6 insertions(+), 2 deletio

Re: [Piglit] [PATCH 2/2] arb_bindless_texture: Add multisampled image load/store test

2018-07-20 Thread Ilia Mirkin
MS images may not be supported. You should add a check in the [require] section that checks that the MAX_IMAGE_SAMPLES >= 2 On Fri, Jul 20, 2018 at 11:36 AM, Rhys Perry wrote: > Exercises a nouveau bug on Maxwell+. > --- > .../images/basic-imageStore-ms.shader_test | 50 > ++

Re: [Piglit] [PATCH 1/2] multisample-accuracy: Add an error margin for lit/unlit pixels

2018-07-20 Thread Mark Janes
Hi Neil, We still get intermittent failures with this threshold, and have historically disabled the multisample accuracy tests in CI. Can we relax the threshold a bit more? -Mark Neil Roberts writes: > The unlit and totally_lit stats are supposed to count the pixels where > either a primitive

Re: [Piglit] [PATCH v2] arb_shader_image_load_store: Test format incompatible texture buffer

2018-07-20 Thread Francisco Jerez
Danylo Piliaiev writes: > On 20.07.18 17:04, Danylo Piliaiev wrote: >> >> >> On 20.07.18 02:26, Francisco Jerez wrote: >>> Danylo Piliaiev writes: >>> Test for the regression which happened when GL_TEXTURE_BUFFER was allowed to have incompatible format. v2: Removed unnecessar

Re: [Piglit] [PATCH 2/2] polygon-mode: also test polygon culling

2018-07-20 Thread Charmaine Lee
For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, July 20, 2018 8:48:12 AM To: piglit@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee; Brian Paul Subject: [PATCH 2/2] polygon-mode: also test polygon culling Test polygon cull